Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct

[Dekel Peled <dekelp@nvidia.com>]

Hi Ferruh,

Sorry for the late response, we are checking for additional impacts of this change.
Looks like there is another fix needed, after all checks are completed we'll submit all relevant patches.

Regards,
Dekel

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 9, 2020 12:05 PM
> To: Xiaoyu Min <jackmin@mellanox.com>; Ori Kam <orika@nvidia.com>;
> Wenzhuo Lu <wenzhuo.lu@intel.com>; Beilei Xing <beilei.xing@intel.com>;
> Bernard Iremonger <bernard.iremonger@intel.com>; Matan Azrad
> <matan@nvidia.com>; Dekel Peled <dekelp@nvidia.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>
> Cc: dev@dpdk.org; Jack Min <jackmin@nvidia.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Hyong Youb Kim <hyonkim@cisco.com>; John
> Daley <johndale@cisco.com>; Asaf Penso <asafp@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr
> struct
> 
> On 11/3/2020 2:27 PM, Ferruh Yigit wrote:
> > On 11/3/2020 1:20 PM, Xiaoyu Min wrote:
> >> From: Xiaoyu Min <jackmin@nvidia.com>
> >>
> >> The rte_flow_item_eth and rte_flow_item_vlan items are refined [1].
> >> The structs do not exactly represent the packet bits captured on the
> >> wire anymore so set raw_encap/decap commands should only copy real
> >> header instead of the whole struct.
> >>
> >> Replace the rte_flow_item_* with the existing corresponding rte_*_hdr.
> >>
> >> [1]:
> >> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and
> >> VLAN
> >> items")
> >>
> >> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> >
> >
> > Hi Dekel, Ori,
> >
> > This is second fix [1] we get related to the "rte_flow_item_xxx" size
> > changes [2] from you.
> >
> > The assumption that 'rte_flow_item_xxx' size is same as xxx header
> > size seems implemented in multiple locations, and changing
> > 'rte_flow_item_xxx' struct size breaking those usage.
> >
> > Can one of you guys spend some time to actively check all possible
> breakages?
> > They may be very hard to find unless someone explicitly check for this.
> >
> 
> Hi Dekel, Ori,
> 
> Is there anyone actively checking for this?
> 
> 
> > Thanks,
> > ferruh
> >
> >
> > [1]
> > first one:
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hes.dpdk.org%2Fpatch%2F82863%2F&amp;data=04%7C01%7Cdekelp%40nvi
> dia.com
> >
> %7C3ab20dfba7264766e7e808d88496fab7%7C43083d15727340c1b7db39efd9c
> cc17a
> >
> %7C0%7C0%7C637405131289676761%7CUnknown%7CTWFpbGZsb3d8eyJWIj
> oiMC4wLjAw
> >
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sda
> ta=xF
> >
> xO%2BmzQP6bjS9BE1Eg9fd1pd8VPLNHV%2FJm83cwJ2Xw%3D&amp;reserve
> d=0
> >
> >
> > [2]
> > Fixes: ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item")
> > Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN
> > items")