From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA1F5A04B1; Mon, 5 Oct 2020 13:03:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A7521B3BB; Mon, 5 Oct 2020 13:03:37 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id E09401B2A9 for ; Mon, 5 Oct 2020 13:03:35 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 05 Oct 2020 04:02:39 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 5 Oct 2020 11:03:32 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 5 Oct 2020 11:03:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e1d749P06KZVcWoUnN8xxLdvqrMxNgCxYdppetVeEWAO+J95L0pWY1WRuBf+gUXJz5USXmrS6v1Disqa81wixpcRItN7jl6J/LkWwDYFqKNxtLEe7dBLqQpj2E27psyd6w/c0VUV3LnzPxtYXtLVNOq+jmcDoyd7yKRfX6ihDmOygFH9TzaIeiiD/x0RV6BAOW+q3nZs6AIE2uTZ2XG5Oi+/6NfEPkIiybI8Lf4HOwlNIov6gOUMvHdfJFyGow9YKmzcRdpXg6Ek73kFwR9dwPof6IJYmeglt4L1wPXLjKGv8c47q9mTfYqBHdnZ5DKY6KLT0ywdhM49PhNRSDxrSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PCQ54Y+Lg7jWNhVBUcu76Kt1jyRlcr9QRw5LbSGigbM=; b=mWVfovzOzThSKKRLHHoZJK36KJmAK9WN+xIDMs19GqEeA7oJezS15m3Qb3PqReFvBUFYVTTvucLTlFLX5PzAms0swGNttzS7ET15laURwILcBIms9lMHMYk4Kl7+Gop76tOEeY/E91S4NYZNZWGq160uq/c2xl2axklgIG0lJHpWcKJQVynhwZVAygVeZ2CiCcXqozDzyPJPiI3+lL/6pY7hEuRVXJcBZoIeij6cInmh9aCVlShsxlDiV/TJFwkH7v0lQ6HTuOMtP2fFYnUHHfcOQ1BXPCGVH/8ehdY/ogCf/NaKbRqQsU2h9Rp/fm29rWkjOJQKGQ5S92EoyeDT/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4375.namprd12.prod.outlook.com (2603:10b6:208:24f::16) by MN2PR12MB4094.namprd12.prod.outlook.com (2603:10b6:208:15f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Mon, 5 Oct 2020 11:03:31 +0000 Received: from MN2PR12MB4375.namprd12.prod.outlook.com ([fe80::dd46:f544:6a2a:601c]) by MN2PR12MB4375.namprd12.prod.outlook.com ([fe80::dd46:f544:6a2a:601c%9]) with mapi id 15.20.3433.044; Mon, 5 Oct 2020 11:03:31 +0000 From: Dekel Peled To: Ori Kam , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/2] ethdev: support query of AGE action Thread-Index: AQHWmCm029y5sUfhY0G7k3Iyw9+v96mHOmQAgAGigNA= Date: Mon, 5 Oct 2020 11:03:31 +0000 Message-ID: References: <5a46a1ed26cd7e89483d06eaf676d44a088738f2.1601456245.git.dekelp@nvidia.com> <24deb8ad7d1b5a5d6e4d4a7da3ff85ba467b2774.1601580235.git.dekelp@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [213.57.241.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10aa4cdc-46f1-429c-8c7d-08d8691e4c0e x-ms-traffictypediagnostic: MN2PR12MB4094: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jXqRO4Pu6SfiHgcTcryakVk+8WCTGqsyGntunsMtY2R/VTHSKhS2EwlUDCaAheYXU8MNlEl37xPZVY3axg1ssrMIwjJzWlqg3U15pR4iG+z3UxNTxoYqiCtdlsU9J8rmwj2aySTHL9dnj4CdbDpXqCCmM9+q8RwvbDK8tYHl/whJqhpBRu3yjClGzkKQggdxTM2KFcu+lDhNkHQhSNUbuyzi/QGOWL4ZfwOAcpAUDcQ6l/7PyOJCksXLLmUi5hiELvXOSuGrPqM7G2o5OupA/RtrhF/1R5oQGEJXsBrR28pvpyoEv5TNtUHLt+615NpOGEIHwu3HvQLs51mbniT1hnugq8ohQyuacEEoYoIPxhTHsEaiyWbJ0Ztur7sAUBd4uFk9q9jMeBgXnpar+BHGTQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4375.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(66476007)(64756008)(66446008)(66946007)(66556008)(110136005)(45080400002)(76116006)(2906002)(5660300002)(71200400001)(316002)(966005)(4326008)(52536014)(86362001)(83380400001)(8676002)(83080400001)(6506007)(7696005)(55016002)(53546011)(186003)(33656002)(9686003)(8936002)(26005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: OnFoCCLcUsXE9SOk45Zu5ouwvVtWHDTa76w8TI0EGKg+FreRQTNLxodj0WwHtttNQbMDEQx0IucnHa80QgLlOPJlqLC/s/zs226lNYvcDg7ftTca1GG4QuTBA6gGD54pLCZQfPH+v7vITkkLqqkOGOY9nwZeCmjbFwy63LkHlTKPQVuPeb5CMoJbeMXAY7JvG4UsiVYX5xMyhIiEdXIPbL6+ZqOxwRsBHxFAaSeMqQFqSxm8grtQ+/I2Ewp1i6stRzsy7+OQFEUeHztzg2g8f9jg0E/1X+F7knM7NX7TfBmGkNigbKuQdjm419vp4ZpmVVZWVFZse5x1m4kkWPgoZLhiTi97ZrX8Xe4RNJRd5GSdAByHZ/NCvgl+4T6Qv2GijW1iScu1/RMD7pwSa8HXxUYQZEUIde9CvLEgSBpKq1zMyWKkxfxrtm6gbNRkddJEdVw0mNbi0W2irN77JifSZfpJzlWPxq1VJOjHmfGCwdYEM49pzfB5XJWZLuGjF0Rjb4n/aBHmz6byrr6UOMZ9gBTYUbN8IcaR/Ivyp3l9TkLhmkYFnd4DIhX35r+Ftn7S1jvHhNGU6XPf0nKux+nQs4X/H9mQKpqMcExqosJcoHDkHFPtqK3fYMNlsxEC7PFdBlbf+pnko2MeGUcxaNHz3Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4375.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10aa4cdc-46f1-429c-8c7d-08d8691e4c0e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2020 11:03:31.7856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: amUcKHRAZ7AwjPGL6aVT069bVAfKKNwO3WtfB9hgdTUhuTtCqWoSrGH5/ruwdNZOW0ESewZh1RXTVWPjZhlygQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4094 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601895759; bh=PCQ54Y+Lg7jWNhVBUcu76Kt1jyRlcr9QRw5LbSGigbM=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=BegNxp05DZ+g+c1n4J2YvWC6RuvTzGqw10E7KTwt10ogF/0N+rpRvoa2w6cUr4xKM dxQ2ggAJWZrGzSNbkiikNl5NEnhOt/Iq/gnhsRXPsvB9FmS/xg7fybbn6Ql9jph7OX eF4aP43pDoT6rJYyzbmc1i9f6NrT8xx5Z3sv2Ozl517G+3SJOkBHNeNUyXJbs2vpOp RD9FxhbCTiRIZaSCuPMtFvFgEtW1dUE9I4W0h5XSnvC5JzSI4jimHgyJ36uugb8BlN 5/OmKvw5W0RR9SaRIvUG48n6mhsb2UnsK4vMjRiXfw/uqPKrlsZfeeGMKT1JxlmRwe 0xY8h/cbAt0+g== Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: support query of AGE action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, PSB. > -----Original Message----- > From: Ori Kam > Sent: Sunday, October 4, 2020 1:02 PM > To: Dekel Peled ; NBU-Contact-Thomas Monjalon > ; ferruh.yigit@intel.com; > arybchenko@solarflare.com; wenzhuo.lu@intel.com; beilei.xing@intel.com; > bernard.iremonger@intel.com > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/2] ethdev: support query of AGE action >=20 > Hi Dekel, > PSB >=20 > > -----Original Message----- > > From: Dekel Peled > > Sent: Thursday, October 1, 2020 10:33 PM > > Subject: [PATCH v2 1/2] ethdev: support query of AGE action > > > > Existing API supports AGE action to monitor the aging of a flow. > > This patch implements RFC [1], introducing the response format for > > query of an AGE action. > > Application will be able to query the AGE action state. > > The response will be returned in the format implemented here. > > > > [1] > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fmail > > s.dp > > dk.org%2Farchives%2Fdev%2F2020- > > > September%2F180061.html&data=3D02%7C01%7Corika%40nvidia.com%7 > Ce > > > c8f8a845a284c153d7d08d86640d8e6%7C43083d15727340c1b7db39efd9ccc17 > > > a%7C0%7C1%7C637371776001401360&sdata=3Dy8g1yZiKsypXy%2BgsXtR5L > > Q2yVQ%2FudbbCfbbM1Zwt5dY%3D&reserved=3D0 > > > > Signed-off-by: Dekel Peled > > Acked-by: Matan Azrad > > --- > > doc/guides/prog_guide/rte_flow.rst | 17 +++++++++++++++++ > > doc/guides/rel_notes/release_20_11.rst | 3 +++ > > lib/librte_ethdev/rte_flow.h | 14 ++++++++++++++ > > 3 files changed, 34 insertions(+) > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > b/doc/guides/prog_guide/rte_flow.rst > > index 119b128..4b8d033 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -2666,6 +2666,23 @@ timeout passed without any matching on the > flow. > > | ``context`` | user input flow context | > > +--------------+---------------------------------+ > > > > +Query structure to retrieve ageing status information of a shared AGE > > +action, or a flow rule using the AGE action: > > + > > +.. _table_rte_flow_query_age: > > + > > +.. table:: AGE query > > + > > + +-------------------------+-----+----------------------------------= -+ > > + | Field | I/O | Value = | > > + > > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D+=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D > > =3D=3D=3D=3D+ > > + | ``aged`` | out | Aging timeout expired = | > > + +-------------------------+-----+----------------------------------= -+ > > + | ``last_hit_time_valid`` | out | ``last_hit_time`` field is valid = | > > + +-------------------------+-----+----------------------------------= -+ > > + | ``last_hit_time`` | out | Seconds since last traffic hit = | > > + > > + +-------------------------+-----+----------------------------------- > > + + > > + > > Negative types > > ~~~~~~~~~~~~~~ > > > > diff --git a/doc/guides/rel_notes/release_20_11.rst > > b/doc/guides/rel_notes/release_20_11.rst > > index 7f9d0dd..dd77f04 100644 > > --- a/doc/guides/rel_notes/release_20_11.rst > > +++ b/doc/guides/rel_notes/release_20_11.rst > > @@ -168,6 +168,9 @@ API Changes > > > > * ethdev: ``rte_eth_rx_descriptor_done()`` API has been deprecated. > > > > +* ethdev: Added struct ``rte_flow_query_age`` for use in response to > > +query > > + of AGE action. > > + > > * Renamed internal ethdev APIs: > > > > * ``_rte_eth_dev_callback_process()`` -> > > ``rte_eth_dev_callback_process()`` > > diff --git a/lib/librte_ethdev/rte_flow.h > > b/lib/librte_ethdev/rte_flow.h index da8bfa5..1a13802 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -2130,6 +2130,7 @@ enum rte_flow_action_type { > > * See struct rte_flow_action_age. > > * See function rte_flow_get_aged_flows > > * see enum RTE_ETH_EVENT_FLOW_AGED > > + * See struct rte_flow_query_age > > */ > > RTE_FLOW_ACTION_TYPE_AGE, > > }; > > @@ -2194,6 +2195,19 @@ struct rte_flow_action_age { }; > > > > /** > > + * RTE_FLOW_ACTION_TYPE_AGE (query) > > + * > > + * Query structure to retrieve the aging status information of a > > + * shared AGE action, or a flow rule using the AGE action. > > + */ > > +struct rte_flow_query_age { > > + uint32_t aged:1; /**< 1 if aging timeout expired, 0 otherwise. */ > > + uint32_t last_hit_time_valid:1; /**< 1 if last_hit_time value valid. = */ > > + uint32_t reserved:6; /**< Reserved, must be zero. */ > > + uint32_t last_hit_time:24; /**< Seconds since last traffic hit. */ > > +}; > From previous patch, I asked you why set the reserved in the middle? I will move it to the top. >=20 > Also I think last_hit_time is by definition time, that the rule was hit. > I think you have couple of options: > 1. keep last_hit_time but then set it to he time the last packet was seen= . > In this case the type should be changed to 64 bit. >=20 > 2. set the name to remaining time - in this case it should show the remai= ning > time. > I think that maybe this is worth adding in any case. Since I can see a lo= t of > uses to know how long this flow will age. >=20 > 3. rename to seconds_since_last_hit >=20 > What do you think? I will go with option 3. >=20 > > + > > +/** > > * @warning > > * @b EXPERIMENTAL: this structure may change without prior notice > > * > > -- > > 1.8.3.1