From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AE19A2EF1 for ; Sun, 15 Sep 2019 12:47:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F25471C1C9; Sun, 15 Sep 2019 12:47:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id A2FF41BFBA for ; Sun, 15 Sep 2019 12:47:40 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8FAjg9O022025; Sun, 15 Sep 2019 03:47:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=5+yTz6kbF/EfXM62JJdYhDyvr0G6ZIRJkwuHRAR1EuA=; b=JYzwq4cDMKUkK3yhRD/AZgcZdfYL3eQsxeZwDkMsvC6G4mBCtk/TsEFDAu8HdUMRyG6N kfQvdcMatGL5lAjrFczAmne2f5A2hGcdA22y0wM4FsiM0Eim6C0CeNJI2D2bNrv9mBzA lIS5OJKjUfzhzggNxiMVGzrDE6MYt431xSWbeDdW6GS1J4t3sF7GsLpMoz2ExB7fBt1+ pqSrbe1xAKL9Ddv4UxSj8SuuZFo7jIFrYMB502CN9TONNYxQtqQDE5cG/6gzBE+zeY4W I9eLLEDcVv4teeP5JDRNChqCByeeBYHLdvPtfp6Y0KFV2IOvYFiYcKJMu6ZAjmMdB3i2 vA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2v0wjpbe81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 15 Sep 2019 03:47:39 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 15 Sep 2019 03:47:38 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.51) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sun, 15 Sep 2019 03:47:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yf6ZFGtrRsF5944Wl55ZOPj9r+Yf7uyLz4kXXtB/TxFuWKhmwykhjtsPRMhxJMmvPflbmeZ+7K4tvUvJbhQaBMJ4B8dUo0xR7s5p5EwWoJ/bOvrOXpixATrcKrHeXJl/ru19kcTjkZuSHby2uP3JO6u+X7CMUXyzQfO5COzwyMo8TmNMZMOUwIq9eUUjKwROxKJwbc+fK1ubE8i7VlSgwOPO5v6eJf2lyh3fAILprwHVVg3DiGwRpXG6FhQvts07rnBFsUK1tPkoVkYCwQtXwQPrPzgJxDRNSOJGE1+0yXFRMg5WyTWz2dHNPoK3STZ2C8A6dtd4SARaZW9YDzamSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+yTz6kbF/EfXM62JJdYhDyvr0G6ZIRJkwuHRAR1EuA=; b=FcqDitWl8tvhr5fF8lHbAESHh8UgzeU++XOo+ITXSoh5iOPW5m2LN8I/RLauRvKDdy9Zo1X+YteeUBBZdHHA/hMFz2vJvJAsu+Hh5ONfT9PbJecGZ0YT9YtA+ClO1HlSHUhlYENk8QIfH8ctZQK0LGL271wzUfUSdrZMbwzxKTwHQFzTbfj3+z/8iG9Mbm3cCZZ5ldt2LSOL3fm7/5YiM34Q8R5395Vjr8X5dqiIah6ouXvOltDpqBjM0jT/wkvqWXP2HMxXbUJdvuISukDrewRSYDOvVMDMpvqJ34N0e5P5u6eQFk5+TSWFRA++cU8j0yZVHdAMmJY7jfb9Jx7YwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+yTz6kbF/EfXM62JJdYhDyvr0G6ZIRJkwuHRAR1EuA=; b=OEk+uznKSSD0troWiCcVPp6o972hMLDsQd4WqOftjQHlv9TFgYfeIHDXlvHfjW3sQrcgSLCbtZVfgHSz8q6zojNCks5TlYdRySx0r3SI6/R2r4J/k8d/OCXspJ3PqtIEWhfw2RxvoIWHhATpD20VruKsERgteEREZqUYI8dMSjI= Received: from MN2PR18MB2480.namprd18.prod.outlook.com (20.179.82.22) by MN2PR18MB2624.namprd18.prod.outlook.com (20.179.83.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Sun, 15 Sep 2019 10:47:35 +0000 Received: from MN2PR18MB2480.namprd18.prod.outlook.com ([fe80::65c2:e687:5420:9349]) by MN2PR18MB2480.namprd18.prod.outlook.com ([fe80::65c2:e687:5420:9349%4]) with mapi id 15.20.2263.023; Sun, 15 Sep 2019 10:47:35 +0000 From: Michael Shamis To: Akhil Goyal , "marko.kovacevic@intel.com" CC: "dev@dpdk.org" , Liron Himi Thread-Topic: [dpdk-dev] [PATCH 00/12] FIPS improvements Thread-Index: AQHVW+/zg7fNp1Ihm0m3sMI6mdHDAacbWyMAgAzutuA= Date: Sun, 15 Sep 2019 10:47:34 +0000 Message-ID: References: <20190826094120.22590-1-michaelsh@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [212.199.69.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94ccff67-56ec-4d38-4558-08d739ca1eb3 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2624; x-ms-traffictypediagnostic: MN2PR18MB2624: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01613DFDC8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(39850400004)(376002)(136003)(396003)(199004)(189003)(13464003)(76176011)(54906003)(110136005)(5660300002)(8936002)(14454004)(53936002)(9686003)(14444005)(256004)(52536014)(81166006)(33656002)(476003)(76116006)(66946007)(66556008)(64756008)(66446008)(66476007)(486006)(86362001)(81156014)(6246003)(305945005)(229853002)(6436002)(55016002)(7736002)(74316002)(8676002)(71190400001)(71200400001)(186003)(11346002)(446003)(478600001)(99286004)(2501003)(107886003)(2906002)(316002)(4326008)(6506007)(66066001)(25786009)(53546011)(6116002)(102836004)(7696005)(3846002)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2624; H:MN2PR18MB2480.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: SinURlOhLWEMSveHmM641PlyietwoCH1o9OXYBvf2ZTAh5MTpvRTTA31wN0HfiSxDY0KV+t1kdd+06FA5ngC4pNwTIbR8xklLp5uwlVQpC7XAGb8k9Syc27Lah0plgeXfKbv5H2YFndML+NNzvgjbK8A97T8HpGnnUp8oGQkhIhOCqsEJVKm/bA+USUAtu+9nCH+MVqFD3vGIWD45NIWBywk6WvXG8WLpRk8pqFFfANtoKQ6eOkOhiugGMxrQVJB/okDuHLszba+2lTGELnjAFE378dGVeDkK7V7vanrP1e7xhWOC8ZTmO+1+Ctur3lIkqmvHXn7eXD5FZdNbSGdMzuFyO0+3Jf1A0GltzfR9bJwaUC+pObtIzs9N8OK31atioB14yMznEIXnNOoDpaIzwTUsUJ6xYfqfntFvWK/K2w= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 94ccff67-56ec-4d38-4558-08d739ca1eb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2019 10:47:35.5008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BhKJ9FHpkBAdVf8PM4flRRqi0gZ1adoA/OyJBylReHldQMqcEoilxXsM0byZQi0cdRjEUcTFZrTky0QDcUHM5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2624 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-15_05:2019-09-11,2019-09-15 signatures=0 Subject: Re: [dpdk-dev] [PATCH 00/12] FIPS improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, I send 2 patch sets: one for new functionality support and another one for = fixes. One patch was sent separately from both of the sets according to your requi= rement: >> examples/fips: fix bad return code in fips_test_parse_header() >examples/fips_validation: fix bad return value Can be a separate patch fro= m this set. Also send to stable. Please instruct me how to send the patches to stable. Thanks, Michael -----Original Message----- From: Akhil Goyal =20 Sent: Wednesday, September 4, 2019 1:14 PM To: Michael Shamis ; marko.kovacevic@intel.com Cc: dev@dpdk.org; Liron Himi Subject: [EXT] RE: [dpdk-dev] [PATCH 00/12] FIPS improvements External Email ---------------------------------------------------------------------- Hi Michael, Please try to improve descriptions and patch titles as per the suggestions = given below. There are many patches which are fixes. Are the eligible for backport to st= able branches? The support which is getting added, is it eligible for documentation update= for the application. -Akhil >=20 > Added support for ECB mode in TDES and AES. > Fixed some bugs in TDES and AES-GCM. >=20 > Michael Shamis (12): > examples/fips: added support for SHA algorithm in FIPS tests examples/fips_validation: support SHA > examples/fips: added support for TDES ECB mode in FIPS tests examples/fips_validation: support TDES ECB > examples/fips: added support AES ECB mode in FIPS tests examples/fips_validation: support AES ECB > examples/fips: fix bad return code in fips_test_parse_header() examples/fips_validation: fix bad return value Can be a separate patch from= this set. Also send to stable. > examples/fips: AES-GCM vectors will use aead structure examples/fips_validation: use AEAD based structs for AES-GCM rather it is a= fix and should be sent to stable and the title would be examples/fips_validation: fix structs used for AES-GCM > examples/fips: set initial IV in AES-GCM if configured only salt=20 > value examples/fips_validation: initialize IV for AES-GCM > examples/fips: keep digest after crypto text examples/fips_validation: move digest after cipher text > examples/fips: AES-GCM decryption vectors fix examples/fips_validation: fix AES-GCM decryption vector Add fixes line and = cc stable. Can be a separate patchset for fixes. > examples/fips: fix KEY and PT output prints for TDES mode Does not have a patch description and title does not look to justify the pa= tch. > examples/fips: supported IV, PT and CT init for TDES ECB mode Again there is no patch description and title is pretty long. Try to make i= t short. > examples/fips: algorithm definition by folder if it's not in file examples/fips_validation: improve algo parsing logic update description tex= t to elaborate the need for this logic > examples/fips: erroneous overwrite of PLAINTEXT after DECRYPT examples/fips_validation: fix plain text overwrite send to stable and add f= ixes line. >=20 > examples/fips_validation/fips_validation.c | 92 ++++++-- > examples/fips_validation/fips_validation.h | 7 + > .../fips_validation/fips_validation_aes.c | 1 + > .../fips_validation/fips_validation_gcm.c | 39 +++- > .../fips_validation/fips_validation_tdes.c | 7 + > examples/fips_validation/main.c | 204 +++++++++++++++--- > 6 files changed, 301 insertions(+), 49 deletions(-) >=20 > -- > 2.23.0