From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8232F3256 for ; Fri, 12 Apr 2019 09:08:19 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3C6tTvg007577; Fri, 12 Apr 2019 00:08:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=HpN3w+OhKHF80rKLvUhbBgyXicLJS5qyOAO2Z+kndkM=; b=OmWdSYC/OG8t29aLlXsyVTcMwGwt7mgmMMwt6PaKoipiiNzOmTT0xn0RmxRhLeucgZVY eVRkS75TYdzFmDMsmyLKEsFvt0RB2lyliIhtkwTHw48cPOGzXQ2nwLlS7m14ZE3WAV// 1RuzLXCmYXTXVUPjPdnYlnihPPY3YU5QT0y3mejXqS1Yc9tQylzSjn73xK3wnhKIvD2V yv4H0P1vSZiaMDnzjSMV39WclN1ZLURB01eVyTqUZ0NT2x0R5kvLtyzN5jPcu+d4ZZo/ qzIkzkS3Zgs2f4hRA80meC/XPRQ2HnWUW+ax6UoKgHTgU3MKEjcjEahkkExKwkdTyUsQ Qg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2rt2xvc513-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2019 00:08:18 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Apr 2019 00:08:16 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 12 Apr 2019 00:08:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpN3w+OhKHF80rKLvUhbBgyXicLJS5qyOAO2Z+kndkM=; b=LCfUxONoQpQseQgYMgligGnyHiBJCXA7dmPrVtE3DDeCsDJKvlHMMWx7IL6TEpVEmwidPuOpF46M0wocj5HZ8LgPIlw50QMvq7pc7Qe+eO94V1XHIkkn7yYSShYFVUbX5bIVLagelVH+KGvfFX7XuaBXKs8czhVh6K0LG9EXmYs= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2493.namprd18.prod.outlook.com (20.179.82.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Fri, 12 Apr 2019 07:08:14 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1771.016; Fri, 12 Apr 2019 07:08:14 +0000 From: Ayuj Verma To: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" , "De Lara Guarch, Pablo" CC: Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Thread-Topic: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Thread-Index: AQHU7sgbOe99eNqykkejJ7mQ56SJHKYz8Q2AgAQtLFM= Date: Fri, 12 Apr 2019 07:08:14 +0000 Message-ID: References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com>, <348A99DA5F5B7549AA880327E580B4358973CC8B@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358973CC8B@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26a486a1-34a4-4adc-00d3-08d6bf15a1b5 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR18MB2493; x-ms-traffictypediagnostic: MN2PR18MB2493: x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(346002)(376002)(366004)(13464003)(189003)(199004)(186003)(8676002)(81156014)(81166006)(486006)(6116002)(3846002)(8936002)(476003)(446003)(7696005)(99286004)(11346002)(6506007)(2906002)(68736007)(55236004)(52536014)(76176011)(105586002)(316002)(26005)(5660300002)(19627405001)(54906003)(110136005)(102836004)(33656002)(53546011)(106356001)(99946001)(14444005)(256004)(6246003)(4326008)(14454004)(229853002)(6436002)(25786009)(478600001)(6606003)(71190400001)(71200400001)(53936002)(7736002)(97736004)(54896002)(9686003)(236005)(86362001)(74316002)(55016002)(66066001)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2493; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kayIu/RcUOZEqJaYdd5bD7FZJPt09G6maJMKVXlEPeKN+i0KlJtfSXGkZ+X7Rp7b9Zxxuemgnza/aVriuwBBu/B+laJ133C51aW+7FNiRYAJ8mI4pr0ICw0Li6tBqp2b06GWGFVNNONtxjbVSUUT+j+aYGtKxKDsaEQwS34gbYY3KtwZR9QAaAzmRLql80UteXa6BR7Ur3qNxXYpijpQTSKmnh9jOfQEpPbdE/L7OYnfB9mLDGYFMa4m8g1RtTiLn/j0WXx0TlB6vPXjqdDiB5ClE7xGOC3vM9T0FXAeGmvI+aOlM2vyTByH6n+wVHiq1qpQI31LAF3Anw9qwnyXxjoPh1dvvR8Q1V2AMPR1ZT9mh3tGT8rSkIxudX0H68pZlezOlKaMgs3qS5KP8aXjg5yzn4yKeQ4eN1opl9ssxxU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 26a486a1-34a4-4adc-00d3-08d6bf15a1b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 07:08:14.6305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2493 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-12_05:, , signatures=0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 07:08:19 -0000 Hi Fiona, Please see inline. Thanks and regards Ayuj Verma ________________________________ From: Trahe, Fiona Sent: 09 April 2019 20:47 To: Ayuj Verma; akhil.goyal@nxp.com; Kusztal, ArkadiuszX; De Lara Guarch, P= ablo Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@d= pdk.org; Trahe, Fiona Subject: RE: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Tuesday, April 9, 2019 12:34 PM > To: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > ; De Lara Guarch, Pablo > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma > Subject: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP > > Return -ENOTSUP for unsupported tests > > Signed-off-by: Ayuj Verma > Signed-off-by: Shally Verma > --- > app/test/test_cryptodev_asym.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index d2efce9..feed3a8 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -352,7 +352,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } > > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -498,7 +498,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } > > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1261,7 +1261,7 @@ static inline void print_asym_capa( > &modinv_xform.xform_type, "modinv") < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] this looks more like a test code bug rather than an indication that= the device doesn't support modinv. SO should still return -1. Also - while you're updating, can you please fix the typo in the trace - AS= YNC should be ASYMM [Ayuj] Each test execute if device supports that algorithm else it is skip= ped. Thus, here it checks if modinv is not supported in capability then ski= p the test, which looks okay to me. So, why do you say it is a bug? Probably message is not proper should have been "Device doesn't support MOD= INV" Will update typo. > } > > cap_idx.type =3D modinv_xform.xform_type; > @@ -1273,7 +1273,7 @@ static inline void print_asym_capa( > modinv_xform.modinv.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] please update the trace to match the return, e.g. something like "m= odulus length %len not supported by this device" [Ayuj] Sure. > } > > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1380,7 +1380,7 @@ static inline void print_asym_capa( > < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; > } [Fiona] same as above, i.e. code bug. And typo in trace. > > /* check for modlen capability */ > @@ -1391,7 +1391,7 @@ static inline void print_asym_capa( > capability, modex_xform.modex.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] same as above. Fix trace. > } > > /* generate crypto op data structure */ > -- > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3A41CA0096 for ; Fri, 12 Apr 2019 09:08:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B15433772; Fri, 12 Apr 2019 09:08:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8232F3256 for ; Fri, 12 Apr 2019 09:08:19 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3C6tTvg007577; Fri, 12 Apr 2019 00:08:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=HpN3w+OhKHF80rKLvUhbBgyXicLJS5qyOAO2Z+kndkM=; b=OmWdSYC/OG8t29aLlXsyVTcMwGwt7mgmMMwt6PaKoipiiNzOmTT0xn0RmxRhLeucgZVY eVRkS75TYdzFmDMsmyLKEsFvt0RB2lyliIhtkwTHw48cPOGzXQ2nwLlS7m14ZE3WAV// 1RuzLXCmYXTXVUPjPdnYlnihPPY3YU5QT0y3mejXqS1Yc9tQylzSjn73xK3wnhKIvD2V yv4H0P1vSZiaMDnzjSMV39WclN1ZLURB01eVyTqUZ0NT2x0R5kvLtyzN5jPcu+d4ZZo/ qzIkzkS3Zgs2f4hRA80meC/XPRQ2HnWUW+ax6UoKgHTgU3MKEjcjEahkkExKwkdTyUsQ Qg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2rt2xvc513-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2019 00:08:18 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Apr 2019 00:08:16 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 12 Apr 2019 00:08:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpN3w+OhKHF80rKLvUhbBgyXicLJS5qyOAO2Z+kndkM=; b=LCfUxONoQpQseQgYMgligGnyHiBJCXA7dmPrVtE3DDeCsDJKvlHMMWx7IL6TEpVEmwidPuOpF46M0wocj5HZ8LgPIlw50QMvq7pc7Qe+eO94V1XHIkkn7yYSShYFVUbX5bIVLagelVH+KGvfFX7XuaBXKs8czhVh6K0LG9EXmYs= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2493.namprd18.prod.outlook.com (20.179.82.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Fri, 12 Apr 2019 07:08:14 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1771.016; Fri, 12 Apr 2019 07:08:14 +0000 From: Ayuj Verma To: "Trahe, Fiona" , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" , "De Lara Guarch, Pablo" CC: Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Thread-Topic: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Thread-Index: AQHU7sgbOe99eNqykkejJ7mQ56SJHKYz8Q2AgAQtLFM= Date: Fri, 12 Apr 2019 07:08:14 +0000 Message-ID: References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com>, <348A99DA5F5B7549AA880327E580B4358973CC8B@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358973CC8B@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26a486a1-34a4-4adc-00d3-08d6bf15a1b5 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR18MB2493; x-ms-traffictypediagnostic: MN2PR18MB2493: x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(346002)(376002)(366004)(13464003)(189003)(199004)(186003)(8676002)(81156014)(81166006)(486006)(6116002)(3846002)(8936002)(476003)(446003)(7696005)(99286004)(11346002)(6506007)(2906002)(68736007)(55236004)(52536014)(76176011)(105586002)(316002)(26005)(5660300002)(19627405001)(54906003)(110136005)(102836004)(33656002)(53546011)(106356001)(99946001)(14444005)(256004)(6246003)(4326008)(14454004)(229853002)(6436002)(25786009)(478600001)(6606003)(71190400001)(71200400001)(53936002)(7736002)(97736004)(54896002)(9686003)(236005)(86362001)(74316002)(55016002)(66066001)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2493; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kayIu/RcUOZEqJaYdd5bD7FZJPt09G6maJMKVXlEPeKN+i0KlJtfSXGkZ+X7Rp7b9Zxxuemgnza/aVriuwBBu/B+laJ133C51aW+7FNiRYAJ8mI4pr0ICw0Li6tBqp2b06GWGFVNNONtxjbVSUUT+j+aYGtKxKDsaEQwS34gbYY3KtwZR9QAaAzmRLql80UteXa6BR7Ur3qNxXYpijpQTSKmnh9jOfQEpPbdE/L7OYnfB9mLDGYFMa4m8g1RtTiLn/j0WXx0TlB6vPXjqdDiB5ClE7xGOC3vM9T0FXAeGmvI+aOlM2vyTByH6n+wVHiq1qpQI31LAF3Anw9qwnyXxjoPh1dvvR8Q1V2AMPR1ZT9mh3tGT8rSkIxudX0H68pZlezOlKaMgs3qS5KP8aXjg5yzn4yKeQ4eN1opl9ssxxU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 26a486a1-34a4-4adc-00d3-08d6bf15a1b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 07:08:14.6305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2493 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-12_05:, , signatures=0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412070814.oxDJ3IlJmDLdTTF8Q97z9g-O752ZVJAVOUnjGAjeRm8@z> Hi Fiona, Please see inline. Thanks and regards Ayuj Verma ________________________________ From: Trahe, Fiona Sent: 09 April 2019 20:47 To: Ayuj Verma; akhil.goyal@nxp.com; Kusztal, ArkadiuszX; De Lara Guarch, P= ablo Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@d= pdk.org; Trahe, Fiona Subject: RE: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Tuesday, April 9, 2019 12:34 PM > To: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > ; De Lara Guarch, Pablo > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma > Subject: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP > > Return -ENOTSUP for unsupported tests > > Signed-off-by: Ayuj Verma > Signed-off-by: Shally Verma > --- > app/test/test_cryptodev_asym.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index d2efce9..feed3a8 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -352,7 +352,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } > > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -498,7 +498,7 @@ struct test_cases_array { > RTE_LOG(INFO, USER1, > "Device doesn't support sign op with " > "exponent key type. Test Skipped\n"); > - return TEST_SKIPPED; > + return -ENOTSUP; > } > > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1261,7 +1261,7 @@ static inline void print_asym_capa( > &modinv_xform.xform_type, "modinv") < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] this looks more like a test code bug rather than an indication that= the device doesn't support modinv. SO should still return -1. Also - while you're updating, can you please fix the typo in the trace - AS= YNC should be ASYMM [Ayuj] Each test execute if device supports that algorithm else it is skip= ped. Thus, here it checks if modinv is not supported in capability then ski= p the test, which looks okay to me. So, why do you say it is a bug? Probably message is not proper should have been "Device doesn't support MOD= INV" Will update typo. > } > > cap_idx.type =3D modinv_xform.xform_type; > @@ -1273,7 +1273,7 @@ static inline void print_asym_capa( > modinv_xform.modinv.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] please update the trace to match the return, e.g. something like "m= odulus length %len not supported by this device" [Ayuj] Sure. > } > > sess =3D rte_cryptodev_asym_session_create(sess_mpool); > @@ -1380,7 +1380,7 @@ static inline void print_asym_capa( > < 0) { > RTE_LOG(ERR, USER1, > "Invalid ASYNC algorithm specified\n"); > - return -1; > + return -ENOTSUP; > } [Fiona] same as above, i.e. code bug. And typo in trace. > > /* check for modlen capability */ > @@ -1391,7 +1391,7 @@ static inline void print_asym_capa( > capability, modex_xform.modex.modulus.length)) { > RTE_LOG(ERR, USER1, > "Invalid MODULOUS length specified\n"); > - return -1; > + return -ENOTSUP; [Fiona] same as above. Fix trace. > } > > /* generate crypto op data structure */ > -- > 1.8.3.1