From: Ayuj Verma <ayverma@marvell.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: Shally Verma <shallyv@marvell.com>,
Sunila Sahu <ssahu@marvell.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers
Date: Tue, 16 Apr 2019 16:15:55 +0000 [thread overview]
Message-ID: <MN2PR18MB25427C462B53137B77330221AD240@MN2PR18MB2542.namprd18.prod.outlook.com> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B4358973F9C4@IRSMSX101.ger.corp.intel.com>
Hi Fiona,
Sorry for delay in response.
Please see inline.
Thanks and regards
Ayuj Verma
________________________________
From: Trahe, Fiona <fiona.trahe@intel.com>
Sent: 12 April 2019 20:47
To: Ayuj Verma; akhil.goyal@nxp.com; Kusztal, ArkadiuszX
Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@dpdk.org; Trahe, Fiona
Subject: RE: [PATCH v1] fix alphabetical ordering of headers
Hi Ayuj,
> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma@marvell.com]
> Sent: Friday, April 12, 2019 8:03 AM
> To: akhil.goyal@nxp.com; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>
> Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; adesai@marvell.com;
> dev@dpdk.org; Ayuj Verma <ayverma@marvell.com>
> Subject: [PATCH v1] fix alphabetical ordering of headers
>
> rte_crypto_sym.h is included prior to rte_crypto_asym.h
> in rte_crypto.h, which breaks alphabetical order.
>
> include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
[Fiona] I presume you tried just swapping the order and it broke?
If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it
probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h?
[Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h?
next prev parent reply other threads:[~2019-04-16 16:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 7:03 Ayuj Verma
2019-04-12 7:03 ` Ayuj Verma
2019-04-12 7:03 ` [dpdk-dev] [PATCH v1] lib/crypto: " Ayuj Verma
2019-04-12 7:03 ` Ayuj Verma
2019-04-18 3:58 ` Anoob Joseph
2019-04-18 3:58 ` Anoob Joseph
2019-04-22 12:52 ` Shally Verma
2019-04-22 12:52 ` Shally Verma
2019-04-23 5:42 ` Anoob Joseph
2019-04-23 5:42 ` Anoob Joseph
2019-04-23 6:26 ` Akhil Goyal
2019-04-23 6:26 ` Akhil Goyal
2019-04-12 15:17 ` [dpdk-dev] [PATCH v1] " Trahe, Fiona
2019-04-12 15:17 ` Trahe, Fiona
2019-04-16 16:15 ` Ayuj Verma [this message]
2019-04-16 16:15 ` Ayuj Verma
2019-04-16 7:40 Akhil Goyal
2019-04-16 7:40 ` Akhil Goyal
2019-04-17 9:57 Akhil Goyal
2019-04-17 9:57 ` Akhil Goyal
2019-04-17 11:24 ` Trahe, Fiona
2019-04-17 11:24 ` Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB25427C462B53137B77330221AD240@MN2PR18MB2542.namprd18.prod.outlook.com \
--to=ayverma@marvell.com \
--cc=adesai@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=kkotamarthy@marvell.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).