From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4B11A04A2; Tue, 12 May 2020 15:26:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A58231BF75; Tue, 12 May 2020 15:26:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id AF5FA1BF31 for ; Tue, 12 May 2020 15:26:47 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04CDLFFC002813; Tue, 12 May 2020 06:26:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=LyB1JpPK92aBQU+LkmpjJcSliXfoH5WYqvICt1uyFA8=; b=aGXnFTlDESfLmqllaTn13sJ615OFkMw8tArDgEK8SPU4lF2GZEek4rd1qboSLS5Zpcx0 eMeHhVz6AbtjQuVo9W/nXBtS66RzwhHLzv1MuVOGjkmMeke3/B54sWD2O98GZ9t/xXon 7JPrfTBE9+ituhhv1RfVXb216FRU+DfPXrNrPEfe5yl9Y94nr/ON6MHLhI9pd43GesG9 FLXYiIfWe3M7DzJNdFltvwikPLU8Yz20ufdCqeJLBepDCRf1uxa+fCXG7KrYBlNtyPe7 nG/EA7LpxSSw8GydzvCy6HBXXnvo3xb3s0orvKfqp5kQ5wNUgpOOep/GjKr/qKkegPR8 Ow== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30wsvqkxqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 May 2020 06:26:46 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 May 2020 06:26:45 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 12 May 2020 06:26:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b8eaGAcKou4BSJDciTIGaD65ehnSABc8dxu67ypzIzddIMC8zSYkJ1hi5HSA+Om3+GFHHEt8Tl9j6aa9KbpKjl890mZ2NpRx3aStSMiujdZDjFUzj3+3+G6CpR39vtGbZv8yYujgclDethnA58bH7ZtSD0irrbulc78bei3QVPem6Qry1igoPtFIurpwyEwwDN5g72Yci+oIN22F34bW7eY+SWlAR19cZz5VJGJ/d+WnbZR7/ZBl+RsREZBKFDBwE8dDAx3ZOnR+uJG3Yf1aqJQ7EOIhkuUuqqi5a5fTqpwPuZ+hhDwA2fObIXm32nlgBMdPAydzBz3tPrEhI+GqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LyB1JpPK92aBQU+LkmpjJcSliXfoH5WYqvICt1uyFA8=; b=FLK3dVg22X0Uk2HuZoulN+SEbYiiysLhoi+rkqhRR2ZExYH7eg/QuJQsx5uV6cFf5+AEVjO46xzBbXk7drGZfMEs3BjXLBECGlbcFe/+yifJgo/6lq0JnQgr0+mCLCuZdhLW+oupbgSHJE6SGcusPvUglwY7kfTbuHNs7GvFm5ZnqoLl02tXnx91RFm3dWTCNjUcbuSTiMa0C8oyVcHhC+wiRIBo6dA1RNiM7tmeBbl840DJ2rnLNRubpJb/ML6lZkAgWQW0QGQcQu4gJ5z/kp08UIgmgC0jOmhVA/Ysl68Zvd7ozSsZ9A/SfcmLZHEB/lQEeazB8jZ7ufDB3uCUVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LyB1JpPK92aBQU+LkmpjJcSliXfoH5WYqvICt1uyFA8=; b=Pb6Xu4d83grnfczJ/xsBM7FqXP2zfRXvnMUxQ10VR+ncuVognprPrlw6RPhGc/8B4CqvB8c4CsIA2v4mXH/deBZIAAUkI54mtAv7dXM51mWS1zM/lonsaJK9D40HUSgzhnisseE4+mzpk9C/9Dzg4fdfNH4l1+rYyJnxbAzsQIs= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3671.namprd18.prod.outlook.com (2603:10b6:208:26a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Tue, 12 May 2020 13:26:43 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f%7]) with mapi id 15.20.2979.033; Tue, 12 May 2020 13:26:43 +0000 From: Anoob Joseph To: "Dybkowski, AdamX" , Akhil Goyal , "Doherty, Declan" CC: Narayana Prasad Raju Athreya , Ankur Dwivedi , "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors Thread-Index: AQHWKF5djITQg8NYKUyAkOKTxbsonaikbafw Date: Tue, 12 May 2020 13:26:43 +0000 Message-ID: References: <1589267544-18134-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [111.125.205.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc41c219-04d4-4425-f0b3-08d7f6781cca x-ms-traffictypediagnostic: MN2PR18MB3671: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lCw7rpXrhEVrK1t04ONuv6KLWxYm8k/+7rJMug2uKvYObnwaSgPYp2IQY4g9MTJRWSOr6leZeK9pYSfVyiPeQ8wj3NHZKeM7gyNzvgIqc51R8tYr6PPbUnkLxUHAQW8JRgnwB7i7lvUYf6Oe42GFjnm5/aEEB/qjUQTfwBG5h9S4mXuFBgonbmZ1OcO9AkSKXxB3AaIqlSEi6n0VutTLx8KMnR6/v054PtdLjdw/XYKcfUnetwa7NinwRmh8lYAm5pp3nf1bqG5u+9p1LnCv3KygiB+FTZk1NS9Qm+VdZUX/+XPJbIt48o6BQdfg1U7veF8I/EnCfcLuOpZ9WLdErK+L4+0uRDUc+tAHbizkclBoBLESnWOFdkkz3Kezr4ULXURMCnwCNNxC8YeM/CUZ7r/7azlBNt7JcjIX7rXxBO4S3EUwIkl8wj9msxfqum9p3A47XkThGeB/R3oX4YDsc7kfV/IUL7V11xYTpRDUA06tKSBKgxaqJYmpvpG7qAfNqlJLHieS5plKuKY6CjAzmQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(33430700001)(7696005)(6506007)(53546011)(55236004)(5660300002)(498600001)(33440700001)(54906003)(110136005)(26005)(71200400001)(186003)(9686003)(8936002)(4326008)(52536014)(66446008)(55016002)(76116006)(66946007)(66556008)(86362001)(64756008)(2906002)(33656002)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: KLt/fW6dByhUyDDDLHjLCONsrkuRiXUdDKncAN9qtesr/hd2BXhrnn7UE8ASbA3il8cN092p2dbUptvAEcXW+e5hwH8y+fOE/oqKLO0A8LRahhsyIlssTR9zi6DHLup2c9Wn1W1672pkV0JMKZJKZItSAt2eBjqUWqowDZVGZM/cM/AkPM/FEx44P2OVdCM6Kt2cmu9U2BcdVo+8fheKkacTuMKrKQa85XVfRO38zQg3jvxXWGnvsnPfYytYyOVD7uyJV1CXm6sz1fZbu24BYGiDEDkqPUK9/Mr8RqQB1Vk7vYYYuQPqOv+IYs5fqIFvBdxPWGZ4xWO68ZYWct4VNDdQ1zbel7J66rUwxKUrFLGVBw/FWYQJNDrqn4IDbOusJoUekuPRdzssx8qY0yLkLIETOn0ayrWCgKiJRbPHHCQqLFwsXHuHZnrGJTVhJMEfcuY3OPKemUr68bsHBnH0sDSb0DNtgIav9pkQ1Kr1Cw+hUGBhCxOtwwq1dk9s3bte Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dc41c219-04d4-4425-f0b3-08d7f6781cca X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 13:26:43.4705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G6y/L2bmFuu1uGWy9cWuht5rXg9eBkaCEOw/sdGtm4oIXDdgoxqhIcogdtLam/KYydtO7gvuhzCpRGkuPypBCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3671 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-12_03:2020-05-11, 2020-05-12 signatures=0 Subject: Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, The crypto library doesn't specify an upper limit for the nb_descriptors to= be passed for queue_pair_setup. So technically all the values that you hav= e passed as invalid is not correct. I did check few PMDs when I saw this issue with OCTEON TX2 crypto PMD. QAT = support max 4096 descriptors and so the invalids that is present is exactly= following that. I checked DPAA drivers, but in that the entire conf is lef= t unused. So I'm not sure whether DPAA passes these cases. I couldn't check= the entire list that you have mentioned. But it doesn't much sense for s/w= PMDs to limit max_nb_descriptors.=20 If we need to have an invalid check, we should probably add max_nb_descript= ors in dev_info. And then we can have these tests. I'm open for that idea a= lso. But I don't know whether that is allowed now or not. I leave that to A= khil. Thanks, Anoob > -----Original Message----- > From: Dybkowski, AdamX > Sent: Tuesday, May 12, 2020 6:37 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan > Cc: Narayana Prasad Raju Athreya ; Ankur Dwivedi > ; De Lara Guarch, Pablo > ; dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH] test/crypto: remove tests for > unsupported descriptors >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob. >=20 > What's wrong with this test? Is this unit test failing on any PMD now? > I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, > SCHEDULER) and it passes everywhere. Then why should we remove it > completely? >=20 > Adam >=20 > > -----Original Message----- > > From: dev On Behalf Of Anoob Joseph > > Sent: Tuesday, 12 May, 2020 09:12 > > To: Akhil Goyal ; Doherty, Declan > > > > Cc: Anoob Joseph ; Narayana Prasad > > ; Ankur Dwivedi ; De Lara > > Guarch, Pablo ; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported > > descriptors > > > > Cryptodev doesn't limit the number of descriptors that can be > > supported by the PMD. > > > > Signed-off-by: Anoob Joseph > > --- > > app/test/test_cryptodev.c | 45 > > --------------------------------------------- > > 1 file changed, 45 deletions(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index > > c624018..1ed2df8 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) > > ts_params->valid_devs[0]); > > } > > > > - /* invalid number of descriptors - max supported + 2 */ > > - qp_conf.nb_descriptors =3D MAX_NUM_OPS_INFLIGHT + 2; > > - > > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > > - ts_params->valid_devs[0], qp_id, &qp_conf, > > - rte_cryptodev_socket_id( > > - ts_params->valid_devs[0])), > > - "Unexpectedly passed test for " > > - "rte_cryptodev_queue_pair_setup:" > > - "num_inflights %u on qp %u on cryptodev > > %u", > > - qp_conf.nb_descriptors, qp_id, > > - ts_params->valid_devs[0]); > > - } > > - > > - /* invalid number of descriptors - max value of parameter */ > > - qp_conf.nb_descriptors =3D UINT32_MAX-1; > > - > > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > > - ts_params->valid_devs[0], qp_id, &qp_conf, > > - rte_cryptodev_socket_id( > > - ts_params->valid_devs[0])), > > - "Unexpectedly passed test for " > > - "rte_cryptodev_queue_pair_setup:" > > - "num_inflights %u on qp %u on cryptodev > > %u", > > - qp_conf.nb_descriptors, qp_id, > > - ts_params->valid_devs[0]); > > - } > > - > > qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT; > > > > for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > > @@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) > > ts_params->valid_devs[0]); > > } > > > > - /* invalid number of descriptors - max supported + 1 */ > > - qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT + 1; > > - > > - for (qp_id =3D 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > > - ts_params->valid_devs[0], qp_id, &qp_conf, > > - rte_cryptodev_socket_id( > > - ts_params->valid_devs[0])), > > - "Unexpectedly passed test for " > > - "rte_cryptodev_queue_pair_setup:" > > - "num_inflights %u on qp %u on cryptodev > > %u", > > - qp_conf.nb_descriptors, qp_id, > > - ts_params->valid_devs[0]); > > - } > > - > > /* test invalid queue pair id */ > > qp_conf.nb_descriptors =3D DEFAULT_NUM_OPS_INFLIGHT; > > /*valid */ > > > > -- > > 2.7.4