From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E825EA0613 for ; Thu, 26 Sep 2019 13:21:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18D292F4F; Thu, 26 Sep 2019 13:21:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 900042C38; Thu, 26 Sep 2019 13:21:53 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8QBLp3T031851; Thu, 26 Sep 2019 04:21:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=PZqdUNb6zbe0K/LNuG1q5iP3c/yscy25g8VUiZgZvHQ=; b=WKBfEtNYOVWPx5f/yDv2eukXUsGCcQdn+vKrAXBSApK8rXyFbByay1e1qMi370Q9G6bd l2cvWG5hGfBXrzGkEcr2+Sd4OCDbWnSzLk9ygD9ZrE7snv+xksQFJWBd6czSIlHMJyLq Ta8ySdnFJwU//EBJb3rOJBPUK9zBYeF9nY/zyTOB14Fwm7+YCHXLzj62S89hrxq3WpSO PCjXD5kmfGXzxhbVkPUhaBR+1OnBYHDsTm4rYjp+UuZXBtzgXduPs9JCMlMU3vPdP5FF 6PivGV8/2OYrincukl7CXqweI5JbinvCiR4+fjHsUAaep7K061fJUKC/P85tEk7GtVVM Yg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2v8vct001f-12 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 26 Sep 2019 04:21:51 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 26 Sep 2019 04:20:57 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.52) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 26 Sep 2019 04:20:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6h07T0U7rVCxts45rGWn0kJ6wNZc1ravizrI7RK5mW1EONPTbj+FjRUO9+rEdposZLKisro2KQnh40IKtZy/XTBu+Oa2ZRgXdLDd6BQuVtMUhXj39v1zZmRawX0Jg5OHk+qtSQAm1XCwkSnl/IO9TERB5qkFT0Yd3Yopm3yIU5+JcKrjxOaSSkvDsjWnMtiJ7WGglIs5telbPlpPCRpirxBIecoljtbQmm9Mz6NVBKjLc0INSPvh4ZaJ6rhFa7E7PcjqsvwVRynRH7BaZtah1SR5ZsCAHTg7n1hc/quGtFVl7Sv+q91qtbR/aDuqjUQcn65Rl2pdHOi9/EStMEUkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PZqdUNb6zbe0K/LNuG1q5iP3c/yscy25g8VUiZgZvHQ=; b=KZHHt02eOTTJWg5g/QWKxCyDxgpqEBT990/DDK/zHppw0u8crnlddkOcoCmuT8RVOGW53SoRWWk5c6WYo+yopWnKx3R58jgGMnLM2TSnXfQU+rLXb7QiJj+dG9r9qSs0rHQxmJ014/rNmZWTAMAd7BaKiIin4w6clCDAq0BAzqtJSo2jyX5vF2I5SNADg4RzTvEritl3ktz6rOYLvbFTDI9eO4+lno/DQXYfZkRtl8nsazIOONb+baCoOvV1ulId0iKFzhhVmRuRO9PzGCptnL9PJOf8wiC+SO+CdM7VYisVdL4QK+y6zxJPDQPfJsNMsYToAfvdniUN+161vg+Ppg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PZqdUNb6zbe0K/LNuG1q5iP3c/yscy25g8VUiZgZvHQ=; b=gp01pP0FeGHNm2XNBmP02gDoFrKBKXUsjcuFUtAzi/3Ohr3G4qFsdMdZByChB00ASjKsvmlhuhffAhgGAAZ13mhdKjFAkZDbHGyhSQnsxgRZcMFfH8mMs6Z2EhFjUqT7IkolNdN/ZQIcOITTSvc39C/vXGoQMz/DUe9fPK1vGh0= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3406.namprd18.prod.outlook.com (10.255.238.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.26; Thu, 26 Sep 2019 11:20:54 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa%7]) with mapi id 15.20.2284.023; Thu, 26 Sep 2019 11:20:54 +0000 From: Anoob Joseph To: Ferruh Yigit CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [EXT] [PATCH 04/10] crypto/octeontx: fix global variable multiple definitions Thread-Index: AQHVY/mupczcUsu/CUyGdHExw4Mp8qc97TYQ Date: Thu, 26 Sep 2019 11:20:54 +0000 Message-ID: References: <20190905145315.19395-1-ferruh.yigit@intel.com> <20190905145315.19395-5-ferruh.yigit@intel.com> In-Reply-To: <20190905145315.19395-5-ferruh.yigit@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d930fbd-80a1-49e1-1982-08d74273989a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB3406; x-ms-traffictypediagnostic: MN2PR18MB3406: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0172F0EF77 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(13464003)(199004)(189003)(55016002)(26005)(9686003)(186003)(76176011)(6436002)(25786009)(53546011)(6506007)(55236004)(5660300002)(52536014)(54906003)(14454004)(8936002)(6916009)(305945005)(71190400001)(71200400001)(256004)(7696005)(81156014)(81166006)(102836004)(478600001)(8676002)(74316002)(7736002)(4326008)(76116006)(66556008)(64756008)(6246003)(66446008)(446003)(66946007)(33656002)(66476007)(11346002)(99286004)(316002)(2906002)(486006)(86362001)(229853002)(3846002)(6116002)(476003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3406; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: eX9vqDky8eXVwEn355MTl3cEAsr31cv9FPVHNTBsqdeiERneB9QJH4C9yLNXFoLKgb1lF6mv9g/gav82Zv03poa94a3p5U12m/Issf62Z3nvVI3ogaxfvryKdq9ET3VgFDBtbn4g8LBNAeo9wtZp2jaGc8lxGmUVJNaFSKoGYexOs9Mp5fBtftmsA1zERslUMShX/L+FqgM+KwkJp8hG2zCSGm8aTLCWknHH/Ijk6NM8TBb1r8vk9bIPnhYEN6VaBwpf54Hf4s2m9MaXjTztxfMuvraRv3HFSMYq+rQF3cIAGh3RHkDX68fxEs5G7hBwRl26+GDLc2XdNDGNFzqYlRgxs1fCiw+aTtf473i3Yn2klA9LLxydKfMX3cB1z7ubDcm/2hS/fs9LCgdMxP/0FAjufA18ByXUy4Mo9JPLs6w= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3d930fbd-80a1-49e1-1982-08d74273989a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2019 11:20:54.4243 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FOaZWOqZZ+dH1z4OgT2X+JZFSHy3i1RtF1DW3cuUatRMqDTGX30Qn1m1w7JTMppj2C4hdycBG1Z4uDmhdf0liw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3406 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-09-26_05:2019-09-25,2019-09-26 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 04/10] crypto/octeontx: fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, This patch could be problematic as our new PMD(crypto_octeontx2) also makes= use of some of these. I will propose a new patch with the required changes= so that you wouldn't see the mentioned issue. Does that sound ok? Thanks, Anoob > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, September 5, 2019 8:23 PM > To: Anoob Joseph > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [EXT] [PATCH 04/10] crypto/octeontx: fix global variable multipl= e > definitions >=20 > External Email >=20 > ---------------------------------------------------------------------- > 'cpt_logtype' & 'otx_cryptodev_driver_id' global variables are defined in= a > header file which was causing multiple definitions of the variables, fixe= d it by > moving them to the .c file. >=20 > Issue has been detected by '-fno-common' gcc flag. >=20 > Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/common/cpt/cpt_pmd_logs.h | 2 +- > drivers/crypto/octeontx/otx_cryptodev.c | 2 ++ > drivers/crypto/octeontx/otx_cryptodev.h | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/common/cpt/cpt_pmd_logs.h > b/drivers/common/cpt/cpt_pmd_logs.h > index 4cbec4e36..2681d1286 100644 > --- a/drivers/common/cpt/cpt_pmd_logs.h > +++ b/drivers/common/cpt/cpt_pmd_logs.h > @@ -45,6 +45,6 @@ > * cpt_logtype will be used for common logging. This field would be init= ialized > * by otx_* driver routines during PCI probe. > */ > -int cpt_logtype; > +extern int cpt_logtype; >=20 > #endif /* _CPT_PMD_LOGS_H_ */ > diff --git a/drivers/crypto/octeontx/otx_cryptodev.c > b/drivers/crypto/octeontx/otx_cryptodev.c > index fc64a5f30..604dc2cdb 100644 > --- a/drivers/crypto/octeontx/otx_cryptodev.c > +++ b/drivers/crypto/octeontx/otx_cryptodev.c > @@ -16,6 +16,8 @@ > #include "otx_cryptodev_ops.h" >=20 > static int otx_cryptodev_logtype; > +int cpt_logtype; > +uint8_t otx_cryptodev_driver_id; >=20 > static struct rte_pci_id pci_id_cpt_table[] =3D { > { > diff --git a/drivers/crypto/octeontx/otx_cryptodev.h > b/drivers/crypto/octeontx/otx_cryptodev.h > index 6c2871d71..0b204320a 100644 > --- a/drivers/crypto/octeontx/otx_cryptodev.h > +++ b/drivers/crypto/octeontx/otx_cryptodev.h > @@ -15,6 +15,6 @@ > /* > * Crypto device driver ID > */ > -uint8_t otx_cryptodev_driver_id; > +extern uint8_t otx_cryptodev_driver_id; >=20 > #endif /* _OTX_CRYPTODEV_H_ */ > -- > 2.21.0