From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B61D6A3168 for <public@inbox.dpdk.org>; Wed, 16 Oct 2019 06:18:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA03E1C1E6; Wed, 16 Oct 2019 06:18:57 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 369F61C1DD for <dev@dpdk.org>; Wed, 16 Oct 2019 06:18:56 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9G4Ei19022921; Tue, 15 Oct 2019 21:18:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=QemGMwdbKjGKjgtQeQumKPESImZrCp5UxnSr3YC6q7o=; b=yx/72TG/Lnb76fHmGX8MaY0fhIVUhhX33YU2vkiFz6rNEloy1hv/7V7omqZ6tAz40xIm F+4Z+0emili/hN2N0ut11SED9CclXGuBgyNP80QomAwy/hZ4Fk66bf96K9COHN9c4AQV Z0i/W9Ah3VuBRrsO3ckFh4RQcxyyUWc8Nb90neLAy5FKYhl5gXMDClTMHmsSFp8BZ4+f QbtXkzH5FYuiyK8BqDYPtiSdbWRnfe/Uvzv4rDrcMxzDgspx19zUjc46gj9FmcsRY0Cg PRMQoSMxpo9kostBL7aelMuW8GL8oQhp5ULPAY1oJ7z5/UrU4SURDkT9kyuU23TjM9io hA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2vnpmbh606-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2019 21:18:54 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 15 Oct 2019 21:18:53 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.58) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 15 Oct 2019 21:18:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QKisWrF2DZoGPREPYa476hqkMPErJixSOmgyh8EKSaxFXmrw8i8hAVBsbDtGH2XDrL3hSCSNXYxim1QELRYAfa+/akk0iJ4o8DjX2ZZhs8PdRnkV+8GoLaWXEZ+0IBUJv12uBxVa8Xh/xc8nAZ3jzGwuRUxz0fKBTPrDdU1Tq66vVMMh5jWzJdfaC1wv8k6V/CzQol9BOAAm2LL0wcMo1WPj3+fZuL+zPUQ/dkD75zFfNVWWsS2zTIeZ/w4fhewx9eZHcptB24wyYlvge5vJWffFqN/qwGNMYtzVU+s5gA1kWw1CVbseRE/QJXej5y+tR0Qr/wV/d79MtYdp/4krNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QemGMwdbKjGKjgtQeQumKPESImZrCp5UxnSr3YC6q7o=; b=mZqbKuJwZY+8aYriyWt/fPHyZPAQ37AZAHyjbSMfOsarUalnTPrTJ1LPfmQo58iBhxpDlbxx18RULZ3sZKOc1g2YmFiCT7NRrb9nMcigZg/Ri/XvTrwKMb+vbZln/gB7unzbE9lTs2Z1X5tDKdPiV5iOtBl/fbUrfr4SuIC892PCvhbKrYQUvkk0SJ4brpIokhixRUs6FKpFr+GAyZACk0X+VNqlVU4Gh9VaCYkPTLrBDROcVUhWEwKwTV/b9vMAyF1BMPLvGQTooQAwB766LgIFLAcpxBBqPetC6ECjj7wfjKjKI/BCAN4+y7CC6VNFzBZYloAvD54wjWt1KM+3jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QemGMwdbKjGKjgtQeQumKPESImZrCp5UxnSr3YC6q7o=; b=BI+zyOz8dC4b9+WMrO1fM692iw1FVNuJhz2NPNpWMgltgtU2aOWsElb1aY3/I8oMyAKhg6WdepTzhfK1XZ6SImtvU4+NZoEgAy63grwoWVcZKwYUBs7HX39f1d2V8Vd94g1be53kLg2Oyq8gReJlWvy6jEVhtmZYz4jMG/C/wtY= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3374.namprd18.prod.outlook.com (10.255.236.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.17; Wed, 16 Oct 2019 04:18:52 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::6d15:3367:4c9:5385]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::6d15:3367:4c9:5385%7]) with mapi id 15.20.2347.023; Wed, 16 Oct 2019 04:18:52 +0000 From: Anoob Joseph <anoobj@marvell.com> To: Akhil Goyal <akhil.goyal@nxp.com>, Bernard Iremonger <bernard.iremonger@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "Jerin Jacob Kollanukkaran" <jerinj@marvell.com>, 'Thomas Monjalon' <thomas@monjalon.net> Thread-Topic: [PATCH v2 0/3] examples/ipsec-secgw: set default Thread-Index: AQHVgDEPONKIrGA+PUqTjs6+K352NKdZgfzQ Date: Wed, 16 Oct 2019 04:18:52 +0000 Message-ID: <MN2PR18MB28771AA7890F26DFB2762845DF920@MN2PR18MB2877.namprd18.prod.outlook.com> References: <1567069173-10505-1-git-send-email-bernard.iremonger@intel.com> <1569943080-20228-1-git-send-email-bernard.iremonger@intel.com> <VE1PR04MB66394E65C755CF041E9F6067E6970@VE1PR04MB6639.eurprd04.prod.outlook.com> In-Reply-To: <VE1PR04MB66394E65C755CF041E9F6067E6970@VE1PR04MB6639.eurprd04.prod.outlook.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66016bbc-c6fb-460d-b565-08d751eff3c6 x-ms-traffictypediagnostic: MN2PR18MB3374: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <MN2PR18MB3374112DD2580D2F3700A519DF920@MN2PR18MB3374.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0192E812EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(396003)(366004)(136003)(376002)(53754006)(199004)(189003)(13464003)(6116002)(102836004)(7696005)(6506007)(186003)(55236004)(76176011)(446003)(26005)(11346002)(256004)(476003)(53546011)(71190400001)(71200400001)(486006)(99286004)(2906002)(3846002)(14444005)(66066001)(25786009)(7736002)(14454004)(305945005)(74316002)(66476007)(9686003)(478600001)(110136005)(76116006)(316002)(64756008)(66556008)(2501003)(66446008)(6436002)(66946007)(8936002)(229853002)(6246003)(55016002)(8676002)(81156014)(81166006)(33656002)(2201001)(5660300002)(52536014)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3374; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HySyTGNKTK1uZPxRpmkoxmurk0zBNmiwDhuNfMCTC7RqlH7/bGNxOWyx8zibHQlgNf7SNQWfm5fbGINaLNkyVLP1iXYeUgVnYRFPmMBwu+OVMcGA8rek9NttLZ4qw9qLxLelYNRAIBW8Pj/d6kx81g89G9JGreyQbF8K/1g8PEUKSWfhF+GbgP2z9fImYRbtb1I/CiDbmpfdIcW9iYDWoSJiHx65JWGDarM58ZjtdtCF+kreM01W/0v9cXsj79PT25jBXUWgu56fB3lMGWsyEWlOVgVg/b0NTEX3cmcQaBwmWCQGrbdnDHEJ22h2bZPL9iEQE0E5aDB0Dk4AgEZ5cunDZNaLSVr7A1nutcen6lrw9qJKiOVRb2TDliNYKvFw0bf3ZjX9CT2c2p3MriKxVGxY0aiXtQu5V4SCBqcxCLY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 66016bbc-c6fb-460d-b565-08d751eff3c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2019 04:18:52.4204 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6/T65X3CWdVwM1kioXAkAQTlvZKOlyuKK3czu+d7RsdTwzwxnJGDZBv+3EI4v7k6qnknMAczXCGPHWwVclX0IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3374 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-16_01:2019-10-15,2019-10-16 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Akhil, Marvell is NOT OK with this change in this cycle. The library is still emer= ging and the boundary between ipsec-secgw and lib ipsec still hasn't emerge= d clearly. Moreover, lib_ipsec mode isn't even working with the default con= f (I believe the fix for this still in discussion. The issue was reported b= y a Marvell engineer some time back). There are questionable features getti= ng pushed, for which Marvell's concerns were subdued. I would expect this taken up after lib ipsec is found stable for atleast on= e release cycle. As for the performance, we found 2-3% drop with the lib ipsec in the last r= elease (lookaside crypto mode). Yet to try out with latest codebase. With s= ome of the recent submissions, I expect an even higher performance hit. Als= o, eventmode ipsec-secgw (already submitted RFC) is using non lib ipsec mod= e. We don't have plans to move that to lib ipsec mode until lib ipsec is ma= de stable. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal <akhil.goyal@nxp.com> > Sent: Friday, October 11, 2019 6:10 PM > To: Bernard Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org; > konstantin.ananyev@intel.com; Anoob Joseph <anoobj@marvell.com>; > Jerin Jacob Kollanukkaran <jerinj@marvell.com>; 'Thomas Monjalon' > <thomas@monjalon.net> > Subject: [EXT] RE: [PATCH v2 0/3] examples/ipsec-secgw: set default >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi All, >=20 > This patchset would need ack from more vendors as it will impact user > experience on a key example application which is normally demonstrated to > customers. >=20 > IPSec library is still evolving and there are new functionality added eve= ry > release. > Atleast from NXP side we are not OK with this change. >=20 > I would hold this patch till RC2 atleast. >=20 > Regards, > Akhil >=20 > > -----Original Message----- > > From: Bernard Iremonger <bernard.iremonger@intel.com> > > Sent: Tuesday, October 1, 2019 8:48 PM > > To: dev@dpdk.org; konstantin.ananyev@intel.com; Akhil Goyal > > <akhil.goyal@nxp.com> > > Cc: Bernard Iremonger <bernard.iremonger@intel.com> > > Subject: [PATCH v2 0/3] examples/ipsec-secgw: set default > > > > This patch set, sets the default code path in the ipsec-secgw > > application to use the librte_ipsec. > > The *_old test scripts have been modified to use the legacy code path. > > > > Changes in v2: > > ------------- > > The error messages for the -l option have been updated. > > The pktest.sh script has been updated to drop the -l option. > > > > Bernard Iremonger (3): > > examples/ipsec-secgw: set default to IPsec library mode > > examples/ipsec-secgw: add -l 0 parameter to old scripts > > examples/ipsec-secgw: update pktest.sh script > > > > doc/guides/rel_notes/release_19_11.rst | 8 ++++ > > doc/guides/sample_app_ug/ipsec_secgw.rst | 6 ++- > > examples/ipsec-secgw/ipsec-secgw.c | 46 ++++++++++++++= ------- > - > > examples/ipsec-secgw/test/pkttest.sh | 1 - > > .../ipsec-secgw/test/trs_3descbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/trs_aesctr_sha1_old_defs.sh | 2 +- > > .../test/trs_aesgcm_inline_crypto_old_defs.sh | 2 +- > > examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_3descbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_aesctr_sha1_old_defs.sh | 2 +- > > .../test/tun_aesgcm_inline_crypto_old_defs.sh | 2 +- > > examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh | 2 +- > > 14 files changed, 52 insertions(+), 29 deletions(-) > > > > -- > > 2.7.4