From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 572B2A00BE; Wed, 8 Jul 2020 11:51:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1687D1DA9A; Wed, 8 Jul 2020 11:51:16 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 047751D502 for ; Wed, 8 Jul 2020 11:51:14 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0689pDwH026641; Wed, 8 Jul 2020 02:51:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=rHd8fp9nsb/mMcuNMVP+Ztk3HWL3SVfonT0ZNx9jdWg=; b=dizgGXhm03l4JMqhj/BLPHRy8kmaEDn0M9/WQuD+VVvPyoPFEqmTK/rEZwVm9ORMAAfL J4ZgHpqqPZFrqns+NcWQ/pSU+hHgVwFYNXz2NIwCMBCzjkfcjgKts9xCLg2lHH8HlUmR zUwAn8QvChcmrzztZruBfbqeVgtmZq0QRyNitqWaLc1aYJ7hXLgd9PxQ/Cts35J0qsj+ W/8mGJB90HGeWyyr6hB3igWbDxfop4B3eQDKjDW+7E+SptX7CaPkvHJq/SKXz1VdlNFF RLmtsnM3yZ9i0FJFbxLhNidWtUozNxhDUTJXiXlfDRVrAC9PcIV/t3PxRsKGuTTLQ3/M WA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 322s9nfa4n-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 08 Jul 2020 02:51:14 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 8 Jul 2020 02:51:13 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 8 Jul 2020 02:51:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gdY6Oe1KmqAMjb3FuGPHb740zVIXosNR+rKtu6KHFF7OrRhnlYDXMbSEBEdtpqRO9RekYUk3Unh4QyJILXbmizKGClTZ0UrlXm/5nzyzxG0KZwulp3AATvEgQhUXOQrpX+J//O7q3s71x1iv1CmZSPfXu6dn/rpLV/8RmNrb5H2YN52gQgZtajK/rf+FpxefyogD4f2Y/keI8rUdtmh8UYuBk3ovi+PDQqtDExE29qpO8pwNyBdvMCCUJ39hPXgzh9Yiqzw9Ein/yeR9beS0/SsQ2Gant54nQnMiZcaBaoBHDAg4XwQ+HdzqWLgzas5eaJD4gqxgPhQK8LnKKZiLlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rHd8fp9nsb/mMcuNMVP+Ztk3HWL3SVfonT0ZNx9jdWg=; b=n5mMPyJeVjqj3fM+WbgU4ekG9HO1I8gLst5xXPYZa/H4K1Xq4dvz2Qf1g+Ovp86rKxTC/ImyWw4GPCqllzKalvTleD5sGJ4ioCdclsV3S5ceZp5BFibj401Otg258kf2rricrlxaINluRk87CRFm3SD5UuQXG9oAxwzfxnZEOoq6fgIIA94929uPWCfOUB3BDUaSb9+v6A0gA1kNR4lLr7F4HgoZa6fgKQov53sdOX6sSgUEcDmNbzDPG27dRbK/1DjQzE9FiZ8zdmwtldIByuh+Ho1k5/9iIdbJEWYrlobQtXjpspZaCPtZWZA4W39rg27cMPOeGze3tyXzfAwoPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rHd8fp9nsb/mMcuNMVP+Ztk3HWL3SVfonT0ZNx9jdWg=; b=tP9MVFcCIMH+fHVF13I2jXnTEszFF8b1PS50EB7r8evVyjW1f0LmdWGJP3k2d3b8VT+ASNWc/x7MoA1SaezMeWE/hVHg98F/fjZgPV5MdeFaG9h2RBnhD0/YFb3A4KwlU7zrIj/1N1uYXHKtQQ0HlxXoqwT04GVf99eSPAsr1oY= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3087.namprd18.prod.outlook.com (2603:10b6:208:38::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Wed, 8 Jul 2020 09:51:11 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::a975:5b17:ebb4:722a]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::a975:5b17:ebb4:722a%4]) with mapi id 15.20.3153.030; Wed, 8 Jul 2020 09:51:11 +0000 From: Anoob Joseph To: Akhil Goyal , Ankur Dwivedi , "dev@dpdk.org" CC: "declan.doherty@intel.com" , Hemant Agrawal , Vakul Garg Thread-Topic: [PATCH] test/crypto: change cipher offset for esn vector Thread-Index: AQHWOxOwhhxiPZPiZkGBqoF0yFDIJqj6ql+AgAAsyoCAAEBYgIAAvBEAgADdrICAAPE+EA== Date: Wed, 8 Jul 2020 09:51:10 +0000 Message-ID: References: <1591345833-19159-1-git-send-email-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [27.34.244.73] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa7f2263-a8e5-438f-f680-08d823247202 x-ms-traffictypediagnostic: MN2PR18MB3087: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Tf9dypA1A8uKhGwT9tO8h89oOTzzMeNDzFue6wNInxy1344SjHfieqXXIpj5rIYBq+m4zPv0tkwm7GZvYAhQ1KFv+1F3IyO9BL4uJfP363VWYeXv8LqJK299mn+IiMk7cukvY1r8y0+Ki381Hjy+EgEQo9RIjpJKrbXfX2fLj4WAQEYODQnqcMBHRoWR9g0q9F/x8+nYiTl+2qm/+fR8HhPhEd+ftkCeiY/Xn/yVQPKB2LbqJTLZQ39UTCfNahbtZI7S/t7tBN9uKNaCDHPrdaFv4PWr4RLs95coVKzYpZrr1Xf9+krriQm1KNleuhqHRef4DDkPbgXys0dg/SaJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(186003)(316002)(2906002)(7696005)(478600001)(8936002)(76116006)(8676002)(110136005)(52536014)(53546011)(33656002)(6506007)(9686003)(83380400001)(5660300002)(54906003)(86362001)(26005)(66476007)(66556008)(55016002)(71200400001)(4326008)(66446008)(66946007)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HfZGSkMCO1SjSS9yp13iZ7BBXFrydQlkCasNLL5HC8MXcQBvj0/d1hRQqrf+xpDnYwbzdRAdprw7hlLdqftW0hC5pjZAxTHXpCgjucz8vSK15Ep8F8pGT2zcOYuMsOPU60Em5QNqZ0eBaNPjHiv06v3ajiGlrViQYsUBJ3eXJWxFYCaj/vdXBWOd8s/WNqin/i1D9fleGWe1abJfDOgtLoBhHdFP3kXbIWKhC6ftKRSBPEMBVRfj/ebRRWIUGdjbDs2Kxio0isV+SiAgWFA3xbjZ3zmZKAEG3T/oGs3LVNTikSUN7FuIWbeaWvImN5mcISpp50y7/8gl6RdacaB/MGdT9Z2hQN2D9Y/8ZVNRmJiBKryftBsm/+zJby9sTVXu38QtLf1h2uRxoPL5zTppxXIkrWcBKsYrSfwB3DGmd2MurrgFMpiDA3RPa89ws0ETt9YGMzZfC1s+ngUPkONFJuFvAAuAs6rqzXfBcbFYOAc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB2877.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa7f2263-a8e5-438f-f680-08d823247202 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 09:51:11.0287 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sqiDDk1hetXsA7FI6YNvHhRGn25mxrr9aCJ8llO291xHaQTvaBZD6x+69PH2dCBTsL1prpKpHZLT6dMg3qbQIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3087 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-08_07:2020-07-08, 2020-07-08 signatures=0 Subject: Re: [dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil,=20 Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, July 8, 2020 12:51 AM > To: Ankur Dwivedi ; dev@dpdk.org > Cc: declan.doherty@intel.com; Hemant Agrawal > ; Vakul Garg ; Anoob > Joseph > Subject: [EXT] RE: [PATCH] test/crypto: change cipher offset for esn vect= or >=20 > External Email >=20 > ---------------------------------------------------------------------- >=20 > > >> >Why do we need this change? > > >> >The existing test case is to demonstrate a generic case where we > > >> >can have an auth only trailer as well. It is similar to a case of > > >> >IPSEC ESN but not exactly IPSec. Cipher offset can be anything as > > >> >per the app > > >requirement. > > >> >I don't think there is anything wrong in the vector. It should > > >> >pass in every hardware without any issue. > > >> [Ankur] It's a limitation in OCTEON TX PMDs that the (encr offset - > > >> auth offset) should be 8 bytes aligned. > > >> In the IPSEC ESN scenario generally the offsets will be such. > > >> But in the above IPSEC ESN test vector, this requirement is not met > > >> and hence the associated test cases fails on the PMD. > > > > > >In that case, I think it is better to have a separate test vector and > > >both should be executed. With the previous one as not supported in > > >your case and this one will be supported. > > [Ankur] The offsets values are present per crypto operation. So to > > make these tests as unsupported the pmd datapath needs to be changed. > > Is there an alternative to make these tests unsupported? >=20 > I believe this is a data path error and a limitation in your PMD. > You can not stop the application writer from using unaligned cipher > offsets(non-8 byte aligned) [Anoob] Yes. But the typical case with IPsec is what is supported in the PM= D.=20 >=20 > This is just a test application, which may hide your PMD limitation by > accepting this patch But in actual the scenario will fail when some user > configures a 12B cipher offset. [Anoob] Agreed. But autotest having a failure is not an ideal situation to = be it. Especially when it's not the typical usage. Can I propose to add a f= ield like "Know Issues:" in the summary field? We can add a check for OCTEO= NTX PMDs in the test case and mark it as a known case. I do understand that= the vision was to remove all driver specific tests and have generic tests = for all PMDs, but here we are left with no other option. Chances are, other= PMDs also could have similar limitations when moving to generic framework. If you have suggestions to skip this test in any other way, that would also= work for us. =20 > IMO, you should add a new test vector instead of replacing this one and i= t > should Be OK to have the existing one fail in your case. >=20