From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53C9DA0093; Tue, 19 May 2020 11:40:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1CA71D17A; Tue, 19 May 2020 11:40:37 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id C9D351D176; Tue, 19 May 2020 11:40:35 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04J9eVCC006803; Tue, 19 May 2020 02:40:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=tW/pKwriM+N+YmV6Ea9WtVlq72bd7eiGLDo8eIbrLWs=; b=ol2aS0agNLv5rdwtRQgVfsCUwcwTXUgFQRU4a5xm7ElAKmrlpiJ/BA3O9kKIaZUYBXDO oET7epBcqY09wqcsyy37zBzNnv0bBnCcXjmxIoW4e0m8N6CUXNg67pe+S/fY75OKXkpZ 7091iWal/18p87fohDnVrjDWfj3a09c72dNgFyo539WPxKZeN9ex3OhbHA2UxshepNPc nnEmBFVCL2c9YolHvehjigcQV/tk0d6fYvNYzA2MOi5ZaEsQbbIv9p6pD1hwss3p8yTh AUf8iUXtAaUGa3Pa0mpjkJPK5j37MsKcCeJpNMIRtm4U0YHgnVCwwcjQIkNU8sVTiJIR lA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 312fpp2rpp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 19 May 2020 02:40:33 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 02:40:31 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 19 May 2020 02:40:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHkz/8FdNRjC9T97oC+p6LFoDoHFr5Xf/UcEddMFnEy7EZIohGb/e2lxJF/VgmYIS2gILmsSeLDo951n2M5PSA+27O0iC7WgFB9XkKhmVi4nN65Zp5e4ytIJG//S3YJyysuBlhLnJWnKWNGyqcWI4WPnIyFVfu/YE5jcMCG64b/WCg5YZfuVASgacnQ6tx1uYtx31UHWXLOi+osssfAspMZr02qk9BkM1VxJMEcw9YXYCXOuKmDlH8bp3iU9wPpeeGwWw96z86z9WHV1m7ji3INhv5M8/T+6105qAuoDw4V+InkAsPalVfzEyrbYEVwkQD5nAkUR/0w/RUbaF6qtpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tW/pKwriM+N+YmV6Ea9WtVlq72bd7eiGLDo8eIbrLWs=; b=eEL0uSc65QNHdCLFI6X+mFFY/Knlu7WNDfRKDTXYOt7UGYqD/S5ZIyJDAp/mChtFgL9KEE9iVOONUeQZRPSfFm0uw8mLfGKQB0yuHXMKIXbXwgzm/jidnclJ1/msJyVrkZ1xf5MX8CON5hW/OFRMQmQwKkQpD29W/kbNVNvdV7OaDR4JdKwJ6vbIcWqAQPNgYEla3pCbFZRja5nziXH9E0jUlLfYkhTek1dtKP2040I2gzS4ycQsdGTVQFOVI0+2jczLyf9kgfUIS5NP0poXqhhRhxFCjY6BwXXOvfLSTt44olZ3W4ZzvFHGC38LMyOCFxI3q2gdzAm1rr0CUtyQ6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tW/pKwriM+N+YmV6Ea9WtVlq72bd7eiGLDo8eIbrLWs=; b=VbdFIAoN3JsjM1dreury3VTWju3ESV9zmVYWue+CrTZ+MunrIF4RQIm7W6QtGabmJEynuohNgv5cMJSZkW7hU3T0iScq26fyPWVRMnifHKDLSrcOkGuTj4gfeIU4BIwsCM1g8BdQPtrQ43ZCt8Nv6X/M/7px6u/PGqDncGc5pPM= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3360.namprd18.prod.outlook.com (2603:10b6:208:166::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24; Tue, 19 May 2020 09:40:29 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f%7]) with mapi id 15.20.3000.033; Tue, 19 May 2020 09:40:29 +0000 From: Anoob Joseph To: "Dybkowski, AdamX" , "dev@dpdk.org" , "Trahe, Fiona" , "akhil.goyal@nxp.com" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment Thread-Index: AQHWLSI1fSMpWps6+02JAes/IuKaE6iu6G0ggAA9z4CAAAFYYA== Date: Tue, 19 May 2020 09:40:29 +0000 Message-ID: References: <20200518142342.1987-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [111.125.205.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dac0a86e-2cad-4cad-0c56-08d7fbd8ab20 x-ms-traffictypediagnostic: MN2PR18MB3360: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 040866B734 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +WSKY8Hf43H9dENj9f8PHHXx/Rn9Ps3dLnpc9J2xhIhrZa/LGSrpnJOenVBf77+4+lzRxVW6eWIS8+QoZeRAbTvIDE0jwEYk0hDXgj0f+vcyykUbfbUpKbeXxOWo9PTYL8tp/BYFbNrW0rZogqjl2k78ePVP8BFAh/ogP8iBz5rpP5vmHVpvuSlExQ5tEE0rLpMuvLbtm8PPRweZaM5xhPR3ozV96f4O+iq8ej4WPf+Rd7kMpN+3JWyqSOj+viYTWggdLejtiDekXGbkveG03HHh/9VgyCNcdV7memUXj2DSRiA0TtKBWOGJhGz2tbmFqzq+T+FpqVvojvXvOnhYwN9y2uPAXBOJIVAze5ffWA57zpCbHA9/Yt/bOWBgGbTYo2bfFZpOWPlKUCzNlrSDH5uRFlZ+ZeNTd8J9HSmG/tPBvlu019si9gblauba2eSGY8Al6CCCMDvTdErNFGi/1O97pv6yGgkQwSmqfWAxcuJ/GcR79bq5572e4bZsBROnTGOUcuQGLhVO0a3y+mqJoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(186003)(5660300002)(33656002)(55236004)(26005)(110136005)(8936002)(2906002)(53546011)(6506007)(8676002)(7696005)(316002)(9686003)(76116006)(66446008)(64756008)(66556008)(66476007)(66946007)(52536014)(4326008)(86362001)(71200400001)(478600001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: hDme5TIu4BduLEJaktMX7ATBqyNMjl2hPdrIqJWeUj5dUGEimX7I8KCn6OPHZtA8rY0YdNgZm4S7cYeQ8rK/2bnfY/VhbGIhpH7yyoaGyKksUd/0plJFHw/i4Azb8abxn29ci4E2qxHHnpVTINHBp+c+m+4OybMO35Ues3nyCpZDjM1e3ApAmgO0tZ889Px/O6sSjomQUHEVUzmQrL6WPOVOT78yzbVG7oPGuXaL00yCE5Xn5nlCj094TrBElqbYctAYSPVx59Fs2pWru3j/bx1xlneX87+A6Vmy+4FpE7z0igTX74JqudZ9QVvKLVzaHydutTqtJ4cqsmDH3rTD3utk2e6fBNUjDS52BkUb9lILKBG3Jm59/FWo7Rb0tYa8eYq3sjjBy1tgRYDWvyJ2rWOscCjsfTNsHLEZs9m7ZjgvRrRT1cPhItAIypN6G5w6+leS8aFui487P7j2MUoqQVskPPikgo2rkV7M+oCiocL4rsCGqXiMQPpNds9eCnRS x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dac0a86e-2cad-4cad-0c56-08d7fbd8ab20 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 09:40:29.6997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t8sJPwzG/07Ugxrc5aCA/YeaLI02VdudsCU71svU08OVHgUXS+o3+6nPmfNKKv+7WWlUQ4tr6aP+tWkcSOvldQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3360 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-19_03:2020-05-19, 2020-05-19 signatures=0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, Please see inline. Thanks, Anoob > -----Original Message----- > From: Dybkowski, AdamX > Sent: Tuesday, May 19, 2020 3:01 PM > To: Anoob Joseph ; dev@dpdk.org; Trahe, Fiona > ; akhil.goyal@nxp.com > Cc: stable@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum > comment >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi. > My answer below. >=20 > Adam >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Tuesday, 19 May, 2020 07:54 > > To: Dybkowski, AdamX ; dev@dpdk.org; Trahe, > > Fiona ; akhil.goyal@nxp.com > > Cc: stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum > > comment > > > > Hi Adam, Akhil, > > > > Please see inline. > > > > Thanks, > > Anoob > > > > > -----Original Message----- > > > From: dev On Behalf Of Adam Dybkowski > > > Sent: Monday, May 18, 2020 7:54 PM > > > To: dev@dpdk.org; fiona.trahe@intel.com; akhil.goyal@nxp.com > > > Cc: Adam Dybkowski ; stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment > > > > > > This patch fixes improper SHA-1 digest size in the enum comment. > > > > > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Adam Dybkowski > > > --- > > > lib/librte_cryptodev/rte_crypto_sym.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > > b/lib/librte_cryptodev/rte_crypto_sym.h > > > index d9585ecd6..9cea4e5f0 100644 > > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > > @@ -269,9 +269,9 @@ enum rte_crypto_auth_algorithm { > > > /**< HMAC using MD5 algorithm */ > > > > > > RTE_CRYPTO_AUTH_SHA1, > > > - /**< 128 bit SHA algorithm. */ > > > + /**< 160 bit SHA algorithm. */ > > > RTE_CRYPTO_AUTH_SHA1_HMAC, > > > - /**< HMAC using 128 bit SHA algorithm. */ > > > + /**< HMAC using 160 bit SHA algorithm. */ > > > > [Anoob] This raises one interesting question. Is HMAC-SHA-1-96 > > (https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__tools.ietf.org_= h > > > tml_rfc2404&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DjPfB8rwwviRSxyLWs2 > n6B- > WYLn1v9SyTMrT5EQqh2TU&m=3DpgqB2BfFosCF_7l1SdoodgXcipf7G1ofht68ZKMt > oW0&s=3DhxzUN2QfRJGaR7NQ7VKGm5oQvOZez6Z70mqOyg7gKTY&e=3D ) treated > as a separate algorithm or is it a digest size variant of > RTE_CRYPTO_AUTH_SHA1_HMAC? I assume the later. >=20 > [Adam] DPDK doesn't have separate enums for such variations. According to= RFC > 2104, chapter "5. Truncated output", the calculation of HMAC-SHA-1-96 is = done > using ordinary HMAC-SHA-1, but the calculation result is then truncated t= o 96 > bits, or any other digest size provided in auth xform. [Anoob] So it is allowed to support digest sizes 12 & 20, right? Can you up= date the above comment in that case?=20 >=20 > > > > > RTE_CRYPTO_AUTH_SHA224, > > > /**< 224 bit SHA algorithm. */ > > > RTE_CRYPTO_AUTH_SHA224_HMAC, > > > -- > > > 2.17.1