From: Anoob Joseph <anoobj@marvell.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
Shally Verma <shallyv@marvell.com>,
Sunila Sahu <ssahu@marvell.com>,
Narayana Prasad Raju Athreya <pathreya@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless
Date: Mon, 12 Aug 2019 09:26:25 +0000 [thread overview]
Message-ID: <MN2PR18MB28775972BE7D65EAFC53D509DFD30@MN2PR18MB2877.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190603194411.8352-1-arkadiuszx.kusztal@intel.com>
Hi Arek,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
> Sent: Tuesday, June 4, 2019 1:14 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
> shally.verma@caviumnetworks.com; Arek Kusztal
> <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric
> crypto by sessionless
>
> External Email
>
> ----------------------------------------------------------------------
> Asymmetric cryptography algorithms may more likely use sessionless API so
> there is need to extend API.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> lib/librte_cryptodev/rte_crypto_asym.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> b/lib/librte_cryptodev/rte_crypto_asym.h
> index 8672f21..5d69692 100644
> --- a/lib/librte_cryptodev/rte_crypto_asym.h
> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> @@ -503,6 +503,8 @@ struct rte_crypto_dsa_op_param { struct
> rte_crypto_asym_op {
> struct rte_cryptodev_asym_session *session;
> /**< Handle for the initialised session context */
> + struct rte_crypto_asym_xform *xform;
> + /**< Session-less API crypto operation parameters */
[Anoob] Shouldn't we make this a union? In symmetric mode, it is done that way and it makes sense also.
Something like,
RTE_STD_C11
union {
struct rte_cryptodev_asym_session *session;
/**< Handle for the initialised session context */
struct rte_crypto_asym_xform *xform;
/**< Session-less API crypto operation parameters */
};
>
> __extension__
> union {
> --
> 2.7.4
next prev parent reply other threads:[~2019-08-12 9:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 19:44 [dpdk-dev] " Arek Kusztal
2019-06-05 12:16 ` [dpdk-dev] [EXT] " Shally Verma
2019-06-14 10:21 ` Kusztal, ArkadiuszX
2019-06-14 10:24 ` Kusztal, ArkadiuszX
2019-06-14 11:23 ` Shally Verma
2019-06-14 12:12 ` Kusztal, ArkadiuszX
2019-06-20 14:17 ` [dpdk-dev] " Akhil Goyal
2019-06-21 11:58 ` Trahe, Fiona
2019-06-21 12:22 ` Akhil Goyal
2019-06-21 14:18 ` Trahe, Fiona
2019-06-24 7:05 ` Akhil Goyal
2019-06-27 11:54 ` Trahe, Fiona
2019-06-28 16:10 ` Shally Verma
2019-06-28 17:27 ` Trahe, Fiona
2019-06-30 8:37 ` Shally Verma
2019-08-12 9:26 ` Anoob Joseph [this message]
2019-08-12 10:00 ` [dpdk-dev] [EXT] " Kusztal, ArkadiuszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB28775972BE7D65EAFC53D509DFD30@MN2PR18MB2877.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=pathreya@marvell.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).