From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD0B7A0613 for ; Wed, 25 Sep 2019 09:18:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FC302C30; Wed, 25 Sep 2019 09:18:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A272C1E20 for ; Wed, 25 Sep 2019 09:18:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8P7FlCM023432; Wed, 25 Sep 2019 00:18:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=xh/8NK5HDAPw15s+aJzjVrWkwM7ncnaHyXej7L3eTqs=; b=YF8JUXGYalK2Eh3Ft/8Vuoaszla1lCPf/2IXYz/7FIUia/0IKJ9PcsbvDm0bMoO7VfRr uu+pSZPkdwrJp4WydO3B3iLfJhHNwrbrxdjpaAXzidUhhicDJWnkq4Tbi8q7VAqfvXZo bYqVCae0ofsNhRfa67DPYLnztDnjVWwcVwtdGJXZnA/h3yXsOfmhldr7OVMlsQyC8yvN BFKr6SgbiGT+/gO7Qi4yrYUMB4S4TfXvs+hNwvnDEISvXyHldP1XgZAiPsLVfqv2EUbI nMb3Qo/kJWQ0ezZqulFuYU6vavYz497FzJ5aZyC38mGMvmQyn90XImAbn6ugdfWHVbP2 xg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2v83phg0b1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 25 Sep 2019 00:18:47 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 25 Sep 2019 00:18:46 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 25 Sep 2019 00:18:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZH6mLpy4dYHRR5v9oAFb/a6UGyY00mcudO+Uy2AWGqRzbljMMxLTMePmtNqOOCumXJ4o7PwZ4XNJtgLOB+iVDjS6jmz7NxlYcWZLvvCncxi42dQHUC9FMHXydVZhfbZ2+UdWec69F2ECMkO0NFFXQ3ozBavKWeW+b1q7uDSjTzHsavT6Ai7eFwfvmTp7Nj7G+KQVhCgmHwGEQVF9k5Lyv3EBzztSx6C8TTMD4WSvV9BmE5Rn0eYyUOD+Ly3OofD2ZV+RuOVTRsaIgYyE7fMz9WxG0J/iy+lD8SikcbDuWfq1kv1mZesuR4APgOvXm5djso+fM93Ziz6Z9feinjpdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xh/8NK5HDAPw15s+aJzjVrWkwM7ncnaHyXej7L3eTqs=; b=PRoDULGj0YwLFqQ7UBTzMnqsbpwxNG15v2KxeB43P2Pcd0W6/VN4BEfwYcpGxHs9CFbWnHJ7zSEsOSbRHBnRS0YqYuJhyl/MNs8WPZEC+kNTWwi0LhNxUG8jrOf9HSKxKgBDN2Grq66hSREN/Sk1q4LOmMXsL+qF/ZehQaKJ2JCU6PKt9ElWWgR5HmNAB6csbTOrfasfi+UBLITF64iUPbKFAqTua9jpNeYiTvxBdJso15z9SxK2VyJVTRbPBoNCPwsNFIFwd5IJMZXsWE8p41HPBD+EeTUyahCG1AhovQOGV3oUnPkq16xXuiBFYo7/7uu9GuWe7IA2NiNcC9lrZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xh/8NK5HDAPw15s+aJzjVrWkwM7ncnaHyXej7L3eTqs=; b=U5TLKOptsjeky0H8Sj7zXBdqoZQjAus9QAkPCYA4qLZenJTw9Uc/Q9JhRr/M9xyuCgw09K/5o4Itmr4XFStZWP1ZwT7zpEgi3jNNQg+ubf8k5NVfRR+wsa5nSApM8H/edanrx8B20tPtk4Ef2Awdm2vWPMksG+M+m7ZYmaOnAx0= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3280.namprd18.prod.outlook.com (10.255.237.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.21; Wed, 25 Sep 2019 07:18:44 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa%7]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 07:18:44 +0000 From: Anoob Joseph To: Akhil Goyal , "konstantin.ananyev@intel.com" , Radu Nicolau CC: Hemant Agrawal , Vakul Garg , "dev@dpdk.org" , Narayana Prasad Raju Athreya , Jerin Jacob Kollanukkaran Thread-Topic: [PATCH 03/20] security: add hfn override option in PDCP Thread-Index: AQHVbv9EGMJtBWuy8k28lY9RfiJ4SKc77nyQ Date: Wed, 25 Sep 2019 07:18:44 +0000 Message-ID: References: <20190902121734.926-1-akhil.goyal@nxp.com> <20190902121734.926-4-akhil.goyal@nxp.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af43703f-3e1b-4391-4204-08d74188998f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB3280; x-ms-traffictypediagnostic: MN2PR18MB3280: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 01713B2841 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(39860400002)(376002)(136003)(396003)(199004)(189003)(13464003)(256004)(14444005)(186003)(99286004)(6246003)(25786009)(107886003)(6436002)(486006)(7696005)(6116002)(33656002)(110136005)(229853002)(3846002)(66066001)(76176011)(102836004)(26005)(2906002)(476003)(66446008)(54906003)(316002)(2501003)(86362001)(11346002)(53546011)(81166006)(15650500001)(52536014)(8936002)(66556008)(55236004)(55016002)(5660300002)(81156014)(4326008)(8676002)(66476007)(64756008)(9686003)(66946007)(76116006)(6506007)(446003)(478600001)(74316002)(71190400001)(305945005)(7736002)(71200400001)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3280; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Xc3uEgCYCStac5KSbGxWR5fnD/52YY1SrJaHWGJ2Gougobp6Z0IuJGSN4VqLnEYkf8YE1mHx5D/0nzDDYWARbpuTmcRh7NXAO/Y7mkwHPFrRLMtWZ0EDUtIXXozLfp9zlbnQO/IV5YLzZKLzKMuGQU6lGE8qr4WplJzX5nVoYYpFYT1jvMlizZDUtFnul7z117hduZHk2QiOR87b+iHyDfBgN4947D7GZOxGYgbfuhB0m6BAOUrwQbrvsFRjoVfgQYkTVxP/Vua4HfpkTrl89a7znrFxcBdOlk27Q5J7uFUMR0eEyJ1MbSbbu5gw87JGGveQ9j5XCElpYKy9cUx+RdxNXgIvlaZtVZ7yTzAoA6h49fcOTKX2f1SCIRfxjOeCUa6zfEOdqAO1hBeyZSDkrMDDW1FTBrWO+We4+OP0ccc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: af43703f-3e1b-4391-4204-08d74188998f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2019 07:18:44.1935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZCKNMy7cp9A37B91L/dT+rRb2eskBfwqBbxecVq4KqGilYhwoofBOFpelQFiFyWtO2N8+4JI526PbmN/ka+mkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3280 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-09-25_04:2019-09-23,2019-09-25 signatures=0 Subject: Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, September 19, 2019 9:01 PM > To: konstantin.ananyev@intel.com; Anoob Joseph ; > Radu Nicolau > Cc: Hemant Agrawal ; Vakul Garg > ; dev@dpdk.org; Akhil Goyal > Subject: [EXT] RE: [PATCH 03/20] security: add hfn override option in PDC= P >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Konstantin/Anoob/Radu, >=20 > Any comments on this patch. >=20 > Regards, > Akhil > > > > HFN can be given as a per packet value also. > > As we do not have IV in case of PDCP, and HFN is used to generate IV. > > IV field can be used to get the per packet HFN while enq/deq If > > hfn_ovrd field in pdcp_xform is set, application is expected to set > > the per packet HFN in place of IV. Driver will extract the HFN and > > perform operations accordingly. > > > > Signed-off-by: Akhil Goyal > > --- > > lib/librte_security/rte_security.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_security/rte_security.h > > b/lib/librte_security/rte_security.h > > index 96806e3a2..4452545fe 100644 > > --- a/lib/librte_security/rte_security.h > > +++ b/lib/librte_security/rte_security.h > > @@ -1,5 +1,5 @@ > > /* SPDX-License-Identifier: BSD-3-Clause > > - * Copyright 2017 NXP. > > + * Copyright 2017,2019 NXP > > * Copyright(c) 2017 Intel Corporation. > > */ > > > > @@ -270,6 +270,8 @@ struct rte_security_pdcp_xform { > > uint32_t hfn; > > /** HFN Threshold for key renegotiation */ > > uint32_t hfn_threshold; > > + /** Enable per packet HFN override */ > > + uint32_t hfn_ovrd; [Anoob] I think you should document the fact that IV field will be used for= HFN. Your patch description accurately describes the procedure but the abo= ve comment fails to capture it. Also I would suggest renaming "hfn_ovrd" to= something else to make it obvious that IV field is being used. Something l= ike, use_iv_for_hfn or something.=20 Otherwise, I don't see any issues with the approach. =20 > > }; > > > > /** > > -- > > 2.17.1