From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26608A2EFC for ; Wed, 18 Sep 2019 13:41:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67C271C23C; Wed, 18 Sep 2019 13:41:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5C3AB34F0 for ; Wed, 18 Sep 2019 13:41:01 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8IBexJt026390; Wed, 18 Sep 2019 04:40:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=GAY9q7Dw+7S14uh13aQROuclroowl21tQMDxpg36vWY=; b=xykOtwH5m1q5d3nrFgmL7u3mC3gUQDiWg4Z5PFw00SoxBal4Vgi81jyWJ7YVTRu+pdTl udydsRQgvcYjD3wNxxdHioUTfsn7bURkG9TzDZ4pOH7RBT1IrEBgTORYoLFo36XCGUf5 7wWyQK1UpZpPAiraHrnQrzDtdzXkg5SUxmSkU+OVPFVReQr4vLvhJIwGcX+Ko8HYVW7A RusEzmofUaulvvgPSkCVr1WFS55VQ/nwP52KRWsXebedFtZfqZl75jqDxc9Vm9fj4CvH S6sf8YIQQzzOaY7w9FvQ7jIqoz0TnFUzxfntT3S8JDWOFNCShDE3Lg7LrTa3LxinlAE6 GQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2v37kd2edp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 18 Sep 2019 04:40:59 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 18 Sep 2019 04:40:57 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 18 Sep 2019 04:40:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=meNx2nIsmLZDjw19UHfc8pl6G4lW1KVYDu87z0Na3zW8JOAl36RKcBdTu4mmJmTbcbEy4HGBER9yhYa67R2DLwU6boFua5rQQy6F1koSdx+Y5N90Y85p/v3Ux6OHciOmqVKKRh2likbXiSSQmNIW8Kp86BX7ND1OuM1CJ9XXpoJ0PrrK8Wt2VRiE/u92slsSoKfElaLQLxVsS26XAyal0jcW3tCRpUeeEvzEdX5qYW4drD+7r9aBW/pn90lm4/Ua74VnxFT0dYI00i18V6a/lkkneMiohmNxhyv+NG4sPFq+DLcRCPQls5FumOw2OepdHyUwnHsUtDHVtrLv1doH7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAY9q7Dw+7S14uh13aQROuclroowl21tQMDxpg36vWY=; b=V/308WHP8asgq4wrr055K/yRHmlPejcWQI3DekbMLNyey4fBCZVVuGDJKpkauhmz1pRta8x5XBpgI1J6NoYZ+gDS6Eqyea/f0e27LTFLBiUYrtDIjWvhQj342LrKCPDe+pfh8gMNUVa8jIHyo1sdM0/7RKsMxCTzV8NAHf+qUJHYBrPhozYe9Sa34YOMhjaLenmte2HXyi4JgzmeVNOOIeUqM8MEOOCLm+4Z4VG/l/2brbn41AHbxlwP2erk5SYv/8h2SQ+uYPwgzCotMTEdUDGA+j0YyXGsUtJ9J8nIEPdJGkqx15+MbFApBOu87Abag5SWIpKwxJPncCP6fxi3Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAY9q7Dw+7S14uh13aQROuclroowl21tQMDxpg36vWY=; b=uKQBCDM3JIanUwujdRJ69jq4xHikcEUn/K6jkDfOv59cPbH9hfltESXdkbfy+jiT3tP7YQ/+FKgmj04gL82PhS44MqUEkpjDCoKLXVRYSmZqov/I0xKRSAY0P141Oi4MKZdjp1AuNdeYa7cMAV25UePblzSGBuvGRDyQmAl9vMk= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2895.namprd18.prod.outlook.com (20.179.20.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.20; Wed, 18 Sep 2019 11:40:55 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5007:2282:4aff:5baa%7]) with mapi id 15.20.2263.023; Wed, 18 Sep 2019 11:40:55 +0000 From: Anoob Joseph To: "Ananyev, Konstantin" , "Smoczynski, MarcinX" , "akhil.goyal@nxp.com" CC: "dev@dpdk.org" , Narayana Prasad Raju Athreya , Jerin Jacob Kollanukkaran , Archana Muniganti Thread-Topic: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: add fallback session Thread-Index: AQHVYytvQTM+ragIcUyjA1ZmuGIqT6cxEoawgAAiKYCAAALJ0A== Date: Wed, 18 Sep 2019 11:40:54 +0000 Message-ID: References: <20190814204847.15600-1-marcinx.smoczynski@intel.com> <20190904141642.14820-1-marcinx.smoczynski@intel.com> <2601191342CEEE43887BDE71AB9772580191966C6D@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580191966C6D@irsmsx105.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96f8246c-24d6-4ee8-b4ff-08d73c2d10f1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB2895; x-ms-traffictypediagnostic: MN2PR18MB2895: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01644DCF4A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(13464003)(199004)(189003)(55016002)(64756008)(55236004)(102836004)(76116006)(66946007)(66556008)(86362001)(110136005)(486006)(478600001)(66446008)(7736002)(66476007)(52536014)(25786009)(71190400001)(5660300002)(71200400001)(4326008)(305945005)(6116002)(2501003)(76176011)(107886003)(33656002)(74316002)(14444005)(6506007)(316002)(53546011)(81166006)(6436002)(66066001)(256004)(8676002)(7696005)(6246003)(9686003)(26005)(3846002)(8936002)(81156014)(476003)(54906003)(446003)(229853002)(186003)(99286004)(14454004)(11346002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2895; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +gmVXIOplSfH/veDnEFgnPz42hyBBDgDu6j6m0FyVKP6ugLgm1mvMNK5xaBlNJL4+lhbUfuPA25k8/3o7Zto0OnxVykgl2RMapPbp3vWGqbDjVCPnwGn4TtiFlGDrRcxl2mgGUUWoS7BQkM++omoWwvupdnoM+ASIAKLXHYyFu0T8W08waCXhsShLSaiZEF2Bs4dfMp6geQR9DeLpNfCZnskP15aAWZvRo7QZTQHKhCHkLJsWs81T7sgHSkQxiwmFnu9PV4TcE36yQXmB0V6+5rFLXi7pNsC1UIvz77F4fQX48tudJpBfsrdF9hglUWibl8b5HCLj7camhmyPtC5cRAupnj+mKVHymQIa1bDZMennEBNlrfPicDQ78Y7L4NzZj7MUxXFVqSyxYyOYFEQ5fe2RTSz8c0H+G34snOJSXA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 96f8246c-24d6-4ee8-b4ff-08d73c2d10f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2019 11:40:54.9806 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yjpc+ckch+KgMNIO2gUn2wiEZUmdPrLMVUlSQPkdaBpjxf/8XI6MMdCKu1aCU3jpxFn9WXsS0LQu0gy+lTavqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2895 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-18_07:2019-09-17,2019-09-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: add fallback session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, Please see inline. Thanks, Anoob > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, September 18, 2019 2:16 PM > To: Anoob Joseph ; Smoczynski, MarcinX > ; akhil.goyal@nxp.com > Cc: dev@dpdk.org; Narayana Prasad Raju Athreya ; > Jerin Jacob Kollanukkaran ; Archana Muniganti > > Subject: RE: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: add fallback > session >=20 >=20 > Hi Anoob, >=20 > > > > Hi Marcin, > > > > Sorry for the late response. But how do you plan to handle "inline prot= ocol" > processed packets? >=20 > Right now that feature is supported for "inline crypto" only. [Anoob] The description says "inline processed" packets. Hence the confusio= n. =20 > For the case when SA doesn't enable replay window and/or ESN current > patch should also work for "inline proto" too, but this is just my > understanding (not tested, etc.). [Anoob] In case of inline ipsec processing, the ipsec state (which would tr= ack sequence number etc) will be internal to the PMDs. So anti-replay/ESN w= ould have to be done either in the h/w or PMD. This would mean application = will not have state information regarding ipsec processing. Hence fallback = handling with the above scheme will not work in that case. To address this properly for inline protocol, we will have to come up with = some logic to share session private data b/w "eligible" PMDs. This would in= volve library changes to rte_security, etc. Once that is proposed, there wi= ll be one kind of handling for inline protocol processing and another kind = for inline crypto processing. Would you be fine with that? =20 > Konstantin >=20 > > > > Thanks, > > Anoob > > > > > -----Original Message----- > > > From: dev On Behalf Of Marcin Smoczynski > > > Sent: Wednesday, September 4, 2019 7:47 PM > > > To: konstantin.ananyev@intel.com; akhil.goyal@nxp.com > > > Cc: dev@dpdk.org; Marcin Smoczynski > > > Subject: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: add > > > fallback session > > > > > > Inline processing is limited to a specified subset of traffic. It is > > > often unable to handle more complicated situations, such as > > > fragmented traffic. When using inline processing such traffic is drop= ped. > > > > > > Introduce multiple sessions per SA allowing to configure a fallback > > > lookaside session for packets that normally would be dropped. > > > A fallback session type in the SA configuration by adding 'fallback' > > > with 'lookaside-none' or 'lookaside-protocol' parameter to determine > > > type of session. > > > > > > Fallback session feature is available only when using librte_ipsec. > > > > > > v1 to v2 changes: > > > - disable fallback offload for outbound SAs > > > - add test scripts > > > > > > Marcin Smoczynski (3): > > > examples/ipsec-secgw: ipsec_sa structure cleanup > > > examples/ipsec-secgw: add fallback session feature > > > examples/ipsec-secgw: add offload fallback tests > > > > > > doc/guides/sample_app_ug/ipsec_secgw.rst | 17 +- > > > examples/ipsec-secgw/esp.c | 35 ++-- > > > examples/ipsec-secgw/ipsec-secgw.c | 16 +- > > > examples/ipsec-secgw/ipsec.c | 99 ++++++----- > > > examples/ipsec-secgw/ipsec.h | 61 +++++-- > > > examples/ipsec-secgw/ipsec_process.c | 113 +++++++----- > > > examples/ipsec-secgw/sa.c | 164 +++++++++++++---= -- > > > .../test/trs_aesgcm_common_defs.sh | 4 +- > > > .../trs_aesgcm_inline_crypto_fallback_defs.sh | 5 + > > > .../test/tun_aesgcm_common_defs.sh | 6 +- > > > .../tun_aesgcm_inline_crypto_fallback_defs.sh | 5 + > > > 11 files changed, 358 insertions(+), 167 deletions(-) create mode > > > 100644 > > > examples/ipsec-secgw/test/trs_aesgcm_inline_crypto_fallback_defs.sh > > > create mode 100644 examples/ipsec- > > > secgw/test/tun_aesgcm_inline_crypto_fallback_defs.sh > > > > > > -- > > > 2.21.0.windows.1