From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB496A034F; Wed, 6 May 2020 11:43:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 785D01C221; Wed, 6 May 2020 11:43:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8CE191C1AC for ; Wed, 6 May 2020 11:43:19 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0469fCTW025471; Wed, 6 May 2020 02:43:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=3FIDRHCR2z3WX+LMz8uWlYDZt+0FtXbhQM1u7cb4DVE=; b=Dxbi3g0pbHnxP/oIg3mIccdIvvZCYLe2R9Z7zcOFDoA6dbxH6dJ6fbTiBQH6zFJCR+I6 erhZXOj+SFG2zl+erO5ATwk+dEXnuo5oAZe6XeUwi5meq2pDUG+D7qU6+ZBbmjE+LPPT vLmtFdNglHQpkT6TAfll2Q7Lo3RagqPTADPIyUh1jliWvTLtO14s668yinAGZ3b7TIeZ 6+34slAtzg1trjbSeSgSq7K5tK/Bwth2dWEGFv/znZeQBgOI0AzdYgVcjXbDeLNZFlMH 11DEL8hgP4V7jMXS7HI2QDho4AuZ918rTFV9iFCWR1e4y/qCiqDevBLsS/melyY8ZeKm tg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 30urytrdq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 May 2020 02:43:18 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 May 2020 02:43:16 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 6 May 2020 02:43:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ne5aG4CcsjCmpxEhUrVqlJnlYvE0MKisnPZ32eAN9g4YYUfI735NuR+g1QW27BYPaHzJTXzQNDXODMqsxK+N9qNpFXaAOguU+xmZ8hTOZht5GQLxVI9R7yV9HqMZL6yoGNWUWOl0Hw5q1Rnp6dZ7HVzht3s7dBQKolceBNyKYYZrFjfcpCr+x/BoIPa2ooxOS8SWx2LctKnZPOlM/DzzE5cPky0ELQwnh/6Um7m2nzz+1S17x8i4xHshfSyecDIEn+S+cOV6iM1qmCXcZm382JRqCs970KqhnRFW/6pDd91CUgDOHlNc75LxsRQhIg4BHmA7nY3Ncy4UJ8xxz4swDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FIDRHCR2z3WX+LMz8uWlYDZt+0FtXbhQM1u7cb4DVE=; b=jBy9e91BFJMNOROgEP9RR2e2wM+IAev+z/lvN+l4dx+ZUrRWK4BqLVPd1fdJMHxGCZ1b1VY12+uag+yB1fQgqUNAVCN1Py3c9PzZ6pfd0az9FjXiCy4UWJfUodw51C+9AqeFUSgmRnLCtgEVX0aiQZeJA3+LCxAGeq76ZU8OTBPaN+6QDvR8ZYYqmoPCEXBkY7P+j7AMHaFyLUSV+cBaZa3VpKa10maZ1zhndLMGDrFUgjKFxoGErenItcbuoJjJnJFbu0JyujwVAI3fe1M0lllBi/0OxQiYSFJHFJDQMFOzLk19y9/rj79c9urzWgpJuvBbXz0JjsE9t7drFOAGXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FIDRHCR2z3WX+LMz8uWlYDZt+0FtXbhQM1u7cb4DVE=; b=lIjM6/qkc/7GauKZVOpMFUedxUoM3k7X79Q9COL1s1wuppJ03h6q6FpTss0RyAymZhBhTRm83d7OO0cRnukNr/hajOUQMBsAUCb+SlWUdQMEt7GNm3LjDL4htO/qopnQeul7zB64hRKcYsJKRZXj1RezF8xA0rkH2h4re7yFTJ8= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3278.namprd18.prod.outlook.com (2603:10b6:208:168::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Wed, 6 May 2020 09:43:14 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f%7]) with mapi id 15.20.2958.030; Wed, 6 May 2020 09:43:14 +0000 From: Anoob Joseph To: Praveen Shetty , "dev@dpdk.org" , "declan.doherty@intel.com" , "akhil.goyal@nxp.com" CC: "bernard.iremonger@intel.com" , "konstantin.ananyev@intel.com" Thread-Topic: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue Thread-Index: AQHWI4Ugdp1OM19lgE6u2UWcP0h6n6iazeYQ Date: Wed, 6 May 2020 09:43:14 +0000 Message-ID: References: <20200506090240.19214-1-praveen.shetty@intel.com> In-Reply-To: <20200506090240.19214-1-praveen.shetty@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [111.125.205.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f08e583-c41a-4d29-3d84-08d7f1a1e606 x-ms-traffictypediagnostic: MN2PR18MB3278: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R220ltoolSbgZO5Ia1ygjJDsDg1bLN9+GMO6fQhbacGYqJxiSkBHDmYhAE85cyqZ6zCx/VeYEHqK5+6XawchkpbnB0wHisdjp4rKK5BBw8k1WxiaAXnKAnthYMQtskP/elEa0oG33PRc0Dlf/Jl0TClhIhPs46wiP5DOWNXUTK1uhnUVqayyUHlMD8wHeplRZabqnLbHtNiSd32whu8yFpxl/9YEcx9FG7HfPSEY9AieWGdpEHXRtQ3B/L9YWrdkvRpyKTNdkm4j/2GLjyl/CcsE4btPBQzNc+yn8lxYuiKrnC3dmVV8UFUbmNIn0ijdlV7gTmtkgXEQIOm14ak+XrN6LJI+BMQa9wL9ManMVPfpQ0+pi5cR3WgtiBBbPchV/Qv5H4lLy1YxwGEcLRu+kSoPF/UiX9aklDBmcKWK2MDynof7/vsxhh4x1JzP+dS6oNhCpaMJWAP0kS81/x2wl1UgGJqRHb/ylePzMUwPa8NYzp5ypGs+W+8/8MZNb50HfxTUJzdXUwyWDvLJiySdZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(396003)(39850400004)(366004)(33430700001)(66556008)(76116006)(110136005)(33656002)(66476007)(64756008)(66446008)(53546011)(33440700001)(26005)(8676002)(7696005)(316002)(8936002)(54906003)(66946007)(186003)(55236004)(6506007)(52536014)(55016002)(86362001)(5660300002)(478600001)(9686003)(4326008)(71200400001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DHjUsEoz6BVjG65HH5T7mPqphdvCirEAAuKB9/YMzTt+kMH7BZdRdR7MtW0ivxjx7wB+Dj0HsvqYzV0Thf6gvbVRB5ASXX/BrS1bJ2ImE2L6m0uxPlBCWjD+VXLZKyQHiHkMiNQaw+oxxctcVGnYZ4nkAIyT960LBJFhIsYgPrKLOaSjRk84LeLKcNspMFI8Sk3cVdEDBt7Fb+66V/kty7lGsSOiX+dsFx+V1PmJJ+44shieNi04H5KkF2CJ5mKDbWGpW4u9nX5L12xmUI0t9fQ8lcwIkThMNLf7ip1AHWsELfPMI3iN4vy47XvO6PSyeZPgUKmWHuCko9njHt1RhcsbPGJNZVj+miwTFAKpBU6Ysx3zaHXTSZFZYChMg50uLnACyloGirzAveJz6g9VjYIVXItc250RIoqa4WqEtNO6Hf3yPIFtjSM3B0KfDpIKSRfc5XcJs0aVltQnkFdlbxYNjPSX2BMosNe9DMjdTDW3WKYbX6owf3frI42839u+GWpFnb+Y2m4peiXIdO4PtfnSOE05IEHrrra0cDzKWTePbAp8MLIUNG2Te4COhNcDMQob/rcPuxX/VCk70kTtRLOOvPX0p5h43IrLEcz46qzddq7N0wXlNGx+iT52l1JJ1yalOawpI/ICseLlVT+HYazDtNvmxtErQzL1MTdTZ3ehYbWh5R3rET4ovu0qW16O9Xf2u0gWNZh34EkGfnFaWtueWMfWBst+6/3Tz8qIv1S+R6kQ0fTicMCtsjZFrbgu7KeCXiphAEGFGLUhqMHdfB67FKhWZ112GRxLqLd/bJs= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4f08e583-c41a-4d29-3d84-08d7f1a1e606 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 09:43:14.5632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JsTltPPCiQcI+84P8Yjl9sr4az2OAnSVcT1vGn+FjAiUZkNUOe2JQD4c4gXyYmXBotMEBLtCzwsxzwzYBSVOKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3278 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-06_03:2020-05-04, 2020-05-06 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Praveen, Please see inline. Thanks, Anoob > -----Original Message----- > From: Praveen Shetty > Sent: Wednesday, May 6, 2020 2:33 PM > To: dev@dpdk.org; declan.doherty@intel.com; akhil.goyal@nxp.com; Anoob > Joseph > Cc: bernard.iremonger@intel.com; konstantin.ananyev@intel.com; > praveen.shetty@intel.com > Subject: [EXT] [PATCH v1] examples/ipsec-secgw: resolve coverity issue [Anoob] I believe Thomas insists on explaining the issue that you are tryin= g to fix rather than stating "resolve coverity issue" (which is too generic= ). So I guess you can remove all such references to coverity and retain res= t of your description. =20 >=20 > External Email >=20 > ---------------------------------------------------------------------- > Function create_ipsec_esp_flow returns a negative number in case of any > failure. But passing negative number to strerror is causing the coverity = issue. > In case of failure, displaying exact error message to console is handled = in > create_ipsec_esp_flow function.So it is not required to print the error m= essage > again using strerror. > This patch will remove the unnecessary calling of strerror function to fi= x the > coverity issue. >=20 > Coverity issue: 357691 > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") > Cc: praveen.shetty@intel.com >=20 > Signed-off-by: Praveen Shetty > --- > examples/ipsec-secgw/sa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index > e3a1a5aff..632482176 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct > ipsec_sa entries[], > rc =3D create_ipsec_esp_flow(sa); > if (rc !=3D 0) > RTE_LOG(ERR, IPSEC_ESP, > - "create_ipsec_esp_flow() failed %s\n", > - strerror(rc)); > + "create_ipsec_esp_flow() failed\n"); > } > print_one_sa_rule(sa, inbound); > } > -- > 2.17.1