From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18DCAA04A2; Tue, 12 May 2020 14:17:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 155EE1BFBC; Tue, 12 May 2020 14:17:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D87AB1BF9D for ; Tue, 12 May 2020 14:17:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04CCBpBr024874; Tue, 12 May 2020 05:17:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=dBbFLxNbwZQ+hOM6dljqnm3CxCv/pS2N3tfPIihMfZY=; b=GL2jbxmb96WBygjurN7wb9REr2Fx2eYT02gCKmhyVUziM3PXXuDApss0vEydzkdS6nSS HmEpUKwKqWuRQXIkbxHTVGKamsocBPwSfYQnOiemoq5X/0sMsVcO001Rrkr2GSHL7MHp TCWFBVMvDA7uynWPeurcbI1Qv3lXC4EpDBDhVP1k4Kz9wq8OKvFXTF7tN5YlvmzgPxil gWeWg2MTREqfuF+YsFXPG9CjrpiXG4uMJ5ggMvX6TQr63xS5Tpz/1HHzAQOq9eDRsERz 8knsRaRfMli69TmRBdtVqLmZeClKHREDmFlshOHlGBm1R8PcB3irrwXEwBlqToJZ95ox +A== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 30wv1nb847-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 May 2020 05:17:01 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 May 2020 05:16:59 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 12 May 2020 05:16:59 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 12 May 2020 05:16:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dGE/odG6QNDfSvTRanFB9DiQbqQEz0nx6Ys0tJoAkWMBNLeJeL1QKvaL/eGcLz8Wc+TcBH2L6fdOqA7sd5x7GIAdO1yBmCyWf0u+iG7SpmS6EPqonQdmzeLnP+0k1we66heCA4QyCe+5TvxJurGslGtZPEh0merX5K7e621c2f3kFF2FFMphJ9kqdJcTdWHyQy5ZX5Bqi+QTGp7lYESM5zMB04aZHwIEhCgQLXYeV/LwCvCkEd/Rd+mlQI5FRoI7v5V26MzVw/wbcannraCutZ/9lkEnihAEMAjQ/Ph2rhsopn8iWQYrPNYaMz3PP7sEl/OeYGGjK2cb4M5Em+nZ7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBbFLxNbwZQ+hOM6dljqnm3CxCv/pS2N3tfPIihMfZY=; b=OUBpu2edfg3KT9RAy5U/Si4Hs72DlEFHm5mjfonvW6X7LVHKo0kD6prC03sKV4qPy8LueRGhYBLMOdMs/wkdkqqYUvwoqFWZUE0bjP6HVxwXI7mRwhBq9ceBoxtE6c+obSNf2kQCrwx9jDx0qcIggVV4kUocQO1xnCp1bqcoNIqOIUaR3P/tGyh9veHbH5mfP6GThsPt1XvFAXZ8j9y4S+M8tfCB3bw25Lw10H8uGw4xJKc2YCQDpx1gYa0IPw0qXYtJGFXkYJ2NeiGTBnJTxAgEd6JOvh5xfeSK+hndm9QZajuK8bTQuw9n0yvZU3JoBVhkaNYfrc7ufZU2wU3Bwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBbFLxNbwZQ+hOM6dljqnm3CxCv/pS2N3tfPIihMfZY=; b=U3STAHAGTpJRSOG9ocEZGJvp0eRWoYJNQRY7JBQ22h9guB1G1ez6xYLT7UOi6Wv6nPBPwSJQrzOt/9FZIRpuPw9xaMifXtdo6j71lWJNLMgYzBg8KH97IgJa6TKkP7RtLy8p4B52E0/lDk3ymxTE57NA+DbzTSZVDYI+FxYsTJU= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3070.namprd18.prod.outlook.com (2603:10b6:208:ff::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Tue, 12 May 2020 12:16:57 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f%7]) with mapi id 15.20.2979.033; Tue, 12 May 2020 12:16:57 +0000 From: Anoob Joseph To: "Ananyev, Konstantin" , Akhil Goyal , "Nicolau, Radu" CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" Thread-Topic: [PATCH v3] examples/ipsec-secgw: add per core packet stats Thread-Index: AQHWI6SQq94R+vt4mEWeQWZM7gsa+Kid2I+AgAaN8JA= Date: Tue, 12 May 2020 12:16:57 +0000 Message-ID: References: <1587647245-10524-1-git-send-email-anoobj@marvell.com> <1588769253-10405-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [111.125.205.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9623dab1-afc0-4062-15a7-08d7f66e5dcb x-ms-traffictypediagnostic: MN2PR18MB3070: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0401647B7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n0pNXcf4r8pl7poZIZktUMMb67o0a4iXz7JBBA2BHMe3kOdmLZtefvKBrw8/58xWc2qnmI0aAOfWPdwH27pdbFnZVl1QNy4Q8yqNsT17YK0w2BsY0oKFkFuKx3eUJ6BtlpaT8R/gZbo5qbLR9pv5fDLtmZ2RJBXk7YrPyUtmYH/7in5L+JFzb7HrGI9XNp0YhzT1pT+aR0QoBwY4WF+CgiK6C2OdxKwsPyD1bLk1FmfAyqXogXSMDcWPLuMnbM6HfcPClxnew6MGTnFJdj/Nh3iDe7PVtUzLkWZn3XDn8eQs1ouZe4yP3xF6biuhM3wjCvmtwazJ2Rv1krHScvrsc000hGavPyG8z/o2T+mlC4R8RKdz19OeV+Mpy5+ysmTPQcuKoxT0MHBXhCBfP8l94Be0uQiIVVJMBygHfjxkkV9ABoMCovgnM2eb1rqP6mNRVeZL0o/X4Of+FXNQ0os0IKhbJeDtLDsYiThUHgZfaDzjP6gfWeTRd4VCB6EDXMsSQa4sZly+nozDeExddnr96w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(33430700001)(8676002)(33656002)(66476007)(66556008)(33440700001)(66446008)(71200400001)(8936002)(66946007)(76116006)(64756008)(26005)(186003)(4326008)(86362001)(5660300002)(2906002)(110136005)(316002)(54906003)(55236004)(9686003)(30864003)(55016002)(53546011)(6506007)(478600001)(52536014)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: NaDwVimvtoJlUjSzkF9JgWimk9EIfmkEwXp6mpt16C0JQQOS6YwnzpqXxqP005tJBqcWnByANVnLxHy2cxoaxAHVhFSvxKY9eqeC3LJqnWTg8Kt7Ga4QT16Lb66RO1QJQUXTajbFrWED2HD5T5zt/0S9Bn/mc0KOek3pxyWnzMN/LaSCXXDw+T2lMGcGJGbYWrEpbPEdk6I1uPX6qUIov6Q91c/ID4iC7MWuujVqfrBorjJDGKmWv6baqVT/8FqzKpbkHReMo+DeUEgIjctj7bRavbgxWzj7UEb7A38nzLygFBt1DauW0cONI/67wKlQxdY6Lj7Wvw99SO0YJevTdBISp/vCizM2RhZQaa8RhSuCR5EmpxAMvzzs0kGSKDhzK78RgbTWtfnuAHP2vG2a/fpOhDWB5EGfBQ0hm9pk3jdFlXeIHibuUF7jPunhvlu2oQs/aEQFQVNPWAap5i++IgvwrW+/dnfNujtGwW/zDyZ3mAn8k2aCzF8Vl5KCRyNh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9623dab1-afc0-4062-15a7-08d7f66e5dcb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2020 12:16:57.5321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o3/ZlVFjZtd0r7xDdpx9CaTlHgyvAxmGl7gDJpr6cSYBnkM/SIyo5mLaO/rvqXG2UzUZBIAqSQo56jXFlcc4ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3070 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-12_03:2020-05-11, 2020-05-12 signatures=0 Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, Please see inline. Thanks, Anoob > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, May 8, 2020 1:39 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org > Subject: [EXT] RE: [PATCH v3] examples/ipsec-secgw: add per core packet s= tats >=20 > External Email >=20 > ---------------------------------------------------------------------- >=20 > > > > +#if (STATS_INTERVAL > 0) > > + > > +/* Print out statistics on packet distribution */ static void > > +print_stats(void) > > +{ > > + uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; > > + unsigned int coreid; > > + float burst_percent; > > + > > + total_packets_dropped =3D 0; > > + total_packets_tx =3D 0; > > + total_packets_rx =3D 0; > > + > > + const char clr[] =3D { 27, '[', '2', 'J', '\0' }; > > + > > + /* Clear screen and move to top left */ > > + printf("%s", clr); > > + > > + printf("\nCore statistics =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D"); > > + > > + for (coreid =3D 0; coreid < RTE_MAX_LCORE; coreid++) { > > + /* skip disabled cores */ > > + if (rte_lcore_is_enabled(coreid) =3D=3D 0) > > + continue; > > + burst_percent =3D (float)(core_statistics[coreid].burst_rx * 100)/ > > + core_statistics[coreid].rx; > > + printf("\nStatistics for core %u ------------------------------" > > + "\nPackets received: %20"PRIu64 > > + "\nPackets sent: %24"PRIu64 > > + "\nPackets dropped: %21"PRIu64 > > + "\nBurst percent: %23.2f", > > + coreid, > > + core_statistics[coreid].rx, > > + core_statistics[coreid].tx, > > + core_statistics[coreid].dropped, > > + burst_percent); >=20 >=20 > As one more comment: > Can we also collect number of calls and display average pkt/call (for bot= h rx and > tx)? >=20 [Anoob] Can you describe which "call" you meant? We can capture more logs i= f required.=20 =20 > > + > > + total_packets_dropped +=3D core_statistics[coreid].dropped; > > + total_packets_tx +=3D core_statistics[coreid].tx; > > + total_packets_rx +=3D core_statistics[coreid].rx; > > + } > > + printf("\nAggregate statistics =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D" > > + "\nTotal packets received: %14"PRIu64 > > + "\nTotal packets sent: %18"PRIu64 > > + "\nTotal packets dropped: %15"PRIu64, > > + total_packets_rx, > > + total_packets_tx, > > + total_packets_dropped); > > + > printf("\n=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > =3D\n"); > > +} > > +#endif /* STATS_INTERVAL */ > > + > > static inline void > > prepare_one_packet(struct rte_mbuf *pkt, struct ipsec_traffic *t) { > > @@ -333,7 +386,7 @@ prepare_one_packet(struct rte_mbuf *pkt, struct > > ipsec_traffic *t) > > > > /* drop packet when IPv6 header exceeds first segment length > */ > > if (unlikely(l3len > pkt->data_len)) { > > - rte_pktmbuf_free(pkt); > > + free_pkt(pkt); > > return; > > } > > > > @@ -350,7 +403,7 @@ prepare_one_packet(struct rte_mbuf *pkt, struct > ipsec_traffic *t) > > /* Unknown/Unsupported type, drop the packet */ > > RTE_LOG(ERR, IPSEC, "Unsupported packet type 0x%x\n", > > rte_be_to_cpu_16(eth->ether_type)); > > - rte_pktmbuf_free(pkt); > > + free_pkt(pkt); > > return; > > } > > > > @@ -477,9 +530,12 @@ send_burst(struct lcore_conf *qconf, uint16_t n, > uint16_t port) > > prepare_tx_burst(m_table, n, port, qconf); > > > > ret =3D rte_eth_tx_burst(port, queueid, m_table, n); > > + > > + core_stats_update_tx(ret); > > + > > if (unlikely(ret < n)) { > > do { > > - rte_pktmbuf_free(m_table[ret]); > > + free_pkt(m_table[ret]); > > } while (++ret < n); > > } > > > > @@ -525,7 +581,7 @@ send_fragment_packet(struct lcore_conf *qconf, > struct rte_mbuf *m, > > "error code: %d\n", > > __func__, m->pkt_len, rte_errno); > > > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > return len; > > } > > > > @@ -550,7 +606,7 @@ send_single_packet(struct rte_mbuf *m, uint16_t > port, uint8_t proto) > > } else if (frag_tbl_sz > 0) > > len =3D send_fragment_packet(qconf, m, port, proto); > > else > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > > > /* enough pkts to be sent */ > > if (unlikely(len =3D=3D MAX_PKT_BURST)) { @@ -584,19 +640,19 @@ > > inbound_sp_sa(struct sp_ctx *sp, struct sa_ctx *sa, struct traffic_type= *ip, > > continue; > > } > > if (res =3D=3D DISCARD) { > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > continue; > > } > > > > /* Only check SPI match for processed IPSec packets */ > > if (i < lim && ((m->ol_flags & PKT_RX_SEC_OFFLOAD) =3D=3D 0)) { > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > continue; > > } > > > > sa_idx =3D res - 1; > > if (!inbound_sa_check(sa, m, sa_idx)) { > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > continue; > > } > > ip->pkts[j++] =3D m; > > @@ -631,7 +687,7 @@ split46_traffic(struct ipsec_traffic *trf, struct r= te_mbuf > *mb[], uint32_t num) > > offsetof(struct ip6_hdr, ip6_nxt)); > > n6++; > > } else > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > } > > > > trf->ip4.num =3D n4; > > @@ -683,7 +739,7 @@ outbound_sp(struct sp_ctx *sp, struct traffic_type = *ip, > > m =3D ip->pkts[i]; > > sa_idx =3D ip->res[i] - 1; > > if (ip->res[i] =3D=3D DISCARD) > > - rte_pktmbuf_free(m); > > + free_pkt(m); > > else if (ip->res[i] =3D=3D BYPASS) > > ip->pkts[j++] =3D m; > > else { > > @@ -702,8 +758,7 @@ process_pkts_outbound(struct ipsec_ctx *ipsec_ctx, > > uint16_t idx, nb_pkts_out, i; > > > > /* Drop any IPsec traffic from protected ports */ > > - for (i =3D 0; i < traffic->ipsec.num; i++) > > - rte_pktmbuf_free(traffic->ipsec.pkts[i]); > > + free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); > > > > traffic->ipsec.num =3D 0; > > > > @@ -743,14 +798,12 @@ process_pkts_inbound_nosp(struct ipsec_ctx > *ipsec_ctx, > > uint32_t nb_pkts_in, i, idx; > > > > /* Drop any IPv4 traffic from unprotected ports */ > > - for (i =3D 0; i < traffic->ip4.num; i++) > > - rte_pktmbuf_free(traffic->ip4.pkts[i]); > > + free_pkts(traffic->ip4.pkts, traffic->ip4.num); > > > > traffic->ip4.num =3D 0; > > > > /* Drop any IPv6 traffic from unprotected ports */ > > - for (i =3D 0; i < traffic->ip6.num; i++) > > - rte_pktmbuf_free(traffic->ip6.pkts[i]); > > + free_pkts(traffic->ip6.pkts, traffic->ip6.num); > > > > traffic->ip6.num =3D 0; > > > > @@ -786,8 +839,7 @@ process_pkts_outbound_nosp(struct ipsec_ctx > *ipsec_ctx, > > struct ip *ip; > > > > /* Drop any IPsec traffic from protected ports */ > > - for (i =3D 0; i < traffic->ipsec.num; i++) > > - rte_pktmbuf_free(traffic->ipsec.pkts[i]); > > + free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); > > > > n =3D 0; > > > > @@ -901,7 +953,7 @@ route4_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf > *pkts[], uint8_t nb_pkts) > > } > > > > if ((pkt_hop & RTE_LPM_LOOKUP_SUCCESS) =3D=3D 0) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > send_single_packet(pkts[i], pkt_hop & 0xff, IPPROTO_IP); @@ - > 953,7 > > +1005,7 @@ route6_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf *pkts[], > uint8_t nb_pkts) > > } > > > > if (pkt_hop =3D=3D -1) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > send_single_packet(pkts[i], pkt_hop & 0xff, IPPROTO_IPV6); > @@ > > -1099,6 +1151,10 @@ ipsec_poll_mode_worker(void) > > const uint64_t drain_tsc =3D (rte_get_tsc_hz() + US_PER_S - 1) > > / US_PER_S * BURST_TX_DRAIN_US; > > struct lcore_rx_queue *rxql; > > +#if (STATS_INTERVAL > 0) > > + const uint64_t timer_period =3D STATS_INTERVAL * rte_get_timer_hz(); > > + uint64_t timer_tsc =3D 0; > > +#endif /* STATS_INTERVAL */ > > > > prev_tsc =3D 0; > > lcore_id =3D rte_lcore_id(); > > @@ -1159,6 +1215,19 @@ ipsec_poll_mode_worker(void) > > drain_tx_buffers(qconf); > > drain_crypto_buffers(qconf); > > prev_tsc =3D cur_tsc; > > +#if (STATS_INTERVAL > 0) > > + if (lcore_id =3D=3D rte_get_master_lcore()) { > > + /* advance the timer */ > > + timer_tsc +=3D diff_tsc; > > + > > + /* if timer has reached its timeout */ > > + if (unlikely(timer_tsc >=3D timer_period)) { > > + print_stats(); > > + /* reset the timer */ > > + timer_tsc =3D 0; > > + } > > + } > > +#endif /* STATS_INTERVAL */ > > } > > > > for (i =3D 0; i < qconf->nb_rx_queue; ++i) { @@ -1169,8 +1238,10 > @@ > > ipsec_poll_mode_worker(void) > > nb_rx =3D rte_eth_rx_burst(portid, queueid, > > pkts, MAX_PKT_BURST); > > > > - if (nb_rx > 0) > > + if (nb_rx > 0) { > > + core_stats_update_rx(nb_rx); > > process_pkts(qconf, pkts, nb_rx, portid); > > + } > > > > /* dequeue and process completed crypto-ops */ > > if (is_unprotected_port(portid)) > > diff --git a/examples/ipsec-secgw/ipsec-secgw.h > > b/examples/ipsec-secgw/ipsec-secgw.h > > index 4b53cb5..5b3561f 100644 > > --- a/examples/ipsec-secgw/ipsec-secgw.h > > +++ b/examples/ipsec-secgw/ipsec-secgw.h > > @@ -6,6 +6,8 @@ > > > > #include > > > > +#define STATS_INTERVAL 0 > > + > > #define NB_SOCKETS 4 > > > > #define MAX_PKT_BURST 32 > > @@ -69,6 +71,17 @@ struct ethaddr_info { > > uint64_t src, dst; > > }; > > > > +#if (STATS_INTERVAL > 0) > > +struct ipsec_core_statistics { > > + uint64_t tx; > > + uint64_t rx; > > + uint64_t dropped; > > + uint64_t burst_rx; > > +} __rte_cache_aligned; > > + > > +struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; #endif > > +/* STATS_INTERVAL */ > > + > > extern struct ethaddr_info ethaddr_tbl[RTE_MAX_ETHPORTS]; > > > > /* Port mask to identify the unprotected ports */ @@ -85,4 +98,59 @@ > > is_unprotected_port(uint16_t port_id) > > return unprotected_port_mask & (1 << port_id); } > > > > +static inline void > > +core_stats_update_rx(int n) > > +{ > > +#if (STATS_INTERVAL > 0) > > + int lcore_id =3D rte_lcore_id(); > > + core_statistics[lcore_id].rx +=3D n; > > + if (n =3D=3D MAX_PKT_BURST) > > + core_statistics[lcore_id].burst_rx +=3D n; #else > > + RTE_SET_USED(n); > > +#endif /* STATS_INTERVAL */ > > +} > > + > > +static inline void > > +core_stats_update_tx(int n) > > +{ > > +#if (STATS_INTERVAL > 0) > > + int lcore_id =3D rte_lcore_id(); > > + core_statistics[lcore_id].tx +=3D n; > > +#else > > + RTE_SET_USED(n); > > +#endif /* STATS_INTERVAL */ > > +} > > + > > +static inline void > > +core_stats_update_drop(int n) > > +{ > > +#if (STATS_INTERVAL > 0) > > + int lcore_id =3D rte_lcore_id(); > > + core_statistics[lcore_id].dropped +=3D n; #else > > + RTE_SET_USED(n); > > +#endif /* STATS_INTERVAL */ > > +} > > + > > +/* helper routine to free bulk of packets */ static inline void > > +free_pkts(struct rte_mbuf *mb[], uint32_t n) { > > + uint32_t i; > > + > > + for (i =3D 0; i !=3D n; i++) > > + rte_pktmbuf_free(mb[i]); > > + > > + core_stats_update_drop(n); > > +} > > + > > +/* helper routine to free single packet */ static inline void > > +free_pkt(struct rte_mbuf *mb) { > > + rte_pktmbuf_free(mb); > > + core_stats_update_drop(1); > > +} > > + > > #endif /* _IPSEC_SECGW_H_ */ > > diff --git a/examples/ipsec-secgw/ipsec.c > > b/examples/ipsec-secgw/ipsec.c index bf88d80..351f1f1 100644 > > --- a/examples/ipsec-secgw/ipsec.c > > +++ b/examples/ipsec-secgw/ipsec.c > > @@ -500,7 +500,7 @@ enqueue_cop_burst(struct cdev_qp *cqp) > > cqp->id, cqp->qp, ret, len); > > /* drop packets that we fail to enqueue */ > > for (i =3D ret; i < len; i++) > > - rte_pktmbuf_free(cqp->buf[i]->sym->m_src); > > + free_pkt(cqp->buf[i]->sym->m_src); > > } > > cqp->in_flight +=3D ret; > > cqp->len =3D 0; > > @@ -528,7 +528,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > > for (i =3D 0; i < nb_pkts; i++) { > > if (unlikely(sas[i] =3D=3D NULL)) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > > > @@ -549,7 +549,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > > if ((unlikely(ips->security.ses =3D=3D NULL)) && > > create_lookaside_session(ipsec_ctx, sa, ips)) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > > > @@ -563,7 +563,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > ipsec_ctx *ipsec_ctx, > > case RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO: > > RTE_LOG(ERR, IPSEC, "CPU crypto is not supported by > the" > > " legacy mode."); > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > > > case RTE_SECURITY_ACTION_TYPE_NONE: > > @@ -575,7 +575,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > > if ((unlikely(ips->crypto.ses =3D=3D NULL)) && > > create_lookaside_session(ipsec_ctx, sa, ips)) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > > > @@ -584,7 +584,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > > ret =3D xform_func(pkts[i], sa, &priv->cop); > > if (unlikely(ret)) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > break; > > @@ -608,7 +608,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > > ret =3D xform_func(pkts[i], sa, &priv->cop); > > if (unlikely(ret)) { > > - rte_pktmbuf_free(pkts[i]); > > + free_pkt(pkts[i]); > > continue; > > } > > > > @@ -643,7 +643,7 @@ ipsec_inline_dequeue(ipsec_xform_fn xform_func, > struct ipsec_ctx *ipsec_ctx, > > sa =3D priv->sa; > > ret =3D xform_func(pkt, sa, &priv->cop); > > if (unlikely(ret)) { > > - rte_pktmbuf_free(pkt); > > + free_pkt(pkt); > > continue; > > } > > pkts[nb_pkts++] =3D pkt; > > @@ -690,13 +690,13 @@ ipsec_dequeue(ipsec_xform_fn xform_func, struct > ipsec_ctx *ipsec_ctx, > > RTE_SECURITY_ACTION_TYPE_NONE) { > > ret =3D xform_func(pkt, sa, cops[j]); > > if (unlikely(ret)) { > > - rte_pktmbuf_free(pkt); > > + free_pkt(pkt); > > continue; > > } > > } else if (ipsec_get_action_type(sa) =3D=3D > > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > if (cops[j]->status) { > > - rte_pktmbuf_free(pkt); > > + free_pkt(pkt); > > continue; > > } > > } > > diff --git a/examples/ipsec-secgw/ipsec_process.c > > b/examples/ipsec-secgw/ipsec_process.c > > index bb2f2b8..4748299 100644 > > --- a/examples/ipsec-secgw/ipsec_process.c > > +++ b/examples/ipsec-secgw/ipsec_process.c > > @@ -12,22 +12,13 @@ > > #include > > > > #include "ipsec.h" > > +#include "ipsec-secgw.h" > > > > #define SATP_OUT_IPV4(t) \ > > ((((t) & RTE_IPSEC_SATP_MODE_MASK) =3D=3D > RTE_IPSEC_SATP_MODE_TRANS && \ > > (((t) & RTE_IPSEC_SATP_IPV_MASK) =3D=3D RTE_IPSEC_SATP_IPV4)) || \ > > ((t) & RTE_IPSEC_SATP_MODE_MASK) =3D=3D > RTE_IPSEC_SATP_MODE_TUNLV4) > > > > -/* helper routine to free bulk of packets */ -static inline void > > -free_pkts(struct rte_mbuf *mb[], uint32_t n) -{ > > - uint32_t i; > > - > > - for (i =3D 0; i !=3D n; i++) > > - rte_pktmbuf_free(mb[i]); > > -} > > - > > /* helper routine to free bulk of crypto-ops and related packets */ > > static inline void free_cops(struct rte_crypto_op *cop[], uint32_t n) > > -- > > 2.7.4