From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C981DA00C5; Thu, 7 May 2020 06:18:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D42F1D921; Thu, 7 May 2020 06:18:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8F5C81D91A for ; Thu, 7 May 2020 06:18:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0474Hcd4000369; Wed, 6 May 2020 21:18:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=pY3WeFiItX4vztEdSjjspLOsW7lCZLnJ+nGhwt45Za0=; b=JSD93HZ4woSLF8ipIEqiqM7gUbroAfAPrhDjW8xO/5cZCxqSkfDtMcoyJjZtrx8DMhAn sEhL+6Gmdxc7eEErmZwkxkYKaktWdbErLVbcg5FfTNV4HPJ7Onz2M3dSHbq4J3oca9E1 bfoKLET9/xt6zQPyR1n0psKCb0qptucxfDSKB1yOleVE0EQ8Es3xM8fmoH/omAeHpIxc LH9nE99yzPpqAUm31hc8y9kjuxHFHnI/Tgn+me/utN+6Fukm9rdsgcMpnwOkOqbxuFZ+ Rkk46y3oG+X9+bFHUCjBbw6rIlP8AXXdAoN+OLEx6beiTZ85KkKuBDy+ja1ui0+HkcXF 2Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30uaum0fh7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 May 2020 21:18:26 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 May 2020 21:18:25 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 6 May 2020 21:18:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lesc7OKo2g7u8fPsl7OfKmHuufllY8F8A9cxGKjLNjzQ1G5GxT5l+KnF41hTVThHC8xtrD2nbMaF9HG1r21lfmddNxktqck2Eag2gT9HnleB0FIh+Ru68jgfbe7fp9COQCn8ZG52DVgrFnJxKDI2JuYwbP3ap+QujmJqdm9jHlrdzdWFEJP4FYSF95AUURUcNxCW4vuZAyu7GFeC7Izje3byfU0MpCJowXHuQ4/+/slCvRw9LFBmDDosJfbP5forRg6Cy2uyOWcfaflQT1kE3paTZ6UI3oflsnCkmfGcyNFrxlA+pOUGbIohTF701W9rsa84XGfje36HJjttN/TTLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pY3WeFiItX4vztEdSjjspLOsW7lCZLnJ+nGhwt45Za0=; b=TA9NmU7Q1Q9gBUQHN9KTyDCx2hY+ggSIIs2ILc4NFK6DP/WuwMqvnsmb2ujaVMJn9iiH50lsb7M4AA3n3OICHK/xkw991HCiJQVgKEvfT93KqHgKmuEXxm0CNELhUaSkK2ccv/jzO3XC19nkYNmmNr1FyxPHg2/A7HJk7/g4eIeppLn+HL90uv1Az73gCqrXCJ9EV6QXV9f/zgvyeEwr/OZ+2pghkBk6neHCOIL/LV0a3OJGY0pRJPZeEzA4rrESBb9s8aU3E66sVuZaYXwfBhVae9IegzuiiyczUodp9CQbKVjb+lNuDq5tCYjj4J0yQa1iFCdrVfWNQ8j8nBjv3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pY3WeFiItX4vztEdSjjspLOsW7lCZLnJ+nGhwt45Za0=; b=fL6RPn+30mwx/ougpeR24alkjlXB0S25gwcmCxihQStr9sKfYCtPcTWfFZrKnIub8MoPmH7qyQc7M0BJHm7VJukMF3VKyOHpzhwwk1+uBcCIpoPPFMRNlUjpHsgt9tIOJ6ZHF3WTOE3B5ikbfUAA7pPbaLmeTs4tAbu/nrvMhoA= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB2847.namprd18.prod.outlook.com (2603:10b6:208:39::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 7 May 2020 04:18:22 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::15a6:7cce:c7ce:b74f%7]) with mapi id 15.20.2958.030; Thu, 7 May 2020 04:18:22 +0000 From: Anoob Joseph To: Praveen Shetty , "dev@dpdk.org" , "declan.doherty@intel.com" , "akhil.goyal@nxp.com" CC: "bernard.iremonger@intel.com" , "konstantin.ananyev@intel.com" Thread-Topic: [EXT] [PATCH v3] examples/ipsec-secgw: fix negative argument passing Thread-Index: AQHWI5Xio21f5tmdkE2N0383Ho2MQ6icBbFQ Date: Thu, 7 May 2020 04:18:22 +0000 Message-ID: References: <20200506103752.20478-1-praveen.shetty@intel.com> <20200506110241.21118-1-praveen.shetty@intel.com> In-Reply-To: <20200506110241.21118-1-praveen.shetty@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [111.125.205.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a1867cd-b617-4c2c-3908-08d7f23dae22 x-ms-traffictypediagnostic: MN2PR18MB2847: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KYISa2pYtxLqw2Suw1mNC6C1Tm5V1c9zolIeEofiPDYZK45A91hwVNWspkMUV5itg58utaTb+yvl6kJZGLmatXy9nODSUk6FiMIihkX4k5x9bYgAPrBil8GKV7DjJ4lpySnJhgE6lrESDS/rphCnquxv1PtF5isqSOuZBvUGDV7HphMedM/YYRMON5qxPp5RMTKI+3iiLMEzJ8WcKh1w6we8sx+hmcoAXoyPvDi7NcXIsvnMBvLeB3xYzS15v+kE6lwVPMUawKp1mzEaQrcmrzByVUXLT/5JEt5YWYt3xqNIBUY3ffF49Dt8I4XBCkpVqK1MY94Lp+quLrxyi4so7XPEQMUxaM5Oi4Wu+JQOW3Su3IRMAKX9Zw9+GwWC6NWTnl0pSnu+r3LvgKq4155nw0sf0P8uVH10ZQboq88t/sjcsP55ef2m0Nt+oWBORorsN128VALila6QTbUeIgkAXAhD2dVyo5uZ55MQ5+CPt+nmDWma6+aLBBQhIwHw9B3akXiVwy51rbu/N//H4Gg7lg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(33430700001)(6506007)(71200400001)(55016002)(33656002)(9686003)(7696005)(33440700001)(52536014)(66446008)(54906003)(316002)(66946007)(110136005)(66476007)(4326008)(66556008)(64756008)(8676002)(4744005)(76116006)(478600001)(5660300002)(8936002)(55236004)(26005)(86362001)(2906002)(83300400001)(83280400001)(83320400001)(83310400001)(83290400001)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: UGLblSGbAbbZwJNZRgPcGPc4QVRf5k1G5aL6+1nCQpJCMPekyYnqg7EbFv+9YEse8IfwMVRUJJ2Nece7HnNSUsboz4zpbAeRGetUtZm/6Fz1+noYI1o9i7IcO7lY3DtDl31f7M+3mICdHLagyCD34OBLngl9zRKFQqApqIfj9WvgMocnHPxMpJlzd5nGkTEbr17ADDe1N/i50QyfDWwLTQowPLPOXpNsFw8pN7OzKPNefH4i0S/Z36sAXPtqdt6v3seyhOKB018bBLiHpNDg5RNkCoT60lz/duW7mTMumplTucCddQc0e1VDoEpsJiu3r6F+XQ5tC7zeCh8Eb+PmilsNY4tvMbqq1dK/kp61/9dH/SxAlbvl+1m5/EfhxkeSiw9YKCtoL03vxCxXY+0c5bkeSXHvBERS8gLwmnJ0JrsnQYcdwTNSAFiTIrOeYLYDyDd8gTlw0OkrjuLclH25/2W7tXidYlQe3KuY4QtDjgTa+uCLI4g85kO8W+dGM/8ZaruwDs/dcCoX1SxgTZPWiSKQC96gRqxxdhlPDL0xQzzEcE1TT9gmEcGgTefpKoEvTUurP9ydp8ReYxYy/dD4tQYYfYI0U/4EP7x0XR/qjVCP/81sbVgXeFk04PEl50lq2JY+cnFPKOlffzovnRUwPzJx6WJx7eBRnT5dxJq1qWGNHI4QLYxMZxFOZk7hhKMoe/SECqljAMxvuTY9JOoVLCMcI4GaO27c1eRNOs3kWmYWLPxJYqeCb1RhiDGvP7WReULjfI5Msne2A7va3LWKODTO4pMy75VzpI5O0NNtkNE= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5a1867cd-b617-4c2c-3908-08d7f23dae22 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 04:18:22.3350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hg4e5/Jpg6umcZnqH0ODgfH8ORqJGdm7nHhJn2YO5saRDyCk3ZU3c3+EO1Lo8c/DrrjsRaX7kg4GqC30aYUZkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2847 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-07_01:2020-05-05, 2020-05-07 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: fix negative argument passing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Function create_ipsec_esp_flow returns a negative number in case of any f= ailure > and we are passing this to strerror to display the error message. > But strerror()'s argument cannot be negative. > In case of failure, displaying exact error message to console is handled = in > create_ipsec_esp_flow function.So it is not required to print the error m= essage > again using strerror. > This patch will remove the unnecessary calling of strerror function to fi= x the > negative argument passing to strerror issue. >=20 > Coverity issue: 357691 > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") > Cc: praveen.shetty@intel.com >=20 > Signed-off-by: Praveen Shetty > Acked-by: Lukasz Wojciechowski Acked-by: Anoob Joseph