From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77202A00C2; Thu, 23 Apr 2020 06:07:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AF011C43A; Thu, 23 Apr 2020 06:07:23 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id A35E41C439 for ; Thu, 23 Apr 2020 06:07:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03N3xleU005463; Wed, 22 Apr 2020 21:07:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=o78Adu8acoAH2SO40YE5s1d4ZAXRhaQRei8e9KT3U/M=; b=gnYA+A+RaTiBmEmNOgzlqIo1lQ9kAo4D6zSInNumjSzrbc2woIGpxdk9oZTT4QVSajED TM2d4zts2OekB8tNRS0gnR3/G1sh6T3vtcz2ERia8nohjuYY2YTXprDZhzSDjs3nSI0O 5XvHusi9S8/mwS0TnP8Pru+2moVT3NCdsTfX4RNuV+5wFKuE7BjrNosyJEa86NyQkBaB Uq4EXNULV1IGzw9LIv+XoICM7JKThj1hDhc+u9+hla1ITC683x4qNFlAeYqq/FtIyGUT gfuNDO5RflKmND+/AyZrnRs6SZpX4zlmtOItsghl548U03dv86qiVx/z+dN74A2wo4fk kA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 30fxwpn0u1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 Apr 2020 21:07:20 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Apr 2020 21:07:19 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 22 Apr 2020 21:07:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfNhj/2CtFVOSP5TY5I2Mw12WvfJhY9403azJ4mGybZWvEsetnFPxk480J4O8mtTgqtxLZ0jKS6d9xv8osGVa14aNfspQl+6oO/yNioW1K96cFBjrXm+fcMc8s9wFb6q/3UdiDumlOAoyglLfQL8P+z6FzmCY6gyz09/odlDJIOm04cEP8fZR+2Qx7QsDj0SD6F86oH55s39QSH0yvDek5oA4zaKgpAlGbZ+j1RoFrdTKGsHwbyc9qdTDbJuaZZBYW4Rf2CQw2nSTe1P5FrFa3O8LJWllUvbFRml2njOkn1cUVfKhUYoBzyC+vK2jxHbzwZVQarCgle7uL5UMdilBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o78Adu8acoAH2SO40YE5s1d4ZAXRhaQRei8e9KT3U/M=; b=A8a4BFgeLV+ezC/IPiarcq1UVFEQwRXf6B/wU7fC40ETJjIC0lmjHBfrFRam+VJYFOJzdugp2L60kLRBPfiSaricE6u8zCgSZJPACL5JAgrH01G3gTQJnkSy0f54QhRmqmniF1Epmk7irCt7PHspvLhBGjg3cshrfzuBQf++NzD351buMu+aDMSGYd+UNL8Xsc4bvzPJBgcjThuTda0icr/ytwpPl363YEiRGua/VayStwRbarKsbKPBAf+j+tJcMVyAcI8NC0N2A73mz65m4KuSBOzE5PGfsBIGiOznDrlhLeqP0g0EDw7k36VNWBthkgoEINr+lE57oVOTJGKCxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o78Adu8acoAH2SO40YE5s1d4ZAXRhaQRei8e9KT3U/M=; b=RZ9EclADbBHBxzAK2VIwd1u42IUlAF7U1zPA3UzZZZeEYHUX4TNaxhNKesTC6smp7id0HbPGpVxegbMMy4abp/t4N/N/JwGa+Q6wFuLMK7gNRMFZWHXhkw0CNzhOAoeZ6Hn65qhe/UyIfFNji2HK9dasHFwtG0mfRHPwTPNVDSg= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB3134.namprd18.prod.outlook.com (2603:10b6:208:162::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 23 Apr 2020 04:07:17 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::648f:e7fa:f95e:191b%2]) with mapi id 15.20.2921.030; Thu, 23 Apr 2020 04:07:17 +0000 From: Anoob Joseph To: Konstantin Ananyev , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "declan.doherty@intel.com" Thread-Topic: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops Thread-Index: AQHWGQET5ssCrfrdCkGeU0EkO7BVz6iGFf8A Date: Thu, 23 Apr 2020 04:07:17 +0000 Message-ID: References: <20200422235158.24497-1-konstantin.ananyev@intel.com> In-Reply-To: <20200422235158.24497-1-konstantin.ananyev@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [27.34.246.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 33db0e49-f478-421e-0b37-08d7e73bd02a x-ms-traffictypediagnostic: MN2PR18MB3134: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(53546011)(66946007)(52536014)(4326008)(26005)(76116006)(15650500001)(9686003)(2906002)(186003)(478600001)(55016002)(64756008)(66556008)(71200400001)(66446008)(5660300002)(86362001)(33656002)(66476007)(110136005)(316002)(8936002)(7696005)(966005)(54906003)(81156014)(6506007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0afkeyV0e3CXMjag2JTRJ4C18cpQuOZONamIDCPKjCw4JUW30flU2avbdrbZBEqAsAq7t2VZvCnq+1/Lh8iAwRPCk2gmUhz7iR7VUy7nqZuTwXBwUY605Zx8AMcJtQgfFVNvZeNLRKIlCyvZY0AbAiiC9eoyXC0Uwpnx6fGhAHkXX1+Obkl9jfznbocD+87SxvzptevsxHjkx4tpAsrbRRxkL1C2G8C8vWRq34BjhB0lqc84X3tLGNAEyRNTomnC0iji1Zeyo4hqvtXrotDT4fJ2MMAsvxcmrmnGanw4KDzel4EAbxhKSbaldYuGkgWNC1BwfBv7q3/Ml7vuX1rO+TU5ytbxUS9Oav9JOVFaJs+r/6PuJUxMMPv21hQAd0PmbsRYwqumPolGCLw/MSVF8Se+jmbwBEWW/VoTnveqkAuzWv1j42bcPFtvblaDRJUtMh7wUlSnLR3Z9FcXxtlqohZpxI3dNm6iob8+pt4dptKUGlA4Y0Mkar5YBWAI6CKrq6IXvrN2CJo55qXe3+swXA== x-ms-exchange-antispam-messagedata: rphfGjVKOYm/Ub+goG9947qcxQxREVHiS0Ua0IWNunCWH9e1dazQzu3RLrSXlh/G+M4ipCJBuyVM14xGgGLC5pd4apVgBsQ3BgSiYiozz91w+TbJkYNo+DAp/9jEOK8eXcD16ZHI8STtd6fVJb66mQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 33db0e49-f478-421e-0b37-08d7e73bd02a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 04:07:17.6248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yqX2tV5VJ6jauSuQ5gS4l7CowDjJPyDk67K31+eZY76bLJuqN9MYIxg5T1sU7iTNwlOVTO7HtGT8oz7Gu9eMCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3134 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-22_08:2020-04-22, 2020-04-22 signatures=0 Subject: Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, These are data path ops and so it will be better if we can avoid such check= s in the datapath. The same is done in ethdev also. http://code.dpdk.org/dpdk/v20.02/source/lib/librte_ethdev/rte_ethdev.h#L437= 2 Datapath functions in cryptodev (enqueue/dequeue) doesn't even have such ch= ecks. http://code.dpdk.org/dpdk/v20.02/source/lib/librte_cryptodev/rte_cryptodev.= h#L962 Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Konstantin Ananyev > Sent: Thursday, April 23, 2020 5:22 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; declan.doherty@intel.com; Konstantin Ananyev > > Subject: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemen= ted > ops >=20 > Valid checks for optional function pointers inside dev-ops were disabled = by > undefined macro. >=20 > Fixes: b6ee98547847 ("security: fix verification of parameters") >=20 > Signed-off-by: Konstantin Ananyev > --- > lib/librte_security/rte_security.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte= _security.c > index d475b0977..b65430ce2 100644 > --- a/lib/librte_security/rte_security.c > +++ b/lib/librte_security/rte_security.c > @@ -107,11 +107,9 @@ rte_security_set_pkt_metadata(struct rte_security_ct= x > *instance, > struct rte_security_session *sess, > struct rte_mbuf *m, void *params) { -#ifdef > RTE_DEBUG > RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, set_pkt_metadata, - > EINVAL, > -ENOTSUP); > RTE_PTR_OR_ERR_RET(sess, -EINVAL); > -#endif > return instance->ops->set_pkt_metadata(instance->device, > sess, m, params); > } > @@ -121,9 +119,7 @@ rte_security_get_userdata(struct rte_security_ctx > *instance, uint64_t md) { > void *userdata =3D NULL; >=20 > -#ifdef RTE_DEBUG > RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, get_userdata, NULL, > NULL); -#endif > if (instance->ops->get_userdata(instance->device, md, &userdata)) > return NULL; >=20 > -- > 2.17.1