From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D5D6EA0471 for ; Mon, 17 Jun 2019 12:14:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBF311BEC4; Mon, 17 Jun 2019 12:14:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 980A71BEC2 for ; Mon, 17 Jun 2019 12:14:42 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5HA56Ij013564; Mon, 17 Jun 2019 03:14:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=yCjFeAltiHNUHjsJowccUmwIgcTAaL2UgXHHG4B7rbI=; b=idFRl+PF0MtKvXWSNPQAsx4iXxwafN4o3IUhjin1DUKvfrDIiiWDfrAk7KQ7BdO4VCZo t6lwS9GVFnq/WH62sDnnG3g62IyTFiPCcc93F/R0ei0bMoF0fHHcOo33MXzbNAhkkFTi fI0oFQH6uFNL40TlWlRaeqebpFKu/W7hXysYn6ceqync17VwKiW7tH7JGDehM22onslr LasQwGFccPV54i8jX8VD6pxXp8jRMm6zv9m1g91Oo/DEEdwZL2I5O7KMHppHcdGypNIM iqXoRxN0dYG3hrB5X6B0kHSr6NCbdLx9uTSn53z4wReyX1nc5Dv8B3tBVhW8RIH4gMXc VQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2t68rp81ar-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2019 03:14:41 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 17 Jun 2019 03:14:40 -0700 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.59) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 17 Jun 2019 03:14:40 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCjFeAltiHNUHjsJowccUmwIgcTAaL2UgXHHG4B7rbI=; b=ggzrQBCZuGJXyUpENqjhVnUHl8pq7bf4HTK80lBzq7L8MyDxeD8GKDZczqPy1w55bzC0SNt9E87gtvSPT++JPlL4pxJRacadCoyfvXG5V9v+2HM7NeyThMFtviF64KJyd9qPbH/HBr8FVasUMc8Hh5+cTtu1NhbR2/by+/QaXOc= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2479.namprd18.prod.outlook.com (20.179.82.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.13; Mon, 17 Jun 2019 10:14:39 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad%3]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 10:14:38 +0000 From: Anoob Joseph To: Jerin Jacob Kollanukkaran , Nikhil Rao , Erik Gabriel Carrillo , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Liang Ma Thread-Topic: [PATCH 16/39] eventdev: add eventmode CL options framework Thread-Index: AQHVGjLAoSKSsbiDjEqrfOsrUtvRiaaUt4QAgAr8u9A= Date: Mon, 17 Jun 2019 10:14:38 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-17-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78038fc9-96da-4991-008c-08d6f30c9b48 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2479; x-ms-traffictypediagnostic: MN2PR18MB2479: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39850400004)(376002)(396003)(346002)(366004)(199004)(189003)(13464003)(99286004)(8936002)(66066001)(7736002)(3846002)(305945005)(316002)(6246003)(25786009)(55016002)(7696005)(76176011)(54906003)(53936002)(102836004)(6116002)(74316002)(5660300002)(9686003)(6436002)(4326008)(52536014)(55236004)(229853002)(81156014)(81166006)(486006)(186003)(53546011)(66476007)(66556008)(64756008)(66446008)(6506007)(110136005)(68736007)(76116006)(66946007)(73956011)(478600001)(2906002)(86362001)(256004)(7416002)(71190400001)(71200400001)(14454004)(8676002)(446003)(33656002)(476003)(66574012)(26005)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2479; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zC2t8CUHxNYRME2YD/1yhokgc3+8HAd7bcbkl39d407dmCC7smw0glQV7dUmnfHZCkIyJrYVJj7fDi+ijYblMYGmd0Y210cm4l6Y55qKN7qBF5musFTHYAkoGNoOCzGAp64WzOTeYB1fIQsMMEkc5OJNolJo4Jb7/xLvMXlCWXHfeMjSeMl8YGq5cvWHfXYdvqJhRvhFvb0JL9niiK8pH+CeaYBZ6qqTevBegGKjyTpCZWEgaDnzyY6K1FElU3/FIlSU3Bq3V+PA7pfCFpaila4kEc4nQbuC+ki1q72Att64JSWATfuAAprHROk7sPrC3P4LJfo1VLGqymeyTsqngvOHFYYxVNPl+WC8gYrSmDNfjh5TQzKCqcrEkCpqwgfgjWOLw39jHRK+nzJOqj6H08F9IkdpzUCPBfl8pL8JMTc= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 78038fc9-96da-4991-008c-08d6f30c9b48 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 10:14:38.7619 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2479 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-17_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, Please see inline. Thanks, Anoob > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:49 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo = ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bartosik > ; Pavan Nikhilesh Bhagavatula > ; Hemant Agrawal > ; Nipun Gupta ; Harry > van Haaren ; Mattias R=F6nnblom > ; Liang Ma > Subject: RE: [PATCH 16/39] eventdev: add eventmode CL options framework >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Monday, June 3, 2019 11:02 PM > > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > > ; Erik Gabriel Carrillo > > ; Abhinandan Gujjar > > ; Bruce Richardson > > ; Pablo de Lara > > > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > > ; dev@dpdk.org; Lukas Bartosik > > ; Pavan Nikhilesh Bhagavatula > > ; Hemant Agrawal > ; > > Nipun Gupta ; Harry van Haaren > > ; Mattias R=F6nnblom > > ; Liang Ma > > Subject: [PATCH 16/39] eventdev: add eventmode CL options framework > > > > Adding usage prints and CL parsing routines for eventmode. Option to > > select packet transfer mode is also added. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Lukasz Bartosik > > --- > > +#include > > + > > +/* Packet transfer mode of the application */ enum > > +rte_eventmode_helper_pkt_transfer_mode { > > + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL =3D 0, > > + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT, > > +}; >=20 > Need to mark all public structues as EXPERIMENTAL. > Please grep for EXPERIMENTAL in libeventdev or any other library [Anoob] Will fix in v2. >=20 > > +struct rte_eventmode_helper_conf { > > + enum rte_eventmode_helper_pkt_transfer_mode mode; > > + /**< Packet transfer mode of the application */ > > + void *mode_params; > > + /**< Mode specific parameters */ > > +}; >=20 > Please make this event_helper object as 'opaque' and move to internal so > that it does have ABI policies and future new features can be added. >=20 [Anoob] The member, "mode_params" is the opaque pointer which is used inter= nally. There are two fields which need to be communicated between applicati= on and helper library. 1. mode: whether the application is running in event-mode or poll-mode. Bot= h application and helper library would need this. This field is set by the = helper while parsing the eventmode args. 2. eth_portmask: helper library needs this info from application to know wh= ich all ethernet ports it can use. This is determined by the application an= d has to be communicated to the helper library. This can be made as params = passed to the application, but eth_portmask will be the only member in it, = as of now. With the above use case, do you recommend any different structure layout?