From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4568CA0093;
	Tue, 19 May 2020 07:54:11 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B8E331D509;
	Tue, 19 May 2020 07:54:10 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 91CDB1D454;
 Tue, 19 May 2020 07:54:08 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
 04J5oRw1002151; Mon, 18 May 2020 22:54:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
 h=from : to : cc :
 subject : date : message-id : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=pfpt0818;
 bh=q6iAkzE0MuvJf4o0tOK0lsYG9dMCtlvG4oaygPi7xhs=;
 b=yVOtkUciRHGWm625CZuxYMYjoYN3jVtk02zJfC+QiUgBfICQIprf2jpv0lkrIVzI7NmT
 5DF9kQXWEdRGTihXL/iDYYBFbd5BCvJgKiWgcJZeMrqgTUCD2/Sh4RqoEQB0T4X6LMtx
 1HwvwZxvWNjIOrtd71I39Y/N19yOoJ/MFlcmUaHKNinNDCh9hKc6GsbYpXu27jaiRnUT
 bHxYc1LpdxWjx5x8d0GPRnAU3aSAoxZzJ7oy3MBfGxKjSx70dacZTOqcfDTmDe731L+I
 caor2a5l0VCbK/H0zuUyzLN+qwQ+YBOYei7la1DOUWT1Do4OlHCkDUtvH8NK3uZ2yyWJ uw== 
Received: from sc-exch03.marvell.com ([199.233.58.183])
 by mx0b-0016f401.pphosted.com with ESMTP id 312fpp22j5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
 Mon, 18 May 2020 22:54:07 -0700
Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com
 (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 18 May
 2020 22:54:05 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103)
 by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id
 15.0.1497.2 via Frontend Transport; Mon, 18 May 2020 22:54:05 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M9wez9TOOY/Va6zmGhUfR3GtqF+S6p15uT/ZQ1uTIfjraDsu/AgV3dup/1oCMh2ZJOFY2T5dl/w4XuQyVPSJypOnDc0uNLQYOMxXy93JfxVRTRq1EP6krjKdS61H106JB9Fc9UlF/4JM41k2tToEPegGhIaoJseOj98lm77nOjJ3Ub0GezqMewhiEtJin624sS9FIkVmVbpXtKQ95FBchGgyBIWFCKmxYDnE4C7Yb7HypCuegUFM/vArrW3lo87WcGeFCdAG29LCMKb1Z1hKq4UDaINkgGEYQpFQWtGkoFn3eBOR8wjxzcDitqfo1YQpCMkQ0Nel47h5YuctvPWCnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q6iAkzE0MuvJf4o0tOK0lsYG9dMCtlvG4oaygPi7xhs=;
 b=gAWQxJxTdEfjL1WNVlPWwuwARv/05a7bayJKFn3w+yX5yEIkbDYvD13U46k1gdTPGhtksulHfxR48P0wJT6V4sl3403eKbtRTNVvUKkO+XgZNPkMhRVPKuz5AlA9YMFkb3M4ZTY3cA52+HJ7DTH6ckZ3N8PqiyBCQvJ5KO2YBwnYCv189TmrP3BjchD8NYgJCAuYAGKbrdoLwKp6JaCI/fWabD4ArNdeq8WkqUpDQcBgLF3YAZqjbVeNrcIl4cPKr6d9yRWRifiPDsSXS9nSobNNNMP3WqSxZT9yQBmZlQLueZKtaxSTtGZnPbJGN35xRDcbk8sV7qb3PJHeuc9EkQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q6iAkzE0MuvJf4o0tOK0lsYG9dMCtlvG4oaygPi7xhs=;
 b=qk30nvqIDLaak07xAS3xqQqzxSwFyoX+XkCqrNHmxJflJXSMmmEOJyC2bT2D0xl97yYCKhc1htP3GDJQHK5ASV6jl2yoyAfId3kqIdfSmOxcoMHoU3L4JX1w+CBYoB5v4zX9b9dYvufN7Wp51puf16Xas1v/QibEtGCdAGdZuHE=
Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26)
 by MN2PR18MB2750.namprd18.prod.outlook.com (2603:10b6:208:a2::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Tue, 19 May
 2020 05:54:03 +0000
Received: from MN2PR18MB2877.namprd18.prod.outlook.com
 ([fe80::15a6:7cce:c7ce:b74f]) by MN2PR18MB2877.namprd18.prod.outlook.com
 ([fe80::15a6:7cce:c7ce:b74f%7]) with mapi id 15.20.3000.033; Tue, 19 May 2020
 05:54:03 +0000
From: Anoob Joseph <anoobj@marvell.com>
To: Adam Dybkowski <adamx.dybkowski@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "fiona.trahe@intel.com" <fiona.trahe@intel.com>, "akhil.goyal@nxp.com"
 <akhil.goyal@nxp.com>
CC: "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment
Thread-Index: AQHWLSI1fSMpWps6+02JAes/IuKaE6iu6G0g
Date: Tue, 19 May 2020 05:54:03 +0000
Message-ID: <MN2PR18MB2877E0866CE96368EBFF5C45DFB90@MN2PR18MB2877.namprd18.prod.outlook.com>
References: <20200518142342.1987-1-adamx.dybkowski@intel.com>
In-Reply-To: <20200518142342.1987-1-adamx.dybkowski@intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=marvell.com;
x-originating-ip: [111.125.205.80]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e6d560d5-e033-4045-b0f7-08d7fbb908e6
x-ms-traffictypediagnostic: MN2PR18MB2750:
x-microsoft-antispam-prvs: <MN2PR18MB27504DECDD184730018ED370DFB90@MN2PR18MB2750.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5516;
x-forefront-prvs: 040866B734
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Jsi4HAEeGcDnqOYl192S/fjCLqCP5YRpFVi0kyzjUn2CVdSkBPDt9aIPhcds/aySOhaIsyppUaKLBjZlkvMUkSmUn22WwxFrVbZwZX88HG0deIinCUj/w4DHjUXUE4Ia0VnWWuaNVcisR5nKjjF7SxtTkvY/r0abYh4nZ115+1GoPXj+F0jHc93oW4cKvxvilYL4yXtI+hTJuNhTtpsOW+tlP1sRZ5WGJ4zx6MXZvBAmp2G0ZkTn3vR8BVD77kzazr+dkVjJbNucUG7E8PcbY3qv/5oY37dbLthb1c98KAU2wsHGahpREfvEvtpRR6LKlkkgWPaiKQI+urJQnplrTx7jR7K1qdDgy03AVRVm/cC347KYUo1De5gqiKoUhMPryCltl76akWRQkYVp9FdSBR3jsmVLBytiGWvZQFPciqYQHFJ+5oGEng4XcYRKcn+KD8CSgqks7eFwsbbkEJuxcBLo7mBiHXAbsSTLdysFBIVNRnRdQx6xboH0sr54ajqbbFD7HWkZC2OVqjORaY1wag==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE;
 SFTY:;
 SFS:(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(71200400001)(478600001)(186003)(26005)(8676002)(33656002)(55016002)(316002)(66476007)(64756008)(66446008)(9686003)(110136005)(76116006)(66556008)(52536014)(66946007)(86362001)(55236004)(7696005)(5660300002)(53546011)(6506007)(4326008)(2906002)(8936002);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: sQXtFyHeWhxEvGsf4A/w4bqJVDA+Go+g5mxDe117glctBmO6mDEEll3D/YRczMfCWy+4uOkDvN1//ECwzL3iHvQzfa/nM9cUITxaDM3vSNIKOzvyKiui3BXVk7KT/Q2jTbClYNczDKdJCqkNkIN5nZiPXRCUXHi7ZWTGcIwhum+ZfVJ0uUjXab5HrTdidHkpHh559WCuyrA1BymglztAwNFK6uJ83niywnoJ7xU3NyaI1M+9NLAI2o6HVjbwu6AZ21fKGdSvm39znKUrTcNmVMtY2nvzlqGrgQe6GhuvPML1xC6tOh0WlL4j/0qAzN+SN3eRxk8HPcy7oSZvNwLAPPEvXA4iGOAE92SeSYXkmazw7J9jKilRfmNznImsIKu1N8StWD/6QftxBOaA/RTY4y3WUYZFoT2rrqzuiKT78oLBTdogw1eERnqPDORzz5fnlqUetPPX9ldhoEk3sAZV3SqK4vgTBxuUE1pV2VTOreSuuysLvw65IGkG0rQWx9ZF
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e6d560d5-e033-4045-b0f7-08d7fbb908e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2020 05:54:03.2642 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nzDoPNFudJIIwQ2uTca5OxNWT/GCfCIpvPB7YyOE5USy6wc3QHnWIo2Sxku0B2zo1A9FT6Hb7t6wZWqldRO7dA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2750
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676
 definitions=2020-05-19_01:2020-05-15,
 2020-05-19 signatures=0
Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Adam, Akhil,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Adam Dybkowski
> Sent: Monday, May 18, 2020 7:54 PM
> To: dev@dpdk.org; fiona.trahe@intel.com; akhil.goyal@nxp.com
> Cc: Adam Dybkowski <adamx.dybkowski@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] cryptodev: fix SHA-1 digest enum comment
>=20
> This patch fixes improper SHA-1 digest size in the enum comment.
>=20
> Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
>  lib/librte_cryptodev/rte_crypto_sym.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
> b/lib/librte_cryptodev/rte_crypto_sym.h
> index d9585ecd6..9cea4e5f0 100644
> --- a/lib/librte_cryptodev/rte_crypto_sym.h
> +++ b/lib/librte_cryptodev/rte_crypto_sym.h
> @@ -269,9 +269,9 @@ enum rte_crypto_auth_algorithm {
>  	/**< HMAC using MD5 algorithm */
>=20
>  	RTE_CRYPTO_AUTH_SHA1,
> -	/**< 128 bit SHA algorithm. */
> +	/**< 160 bit SHA algorithm. */
>  	RTE_CRYPTO_AUTH_SHA1_HMAC,
> -	/**< HMAC using 128 bit SHA algorithm. */
> +	/**< HMAC using 160 bit SHA algorithm. */

[Anoob] This raises one interesting question. Is HMAC-SHA-1-96 (https://too=
ls.ietf.org/html/rfc2404) treated as a separate algorithm or is it a digest=
 size variant of RTE_CRYPTO_AUTH_SHA1_HMAC? I assume the later.
=20
>  	RTE_CRYPTO_AUTH_SHA224,
>  	/**< 224 bit SHA algorithm. */
>  	RTE_CRYPTO_AUTH_SHA224_HMAC,
> --
> 2.17.1