From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09F83A04F6; Tue, 7 Jan 2020 07:56:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6AC061D8DA; Tue, 7 Jan 2020 07:56:58 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7804E1D709 for ; Tue, 7 Jan 2020 07:56:56 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0076udB5028165; Mon, 6 Jan 2020 22:56:55 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=C9SiLP4Im4i0sRpkwjnpJVZdxm/LlerQqDRxVG5Sh3U=; b=aR1eKE7+OJvoVjDXNQobe15qwPUG2s7Rib4qhag/2obn60CJxiFw7ys7cdAku+dqU80C 2Zs1IKAnyo8htO5JLM6DG1FYdwyXJmdBT11aMAmw4HKOWCa+2OsG4sCuEMsCjYuFTAfI Eyyyj+Vb/Q1jCGsq4hjLjYE/wKKr10YoOb7mRRd3mpaZzgnKBjBfK1ShY4oNwO665HSn Mnyc0OGIQxwvzojfFmtHSyQWxlB5s92ZuISPAyn5cRp2J2jjAKgVv0wweCaRXI+EoRbL 80s1LLkt+VJX4+hG/slZZTKdCc9aez2vLeUMsy68111ESWwydCGida9PTEP/1kJMG20f LA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2xcn0b00ug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 06 Jan 2020 22:56:55 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Jan 2020 22:56:53 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 6 Jan 2020 22:56:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfpwQOSr93wBy74q1nwlkMqYNY/S9GT/zoXRn1unm9o6n0uY38f5Dk8Jmp1k79hfzSyTo/wIvtx7ZvzxOoLvdqk/rrTSPuza5GnjVltsfXRflL6KYKw6CMl8TSMIix2txxt+gWCt4aV1wucun6+sVfzcGa2jHA4ElgIjWa4EruuVdTJxdSmxJ27Khe73m3kkFBnu6UNCqRD3vmXYaVKsVjt+t2yTJoyJUPwsKEoKzBVc6MMIRQ1rFWkpR9rNcShg0Kb3ETcsIsur3rgl/j8K3u0f78KV1TM/VhggN44J8DZorXhaylrbr+wVYxIKOeaYPpxWcR7RFBvLIwm4DFqIXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C9SiLP4Im4i0sRpkwjnpJVZdxm/LlerQqDRxVG5Sh3U=; b=V2GlpSwT35a5XwcFTtc5QIhaiQ5+i4RAXMz22QU3lnmmK1aiR8FwrBd5AswqCb41v+ihvOOqpX7MJb39GRw4opzO9OGaKm1z6lDRPn3+ljwT+sOxKXuC/JvarNnaltxJ6DlsDnirCbDxWpMzAbAvyeWDtTX2lq3hDMBtReTGzeqlpZR5nR2sRoVrL8S/xLI+h5gsy55NS0pVGST9b99E7T7fpfHtieADPguMCznRNS3WxJLzwMabkkbcQ7RzWKNBQkZWxA/48bSQeFp/jYZx3rTyGavQgHTqMTpKLp33fOtvkutUltpyvhrN7NzKIRktrbvWQ1r95EdHuEZz9qQI5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C9SiLP4Im4i0sRpkwjnpJVZdxm/LlerQqDRxVG5Sh3U=; b=qSLUHe6n2zDmTJQHxxG6hFOR24rcOwpxvSa11ZTiRRn4VqpU7Zmqa228lcatKbAaifeuG8DsYN/vbaJn42IEtRI3d64CNj7uUEIrzUDaAIVh9DLtrpa6u4vad8kxra3999LmMCexQuTTEy9vesUpfyIiVeMN0z6NkHixZLdXNBw= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2750.namprd18.prod.outlook.com (20.179.22.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.13; Tue, 7 Jan 2020 06:56:52 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5db5:d179:8a01:4636]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::5db5:d179:8a01:4636%7]) with mapi id 15.20.2602.016; Tue, 7 Jan 2020 06:56:52 +0000 From: Anoob Joseph To: "Ananyev, Konstantin" , Akhil Goyal , "Nicolau, Radu" , "Thomas Monjalon" CC: Lukas Bartosik , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Ankur Dwivedi , Archana Muniganti , Tejasree Kondoj , "Vamsi Krishna Attunuru" , "dev@dpdk.org" Thread-Topic: [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw Thread-Index: AQHVrcOBv+tkQd9jB0KmZByt413uHafJVTaAgA+KzvCABSdGAIAAxEOA Date: Tue, 7 Jan 2020 06:56:52 +0000 Message-ID: References: <1575808249-31135-1-git-send-email-anoobj@marvell.com> <1575808249-31135-10-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62924a36-1b1b-419c-3de8-08d7933ec666 x-ms-traffictypediagnostic: MN2PR18MB2750: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 027578BB13 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(189003)(199004)(13464003)(64756008)(26005)(66476007)(66556008)(66446008)(5660300002)(66946007)(4326008)(7696005)(186003)(478600001)(52536014)(8936002)(55236004)(9686003)(6506007)(2906002)(81166006)(81156014)(53546011)(8676002)(71200400001)(76116006)(86362001)(55016002)(54906003)(110136005)(33656002)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2750; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KDjENwdUyryfS6IJt54Srae3L6pgaCuxZQA1LHRm2uQJYe8+dGtx1iBUQJdEp9iqc3Feetu+KC0zPODOJjukWQJAnDS84xLU6qwlyx/4I+NL07d7br0IhQbzClCJ/57Lj75UzN5ePzMEt5RTvK/I4jXXXtvFEzUQq2hwWzmsPiBHF0KSnhLXgDKyZ2FHoCY/ibAbgOv44mlW841rhwkHdHmU3hUltRKNc75h4UWVA0eTtgPRbhMalQrMLQ8iDtF+bFWAHbKKxBq4ij2TxVZV46StJxcPmzJKXjqsXTRzWKS0XYTTGR8Vj/8oJg1QwqkZL737sijne3bXdJOaj9UK4Isj6NQ85yxJsfg3XZOzXAh2FvJO1A6+5Adi+EFioi1krIFH9CJdiWBDX6TIiYy1Au+NYntxGCUJ5YRir3BRA6sh/k4pBUusVi9CqK8WEXcJpyXCgx8iiAIGezCCPxsXYJYyItD267bDJOnYyesH89H+X/PrW7/wg7tyUtq36SzW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 62924a36-1b1b-419c-3de8-08d7933ec666 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2020 06:56:52.0240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PhNAIOazYHCYtGhOaMRxOtrVyPlmx+f1x9m2LsK3C6OjqEDrYoKzlEXMZM53NMUvZ7DXbUMhxU3TF9NN5DG+xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2750 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2020-01-07_01:2020-01-06,2020-01-07 signatures=0 Subject: Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, Please see inline. Thanks, Anoob > -----Original Message----- > From: Ananyev, Konstantin > Sent: Monday, January 6, 2020 10:21 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Ankur Dwivedi ; Archana > Muniganti ; Tejasree Kondoj > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH 09/14] examples/ipsec-secgw: add eventmode to > ipsec-secgw >=20 > External Email >=20 > ---------------------------------------------------------------------- > > > > Add eventmode support to ipsec-secgw. This uses event helper to > > > > setup and use the eventmode capabilities. Add driver inbound worker= . > > > > > > > > Example command: > > > > ./ipsec-secgw -c 0x1 -w 0002:02:00.0,ipsec_in_max_spi=3D100 -w > > > > 0002:07:00.0 -w 0002:0e:00.0 -w 0002:10:00.1 -- -P -p 0x3 -u 0x1 > > > > --config "(0,0,0),(1,0,0)" -f a-aes-gcm-msa.cfg --transfer-mode 1 > > > > --schedule-type 2 --process-mode drv --process-dir in > > > > > > As I can see new event mode is totally orthogonal to the existing po= ll mode. > > > Event mode has it is own data-path, and it doesn't reuse any part of > > > poll- mode data-path code. > > > Plus in event mode many poll-mode options: > > > libirary/legacy mode, fragment/reassemble, replay-window, ESN, > > > fall-back session, etc. > > > are simply ignored. > > > > [Anoob] The features are not supported with the initial version. But > > the features are equally applicable to eventmode and is planned for the= future. > Also, fragment/reassemble, replay-window, ESN, fall-back session etc are = not > applicable for non-library mode. >=20 > True, but in poll-mode library-mode support all functionality that legacy= -mode > does, plus some extra. > Also I still hope that after perf-problems evaluation with NXP we will be= able to > safely remove legacy poll-mode. >=20 > >We can follow the > > same logic and allow for an extra arg (which is --transfer-mode). > > > > > Also as I can read the current code - right now these modes can't be > > > mixed and used together. > > > User has to use either only event based or poll mode API/devices. > > > > [Anoob] Same like how we cannot mix library and non-library modes. > > > > > > > > If so, then at least we need a check (and report with error exit) > > > for these mutually exclusive option variants. > > > > [Anoob] Will do that. >=20 > Ok. >=20 > > > Probably even better would be to generate two separate binaries Let s= ay: > > > ipsec-secgw-event and ipsec-secgw-poll. > > > We can still keep the same parent directory, makefile, common src fil= es etc. > > > for both. > > > > [Anoob] I would be inclined to not fork the current application. Do > > you see any issues if the same binary could run in both modes. The defa= ult > behavior would be poll mode (with existing behavior). >=20 > My main concern here that there will be over-helming number of options (s= ome > of which are mutually exclusive) in the same app. > So it will be really hard to maintain and use such app. > My thought was that it might be cleaner to have two different apps each w= ith its > own set of options. >=20 [Anoob] Technically event mode would need only one extra argument. The one = to specify "scheduling type". The direction can be removed (discussed in an= other thread) and app-mode can be merged with existing single_sa mode. And we do want the event-mode to be supporting all features supported by po= ll mode. Just that we will have to take it up gradually (because of the vol= ume of code change). Thomas had opposed the idea of forking example applications for event mode.= I also agree with him there. Event-mode just establishes an alternate way = to receive and send packets. Entire IPsec processing can be maintained comm= on.