From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5FAEA0524; Thu, 2 Jul 2020 12:00:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CE5B1D8E7; Thu, 2 Jul 2020 12:00:09 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 1EEC61D8DC for ; Thu, 2 Jul 2020 12:00:07 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0629xVZo022171; Thu, 2 Jul 2020 03:00:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=uVAp8z9JkUpIEhhPyo+EV/nqlHQ1Gs/udONlW2T3wJk=; b=ZeU/n1lgLqIJMmthxvbQobPra1KAMM/42a//4dYWJu4BL4yLWKMfnAnTDByF9lzrctAC OdJYG3oxOayejGT40kyD49BrtWsxTLuHsHipYFGS8/08CTFvwBbDeF5hWmeR482iP0j8 uOLo33CPYmzRS9gLHiamhf4mvUiNS1Y2wy633x+ixtpCiU4VJB/VsrlzSZjCkQSBX+5P ly6BRZpHSFTPtqdgG2u+FZa1J6qapJkl0OoPxwPPv9im33ZgCpT2S6PfLYIjC96vq6P6 EBZu1wEsJJvqAc6IhfqztacKe+U95fp2cjH1oz+hZref81LU5gILFQIuXpEUtaKIvYvj pw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 31y0ws9081-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 02 Jul 2020 03:00:07 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Jul 2020 03:00:06 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 2 Jul 2020 03:00:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CA5EMr3JjOv2L1m1VRUAuV9Y78olySaTNZBIVCa+aDAZj2uUTcvaQa8YsPG+jVNPSFU6kb6IKcWtfPhiEVmH7nHlYjndTrMz2sVcmHnx3kSmyn/PfBpzfzvTk12BauYVdtyjTSjfmTODp42xJnzBhMmeLhIV3KIR3oUMaZ58wCnDlLM495bDSQOHrHf8SNbDGpT22e7q1nS2oRCwS8Ke57tlQcX0BHjJxbNrrMNFnh9CHG+VqUOI4ujsWF5il1gb6XETYYSmSHM1VzK+uj704VcRymv8kKpnU/3/aTSGT7jaJ/1sKh68ho/I+2AoSQbEGjK5E8UxAsqwJYbCxlMD+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uVAp8z9JkUpIEhhPyo+EV/nqlHQ1Gs/udONlW2T3wJk=; b=UrV935PL7KL1Wj7PLXJrMkLa4RBJGO5uupM7DbXvt1KUEmKEVewMR8h6cFTtLOmbnkcdIQW855v8Z6zbCZb11ONvigBndHEVBM7cXEgLMBXc+UOjc6dF0BIzt1fen0VdvHwrGcMHOp4BZh/7XrYhA+YZQ+SBucE3L2Yi80gQAhChXfMgX/Ze/W/2ey+aSo4mVe9dzQjcd9GvQtSl2ebHfQWPOjcRDSqOP5iOnGIT+oKqN3lANUCxnkMoJWvibFHL/Dnie4Qr5pELdtE0UuKs2Okw1ucwLzgIL0uVgsau7siE84GS+T4/K4daj3MEV9R47MJXd2D0q3U36xhyP7/IsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uVAp8z9JkUpIEhhPyo+EV/nqlHQ1Gs/udONlW2T3wJk=; b=Mxwm3ua49abFKM98pl9qi+XULDLqYLiBMNIVfkF0EmSmdjhBWcAiEOyeEs00rc2he6Inru+hmJkyELGIrBOobJ2SaGmSFf/j2JQiKtzLtxyVkv95lpX5T3ta2z7GoSPDCfZb5YYl0S2xDkyEPqt7ncuarNjyKNSoYVWh32q0nTM= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) by MN2PR18MB2877.namprd18.prod.outlook.com (2603:10b6:208:3b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Thu, 2 Jul 2020 10:00:05 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::a975:5b17:ebb4:722a]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::a975:5b17:ebb4:722a%4]) with mapi id 15.20.3131.034; Thu, 2 Jul 2020 10:00:05 +0000 From: Anoob Joseph To: Akhil Goyal , Tejasree Kondoj , Radu Nicolau CC: Narayana Prasad Raju Athreya , "Vamsi Krishna Attunuru" , "dev@dpdk.org" Thread-Topic: [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions Thread-Index: AQHWSVAdm+PQ48BCOEacm3ReMdk7oqjzPs2AgADUwNCAAAMGAIAAAheA Date: Thu, 2 Jul 2020 10:00:05 +0000 Message-ID: References: <20200623121228.10355-1-ktejasree@marvell.com> <20200623121228.10355-3-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [4.31.158.67] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 709251e1-ef0b-4b50-11bc-08d81e6eb1cf x-ms-traffictypediagnostic: MN2PR18MB2877: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SVxwUokR/utWkq+HWR46KCERp6xeHIF0v3XvF5AetawNFp9Ph0/aawOTC+no402TnOXC8ISxxdh2NHtD5PbKcSleJopVOxuJKafBXLwude6alinrfcginOegV8qWio3jxN8tQLw9qHR8Z3KJdFvum2xoAqyutrVVq32aARbTaG2ZEiGfvP9VkLOFNzNlmi/TGKd/vyMmStD4FKk4tC0st5xIXSiECE9i1NLZiEzflYvId1NX4Qr6fj/vn2n9F+LplnQWY/8oQov4zaWzfVfcnSKcZusFpRMJI+PfIEyf6cUMJt0ZTvPXcf3dmJlHaFGItWG5DRpfmjjYF6eF9Y1+Dg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2877.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(33656002)(64756008)(66946007)(66446008)(66556008)(66476007)(76116006)(4326008)(86362001)(478600001)(83380400001)(2906002)(110136005)(52536014)(316002)(54906003)(186003)(26005)(71200400001)(5660300002)(8936002)(55016002)(9686003)(7696005)(8676002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 4k6HoF4kEQbKZq11GN8w5OWjnnn3Q72KuIYXQu4L6z/2v36tGS7jE9oBt9WtMkQzu0G1vyhffLNgY0vCnkq1WT5BCZOVZdO5q3+ScdC4TVIge7Gkl+AfXmqKhRtoyx5+pYS5VVeGCU00lonEpD//fbp8hlGmvwLhxSWpgc4jvXIvRTUY0A/47lMoZPkYRzlE4AaC9oeQzkhJaoDalgkEHFQ0XeM8CtFT61kqGMsVGyXAsieiZ7blHKum/4KrDjoUKJRR+HkmOrEsqONQ+nmI7zYM8Y2pYY3dMKfn1vXM8foY3UcnY69X5pS2P1o8EmPN1yd1Y1V6zDR2b6vsg6XzItuya4nmVxYgGg5iL18wOc1YDa9xYLCqrTNdHrxPfq2nZRMvio/xpCogzr14rwxEeYptKpRYinWkQ4wGNvtx8faLtI5dlJjzAaD8drY5dIviDiLi0GRFhCNoTxj5yyDLX/h2rDqk9BjTU1mUsE4Lv18= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB2877.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 709251e1-ef0b-4b50-11bc-08d81e6eb1cf X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 10:00:05.0809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5bfvF6lWTiKma13s675MehCtx8og/HuG444IMs8LkhJzyBmHezdymjtNrLOI36E/rFEMmzjEhSQE2pQXqcrNeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2877 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-02_04:2020-07-01, 2020-07-02 signatures=0 Subject: Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, >=20 > ---------------------------------------------------------------------- > > > > +#include "otx2_ipsec_po.h" > > > Why is it named like this? What is 'po' ? > > > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for > > inline and one for lookaside. The one for inline is FP and the one for > > lookaside is PO (Protocol Offload). > > > Isn't it better to write "inline" in place of "fp" and "offload" in place= of "po"? >=20 > Fp and po looks very cryptic. [Anoob] Yes. But since it is firmware specific, these need to be added for = all structures etc. And these opcodes can be used interchangeably as well (= as in PO opcode can be used for inline and FP opcodes can be used for looka= side, but both with certain limitations). Hence we have tried to separate i= t out this way. Larger names would mean longer function names and structure= names etc. We tried few other names as well, but then it was conflicting w= ith other opcodes. I do agree that it is slightly cryptic, but we have trie= d to use the names consistently to avoid confusions.=20 Thanks, Anoob=20