From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9391A3168 for ; Wed, 16 Oct 2019 11:57:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECB641E8E0; Wed, 16 Oct 2019 11:57:53 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E7CF71E8D6 for ; Wed, 16 Oct 2019 11:57:51 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9G9tYtc024851; Wed, 16 Oct 2019 02:57:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=OSYu4+kYW0ryfROilA6KudxofSJW4e7zUowXwqykDi8=; b=m2dO/J//m5POo5FeAjtyAVaISN/4Lp6cSz4oB0iwW/ArKRgpXoKNKrqPXENwXHjWTXV9 3tk6UBylvvMe6m4P+W7rGx/gvxTBtqUtfOthFxtDXLAph4ScOVKJ9nwoWIgY2QY8JBC9 iOmOtLYZQBA4ESU6C9+Y4jTw3ZJRpJ1dLfeha1XGa0RmOmmKI0Wta/FVOMXcN8fmzfeA 2Gv7FOIOoUCEOL6kkWldDg5TX3VOEwPWQWzUH+KYg08Sqrf1rrRFYanrLd2OqWB2Yqj4 xcNmvzLNeOfLwVqQ05XrJuHWmlURo6baTT04ha+dEzEmorfflaZNKkYIyX1FKyo5z8yg 3A== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2vnpmbja6k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2019 02:57:47 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 16 Oct 2019 02:57:46 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 16 Oct 2019 02:57:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GWTN22H3llAhf+S+WnzP+Vm46ARr4W6ZKqcCWyy8AsO893xogSq0vgSTdh2I0fbutM4s6R2/H31XEmpy4Jb62WOzbedIoV7sTMUkndHJKM/tsr5GHjCul/4NkQA5q7XpQxxdT4zkrDJz/gXkrr9FlVfeo0sOhGKEGsT6opg1+FV8FD/akD/0bSFbUxJE4BPfWpd7L4kcgfuMRVOlmF+IK7tE1thFNY51qnc56/dSCgRS74zCvB0lEtjxA9qu1RSRsOp8FAL58sLzMoZS9DpGiq1qVMrck7JM0Am+mvCuCxDeEewJvBIrMR06uNXH+RuD6cvkdaKWGZhkJ9EAVjW9MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OSYu4+kYW0ryfROilA6KudxofSJW4e7zUowXwqykDi8=; b=hemo//CbqsaKr1MehUKWeatyshenskE08UxgZyWJSj/nX6ZF7pFVPu/U9IsOyvoKrdTnpnlsdkl0JGijiycAWQAR6TrIPqmZnG0M6Yf4YV687vLt6rZlE2ayOUPmbMsZfiO7A9Y1Csx5THXfTUmpYqfoKuyG/NH/L0VdmUrNuZx/PfwXYt14mYIRjtjzRUU0vwO2CpLDN75aEfoPF7Vxp4JwDqkqJhVDkbDMvI5gGA2TJAC4A2ozqcxMi05gIN4MR71Kl+kHdDt5Mb+euGMc2BM2QsUeKXIHWjarktqZplll63l2vHGbJifXXlyIw+AklcZYmUEi6n8uFvspI5xx8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OSYu4+kYW0ryfROilA6KudxofSJW4e7zUowXwqykDi8=; b=gm7HzzJF3dwWRXSI6mSlR+DjHIJKpAe+HVYV/C+w/fofGtf9nsu+qjbcCJi/NYBM+h+sIui/7C6xlkLB7esfuPaw3ySkcDzp4oNlv7zz1hm1LItp71YH/V+UdV8odRlJeu6dIqkqlMiq9Iqogj32oRQva5SCy6/EHYGzchVoCYY= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2559.namprd18.prod.outlook.com (20.179.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.21; Wed, 16 Oct 2019 09:57:45 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::6d15:3367:4c9:5385]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::6d15:3367:4c9:5385%7]) with mapi id 15.20.2347.023; Wed, 16 Oct 2019 09:57:45 +0000 From: Anoob Joseph To: "Gavin Hu (Arm Technology China)" , "Akhil.goyal@nxp.com" , Pablo de Lara CC: Fiona Trahe , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Shally Verma , Ankur Dwivedi , Kanaka Durga Kotamarthy , Sunila Sahu , Tejasree Kondoj , "dev@dpdk.org" , Honnappa Nagarahalli , nd , nd Thread-Topic: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add enqueue/dequeue ops Thread-Index: AQHVg0qLCoOsJKWOTkK6H4gIWLCjlqdcvd9w Date: Wed, 16 Oct 2019 09:57:44 +0000 Message-ID: References: <1567146501-8224-1-git-send-email-anoobj@marvell.com> <1570970402-20278-1-git-send-email-anoobj@marvell.com> <1570970402-20278-8-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0aec92f0-7417-4c85-57f3-08d7521f4afe x-ms-traffictypediagnostic: MN2PR18MB2559: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0192E812EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(39860400002)(396003)(136003)(376002)(13464003)(189003)(199004)(966005)(478600001)(14454004)(229853002)(7696005)(99286004)(76176011)(2501003)(5660300002)(52536014)(9686003)(55016002)(110136005)(6306002)(6246003)(486006)(446003)(11346002)(476003)(25786009)(71190400001)(33656002)(8936002)(71200400001)(6506007)(53546011)(55236004)(102836004)(2906002)(81166006)(186003)(81156014)(26005)(54906003)(76116006)(66946007)(7736002)(66446008)(64756008)(66556008)(66476007)(14444005)(305945005)(256004)(74316002)(19627235002)(86362001)(66066001)(316002)(4326008)(3846002)(6436002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2559; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dqPjQFLlXIcjO6ZA/IlTkU/aYUd3z1Vx5lti/aaaSPjQ2nVnaWzjYnk5eeZ+0e9bKa83Lj7vBAGzu/uebQW6aOsjZfrw5BM2ffyg97J4yMIbNtt99umrYQ46EK5q8fzmM8EYRipv+ejZmMDN0ijK8jhsn2slMEkcpzCuFmO7I6NU2LNE6aIg0CpTrWQe3keymfBI+ld7cqMsedZB5XjgiQFFCDNCjKKUTLkyc8VKj0O0TxGJ8mk/QNz2zCQifq2FxEf9fHYW4pTfJD3myZ3Pz3d+nIKGeMFsjthj1qLg7gX8cGxxowTNoDPw/ucciewSbUiyZimlIilmiudtHFg+JstVW+5tqmSuLUMHlRVAfxo71kUyoa6mERpPn+om0AT/KUgbM9CrOmVFhyZhNcOJAYri7zjqnIqvwr1JlMg0fNJkPdRM0iPX7Fv1geHXgNZovwOGWaHP6PRGozBvZMMMWQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0aec92f0-7417-4c85-57f3-08d7521f4afe X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2019 09:57:44.9502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vq5m6FjiJsz/oq1OgIqHZBxfztkiaOPahCkI8OzOMiBfFg0GkReqbrfrDy5ioQ736NYyxdiZfjcoIIz8tCTAlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2559 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-16_04:2019-10-15,2019-10-16 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add enqueue/dequeue ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gavin, Thanks for your review and suggestion. I agree with your suggestion and wou= ld be taking up the rework. But since we are close to RC1, I would like to = defer this to the next release cycle. This change would touch all features = supported and hence, will require an extensive QA internally. Thanks, Anoob > -----Original Message----- > From: Gavin Hu (Arm Technology China) > Sent: Tuesday, October 15, 2019 4:50 PM > To: Anoob Joseph ; Akhil.goyal@nxp.com; Pablo de > Lara > Cc: Fiona Trahe ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Shally Verma ; Ankur > Dwivedi ; Kanaka Durga Kotamarthy > ; Sunila Sahu ; Tejasree > Kondoj ; dev@dpdk.org; Honnappa Nagarahalli > ; nd ; nd > Subject: [EXT] RE: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add > enqueue/dequeue ops >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > This is a typical producer-consumer case, enqueue and dequeue operations > must be conducted in a synchronized way, otherwise stale or earlier-than- > arrival data will be got. > Out-of-synchronization issues are more prone to happen on weak memory > ordered platforms, like arm and PPC, if execution in the program order is > assumed. > I see in this patch MOD_INC() and other reads/writes of the indexes might > get reordered with regard to real enqueue and deque operations, this may > cause synchronization errors. > I have a fix for rte ring using C11 to keep synchronized operations, plea= se > refer to: https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > 3A__patches.dpdk.org_patch_47733_&d=3DDwIFAg&c=3DnKjWec2b6R0mOyPaz7 > xtfQ&r=3DjPfB8rwwviRSxyLWs2n6B-WYLn1v9SyTMrT5EQqh2TU&m=3D- > CQNFLhmDggI38cEto5lpU668oUfOgbIO8Akw7ViaVM&s=3Dc5- > AH2gQk6Kqi_AKdacCs0k-w42Qrisy4Ev9SF3fG6w&e=3D > /Gavin >=20 > > -----Original Message----- > > From: dev On Behalf Of Anoob Joseph > > Sent: Sunday, October 13, 2019 8:40 PM > > To: Akhil.goyal@nxp.com; Pablo de Lara > > > > Cc: Anoob Joseph ; Fiona Trahe > > ; jerinj@marvell.com; Narayana Prasad > > ; Shally Verma ; Ankur > > Dwivedi ; Kanaka Durga Kotamarthy > > ; Sunila Sahu ; > Tejasree > > Kondoj ; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2 07/12] crypto/octeontx2: add > > enqueue/dequeue ops > > > > This patch adds the enqueue burst and dequeue burst callbacks for the > > OCTEON TX2 crypto driver. >=20 >