From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D393FA00C5; Thu, 2 Jul 2020 12:32:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B5431D6E7; Thu, 2 Jul 2020 12:32:08 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 2ECE51D6E6 for ; Thu, 2 Jul 2020 12:32:06 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 062AVUOk004125; Thu, 2 Jul 2020 03:32:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=rrIksJIfW2dreujs5/mO7z4UGjTi0HGBw1cK8GKzZ1U=; b=X+pfNN6KvW3ToV7SBOoO9B13ZEg/xaOzblP6W0z5PW0YPLB5FqW6jTuNO4vYqaAxrjNR sCayaFtcuHHeGUctfz1TY0nqM6jv508zp+7G1UEHJ35aPi/3fXawkIpGOCcbwoxSLTfj I6FSNUqGY/xohgrQ4J1KmdXFzj78RCJ3B7t0pWarE66rbzbVBCq5v/YsUryBsILg2k4/ sHdiUXfRlpKMIU1pzWhK1hmv/7r7U4V9NuXq0y5vg54XTlf0fN/7/e+aKo/LDon2oxEX e+bNqv17ai8O6znVqFNAuejSJH9AgfYHz0I9e2cLi/al4yJRrjWKPxO/UOQrm53Iz3tU kw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 31y0ws9433-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 02 Jul 2020 03:32:05 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Jul 2020 03:32:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 2 Jul 2020 03:32:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=koITMj/lPAFazQUOlE0ndj8UcKUgQ46CPl2rofCldQK6vyD25SryyZKHHDaKKKnzzJWAHdEMB1uiN207ClFwSe4kd2du0EqLVtaO1XMeFZTJP+qxRMNhIC1hxWaRNM/wxqhC4bL45XJI5aBCLQumTQMiMwUMdJoowOf+qItP/T1mcZMBIN/8v/Rnz7MaZVy2SVcXdQ992mk/9V9fF8m3kDlUqtZmKc6fOdBzZBHV1nNfiaFB4q8wVphifEfTO8A5GXRCKakxNGfU4uWtm31S/V/m2vAnwjxnfMnswkN5cmMeUPsVpD18VDeM65df+gpAm7WxMDMbs9/sFkget9YhBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rrIksJIfW2dreujs5/mO7z4UGjTi0HGBw1cK8GKzZ1U=; b=I3qDpt08mWzJQB6GweGg7E2momrXxgTO+F0V2UcqBNdASFOgJt845V5OGDEAE9sMVzkR+YhxvxIsZlHfBwS9gramM9Ig83lvZyO5ajBws1KnbU6EDsVocU0gv8tvLKm64+av/ixzMLy1EXA/aW2uOtlzMPUFUcsgkl+PmPIN8CZUVZLX3ONqFuXnfht80m9iNlLPRWwE9BMvPxcUEaamMG8cbvCe4dbDigqjLv4/8m2RV2f7rHKQsoJIBlLMrHHSq3mRnGR+wNhlwg8Ch6L9ToieDjDayqjkZhjo0BEnvi5GxucFOFd0Y+ZI6R4GZ9eUCS3G5NoJMR6cWoIDeY9ZWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rrIksJIfW2dreujs5/mO7z4UGjTi0HGBw1cK8GKzZ1U=; b=ulyv5i0GjG5/scmiSno/0bVPapO/rJnvlii+RmbBGiPZzlnRwLeAa6uMSrTtVwiYAM2XYYP5qSNM3ouU2jOU3Y9UCJuiFzRbUI7IZD1+m6WJvLG8zUifTbzNqRmoOVUEnyTLpeF/V08lFh7dw0YT08O+UwBGpEZIH/pXCgYlD00= Received: from MN2PR18MB2974.namprd18.prod.outlook.com (2603:10b6:208:3a::25) by MN2PR18MB2912.namprd18.prod.outlook.com (2603:10b6:208:a0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.22; Thu, 2 Jul 2020 10:32:01 +0000 Received: from MN2PR18MB2974.namprd18.prod.outlook.com ([fe80::7033:585f:3791:2d41]) by MN2PR18MB2974.namprd18.prod.outlook.com ([fe80::7033:585f:3791:2d41%5]) with mapi id 15.20.3153.027; Thu, 2 Jul 2020 10:32:01 +0000 From: Tejasree Kondoj To: Akhil Goyal , Radu Nicolau CC: Narayana Prasad Raju Athreya , Anoob Joseph , Vamsi Krishna Attunuru , "dev@dpdk.org" Thread-Topic: [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities Thread-Index: AQHWSVAkcj6cmp70jUCDcAw7psLKVKjzRIyAgADfQ/A= Date: Thu, 2 Jul 2020 10:32:01 +0000 Message-ID: References: <20200623121228.10355-1-ktejasree@marvell.com> <20200623121228.10355-5-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [124.123.31.236] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5082e18b-33fe-4306-bd2c-08d81e732809 x-ms-traffictypediagnostic: MN2PR18MB2912: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qQNYEVaFgb8XYnZBDS+fGa1Jx5r1EuZePrjIvK5OO2VbG90FEnMbl2bOWN/rEd9wyIjlOlW/8ZdkWl8NjH8E0S7h9wlzzvEPHMXQUm3j5+jfLuAeQkgoZ9PnH3veYoZCVvhZ5/0lSjqRZKPKC5kLV/DKnM1mn87rCsr86ut71SE+Lcd/eS1J4ct998x9u8BnHJh5NK6aPnOc57eEKaDqOGbAIKwwcAYBLQlRqQdfWe5Dim1KoTErenvpo0dPOnD3CF8fvHj8R+p33qrKoLOyslhqY7uMR1p4IL9yCZRuxAXFpzB/Axmdm2is+AC+F22bXt8XQaD5HUWDD54WiooXkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2974.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(396003)(136003)(346002)(376002)(366004)(66556008)(6506007)(478600001)(4326008)(53546011)(7696005)(83380400001)(86362001)(33656002)(64756008)(8936002)(9686003)(55016002)(110136005)(316002)(5660300002)(2906002)(52536014)(8676002)(76116006)(54906003)(66946007)(66476007)(66446008)(71200400001)(186003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: jAEAXfI9vqm+Q6LGwjodcWE4dK7hDeDIuNYYBLL08w1hny2gGJpz8VNRWt4YW5VFZnf5zFTHtWlFjF9alOfVqZJC8VX3EbpLfHfShqTTQMbK8nF3S0k+UY37bbNXm7F8z3Z9Z30y78o3mxvncogGuwDBcF1D3s/3KtvTK80bidZBx1YuSgrvFoc8LWdfcfGmzpg7HFHma0jM3MTHsj5732p9sdL9RFJAo2DhbGemwcsNuISiiF+PPA/hH0TowVII+ZfqEkxAn0F6dQ0GhDtK7BhK8RHtK99yPYk4X1uw9SOlDtrfE3ZHQaoZZdQbHD9/VFJ4tNG+TAPbIisbgi9LDq/DhgzcYH3TFovFvPjWSd3pTjuWqvvAbhPXUe9P5+9m/6A2eECZ4NV9lfV4O45vk7Nwn+pzjeZfdFSMUwMSOwypJVWETJTeA/vaG3eox/vxkibbBBoYUlEumpdVD94a9gDr8AiMM+8cteMHQt2TA9OgloLz1eoQ1UmjtfKsOFoq Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB2974.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5082e18b-33fe-4306-bd2c-08d81e732809 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 10:32:01.3285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dpzmqon8JTLD/in6493lAykfXWRvHReX6YMi82vNz2XMSmWDGbNnQKOAh0HOaKpYmG3rGJN8XIeC7xPCmlebeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2912 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-02_04:2020-07-02, 2020-07-02 signatures=0 Subject: Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks Tejasree > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, July 2, 2020 2:37 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH 4/8] crypto/octeontx2: add cryptodev sec > capabilities >=20 > External Email >=20 > ---------------------------------------------------------------------- > > +static const struct rte_cryptodev_capabilities * > > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) { > > + SEC_CAPS_ADD(hw_caps, aes); > > + > > + sec_caps_add(caps_end, RTE_DIM(caps_end)); > > + > > + return otx2_cpt_sec_caps; > > +} > SEC_CAPS_ADD should be called earlier when the security context is create= d > Or where all other capabilities of the PMD are initialized. > It should not be added when capabilities need to be retrieved. > As of now you are supporting only AES-GCM, but in future if you add more > algos, Then it would be difficult to manage. [Tejasree] We will initialize capabilities during probe and capabilities_g= et() would return pointer. Would that work?