From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ECA2A04A5; Wed, 17 Jun 2020 12:16:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A79081150; Wed, 17 Jun 2020 12:16:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 6D37AFFA for ; Wed, 17 Jun 2020 12:16:39 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05HAFmmM016677; Wed, 17 Jun 2020 03:16:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=2hWA7VuWzs81sLfpzcCncVpFwe2/TLmVywnmvMGqaaE=; b=W+VXuKeHqEEib2i0pmg6CetlW2u4lZVtdWkXKvvfu9LOSq/09l5ZFKVDLG4SwtTa2ZsO 6uLLPXPp8FPFaxAb2iF+pCbUjAvAl88bmFVSG+bgYLdSIOOX3E81sXTP9P/WA+4dvXp9 1Ko6d2DMivGZ/F2rMc1F2ReYCr1TymwyjflfwgDjymSuEFdmYqkdo4m7OkuXLA7Kntx/ 1ZnxR4b7UnFg1AdJE3iPT0KQt8B3Lz7XCB1IB5JgNWj7nu1axP7nuexQShY+W+6GnqMU KFETL35mXW3zZJWuulJu0enkgS+b3QyhHi+2E8qPiY8OvVYpiY/1kKU3rJiezwS06Ls2 Gg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 31q658kpvn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Jun 2020 03:16:38 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 17 Jun 2020 03:16:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 17 Jun 2020 03:16:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9vrHcsbM3Vh9W7Ao8heUfk55+AKRQJhVdmjk3OgqoDJ6C2D8UbgjnVYqsaPLbeQkZdwu3Us5gqa/nH7ETshcFkpD4HpnRhzEJtsrBiCRdKCIBUicXkL3xWw1qIlvwAFaVT0mlJMWylqEjwIRLnTcS4zVxnaHodfKsHXSGNi1RVL4dGPYhV6W8I3ZCrEmyedozeM//BldNPB1giIKCte58045KtXWYtbya73VXcAL4aqBLOlshkSNPpj8hU30BU/GMPV1kATZ2CRqZdZukWVvcE0qsM6t0pn9K7gMGoLwM84HWmQlUWW0CrcUTrHSSEkYHL5Ja0gS2y4se9xqoZjqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2hWA7VuWzs81sLfpzcCncVpFwe2/TLmVywnmvMGqaaE=; b=RySgA64wA93tkmRSjvk+NtoLk6TtNWwZPyKCj2klT2f8H6mcxg1vMlVtQgm4OUxGBk8P9iToymsIOn7618EMGoEwWuvUHmPWUu3cGka2roLG6/JfBejZOFiKCUuBHcSKDF49XX9C6skvmhytKSY2UH0yhcSTiKnf75o3q4YyeSwDj+HBo0RmUzjnTOnesdkOceDUCdGnET8F3wYHtcinF9oQXlv26vUkerQrHHNoKFDjmTwdSVtdJCxMIyDSmVbMjA9/ZW/cmeybTjL8YsZpMoWIXSTiMgOH4uTMXZyLuoUBid6Vgvj22iDUQ+jM5TsLOaqQDpRXLFnTzF5nqBPEPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2hWA7VuWzs81sLfpzcCncVpFwe2/TLmVywnmvMGqaaE=; b=uHoTnE/v3L5njCY0lXk6Pka8oviKxrL0OGHJ1DdO4K4X709bVAKn10cs/Xn6eWbDT+PDF9FZCcjfoscdU8WwZxBukPggiolVxTDdzSLpNDqJUCWTLbmyXwHcfKv0Ig0Iq3hIiTyo1Af+WuQMgh0e9JialO6R9hxdLSyckiBazWc= Received: from MN2PR18MB2974.namprd18.prod.outlook.com (2603:10b6:208:3a::25) by MN2PR18MB2576.namprd18.prod.outlook.com (2603:10b6:208:105::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.25; Wed, 17 Jun 2020 10:16:35 +0000 Received: from MN2PR18MB2974.namprd18.prod.outlook.com ([fe80::7033:585f:3791:2d41]) by MN2PR18MB2974.namprd18.prod.outlook.com ([fe80::7033:585f:3791:2d41%5]) with mapi id 15.20.3109.021; Wed, 17 Jun 2020 10:16:35 +0000 From: Tejasree Kondoj To: Anoob Joseph , Arek Kusztal , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" Thread-Topic: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chacha poly test cases to cryptodev Thread-Index: AQHWP1v1o7R9GlFCIEee92aGVwOSkKjThBMAgAkduYA= Date: Wed, 17 Jun 2020 10:16:35 +0000 Message-ID: References: <20200610191813.13660-1-arkadiuszx.kusztal@intel.com> <20200610191813.13660-2-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [124.123.75.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a351dd2b-1247-4925-32fb-08d812a78405 x-ms-traffictypediagnostic: MN2PR18MB2576: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LqjsVWYlho2iswXbXSIsrUhbkKLq3e/nsGpZmxD38vdrt0kHMnXYE4BAI+N8JYw4yHBgklTJzUiaA90k2Ts765d81b+5uBihDL8s2SW7TlBMFS+R02ze6Kg/0W/RusKNLvSMTmUH6umu3yxmvYzj0YlJPI5v/1X4CvWdKyhg+nBcs/ogEp9UrZvQwCGnUJBeFZgvfRLW6VF6HXewXRYALF6n6Flpr370OVeyaKacPfyjBH0dUUKsM73vIc7FfNpwUzAedODP+y2vtAxpE+oesw0cY5S3Zk+suIUUJRkon/7Gq0XMCZsfzBaNler4ZX3jeZRYuxdKUz3oHv3Hr3A3cA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2974.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(478600001)(4326008)(33656002)(186003)(26005)(54906003)(110136005)(83380400001)(316002)(66476007)(66946007)(66556008)(8936002)(52536014)(5660300002)(7696005)(86362001)(53546011)(71200400001)(2906002)(6506007)(66446008)(9686003)(64756008)(55016002)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: wsbk1tayAX1UURdZZEoqz9Zfw8ThDSC9sD+/yEPfi3QJSgieyfVExVtAzzDwn4/KH2u8KWNfReit2klJ2bk3X7sLrqoYP04ZahmCXktfGG76Qgw5iL7/Am8Pdg9ZC17m64CPJKArU5ksMdMd5iU3i9X0A5xp8EWEqZTDNxMfRZuyxEDtL5zHeTe48w1CGf1MrZtHBiEhWm6iWJ6N5DrvJnzzicox5yVDHXPaj4Rybr/iCUn+tHK/WQvFaoipoAmCkvTehnjwRUKCssY/4cN6JXRE6nwrPXNTtEDzsmVW5e/OBoRVUfCmLX98dHCOpc/38b+NTk0F0ijBgOd61d96Yf+JBXUX4bQJ2oBx2UeQUe1e7indHdotzZ+3ZkxwXkgh7iPVJfg+k0RtSrITTBH2NmLNFkuWFC6vL2ylcALxz3DdFPu2/tYZHtwu6y5luk10NkjDZs5wmfzbI8YMbQe+ozC1RKCesqzEkmNKioQ1+ey6a0K7RNZhJ7Vqj4wpQyDM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a351dd2b-1247-4925-32fb-08d812a78405 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 10:16:35.4088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cb+Iu9rTWMXlC5P9jOA/Su2Xcze2CBuKUajMotlKfnGM8THPa/HMBVPe+o6K1mZ62K/bzXBK44GbMw+49XIRCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2576 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-17_03:2020-06-17, 2020-06-17 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chacha poly test cases to cryptodev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Tejasree Kondoj > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Thursday, June 11, 2020 8:37 PM > To: Arek Kusztal ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com > Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chacha poly te= st > cases to cryptodev >=20 > Minor nit inline. >=20 > Acked-by: Anoob Joseph >=20 > > -----Original Message----- > > From: dev On Behalf Of Arek Kusztal > > Sent: Thursday, June 11, 2020 12:48 AM > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Arek Kusztal > > > > Subject: [dpdk-dev] [PATCH v4 2/2] test/cryptodev: add chacha poly > > test cases to cryptodev > > > > This patch adds Chacha20-Poly1305 implementation to cryptodev tests. > > > > Signed-off-by: Arek Kusztal > > --- > > v4: > > - resent in 20.08 DPDK window > > > > app/test/test_cryptodev.c | 18 ++++++- > > app/test/test_cryptodev_aead_test_vectors.h | 75 > > +++++++++++++++++++++++++++++ > > 2 files changed, 92 insertions(+), 1 deletion(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index > > 8f63146..2f94ab1 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -11502,6 +11502,18 @@ > > auth_decrypt_AES128CBC_HMAC_SHA1_esn_check(void) > > &aes128cbc_hmac_sha1_aad_test_vector); > > } > > > > +static int > > +test_chacha20_poly1305_encrypt_test_case_rfc8439(void) > > +{ > > + return > > test_authenticated_encryption(&chacha20_poly1305_case_rfc8439); > > +} > > + > > +static int > > +test_chacha20_poly1305_decrypt_test_case_rfc8439(void) > > +{ > > + return > > test_authenticated_decryption(&chacha20_poly1305_case_rfc8439); > > +} > > + > > #ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER > > > > /* global AESNI slave IDs for the scheduler test */ @@ -11956,7 > > +11968,11 @@ static struct unit_test_suite cryptodev_testsuite =3D { > > test_AES_GMAC_authentication_test_case_4), > > TEST_CASE_ST(ut_setup, ut_teardown, > > > > test_AES_GMAC_authentication_verify_test_case_4), > > - > > + /** Chacha20-Poly1305 */ > > + TEST_CASE_ST(ut_setup, ut_teardown, > > + > > test_chacha20_poly1305_encrypt_test_case_rfc8439), > > + TEST_CASE_ST(ut_setup, ut_teardown, > > + >=20 > [Anoob] Might be better to keep a blank line between individual test bloc= ks. > Can keep the existing blank line (which got removed in this patch) and ad= d a > new one after. >=20 > > test_chacha20_poly1305_decrypt_test_case_rfc8439), > > /** SNOW 3G encrypt only (UEA2) */ > > TEST_CASE_ST(ut_setup, ut_teardown, > > test_snow3g_encryption_test_case_1), > > diff --git a/app/test/test_cryptodev_aead_test_vectors.h > > b/app/test/test_cryptodev_aead_test_vectors.h > > index e62fdb2..140f253 100644 > > --- a/app/test/test_cryptodev_aead_test_vectors.h > > +++ b/app/test/test_cryptodev_aead_test_vectors.h > > @@ -3823,4 +3823,79 @@ static const struct aead_test_data > > ccm_test_case_256_3 =3D { > > .len =3D 8 > > } > > }; > > +static uint8_t chacha_aad_rfc8439[] =3D { > > + 0x50, 0x51, 0x52, 0x53, 0xc0, 0xc1, 0xc2, 0xc3, > > + 0xc4, 0xc5, 0xc6, 0xc7 > > +}; > > + > > +static const struct aead_test_data chacha20_poly1305_case_rfc8439 =3D = { > > + .algo =3D RTE_CRYPTO_AEAD_CHACHA20_POLY1305, > > + .key =3D { > > + .data =3D { > > + 0x80, 0x81, 0x82, 0x83, 0x84, 0x85, 0x86, 0x87, > > + 0x88, 0x89, 0x8a, 0x8b, 0x8c, 0x8d, 0x8e, 0x8f, > > + 0x90, 0x91, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, > > + 0x98, 0x99, 0x9a, 0x9b, 0x9c, 0x9d, 0x9e, 0x9f > > + }, > > + .len =3D 32 > > + }, > > + .iv =3D { > > + .data =3D { > > + 0x07, 0x00, 0x00, 0x00, 0x40, 0x41, 0x42, 0x43, > > + 0x44, 0x45, 0x46, 0x47 > > + }, > > + .len =3D 12 > > + }, > > + .aad =3D { > > + .data =3D chacha_aad_rfc8439, > > + .len =3D 12 > > + }, > > + .plaintext =3D { > > + .data =3D { > > + 0x4c, 0x61, 0x64, 0x69, 0x65, 0x73, 0x20, 0x61, > > + 0x6e, 0x64, 0x20, 0x47, 0x65, 0x6e, 0x74, 0x6c, > > + 0x65, 0x6d, 0x65, 0x6e, 0x20, 0x6f, 0x66, 0x20, > > + 0x74, 0x68, 0x65, 0x20, 0x63, 0x6c, 0x61, 0x73, > > + 0x73, 0x20, 0x6f, 0x66, 0x20, 0x27, 0x39, 0x39, > > + 0x3a, 0x20, 0x49, 0x66, 0x20, 0x49, 0x20, 0x63, > > + 0x6f, 0x75, 0x6c, 0x64, 0x20, 0x6f, 0x66, 0x66, > > + 0x65, 0x72, 0x20, 0x79, 0x6f, 0x75, 0x20, 0x6f, > > + 0x6e, 0x6c, 0x79, 0x20, 0x6f, 0x6e, 0x65, 0x20, > > + 0x74, 0x69, 0x70, 0x20, 0x66, 0x6f, 0x72, 0x20, > > + 0x74, 0x68, 0x65, 0x20, 0x66, 0x75, 0x74, 0x75, > > + 0x72, 0x65, 0x2c, 0x20, 0x73, 0x75, 0x6e, 0x73, > > + 0x63, 0x72, 0x65, 0x65, 0x6e, 0x20, 0x77, 0x6f, > > + 0x75, 0x6c, 0x64, 0x20, 0x62, 0x65, 0x20, 0x69, > > + 0x74, 0x2e > > + }, > > + .len =3D 114 > > + }, > > + .ciphertext =3D { > > + .data =3D { > > + 0xd3, 0x1a, 0x8d, 0x34, 0x64, 0x8e, 0x60, 0xdb, > > + 0x7b, 0x86, 0xaf, 0xbc, 0x53, 0xef, 0x7e, 0xc2, > > + 0xa4, 0xad, 0xed, 0x51, 0x29, 0x6e, 0x08, 0xfe, > > + 0xa9, 0xe2, 0xb5, 0xa7, 0x36, 0xee, 0x62, 0xd6, > > + 0x3d, 0xbe, 0xa4, 0x5e, 0x8c, 0xa9, 0x67, 0x12, > > + 0x82, 0xfa, 0xfb, 0x69, 0xda, 0x92, 0x72, 0x8b, > > + 0x1a, 0x71, 0xde, 0x0a, 0x9e, 0x06, 0x0b, 0x29, > > + 0x05, 0xd6, 0xa5, 0xb6, 0x7e, 0xcd, 0x3b, 0x36, > > + 0x92, 0xdd, 0xbd, 0x7f, 0x2d, 0x77, 0x8b, 0x8c, > > + 0x98, 0x03, 0xae, 0xe3, 0x28, 0x09, 0x1b, 0x58, > > + 0xfa, 0xb3, 0x24, 0xe4, 0xfa, 0xd6, 0x75, 0x94, > > + 0x55, 0x85, 0x80, 0x8b, 0x48, 0x31, 0xd7, 0xbc, > > + 0x3f, 0xf4, 0xde, 0xf0, 0x8e, 0x4b, 0x7a, 0x9d, > > + 0xe5, 0x76, 0xd2, 0x65, 0x86, 0xce, 0xc6, 0x4b, > > + 0x61, 0x16 > > + }, > > + .len =3D 114 > > + }, > > + .auth_tag =3D { > > + .data =3D { > > + 0x1a, 0xe1, 0x0b, 0x59, 0x4f, 0x09, 0xe2, 0x6a, > > + 0x7e, 0x90, 0x2e, 0xcb, 0xd0, 0x60, 0x06, 0x91 > > + }, > > + .len =3D 16 > > + } > > +}; > > #endif /* TEST_CRYPTODEV_AEAD_TEST_VECTORS_H_ */ > > -- > > 2.1.0