From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Bing Zhao <bingz@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Subject: RE: [PATCH] net/mlx5: fix the queue length checking
Date: Wed, 9 Jul 2025 06:56:39 +0000 [thread overview]
Message-ID: <MN6PR12MB85679726C7DDDF9D96AEF55DDF49A@MN6PR12MB8567.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20250709040000.112338-1-bingz@nvidia.com>
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Wednesday, July 9, 2025 7:00 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>
> Subject: [PATCH] net/mlx5: fix the queue length checking
>
> In the new consecutive memory mode of Tx queues allocation, the needed
> WQ length is calculated via txq_calc_wqebb_cnt(). This function is used both
> in Verbs and Devx modes, but in the Devx queue creation, the actual length is
> re-calculated / adjusted for the Devx API. The queue parameters
> 'max_inline_data' and 'inlen_send' are used separately for the length
> calculation for different modes and the counts calculated are different as a
> result.
>
> So passing the mode as a bool input to adjust the calculation in different
> modes will solve the mismatch. In the meanwhile, since the memory and MR
> are allocated successfully before creating a SQ / CQ.
> So the error is not critical and a warning message is enough, the saved length
> can be used to create the queue.
>
> Fixes: d94177339289 ("net/mlx5: use consecutive memory for Tx queue
> creation")
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
next prev parent reply other threads:[~2025-07-09 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 4:00 Bing Zhao
2025-07-09 6:56 ` Slava Ovsiienko [this message]
2025-07-09 7:56 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR12MB85679726C7DDDF9D96AEF55DDF49A@MN6PR12MB8567.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).