From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA9A7A04B5; Wed, 2 Sep 2020 09:19:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 535EE1C07D; Wed, 2 Sep 2020 09:19:29 +0200 (CEST) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id 30609CF3 for ; Wed, 2 Sep 2020 09:19:27 +0200 (CEST) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 02 Sep 2020 00:17:18 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 02 Sep 2020 00:19:26 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 02 Sep 2020 00:19:26 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 2 Sep 2020 07:19:19 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.53) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 2 Sep 2020 07:19:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8ojTLdzI/+fg0CBKu/zrEVLTMS4kvY2tpRZ1Kc9CiYZwrKfOLewfbAe9pauxNqkw0mhbe0Tn30kBRu+ES2vSVWINvWqAgM1tkdCpLOyrECvix2vQ928wIyPFgZNaFJw7qHuvsDn7lT25DaqJRJXQcM7rkdioPgqgC9jvHwXRNSGkl+CODgAWcyQCdf3Wi7LZzCpfn9BjwYoHTPz+eFtx9BAjYOVM/MqL44jDwUtHIN+zXqByW2u212APVASlQVuUNebXheQdnOMMTwn6cBp7l8l+UvqRQerdd9fGQZ9Z9hQlSLbQsgvlOOMB5ZsGBdxLPI8F8LIgubIOga2b0fFjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CuWGSkVIEdLJw8B6kY89FUGekZmAveSdb6+7MI3irX4=; b=VZWPojQMZUXQrgrvRNL0VLlPgJfL1HvQqosobVEX5OCdir9FtMO3IX9TcrtqGa5k7TonILa9V2lL7eFx0Zicmis3WwwVAz8t/9iIhpo01x+9CVcDXkSVkSPouXxqLGKRIDKQltyK7sJjW8CDn1XnANgn/SkjS8ttG61pACj/J5igAJXuOAMmDychs1ga84G54IpTVRixhT4JEU09JhAcK4hIzRo/876Or6DF5COReoMf132ngEe5vMtiAXPS8OujwXR7w1+p2RVgIsyFKn3oT7YjdAEx1TA4v9Zqp68An9tL7cYC4O4d6RQaLZ1LH24Tu78FCd2zMunsTMkZLiONyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MW3PR12MB4570.namprd12.prod.outlook.com (2603:10b6:303:5f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Wed, 2 Sep 2020 07:19:17 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::693f:4ec4:caa9:ac9c]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::693f:4ec4:caa9:ac9c%5]) with mapi id 15.20.3326.025; Wed, 2 Sep 2020 07:19:17 +0000 From: Matan Azrad To: Chengchang Tang , "dev@dpdk.org" CC: "maryam.tahhan@intel.com" , "linuxarm@huawei.com" , "ferruh.yigit@intel.com" , "wenzhuo.lu@intel.com" , NBU-Contact-Thomas Monjalon , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure Thread-Index: AQHWfdRddMw/ykWHNkeaRKxv9sXGxqlT7AawgADRJ4CAADaIUA== Date: Wed, 2 Sep 2020 07:19:16 +0000 Message-ID: References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com> <1598685199-1630-1-git-send-email-tangchengchang@huawei.com> <1598685199-1630-2-git-send-email-tangchengchang@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.126.81.41] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88bc44ad-b497-4204-1fc9-08d84f1080b4 x-ms-traffictypediagnostic: MW3PR12MB4570: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +DORBnUjfrY/H4btpES3JZmVjQgcH6Hjmlc8GuuvEXoq9YyA651Bz/rshrKEm9gbwrKACbP3rvd9ksgnpi4gVwVwm/fBczubpQATLZjHlnSSv53B9uMIeX0coq5M/5yAn57Rw4Qiv+eJRNWv4AAs+UoEqFRSautidgAVPQsvxlywR49BTTr0rAcrSE08OerokZcqUEyK6MBSRXVsKkwAywU5cfyrx+lSV5fPpnDGPLR/NvawCidy3N6vnwjMZupdaAoEYgdWWS6/RuX2rgu7FdvewQ2sJJli0/0gq4ZzGxfV88h2IxsMl0n7nZD3SxacScAN6ZumcA6zBU3y8yZr+g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(2906002)(52536014)(5660300002)(8676002)(8936002)(86362001)(9686003)(55016002)(33656002)(4326008)(54906003)(110136005)(71200400001)(316002)(26005)(53546011)(186003)(6506007)(7696005)(76116006)(66946007)(478600001)(64756008)(66556008)(66476007)(83380400001)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DwXVhG6/YsQ1mLEzw8KR325TrnJqs9GDw8htKk33DISu8lwooJTlfqOopksxy5ah5Q+UXsxDJvr1+m/mBQjmP9ic1ftHFuMKvPyTvjCcS+pLirDbdnB8vmCOnLfAMFPzkFi8ZAqoZZqQ8V402aPsHRXcq2vtoUR48vPSQCT4ySa48TOWnztMUB3H/n0Ib6VYjMZVJztKkCutCxZXLzKgEorlMGc2DPMCYG/KlGsalr4IFaIF1nuOeQE6WkstcxR/9fx+gOuKYlcpqUuyHozslMn24DU8y3pO5x0rJKitOKphosNLsP62/czS7jJaujrTB5gr3jWFgjAbP87aFvRz6URjXxnDdLELbH1x4Ka50SgxdW70kQ7gqo7eU8SD/5Hp+++KhMRzMbmrOV4o5hLaIb9uvN4mEKX121tsh051AokXVFSEwASosNTJSCC8WtitBGbBZ7hmZsf+Qbgl9e/s7I1UjDC5IxNTZNqIs4pbGPFPG3FjeicOE3pAOCrZL99AqEX2yFndYQGUFEP1THtmYpIsi7LbBuMAnq8RjTwvYgv8TSTibqpujx65EOFkDXQISo+ty+LnzJLH6iyeRFcIS9hfqIR9tY6X7DAb2Mc96zTaCDXx+evBNXhRKo5ELG7tweo2Ee/2BV8t7uOE/RBdBQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88bc44ad-b497-4204-1fc9-08d84f1080b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 07:19:16.8525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dh8jKondLdzK0m2XHTka3OK0mSmE75qv3iWsKsYfM9OyniPt7+eEUgoMP1tYDWR9Q242Q7nafdH/X5hU9CNuqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4570 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1599031038; bh=CuWGSkVIEdLJw8B6kY89FUGekZmAveSdb6+7MI3irX4=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=OlDRMm5fHgzOJCSAvQItfXd0Ix0i663suTV6m+vzBraZ/an4FngBpM2t4VvxqZPtx EfzZ88MlGe/gMs7K8bk8N3M2van4ZzWE9O2rJm8SUazAHvWnNTFJdtHDT7mfEUCaBj KBG+z3MF2vNfxfH/OE5MO9+44bHVxMe5GJPef6L07eWQiO5LmVTyzJLAGWNBUm9DdP UGBFGdMIKNCmP8kKrFdCSB3EWkBj6XpnXvVQfCmm2wmUVj0T3pKtnYHxYVaDvXirM+ jd+5V8YOBU1iqWx04TYo2Es+Gi8Z38+Yli0vduaaBEVXbJKeLCxcWG0VVrTTffUNXg ap87yb15Lkc3g== Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add a field for rxq info structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chengchang From: Chengchang Tang > Hi, Matan >=20 > On 2020/9/1 23:33, Matan Azrad wrote: > > > > Hi Chengchang > > > > Please see some question below. > > > > From: Chengchang Tang > >> Add a field named rx_buf_size in rte_eth_rxq_info to indicate the > >> buffer size used in receiving packets for HW. > >> > >> In this way, upper-layer users can get this information by calling > >> rte_eth_rx_queue_info_get. > >> > >> Signed-off-by: Chengchang Tang > >> Reviewed-by: Wei Hu (Xavier) > >> Acked-by: Andrew Rybchenko > >> --- > >> lib/librte_ethdev/rte_ethdev.h | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/lib/librte_ethdev/rte_ethdev.h > >> b/lib/librte_ethdev/rte_ethdev.h index 70295d7..9fed5cb 100644 > >> --- a/lib/librte_ethdev/rte_ethdev.h > >> +++ b/lib/librte_ethdev/rte_ethdev.h > >> @@ -1420,6 +1420,8 @@ struct rte_eth_rxq_info { > >> struct rte_eth_rxconf conf; /**< queue config parameters. */ > >> uint8_t scattered_rx; /**< scattered packets RX supporte= d. */ > >> uint16_t nb_desc; /**< configured number of RXDs. */ > >> + /**< buffer size used for hardware when receive packets. */ > >> + uint16_t rx_buf_size; > > > > Is it the maximum supported Rx buffer by the HW? > > If yes, maybe max_rx_buf_size is better name? >=20 > No, it is the Rx buffer size currently used by HW. Doesn't it defined by the user? Using Rx queue mem-pool mbuf room size? And it may be different per Rx queue.... > IMHO, the structure rte_eth_rxq_info and associated query API are mainly > used to query HW configurations at runtime or after queue is > configured/setup. Therefore, the content of this structure should be the > current HW configuration. It looks me more like capabilities... The one which define the current configuration is the user by the configura= tion APIs(after reading the capabilities). I don't think we have here all the current configurations, so what is speci= al in this one? > > Maybe document that 0 means - no limitation by HW? >=20 > Yes, there is no need to fill this filed for HW that has no restrictions = on it. > I'll add it in v4. >=20 > > Must application read it in order to know if its datapath should handle > multi-segment buffers? >=20 > I think it's more appropriate to use scattered_rx to determine if multi- > segment buffers should be handled. >=20 > > > > Maybe it will be good to force application to configure scatter when th= is > field is valid and smaller than max_rx_pkt_len\max_lro.. (<=3D room size)= ... Can you explain more what is the issue you came to solve? > > > >> } __rte_cache_min_aligned; > >> > >> /** >=20