From: Matan Azrad <matan@nvidia.com>
To: Tal Shnaiderman <talshn@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
Asaf Penso <asafp@nvidia.com>, Wisam Monther <wisamm@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions
Date: Sun, 11 Apr 2021 13:00:32 +0000 [thread overview]
Message-ID: <MW2PR12MB249276CC55F845D7717DC6DADF719@MW2PR12MB2492.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210411122136.2560-1-talshn@nvidia.com>
From: Tal Shnaiderman
> Several functions introduced in the addition of the Windows support to
> mlx5 were missing the __rte_internal tag although being exported.
>
> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on
> Windows")
> Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/common/mlx5/linux/mlx5_common_os.h | 4 ++++
> drivers/common/mlx5/windows/mlx5_common_os.h | 6 ++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h
> b/drivers/common/mlx5/linux/mlx5_common_os.h
> index 63f070d9c4..d1c7e3dce0 100644
> --- a/drivers/common/mlx5/linux/mlx5_common_os.h
> +++ b/drivers/common/mlx5/linux/mlx5_common_os.h
> @@ -203,24 +203,28 @@ mlx5_os_get_devx_uar_page_id(void *uar) #endif }
>
> +__rte_internal
> static inline void *
> mlx5_os_alloc_pd(void *ctx)
> {
> return mlx5_glue->alloc_pd(ctx);
> }
>
> +__rte_internal
> static inline int
> mlx5_os_dealloc_pd(void *pd)
> {
> return mlx5_glue->dealloc_pd(pd);
> }
>
> +__rte_internal
> static inline void *
> mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access) {
> return mlx5_glue->devx_umem_reg(ctx, addr, size, access); }
>
> +__rte_internal
> static inline int
> mlx5_os_umem_dereg(void *pumem)
> {
> diff --git a/drivers/common/mlx5/windows/mlx5_common_os.h
> b/drivers/common/mlx5/windows/mlx5_common_os.h
> index e92533c4d3..3756e1959b 100644
> --- a/drivers/common/mlx5/windows/mlx5_common_os.h
> +++ b/drivers/common/mlx5/windows/mlx5_common_os.h
> @@ -248,11 +248,17 @@ mlx5_os_devx_subscribe_devx_event(void *eventc,
> return -ENOTSUP;
> }
>
> +__rte_internal
> void *mlx5_os_alloc_pd(void *ctx);
> +__rte_internal
> int mlx5_os_dealloc_pd(void *pd);
> +__rte_internal
> void *mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access);
> +__rte_internal
> int mlx5_os_umem_dereg(void *pumem);
> +__rte_internal
> int mlx5_os_reg_mr(void *pd,
> void *addr, size_t length, struct mlx5_pmd_mr *pmd_mr);
> +__rte_internal
> void mlx5_os_dereg_mr(struct mlx5_pmd_mr *pmd_mr); #endif /*
> RTE_PMD_MLX5_COMMON_OS_H_ */
> --
> 2.16.1.windows.4
next prev parent reply other threads:[~2021-04-11 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 12:21 Tal Shnaiderman
2021-04-11 13:00 ` Matan Azrad [this message]
2021-04-11 13:09 ` Wisam Monther
2021-04-12 11:25 ` Raslan Darawsheh
2021-04-12 12:26 ` Thomas Monjalon
2021-04-12 12:30 ` Raslan Darawsheh
2021-04-12 12:59 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-12 13:06 ` Thomas Monjalon
2021-04-12 13:35 ` Ferruh Yigit
2021-04-12 13:54 ` David Marchand
2021-04-12 15:00 ` Tal Shnaiderman
2021-04-12 15:12 ` Ferruh Yigit
2021-04-12 15:28 ` [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB249276CC55F845D7717DC6DADF719@MW2PR12MB2492.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
--cc=wisamm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).