From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81A62A0562; Sun, 11 Apr 2021 15:00:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F7381413EF; Sun, 11 Apr 2021 15:00:35 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2056.outbound.protection.outlook.com [40.107.244.56]) by mails.dpdk.org (Postfix) with ESMTP id 209FC1413EA; Sun, 11 Apr 2021 15:00:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNFPOBFk7CDzcd4+6/LIQiXK6OakS3E2zvbTpJL6g/W7E4rr3zMbAfEdNcDEbsL+I2WhcsFlqCC/+lC/fCIpRw5NRtvKG7TAVMmydO2sFKIG6Z24/h/Ds9LoCJuzJetEoc3Ve40v8T4s484pJX4pSJNQ7WH3/LfZtRv1CpennjCYn3QuIxwoPd50/TWpSEJTFus9usEJnC56Se+FIbpxgkwfGNq7XPYJ36nR4mWSQMwnJG0MRQJioH0v0kSP0P/JB6hp0tzcBbrAg8cJkMYP1Z9xMTah0W2ApCaz6+/KdlTXIhTQBW1xqWpyc/Xj2Zjbhz4/uraIIe6UyPuV5eTouQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2nZcSf8yxmyUMFJ27tMKKVdkTHsx3GGMycfC4eDtF0=; b=fejrDsP610BzWnlbNYm2fVg/SbrGDRQrcBP80JRO5U9sncl0Ng49xCcXRNqYB4zzwegWG55pT2C1KozXlUqkB0zWg3E2uKq9PwsGZsmu/K5kyHDj/e3eH7MGJA11+I6FZ3dYRA0dD4kZhRXKmJ5QABCf050brxn6pHWLERcI52gBSXksA8gRf+S9san6hWRfZH9i2mWiOe19iN/bRBBEjnmHRiDnaqMCx71Ao0wEOfqWZdJiY4j+SBXInop8/uZs754YndQ75kyr/xC+9nx3ZWys++tAqLW+04zy7ulMU5AbAPq4Fj+Bxe9RlB5UnKVhoShA5u1R5IakDg8Iwr6OPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c2nZcSf8yxmyUMFJ27tMKKVdkTHsx3GGMycfC4eDtF0=; b=aOF6mzjE7Void/K/7kXRfNUwlJfumzA7bCA2x3A3uCWkCHTkSXoP/2tKRu76uDEZlSh8XccHJ78lI6mk/gI6boePuoNffC03Jvb4AC6cG1+MXhn05ogdKxu5Df6ZbRRzfpWpa8V7fgRTUPo0oeXv8ax+ULqsEr4uWSFxB5bfMXvlcOl/fR6+C64Ptux1F2hRJ8itEKrv9VisIbHgPK5kkI0PgqxMmCgr5eeHVtv7B1f9ndKlDaditjALzy4gaMqvqDdkXO8/joI/FDAOkKJQhRsxd6/Hz5k4dWDZOg95+zcre0hxKLhGr3rthc3qlDfWKWriyYujnOa4p1sTKRjtnA== Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MW2PR12MB2490.namprd12.prod.outlook.com (2603:10b6:907:9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Sun, 11 Apr 2021 13:00:32 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90%7]) with mapi id 15.20.3999.032; Sun, 11 Apr 2021 13:00:32 +0000 From: Matan Azrad To: Tal Shnaiderman , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , Raslan Darawsheh , Asaf Penso , Wisam Monther , "stable@dpdk.org" Thread-Topic: [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions Thread-Index: AQHXLs1UGdrAfo3c3EiqVbbpZwaaFaqvR4Ig Date: Sun, 11 Apr 2021 13:00:32 +0000 Message-ID: References: <20210411122136.2560-1-talshn@nvidia.com> In-Reply-To: <20210411122136.2560-1-talshn@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [216.228.117.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5d00c5e-c2a4-4db8-b866-08d8fce9ca76 x-ms-traffictypediagnostic: MW2PR12MB2490: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:549; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iorXWbFE/eUDI7kODSGLZA7E6AVpUEkmpda5Kz8N8dTiBb9bu16llwPL1uztDG9cY7sWqglFiM+aGsDguJka/ev1FLIs16bZM4FpULyQYxRlTLLMzlnj9NpChZ1JxRd7M1e52jrzKzQpWLfF8/2qXNC7hsJZILanP9sLvQvnj8+CuDKUuHnJDnNN9vwvFteMrv/nbaSeLtoyJsVBvIJXhzkrQrtxRlV25pw5rVpqm20LhaaGVTht8WqZCwYA5jpnfNt9bGxoNP/d2RsBGZi02NgX3CNk0Qj6zZsuum/dvrNHFcYYlV5uAKyud5GJSjIyV8luJ9VtGDkCi0poCtCHfJo54JucEMXuCGbAnHn6Aysx8nuc+PDNNn9FFBSzr92vrhxuzVIrxYfAdRhY0510hlszrLsKc9aMTvYoV76zfcRxV+EbOhrFYbUmp/lbxNJzgDkZTAlaeZ/OS8mZq0V/aOH2RNDFqXxkUC5kqNjMBzJ5ZX4IkoUcGntaU9ecDl2Z+lnQaNr4eS+T966R6mzeaUdpZBTTZkhr8nwI8p6mnSjucAxW6NQbXziK1L0zIVWqoNsZMzCaaMa+VfF/24R18vLSg05SC9C6ByeqSw+no8U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(110136005)(316002)(83380400001)(478600001)(38100700002)(2906002)(54906003)(66476007)(186003)(86362001)(33656002)(71200400001)(8936002)(26005)(8676002)(7696005)(55016002)(4326008)(52536014)(6506007)(76116006)(9686003)(66556008)(66946007)(66446008)(5660300002)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?iNKN/RVbmezspqvxAY3izFWKZcEG0QxOeHYhl0UI85gFpoRoU3lTVrmDeRP7?= =?us-ascii?Q?tgrPVxx6sTWn611rXWYmIkqHGRtajXCg/33E1gq6oZJE5+JjJgyCSI6lNl3r?= =?us-ascii?Q?0GG6mR+hrSUvqq1nRIZTLMzcYA8hS8vRYE0+FSUJbgv6qlCa9XCnkVNNfP6d?= =?us-ascii?Q?Jrdv4a9Gv1Sb0UdKXXdZVlnoekModlKLiTvm4J5R+9m1bembSogILS+ghiBd?= =?us-ascii?Q?mlFOTMOzXJ1chZp8uq07SSKYcR2LeM6RPxYYXMeC2/iDUamWNiaaki413A3W?= =?us-ascii?Q?MMfmdTGMDJWSclOpLgbc/oOoebqr1bA4Ivh+PCz3LR+gcSeXb/1otkY4WBvB?= =?us-ascii?Q?jTTIaHlC+REBbpqqfZnyjduMXhRI+1Fh62VaCB3A7soSH8Okv7qlLN71RCuc?= =?us-ascii?Q?pp7Q8uyly1pWWocWXtbe5K6LCqx2xHyw4j1OpEqEM4/igilVqKyJAzpVjQvJ?= =?us-ascii?Q?q+MPFkvP02C1a3edydSpNPFI268Pg8mqUkEtsliaIY3NseuaDB809q6bMkAO?= =?us-ascii?Q?VN7T16cyCKr01To7z2IE/vd+pPuyMHg+j0UJ5+NMEiyQQo1/fBldkaeVrxqx?= =?us-ascii?Q?K7Ajy3vGm1Qj46rWLzjVKAtCFci9xwxXkemgfCVm8ilPNZS8Uj8mEKiJz5Po?= =?us-ascii?Q?xAD9VCW1vfx7PUQMtcvXkkS63FcBuKNcyQbj3XEmMdNAPOnyXANtVDzNvdn9?= =?us-ascii?Q?NhoRg2YNRTp75TtiEohzXi9oHPoWuKZ/1iD+lY0Ftr1iZzNcdrEoFxHoRJO3?= =?us-ascii?Q?2mWT9WUtdJCxbv8y9UuzlCKADjtk25G34FeXECz53x/XRvRVSDPpT3+jRXkE?= =?us-ascii?Q?YHEEBYX0Ml13KJ4jHei+P9JP0wqFXmtc2WbhY4hpwws2ekxfGVRiVU/kMM6p?= =?us-ascii?Q?nwxZT4AAPDL+JobtM4bOV4FSolziBx6aJc7mVLKQkIKHQPAoQjnCxD3UQ0p7?= =?us-ascii?Q?cuezEdOBqteNU4szgJK1PjslzbuB5pm8Bw2eBLxtwG4LiSxYneSb9SsW2rkH?= =?us-ascii?Q?aw5bftItVALXTQM2JJut4MeKx2cP8lnWt3llIpl7K/+i9spRp7c+xKbfTVLA?= =?us-ascii?Q?/L3CY9D8wuVSoD2jCH5MQbg6U3prEhBEhhdE/90GjMgciTPWcUeUqmWn4ajl?= =?us-ascii?Q?RG9gRgJ0/WRT+EYzwJDMcq8NU7rIMtxoX9/s64bsaAVY5mkICL+4YzQOTDQF?= =?us-ascii?Q?x4RtOEkZxJ8DlSkQiGXutthrY/PNL7n5q0VSR6ZcEZ6UHHi/7n/AkJMm6Fpt?= =?us-ascii?Q?txRSgjIkXwpvnd8LYFdg/l+2fUJW5iOjFWh68VkuhXh9U49wdOlv696axbsv?= =?us-ascii?Q?p+101W63N30DIgZS6J0Wev0N?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5d00c5e-c2a4-4db8-b866-08d8fce9ca76 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2021 13:00:32.5543 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oDmMJ2B5oUdaDg2lEmcDQo8iALcMmfq2JJtsplwZSQdVphdH2HlZqSriffSdrJiPjINSyLTLrGqNAlIOYv0eHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2490 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Tal Shnaiderman > Several functions introduced in the addition of the Windows support to > mlx5 were missing the __rte_internal tag although being exported. >=20 > Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") > Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on > Windows") > Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows") > Cc: stable@dpdk.org >=20 > Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad > --- > drivers/common/mlx5/linux/mlx5_common_os.h | 4 ++++ > drivers/common/mlx5/windows/mlx5_common_os.h | 6 ++++++ > 2 files changed, 10 insertions(+) >=20 > diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h > b/drivers/common/mlx5/linux/mlx5_common_os.h > index 63f070d9c4..d1c7e3dce0 100644 > --- a/drivers/common/mlx5/linux/mlx5_common_os.h > +++ b/drivers/common/mlx5/linux/mlx5_common_os.h > @@ -203,24 +203,28 @@ mlx5_os_get_devx_uar_page_id(void *uar) #endif } >=20 > +__rte_internal > static inline void * > mlx5_os_alloc_pd(void *ctx) > { > return mlx5_glue->alloc_pd(ctx); > } >=20 > +__rte_internal > static inline int > mlx5_os_dealloc_pd(void *pd) > { > return mlx5_glue->dealloc_pd(pd); > } >=20 > +__rte_internal > static inline void * > mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access) { > return mlx5_glue->devx_umem_reg(ctx, addr, size, access); } >=20 > +__rte_internal > static inline int > mlx5_os_umem_dereg(void *pumem) > { > diff --git a/drivers/common/mlx5/windows/mlx5_common_os.h > b/drivers/common/mlx5/windows/mlx5_common_os.h > index e92533c4d3..3756e1959b 100644 > --- a/drivers/common/mlx5/windows/mlx5_common_os.h > +++ b/drivers/common/mlx5/windows/mlx5_common_os.h > @@ -248,11 +248,17 @@ mlx5_os_devx_subscribe_devx_event(void *eventc, > return -ENOTSUP; > } >=20 > +__rte_internal > void *mlx5_os_alloc_pd(void *ctx); > +__rte_internal > int mlx5_os_dealloc_pd(void *pd); > +__rte_internal > void *mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t acce= ss); > +__rte_internal > int mlx5_os_umem_dereg(void *pumem); > +__rte_internal > int mlx5_os_reg_mr(void *pd, > void *addr, size_t length, struct mlx5_pmd_mr *pmd_mr); > +__rte_internal > void mlx5_os_dereg_mr(struct mlx5_pmd_mr *pmd_mr); #endif /* > RTE_PMD_MLX5_COMMON_OS_H_ */ > -- > 2.16.1.windows.4