From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6216FA04DD; Wed, 21 Oct 2020 16:23:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86438AA16; Wed, 21 Oct 2020 16:23:02 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id E05A8A9DB for ; Wed, 21 Oct 2020 16:23:00 +0200 (CEST) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 21 Oct 2020 22:22:58 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 21 Oct 2020 14:22:58 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 21 Oct 2020 14:22:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGebRvgmUw+2H9i4uGpzZrtihR+wMhnHOwnhsb39Kt95r2wg/9nrbe7tJgK46VuNy7FS4coUoyWjSKxCTNZnYMv4C1spFlfYslXc32qOxr8WGj6rSeuv1EHKoVNWDSZoti6LdJ1vUWlWEb7pJl71RRsePJtj0e4kxZfnuJZXo7O/dm84Uga6pL5NTItT646KWDvDErulAhobZs42E48DZx75PJ10QKZiFGwdNtigvZraUsdsw85X18a1DyXc61ySEPxMajxvHffuGn5aPk6ZeF0SeLCEJW5vJnlpxLYPKiDPfrEFtEnvC5jC+p7kBBSbcOhUkPlxYffIXjte1dmGvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qMTfhkwT7+51bGp735Q5a1dV6o8kytc2KzjS3Y91XBM=; b=PEdefykkFwg0jT9fM5NOUewXTUrcWOcVSrCzUJzfgqP4x/VpFuqJD1J4fch2wruSPRa3vaUuXpvpNbA5oPnbbRwCt/UTulU4MQa+goEBdYp7uEUuRlkOHw/7GXIe6pjHGK5A0240W8DfAQCQ1j7WJCmG86y8kRDmtEPxuWhOVOUtLR1Y20/zjbAb+0XiHgHP2vCYgKD7sbAG3xG7luYnyNZyJaEhsEG4KBOxCinBXb75KCjsGl/5zQ2B/u03fXwidhY4DWt71oloR+GWZcCl9awkp46cwyhI45Q4yPwwxVYyiSoDTe7bY0zpglZjBYAbsfrefy7yKL8kcMb+j5Gi7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MW2PR12MB2491.namprd12.prod.outlook.com (2603:10b6:907:f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 21 Oct 2020 14:22:55 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::39f3:2b4b:6018:4b88]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::39f3:2b4b:6018:4b88%7]) with mapi id 15.20.3477.029; Wed, 21 Oct 2020 14:22:55 +0000 From: Matan Azrad To: Eli Britstein , "dev@dpdk.org" CC: Dekel Peled , Ori Kam , Eli Britstein Thread-Topic: [dpdk-dev] [PATCH V2 1/1] net/mlx5: fix IPv6 next proto validation Thread-Index: AQHWpuPfKahBWrGON0KEv+m0t26pzqmiHTRg Date: Wed, 21 Oct 2020 14:22:55 +0000 Message-ID: References: <20201020131913.19755-1-elibr@nvidia.com> In-Reply-To: <20201020131913.19755-1-elibr@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.126.110.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c3af9d7-3561-47b0-d9bf-08d875cccdc1 x-ms-traffictypediagnostic: MW2PR12MB2491: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yc22VvkgUfdb3lRafMAnrKxNDQuiXS5Yy5DGcRTxt2RuiC2V/5N38gLYQFeqTdfbnCMQx4f3KEzlAWX3gUUVzmtEY+ktRCVUceklUqWenO1vzFldNHCuRbE01WH1WAZYGhLOMFSL8M3WpaLM9cwrTDQhBsuK2sUSBI9liKXUPyRcX3Dt1byRP1yV7W9MbKdDjKmFEzzZNh3D2VchnNXNh2WbOdniz/uOXFG5Lc58JDwXEALAbspLxtxJjqtZctw035TcSGyVJ0LkdEvVJtuXiCU8J6shGn5MpYc3S9x+z8F1GeF8BVHePBKHrZG6DK6Q x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(186003)(8936002)(478600001)(26005)(4326008)(107886003)(8676002)(71200400001)(66946007)(66476007)(5660300002)(52536014)(66446008)(64756008)(66556008)(76116006)(86362001)(33656002)(7696005)(55016002)(6506007)(83380400001)(2906002)(54906003)(316002)(9686003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Ac3Bk8Lj4K7cvMSxLY2usrmC+lObcr+Q0+DXXaKs3bSpeeEx+uuTVD70JnkU2iM/Lw7kh5hXkF6bOdTWQNb3HWjgwoFc/WFmZKi1Sf2Kk85Uw+Qpcqnd8JMmClOhxzJ7Z7lfD1nX3I5EquRI9o2YxKVWRwivEeHkT8MfU6i9WKD9zO/KYbpP/ZCzH7UjTdnveFU7eGgDRxJZ/SRvg7U7p8FjoslN/CSiyO9Jkuvg2Jqgb5WzWK3eFSySwp67sH7w5l45mqxGpACCS7d8AVqSvOHxRVVTYwexWpjVoeVKwcQjEP6FDeiQTAFn+m+HRhm1cV1DhhFCGXUj+O3YNZD2jKvc+uLGc0WIv8iKwU0KrXmdQfRDmcwCj4MRvQFuHWTYizFwOLsB3I+kZslNvD6AwWv5ormOh8cgoIcrv++HGhvWYXaq9ZNcVq8W2+76HW4+y99wo8M9Qpdcajf64UebnMUDOkQDqX5wcBoZR1m9nM8iGvrlnWShXgVtbZ72wnnelYcisafMlc0282v3Q0tPTZ2HsQD+1ifAUuT0NaDb8x7ssy2RjvojAFg8TcQ0/p/dejQBIqMEZNpf6a4WngKzqmT+fKHouXx+JQf/Kd2NwoepSTd4fZc0iNbKzJdoQ/vNWmaoTcv4BtaOMN2ighuLeA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c3af9d7-3561-47b0-d9bf-08d875cccdc1 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2020 14:22:55.5988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1exeIp90OdkLUc20jV+RW/RCqUKwHO/SD5mEocGwu8qEcbh6/b4j+eSoA5Z2Ym0jFU6AtlqFokubrOGE7Rg1BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2491 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603290178; bh=qMTfhkwT7+51bGp735Q5a1dV6o8kytc2KzjS3Y91XBM=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=PC2bkzI8IXLihqKI74P7+k3DK2UyxTVGb5w3w/RjAKMWEfru5hMdVl/PRcruwzfPL iE0mATwncjLixogkg4HyMZZBVt4XGDBbyVmEyr5TK8U1R7z/RlzkAvTxV1woHkZJZ1 DDay7ZT1tcmnLYjYETikkoAYIOT0erRIuagGoTzXh6b/8a7NUhiA3h3DvE80GrY0hM WfEU/cbVZ5yMz2F7dW/8zfM6SbWdWowS0wsSSM1KUL15+LHu6OxJNGUz0yoiDWwoMB FiB5tmOige/WrBAg0+iN6Pc7FMQ1KX09mE8fTMcv7qDFcdqgM0hve5CIwFfmk94EbB h8iJyGEzKnquA== Subject: Re: [dpdk-dev] [PATCH V2 1/1] net/mlx5: fix IPv6 next proto validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Eli Britstein > Previous patch added validation of the IPv6 next proto field, in order to > overcome a known limitation. > One of the values checked is IPPROTO_HOPOPTS, which is defined as 0. > If proto field is not specified for matching, or mask=3D0, as in the foll= owing, a > wrong validation takes place. > flow create 0 ingress pattern eth / ipv6 has_frag_ext is 0 / end actions = drop / > end Fix the validation only on proto asked by the user. >=20 > Fixes: 55e4c1d1ba73 ("net/mlx5: enforce limitation on IPv6 next proto") >=20 > Signed-off-by: Eli Britstein > Acked-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index c56dac89f9..e0ca8e06b1 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1977,7 +1977,7 @@ mlx5_flow_validate_item_ipv6(const struct > rte_flow_item *item, > RTE_FLOW_ERROR_TYPE_ITEM, > item, > "IPv6 cannot follow L2/VLAN layer " > "which ether type is not IPv6"); > - if (mask && spec) > + if (mask && mask->hdr.proto && spec) If you want to be sure os specific proto only you need to check mask->hdr.p= roto=3D=3D0xFF, no? > next_proto =3D mask->hdr.proto & spec->hdr.proto; > if (item_flags & MLX5_FLOW_LAYER_IPV6_ENCAP) { > if (next_proto =3D=3D IPPROTO_IPIP || next_proto =3D=3D > IPPROTO_IPV6) > -- > 2.28.0.546.g385c171