From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E007A0579; Thu, 8 Apr 2021 11:36:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9F6240698; Thu, 8 Apr 2021 11:36:47 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2086.outbound.protection.outlook.com [40.107.223.86]) by mails.dpdk.org (Postfix) with ESMTP id 2851040138; Thu, 8 Apr 2021 11:36:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OtlUG1xEoYNz8P33GyeUcHdMc+mSfr/Ti4dTg3aAueHWpB1WFjdDDJ+OZJjEz5g/MYdGPDOIqYXLyRoVhhuoASvWDbQGS1BKMn00dEQ9PBicm0RX0+GN8TKMqyHwz+qduhfsCPLgogA0RwOt4zOXXcFQJD9uIak40bNv80MXo7eHLaQcRMLlF/ghMdNRCYoxKYSmIf7ySQqy99ybaa7yFnrV2+Uz1ZCTO7WzYo4RWAawjjcj/zWuSvc3hEiaaybe2VWzWtiXA3bgZb97lHpjO3jZnS/TpALSB+d2BWdZro3yv10y6MZQAJd8zNo0UJXPxf72v+rG0CA/lUMpU6R0hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2aUXwGklVegYmpnQfNuULUrUKYcVUymR1vFLW03Yf1s=; b=X94dhzlVVAdUkQHhSGg42phGzKYbt0vIKULg9mlzgTuVXrWJaMQ1AUMQPN2aUxBdcEnyG6/kUb3VDK6jfZupY5xwNplfdJYREQbcRoIdI3nhIqEBmBe7vuGCGViX1RoT1ViKQ2iPoPL9aKDaoAL4FQ7IMUWrKOVbcs1k4IODofdQgK43pCa2iBye+BaOGPXIbcbreX3qCwYNSByjSmgHCajn+VVo5AWSR8iDaqfjo6FUyA0ijuVYaBzrvf0dO2pqYS4tqGD8YQOk3kpy5DQV/rBORkKPubyYVxC3xVAZXCYQdQ2KN3tszUeFAA/Ty9avtTovLQaGhwh8Pppu6XKm2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2aUXwGklVegYmpnQfNuULUrUKYcVUymR1vFLW03Yf1s=; b=oa3AzqkGn5DfsKBIWd2hYh9eB8wOCu8WjuZycE84a9LQSAvG5BQpTyi9nPQ1jpZOZ+AyHquRwrpQb7lJXipoTGb1ilyLoNkHtN4vCtawhttx9/pLaS17nq7og8mWb8JsstXLchAmrmmwVdhqkcRWHzfMqoh1G5w+Xvk3CU9AQT/dFl2mUVZDLP0fEXrS1ad4tyPFkXJ1lzcPgvYEM0B+OvF9PZjJATsmj7VLaFD5JXa1YmISEfXInTWHZVhpt+oG6E33ghL12IIgz8j2Tmi1bFJmVG2FQ496kh2FruNUL0pG7wAQIRVqMRi5HL/JrzbaT+NVjwRD/w7TDx23MDcesA== Received: from MW2PR12MB2492.namprd12.prod.outlook.com (2603:10b6:907:8::19) by MWHPR1201MB2509.namprd12.prod.outlook.com (2603:10b6:300:e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Thu, 8 Apr 2021 09:36:44 +0000 Received: from MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90]) by MW2PR12MB2492.namprd12.prod.outlook.com ([fe80::997d:63f4:b22c:8d90%7]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 09:36:44 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: Raslan Darawsheh , Ori Kam , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx4: fix RSS action hash key null pointer Thread-Index: AQHXK8LvJUH8ZF4chUiSKkzeiRzP36qqXbyg Date: Thu, 8 Apr 2021 09:36:44 +0000 Message-ID: References: <20210407153015.32035-1-viacheslavo@nvidia.com> In-Reply-To: <20210407153015.32035-1-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [216.228.117.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b382ac94-d465-4dcf-62a5-08d8fa71d2b2 x-ms-traffictypediagnostic: MWHPR1201MB2509: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uGNyjqI74/4FwW+FkvMzLO7K0yIHxtT7fhJWsfT47owyhA+T3zO9foQ84hrnQJTGcspGEECkAIiJ5SHjVxpH2JozeKEz0B1xx4eSEnzQ5YqtcOCYBwWOR+ezInxeNWurS2e8YzSByiG1r5RfyrLy5sHRmZaAFGRw4E8EcQRZ/bpC9+iuUoU2nriYj/bASPCEJS/1wbIpH/2ZDOvtEguYiw80nQldXMuuNNtL/oHepFCSNYcmsOSo4iqQvGIs5+duM0O8ukdmtn+HG7iQuWCiSRkyrtQM0jrZ9E1lSS6eGUVimMs27pt4ldRpGuVUPOr1jXRQGBhg4dQLuEDdrzeeqTk4RXsXzHMNsJQD9ztIfEBzHvO6B94/CPd9bwbyFcz+zXvXByu4tCqAsDNIpwhn56fxf+3j5fDUMTKN40tapSQ+SD9DzLjcfmtBqEkt4LaCErAzXqKe66QYq+H4BtY/pSq7Q3UPhPboG4AwRO0QOsYTt4/9Si35CjXxWvdvIOKwZkp74Oyp8+y9OrEIpOWFNJX8hYXvD7of40F9ZJH+rCAhfUvLhjBxfN/ALHQItnUlnTyt6TK9zbTynooVeApKCzJciUDo4Gw4fH8duV3OoReGFGKDYadn+pS42siUwJCDBKlTSrtkWz67yOrK/BFvEyk1YJQJ6txqCV+rLYfre0M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2492.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(8676002)(83380400001)(33656002)(76116006)(66446008)(66476007)(66946007)(66556008)(64756008)(9686003)(2906002)(55016002)(38100700001)(52536014)(26005)(6506007)(4744005)(110136005)(86362001)(4326008)(316002)(54906003)(186003)(8936002)(71200400001)(478600001)(450100002)(5660300002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?m8VkoOOdfwG1zGIStwKvnvclKkoYPYHopPyqUfAVANiLjORD+e5rXtC6iz6H?= =?us-ascii?Q?6RKl6gVU4DuU7iUPL+y0rkCANTyt1V8D/SDfT6YSDQ2RMFla+j225JrEkWx2?= =?us-ascii?Q?1AAHJrY/B5RsDiw0WREIU2/9XCk8UCAAgIlOs3TspUyEianhxkl/wE895RBL?= =?us-ascii?Q?Qvs73p3INaQrlVljujkxD5yYGEGFEwGMIrJRdM7VXEmUOL8Dbjbnr4a2pQGf?= =?us-ascii?Q?yS9oEH4kKz9je38ooIn6584TRTEjYXFX59TDvNjxBqX6wEuWqaqbYl4oJDi9?= =?us-ascii?Q?pJidjCDzpBuNYkd+Qrk7f6ijjxifwPTPDJA/e7JlQSUzzewSUqLsoGNjQbZ6?= =?us-ascii?Q?Xf4kp0LQTmsGKoHMn3zhDFwDINej5aYOEc/LVyoBf3YQ5u/4UUtDTmGyNKn8?= =?us-ascii?Q?bOZF81gE6uj2IQ1TSI4eZS7pHxDVxgIBtnJBRguDz1rESMSFEjq3pwZdPwEe?= =?us-ascii?Q?sxjVfPsCWCocf4jTbXTh3T6oUIhW9g2GgZY15jswY0AJawJ9sLInrkn084ur?= =?us-ascii?Q?b6Rxld4zxWZyTIipHwTRFpk//GLJV4PlKWHmzpDgseO4kRrmOF5KzGxJGIlP?= =?us-ascii?Q?SkwvHLoqAxutvReuf6gmiVl+YqdIuDBUHn5cfFX1f0uv+cY4YiM6sN5WZWFw?= =?us-ascii?Q?alVWZOptOvsjwzZ/5KQCFV85b4WIalUibJCAWhT2M8ddoRNEWkzsxQgGeB23?= =?us-ascii?Q?+Bg1SXWO1lv+rNLkclt5LbrPyyI29lD6oRCFzgFIC6sNLG776WJBDhxFFYpJ?= =?us-ascii?Q?o9+dhjyTYBW7oTbK0++wl64aZpK9NRAB/lWbqXmhjl5GRqXPWqWpUzhX/M2I?= =?us-ascii?Q?baHK/5o2uImadu39hv13rWWl0UjD6S9+JZqNd8TleqAWXqMHDQ7wv4Y3tT74?= =?us-ascii?Q?a9rAikYuqsLBd1XswsdXvevZm92R2PLci4l3yxAhNXuaOQj2dlHYMCW1AHaD?= =?us-ascii?Q?FXO0OHI19QRQaAbJZ/twLdT0lOTP9pDaamsJQcN0M2L/9JIH+C4BJxRIUosz?= =?us-ascii?Q?2HnOaUvhqmrgHC7USGCy8GpAIjA50PBtfuACjZMYqbR/XAY7CfTwIgydQto9?= =?us-ascii?Q?oy5U1SHzhNrSpaEqL2n4BcKKSjBJxCYaXkZCtPSPvNI+ajBKE5q3oUhQy4rf?= =?us-ascii?Q?VqjLnJBACigIgjlBPN7riSmDRQpwF2wcqO3mZSXOZw9Sgc6U5uudMiXi2je1?= =?us-ascii?Q?2h5k1bYEY4z8Byfkoff7qGkASVx4hpulX6rp6NsS0dODuySAyq5nQbCRWvH4?= =?us-ascii?Q?M9EY8Swh2M33luLv1gB50Gdq6B3Yoye5pOFa6K9ook902/oDTTgXmcq2k2aK?= =?us-ascii?Q?GST3hNq+OkQ73KwiuzVKwbV2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2492.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b382ac94-d465-4dcf-62a5-08d8fa71d2b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 09:36:44.4410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: flukArbThmeuR38808x+AapgoLmgrxGY3Hcz66Sg44QW+FHYGbzo5qpIGDaLcmq4yMaWvw+0DIrrwJVQOtvPhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2509 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko=20 > If RSS action contains non zero hash key length and NULL key buffer point= er the > default hash key should be used. > The check for the NULL pointer this was missing in the mlx4 PMD causing > crash, for example, in testpmd with command: >=20 > flow validate 0 ingress group 0 > pattern eth / ipv4 / end > actions rss queues 0 end key_len 40 / end >=20 > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad