DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation
@ 2021-04-05 16:18 Tal Shnaiderman
  2021-04-05 19:01 ` Thomas Monjalon
  2021-04-06  7:31 ` [dpdk-dev] [PATCH v2] net/mlx5: fix link speed calculation on Windows Tal Shnaiderman
  0 siblings, 2 replies; 6+ messages in thread
From: Tal Shnaiderman @ 2021-04-05 16:18 UTC (permalink / raw)
  To: dev; +Cc: thomas, matan, rasland, ophirmu, stable

In Windows DevX returns the value of the current link speed
in bps rate, the conversion to the Mbps rate expected by DPDK
is incorrect and fixed.

Fixes: 6fbd73709ee4be32 ("net/mlx5: support link update on Windows")
Cc: stable@dpdk.org

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
 drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/windows/mlx5_ethdev_os.c b/drivers/net/mlx5/windows/mlx5_ethdev_os.c
index 8609d38eca..c709dd19be 100644
--- a/drivers/net/mlx5/windows/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/windows/mlx5_ethdev_os.c
@@ -254,7 +254,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 	}
 	priv = dev->data->dev_private;
 	context_obj = (mlx5_context_st *)priv->sh->ctx;
-	dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1024 * 1024);
+	dev_link.link_speed = context_obj->mlx5_dev.link_speed / (1000 * 1000);
 	dev_link.link_status =
 	      (context_obj->mlx5_dev.link_state == 1 && !mlx5_is_removed(dev))
 	      ? 1 : 0;
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-08 10:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 16:18 [dpdk-dev] [PATCH] net/mlx5/windows: fix link speed calculation Tal Shnaiderman
2021-04-05 19:01 ` Thomas Monjalon
2021-04-06  7:02   ` Tal Shnaiderman
2021-04-06  7:31 ` [dpdk-dev] [PATCH v2] net/mlx5: fix link speed calculation on Windows Tal Shnaiderman
2021-04-06  7:46   ` Matan Azrad
2021-04-08 10:59   ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).