From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81B99A0352; Tue, 25 Jan 2022 17:21:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E58F5426F9; Tue, 25 Jan 2022 17:21:36 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2047.outbound.protection.outlook.com [40.107.236.47]) by mails.dpdk.org (Postfix) with ESMTP id B568B426E4 for ; Tue, 25 Jan 2022 17:21:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XNi/6bwsATqGCzy+uhjmk9nhDIQwmT+0NXt+HsWqhnbd9b0vxtmWWwSMpNbJJi7emYYSyW/phMg8O/U6+zdYmIz/C2YJKXB6R0+esdgcHpeRK0IhFMYnO8nmPtjxB3rjOe5fo6YoFVP1aTWLN/2xVKJRQeyFKdjoOtuFdtYIwP6B78tmFBqsE/9y+fv0Vt9ldCJBn4IhmSGpGijvCpwPq5AxUVIyiki5fg49kUxp2a9VSY/9JjqvksU5nHm/MFscRD6WiGDH2dl3v1JCFf3YGM7Wp2WgEwiWvkPK+C4iovsMxzJzzyeodfOfRwxb9ya6gEqHeeYb29yY859exiCbfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=26Kn5re4FLi2Gq9Ra0v5xaJYprzJUL4dK+PcjrLNzf0=; b=mgBhUje7ln7i8DSTW47tUhvCwHkbP8iilLFBzWv1g+jZKiPxUq9ojONAtVDncJ88iH7S4v9cwM2sr+h0ON6UG28j7vSWc71Ud0UIowwMtU6Rd2OIw4wV8pUBHt8GgO+vzIRt6EBIH+1nIMNo+hbDwsUKxR8yYy52b6wMxWtyKigJNYVgh1r1RiqIDCBwcgq1860NW5f976rGpJ1HDbpzeVl3Grgz0TdlfrBTgjHNYhhlR0s7qdvTtkGDh+zziu7pC7rJ46jvV9yVgon5ai/u4LuJi+9ZDAUdLJQ+h/EbB07qbpA77WCij8RQe9xjzybKZTSODhBWo34s9JzSsCRJSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=26Kn5re4FLi2Gq9Ra0v5xaJYprzJUL4dK+PcjrLNzf0=; b=kOo15zndWU3o/do/GsJkKfRGVJW16HTodVmKkmf35kd4ZLYC5Z8y0ZOfZHwZIiTPBChTEcjncUG6YuxqEnP/vZLxWASFaBCFlfa/SBy42DxWhMWfE+Hv+ycDCUUG7nEMfdOsOEMi7Bt/ORxLpCUyU7SP5LQYiVOqFAaAl8hVNgQ= Received: from MW2PR12MB2538.namprd12.prod.outlook.com (2603:10b6:907:5::14) by DM6PR12MB3225.namprd12.prod.outlook.com (2603:10b6:5:188::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Tue, 25 Jan 2022 16:21:30 +0000 Received: from MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a]) by MW2PR12MB2538.namprd12.prod.outlook.com ([fe80::ad98:6ba4:7d63:fd6a%4]) with mapi id 15.20.4909.017; Tue, 25 Jan 2022 16:21:30 +0000 From: "Namburu, Chandu-babu" To: "Sebastian, Selwin" , "dev@dpdk.org" , Ferruh Yigit Subject: RE: [PATCH v2 6/6] net/axgbe: alter the port speed bit range Thread-Topic: [PATCH v2 6/6] net/axgbe: alter the port speed bit range Thread-Index: AQHYEeXmppg09N94kk6kHULFnQ9nj6xz6yNQ Date: Tue, 25 Jan 2022 16:21:30 +0000 Message-ID: References: <20220125121747.344631-1-ssebasti@amd.com> <20220125121747.344631-7-ssebasti@amd.com> In-Reply-To: <20220125121747.344631-7-ssebasti@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-01-25T16:20:35Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=018c0aec-ce11-4793-af5c-c904eaa9e1ae; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_enabled: true msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_setdate: 2022-01-25T16:21:27Z msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_method: Privileged msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_name: Public-AIP 2.0 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_actionid: c071b8db-87a1-4469-bf6b-f61a68b2ffd7 msip_label_d4243a53-6221-4f75-8154-e4b33a5707a1_contentbits: 0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ee2025c-7b0c-4979-854a-08d9e01ebebf x-ms-traffictypediagnostic: DM6PR12MB3225:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ignlYVLsyYXeEDD0xGEwGMXCwtuwyyO77FbPZK8P+CnJ8zRgX0F4O+2RWUFfmV+R/KHQjAqr4jtVIMlWrqgbp54j+bPthwdjdIzhZXX5dRhxfIsgxfNOpARcXrZW7irTQZOfOjaljrfVmD2lRNzI2z30t3iIxsRuAED009Asvbrw60JkWe789HM/bMqwai9GwC1l9zSyuiQZ9xhdMVVwY6/4cWy3rcxqXBi6sy6BYVOrSEOX/Xbypsjvpau0+hBI6UPqYdGQXKtx+Ob5FheC9lEajGtlFCPaBlCi8rv60E+cVBkv5iHzX67xUzcpP5VI6l7BT/nK9UrP8YAvy4WAwC/q2drPbVsGLgMPBIzUzzQM9p6GtTjSJvORnxHgTLXfCm/cFmKwHsLObWAayyL9gImTTGqv2t7U+6AYUynqOWpoiKEtnh0qsBD7KzIFL/eago3z8mT4gmo82YP4Tj50xNmkZnDEso/6jm/YUASoyNxySjnRQxs/1p5T+a+9ZvUNKVxznh2HCXBEUBsYw+4oyiGgm1uNwsK3YFHLw9Ik9guqylS47S90KouvKrEae+iRQniml1eU3aAtcgmVRF16b9QnJlwpIfvoia4zBzYYhfQh/bEdtHRoh6FDx/maNuG1b8V3l27WkvEUJJs8osglcqJHGfCujM/6FEtnKeg5V444G3XORX2MEPHLOb4SoClhxLas7zspGVmJ5XBQUaVPFw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB2538.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(66446008)(316002)(9686003)(66476007)(64756008)(55016003)(8936002)(6506007)(38070700005)(83380400001)(7696005)(186003)(8676002)(76116006)(110136005)(52536014)(86362001)(26005)(122000001)(508600001)(53546011)(5660300002)(2906002)(66946007)(66556008)(71200400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ooXYBgldSoYCblQ4yKGacb1/Ef7diRzbzQeu/UQNGGjRtzo/TcwfHpM8ZBoW?= =?us-ascii?Q?rWlG8eUSv3Q7AmklioCkZX2gxFEbuvAl/3kLfUDVsisTIZCa5LWQQAuOPxB2?= =?us-ascii?Q?jzT96jTV5zcLzvsIrkOrUuon6ULAcpEX5/fDnGhCAdqzOA4D3tTz9Hs+S6pi?= =?us-ascii?Q?7GvoMa7Y4KaBZJCWqQadd2ufq+WeczVFm7eNEf1Cd8hYM4RlAxVZPysfPFCo?= =?us-ascii?Q?srimubJ2YSvA8BwOfZCt1Lq+8BLabgtODq4cUvHQCPy6yh97AFPq6SyX905Q?= =?us-ascii?Q?jxQLgXWWYdM3DgF3xPy+nVaSAJ31uL38eJJkfd1z6Q0TYc6VHzwd7SkMwmIK?= =?us-ascii?Q?OFoufbI87NAB1eaKqQpuYlaOp1EVwoXTCN7NdXowrU05GzK9Bs1zdP4m0BfL?= =?us-ascii?Q?gyCMZysDnQoRiDkEhy75lc2zQ6XdUpFD6+ncPZhnmazA2V4Je09gG3dgyaSB?= =?us-ascii?Q?IIdaBtGjuHYOzbC49yG5Iz09tH6TcEW3ubGSUiJdXeqBLXvMce6L3aDupzYm?= =?us-ascii?Q?aNhGooxjND/qzVnrRlHxGP3opPGXAIUPBmJ4NQ+FwEe0fIf+bzu7nq1HNUaP?= =?us-ascii?Q?ms0qwmC1ERud2c5mCXJ7xDpeVWbOL5GM219l78/sNRVDKHviaa40BML87LWe?= =?us-ascii?Q?pxPSQ6krwJwLAjlyLDlfUfy6O1pyrj+5bThAiQJo1XNZhHOWrIJEWLulGY/Z?= =?us-ascii?Q?adkERNDyQb0yTmDRH9jgngDRTK5YAQMsb1aVQ6sPccrfGs6ZJ4xgqRcxPoJa?= =?us-ascii?Q?MosyXzxkAfTDJ+HL133nh2z2hoHyk7R7EC/fXV1+/KuAjlNE0q8rbMB7BflX?= =?us-ascii?Q?gphwC/ImqTtSVuDTH4qjyZeuVVJ51uUSu092X9rLAMu2KP99sGMqLduB5TK2?= =?us-ascii?Q?s+WVTaInGaT7CmAxwgPyOdK8emeSJrd99CUvJhZ9fcCflnqWP1OjNB9pbXSZ?= =?us-ascii?Q?JCw58DNJ4Obx+0Afz6BEkTogj9LiCUe1Oo0hAEat4lvuYs7cp279u655JIoI?= =?us-ascii?Q?u08Nb0hbBMetjlHBa9KFmBjyYS2X0G6QPgGU6TdhmkfAdxGI2Fe15NJzK+xv?= =?us-ascii?Q?92j9b9HTlHRTkVMMVdIlcqk6K9psL5VPIkBx25bY+Pf88vlN1g8CR8y8engJ?= =?us-ascii?Q?QFREvxZYqM/mhntR3Nf7rOdj8fHBIaWK7v+O8t87LgKyvyjZmnetX6zNBJBP?= =?us-ascii?Q?dY2hX6xcfXtRU61jM6AsNbW9aqfFY1H3oevwvWRAbM/zIy82JmHt1k7t3K9W?= =?us-ascii?Q?p45WFruF13a2NEkc+BxPRPl4YhHbITWGxocSa+2g6eitL88acXlYFTYXV4en?= =?us-ascii?Q?vImEN5ei71LZDEHkIORMzpAYYRS9ijbfsAPYJufIhEN1hA/wserY+/MmyKfI?= =?us-ascii?Q?UuZ5J6OHVZTCiRrHR7dTz4uZ1OvzX0OTmPRxowO6XR34G8ZdiGSChWYbFUJf?= =?us-ascii?Q?pJiMWW7889j07TTghNH/HOViXWULOfNiKjL5xa5L0bQBsMLMMk05V5FbD+3z?= =?us-ascii?Q?bZ5EkJAWKzNHrKNYnsT73QdmULONexPSTj1yUDnkcI94ATljcdesdNCCepfc?= =?us-ascii?Q?I1YHDUImarTPMDAAvydfaZa2udfIVwLV0zEmo+njDvp0iYfyV1mUm5R3chO3?= =?us-ascii?Q?VdD3CqL49G7YYbgrxBYXo0s=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2538.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee2025c-7b0c-4979-854a-08d9e01ebebf X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 16:21:30.2249 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3QWXRSoqu6VBavLl8pLJ5aHrwQItSMJODplfpRv9KeZN+l45uVAoa2ADsT3pyDI1nEsTEAihvT4UfK1YY4GLvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3225 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org [Public] For series, Acked-by: Chandubabu Namburu -----Original Message----- From: ssebasti@amd.com =20 Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 6/6] net/axgbe: alter the port speed bit range From: Selwin Sebastian Newer generation Hardware uses the slightly different port speed bit widths= , so alter the existing port speed bit range to extend support to the newer= generation hardware while maintaining the backward compatibility with olde= r generation hardware. The previously reserved bits are now being used which then requires the adj= ustment to the BIT values, e.g.: Before: PORT_PROPERTY_0[22:21] - Reserved PORT_PROPERTY_0[26:23] - Supported Speeds After: PORT_PROPERTY_0[21] - Reserved PORT_PROPERTY_0[26:22] - Supported Speeds To make this backwards compatible, the existing BIT definitions for the por= t speeds are incremented by one to maintain the original position. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_common.h | 4 ++-- drivers/net/axgbe/axgbe_phy_impl.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_com= mon.h index a5431dd998..5310ac54f5 100644 --- a/drivers/net/axgbe/axgbe_common.h +++ b/drivers/net/axgbe/axgbe_common.h @@ -1032,8 +1032,8 @@ #define XP_PROP_0_PORT_ID_WIDTH 8 #define XP_PROP_0_PORT_MODE_INDEX 8 #define XP_PROP_0_PORT_MODE_WIDTH 4 -#define XP_PROP_0_PORT_SPEEDS_INDEX 23 -#define XP_PROP_0_PORT_SPEEDS_WIDTH 4 +#define XP_PROP_0_PORT_SPEEDS_INDEX 22 +#define XP_PROP_0_PORT_SPEEDS_WIDTH 5 #define XP_PROP_1_MAX_RX_DMA_INDEX 24 #define XP_PROP_1_MAX_RX_DMA_WIDTH 5 #define XP_PROP_1_MAX_RX_QUEUES_INDEX 8 diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_p= hy_impl.c index b0e1c267b1..d97fbbfddd 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -7,10 +7,10 @@ #include "axgbe_common.h" #include "axgbe_phy.h" =20 -#define AXGBE_PHY_PORT_SPEED_100 BIT(0) -#define AXGBE_PHY_PORT_SPEED_1000 BIT(1) -#define AXGBE_PHY_PORT_SPEED_2500 BIT(2) -#define AXGBE_PHY_PORT_SPEED_10000 BIT(3) +#define AXGBE_PHY_PORT_SPEED_100 BIT(1) +#define AXGBE_PHY_PORT_SPEED_1000 BIT(2) +#define AXGBE_PHY_PORT_SPEED_2500 BIT(3) +#define AXGBE_PHY_PORT_SPEED_10000 BIT(4) =20 #define AXGBE_MUTEX_RELEASE 0x80000000 =20 -- 2.25.1