* [PATCH] app/testpmd: fix incorrect flow arguments name
@ 2022-09-30 11:39 Suanming Mou
2022-10-06 7:59 ` Singh, Aman Deep
0 siblings, 1 reply; 4+ messages in thread
From: Suanming Mou @ 2022-09-30 11:39 UTC (permalink / raw)
To: Ori Kam, Aman Singh, Yuying Zhang, Alexander Kozyrev; +Cc: dev
There should be no spaces in flow command arguments name.
This commit removes incorrect arguments name in queue based table
template.
Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
Cc: akozyrev@nvidia.com
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
app/test-pmd/cmdline_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 148dbc082d..e59d64ffa9 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -2968,7 +2968,7 @@ static const struct token token_list[] = {
},
/* Queue arguments. */
[QUEUE_TEMPLATE_TABLE] = {
- .name = "template table",
+ .name = "template_table",
.help = "specify table id",
.next = NEXT(NEXT_ENTRY(QUEUE_PATTERN_TEMPLATE),
NEXT_ENTRY(COMMON_TABLE_ID)),
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] app/testpmd: fix incorrect flow arguments name
2022-09-30 11:39 [PATCH] app/testpmd: fix incorrect flow arguments name Suanming Mou
@ 2022-10-06 7:59 ` Singh, Aman Deep
2022-10-11 6:55 ` Ori Kam
0 siblings, 1 reply; 4+ messages in thread
From: Singh, Aman Deep @ 2022-10-06 7:59 UTC (permalink / raw)
To: Suanming Mou, dev; +Cc: Alexander Kozyrev, Yuying Zhang, Ori Kam
On 9/30/2022 5:09 PM, Suanming Mou wrote:
> There should be no spaces in flow command arguments name.
> This commit removes incorrect arguments name in queue based table
> template.
>
> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
> Cc: akozyrev@nvidia.com
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Aman Singh<aman.deep.singh@intel.com>
>
> ---
> app/test-pmd/cmdline_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 148dbc082d..e59d64ffa9 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -2968,7 +2968,7 @@ static const struct token token_list[] = {
> },
> /* Queue arguments. */
> [QUEUE_TEMPLATE_TABLE] = {
> - .name = "template table",
> + .name = "template_table",
> .help = "specify table id",
> .next = NEXT(NEXT_ENTRY(QUEUE_PATTERN_TEMPLATE),
> NEXT_ENTRY(COMMON_TABLE_ID)),
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] app/testpmd: fix incorrect flow arguments name
2022-10-06 7:59 ` Singh, Aman Deep
@ 2022-10-11 6:55 ` Ori Kam
2022-10-17 7:53 ` Andrew Rybchenko
0 siblings, 1 reply; 4+ messages in thread
From: Ori Kam @ 2022-10-11 6:55 UTC (permalink / raw)
To: Singh, Aman Deep, Suanming Mou, dev; +Cc: Alexander Kozyrev, Yuying Zhang
> -----Original Message-----
> From: Singh, Aman Deep <aman.deep.singh@intel.com>
> Sent: Thursday, 6 October 2022 10:59
>
>
>
> On 9/30/2022 5:09 PM, Suanming Mou wrote:
> > There should be no spaces in flow command arguments name.
> > This commit removes incorrect arguments name in queue based table
> > template.
> >
> > Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy
> operations")
> > Cc: akozyrev@nvidia.com
> >
> > Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> > Acked-by: Aman Singh<aman.deep.singh@intel.com>
> >
> > ---
Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] app/testpmd: fix incorrect flow arguments name
2022-10-11 6:55 ` Ori Kam
@ 2022-10-17 7:53 ` Andrew Rybchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2022-10-17 7:53 UTC (permalink / raw)
To: Ori Kam, Singh, Aman Deep, Suanming Mou, dev
Cc: Alexander Kozyrev, Yuying Zhang
On 10/11/22 09:55, Ori Kam wrote:
>
>
>> -----Original Message-----
>> From: Singh, Aman Deep <aman.deep.singh@intel.com>
>> Sent: Thursday, 6 October 2022 10:59
>>
>>
>>
>> On 9/30/2022 5:09 PM, Suanming Mou wrote:
>>> There should be no spaces in flow command arguments name.
>>> This commit removes incorrect arguments name in queue based table
>>> template.
>>>
>>> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy
>> operations")
>>> Cc: akozyrev@nvidia.com
>>>
>>> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
>>> Acked-by: Aman Singh<aman.deep.singh@intel.com>
Acked-by: Aman Singh <aman.deep.singh@intel.com>
>>>
>>> ---
>
>
> Acked-by: Ori Kam <orika@nvidia.com>
> Thanks,
> Ori
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-17 7:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 11:39 [PATCH] app/testpmd: fix incorrect flow arguments name Suanming Mou
2022-10-06 7:59 ` Singh, Aman Deep
2022-10-11 6:55 ` Ori Kam
2022-10-17 7:53 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).