From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B70C6A0553; Thu, 26 May 2022 14:16:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A88C640151; Thu, 26 May 2022 14:16:34 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2051.outbound.protection.outlook.com [40.107.212.51]) by mails.dpdk.org (Postfix) with ESMTP id 158FA40150 for ; Thu, 26 May 2022 14:16:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YYvkEs4INmjbGfC1R0jQ6LeEinr4C0bAnfkZYP1VZ+4psIxRWenY85CmuelLaoR2/7dEyF/wcoOMldQmJcVn4OHl03QohebmX3AKWQg3WRvKAbDorTFgeCQXBIk72b6l3mjzZ3h3YmATZf3h6YXlNdvkc0gWDK+CaIxhimBRn6DaiPvyzHSqceUvJUdvf6VLHLQZ48ZwXg0vKJ8gZad54k5FMbXV+hD99h3/Ct8udGf5D1F2kUxiEC/Lnd0mDe0BxqFHKnk0UZP92EbtZiWdNpyWr/mhvkwJ+3rtP+OC6VOXXtf6EFTv2UUkfiSvvztQEXNgZrH2qpjktNySAlDQnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mn9tCTDZx8w/wMeKYXE9zk+OMTYsrhmiEMvOG4RneLQ=; b=YOPvoQdpMIVJ0gh6S3AKvUdXOO9VQd3ieobEx4C7rXWgvQhoLAAFgXph68q/mxJQqi9INN/JRe5oS+veNaPS2XFsbvzn4VY+nN62ME6L5NeMvI8BojHTb02kvthwdbeDvMaRCg56G9ZXqn2PKrEOfK2u4jRhx8JVFKTywCYM7gBRfCWFuzlKn4pKP6O6EZoVFjFWqZAHn9oQsJBPQ3yJNu9WA7AsPXe0srEMpv6oxwxTm2PgKJmL1QmUE99C5lJRL3eEgqGnPEp0rSpc/8KLCNpFqqoWP5FhYR6hG09YWRe+VnbB1YvvCKybDbgyyhKrGst7aUoBPwIJzPZ0S0edGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mn9tCTDZx8w/wMeKYXE9zk+OMTYsrhmiEMvOG4RneLQ=; b=TEasZnkqeOJzRmeotouZU5ZEaP+QSmzJTSD57QjpD8pCEl/0ewAPcDQT+dEXee62m2l9VyirqoEnYsRmuShrzkUhr6TfbfxEnIkQRvdFFulUzQ6ZWd4D9HBHsNSLAh7XogVa7WhhDIo/PAKztwULVk+rGgeAi7GvGCNlhp0WTKsV5CEjaIM6HNpA500E5psk4W+NG11zW3/C3EGyy8RhjtaViOFMwjHegq6Tp8ubYr8OKMQyICHfh6YdB+8gOBHc3pcczENDZuj6wsRSo0hY5YjigXGRtbhU2bmGzkMx8iR2HwpbJOWYgMRS9rbo7v63J5uNjd1ZrsAS4d85ztFHHQ== Received: from MW2PR12MB4666.namprd12.prod.outlook.com (2603:10b6:302:13::22) by BN6PR12MB1425.namprd12.prod.outlook.com (2603:10b6:404:1f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Thu, 26 May 2022 12:16:31 +0000 Received: from MW2PR12MB4666.namprd12.prod.outlook.com ([fe80::edeb:4144:1ee4:83a1]) by MW2PR12MB4666.namprd12.prod.outlook.com ([fe80::edeb:4144:1ee4:83a1%6]) with mapi id 15.20.5293.013; Thu, 26 May 2022 12:16:31 +0000 From: Ori Kam To: Alexander Kozyrev , "dev@dpdk.org" CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@intel.com" , "mohammad.abdul.awal@intel.com" , "qi.z.zhang@intel.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "bruce.richardson@intel.com" Subject: RE: [PATCH v2 1/4] ethdev: add meter color flow matching item Thread-Topic: [PATCH v2 1/4] ethdev: add meter color flow matching item Thread-Index: AQHYbcnhXZdyuG2qA0KOZJHpTHY0qK0xF5mA Date: Thu, 26 May 2022 12:16:31 +0000 Message-ID: References: <20220518043459.1281590-1-akozyrev@nvidia.com> <20220522105102.1692526-1-akozyrev@nvidia.com> <20220522105102.1692526-2-akozyrev@nvidia.com> In-Reply-To: <20220522105102.1692526-2-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 00feba57-76a3-4fd5-f645-08da3f11917b x-ms-traffictypediagnostic: BN6PR12MB1425:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0m+4D8qHLKN6YWcRiEtpbGPvQrEtT0+Rb+Uhl6cI/yLdCVVWVhq40h/cuo8T7bQybMdWPrEAchlA1uWu8u+eNVT1awGo+1VGUNUcT3tEmGPk2Ivdo1x5Q5XlsHl0Dk6I3ixnknKsWfK7Qm48yTUo/vpCAbVB0vTw8CkIH2WHCFTF3/UDbOBLdpXu48RQZdDYTfeVDjtTCId4MryvCg3DAXo5iNkaR+3TiU6Dv5rBd9Y1Uy4IJ11pEG2k71M2c6NPKezkDEaDwovTQRia3AwNtVu28WuY6r1YCaJ0ZPywF25K7NyrFTAnKdZLkZfoWG/yw4re3mxhIUNzfZI3aQ2Lq7vwQ/NeQUYrlvlgK8poX4vV3/eaNDlyaOj30F91KQaTgdP9gcwAAKe7fSftqkxtPew8+8/zNwGyjjDDfvJz8eCXmuA4ddFGi1aea0Ju7kzJ/Iv9rg6sclHvxVNIrPAtRJSq1MVrkxtz4Osq0QODEEKBdChkwF1NUVfDDDxZY8gvEzWgQ+SdCMfviAP4YdhnnCZmE97knvIDWIZTYWBB8tS+v3d0qVsl+xAYRCMzMIs5SbjBWjxI0E/XgNoQlV0PHkvYNbvx+KgeH0L113VsiGuU4C4zs63ehdbmy7ynLgyQUnmKhOgvkBl0T/AevN8tfmr8l48BrYnP+rECq3Nr/olftDS28Wwvp99kgm4Dret0tW3z1kTgpjj2VJFEXvAgxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB4666.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(7696005)(53546011)(2906002)(4326008)(64756008)(38070700005)(6506007)(66476007)(66946007)(76116006)(38100700002)(8936002)(55016003)(33656002)(316002)(66446008)(122000001)(52536014)(7416002)(5660300002)(508600001)(83380400001)(71200400001)(54906003)(110136005)(186003)(9686003)(86362001)(66556008)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DNz4cUnboivkkwI2GVmep0iVD1PCAaEtQQYn+XLZqjZOvQVdBLtc4FBcqGFU?= =?us-ascii?Q?2GwsImE85Pjx2qNow0Ix6UjJMFvaUk+HWrE36mOIiXbVdF6vT2XmKWXDQWFq?= =?us-ascii?Q?2hEXLaacGsGpD0sJ+xEr+qX+yBYgOkhGRTcUKRQciELXzvP062yjNKfwpPhL?= =?us-ascii?Q?gv1uxdjwMW5w8FIaranrW9WsDy4/IpEQXodaCl58k+PEI66gwRtMVVg4u80G?= =?us-ascii?Q?AxNLMu8G2xpyjLxxWejpcXN54G2RpLvNEZxiVEssNaA93AQQlCkmPEe4tkGR?= =?us-ascii?Q?lMicRbGgTT/KFpUMS8bO8opvl9Z7YcPOFxABnXOCXW61ChUtP6e+3Bt2ks5x?= =?us-ascii?Q?xiVG0GJHEIrrH+J4f/GxOh6yOYY9KmhEzbGQQvkuzDiAkt2XBK+jO3vqVuA0?= =?us-ascii?Q?wwMY/dSHb6GTtMShoR/yJoUHN1mpeuR0kkL0OebXrW3I6DTZ/JLSkbFwFCHR?= =?us-ascii?Q?ZLIe2s3HUQG5PQqXKurRo+KVktAKsWo3/0pOXsVG5fHO9X7RxgSuKd24h/8+?= =?us-ascii?Q?oL9EB3oS9Bbx+zU0G8rf2uWfHAXX6EPMBGQctbmcMANzCVG4p0d4d99Ks1GW?= =?us-ascii?Q?0Em9w7ROw5ysKeO4triae7hLOXvWrtyyOajtV7G44DF/DqM0nY6XE2m1f9JG?= =?us-ascii?Q?5KKHEmLEPc/vVOB26QliE+XMoTUn+QBXM8FcfCoddV4f8T+2VdiMhsAIUwob?= =?us-ascii?Q?4QdGunAVuQT3N5Z2Gayyn+9AL7e4rysnv2PDKN09FmaQ0oRW8L+QSJkhVao8?= =?us-ascii?Q?OBz5kzLZweX/24MvyFmLmpqsV58qv1Pm6arqQwmpf/osXmLRtHNRGlmLHOzL?= =?us-ascii?Q?ih216qt7LQW/RVdqv4zzIMAbddVuK6aRiEsnI81U2PM9OcUEcEkOJDeWAL5m?= =?us-ascii?Q?nbo6yCy+p23dd5BIbJED0S3A0GbaeYfRRwhWPhcQzuWshHvIij1HT72ZWHkw?= =?us-ascii?Q?Go4qeVhlP4YWQLSTZBTSxrAjoawW1TS+dAL9EYUotzrzyQ+RDoo9PQvp0Mke?= =?us-ascii?Q?U4zmqtdphffSj6QH2sd1ntJC/dju5X1I9yoLh6VfCSOSkPJlPF+H+rxzbttx?= =?us-ascii?Q?M2VlI+jINilWmU8rYdw3NL0d+8Y7sqwnfoL7Kjvg/89hRE+5eRI8QZdZ+5eJ?= =?us-ascii?Q?mlO08WAwe5Kpz6WHDy2C+uHU5Xs25miWDIywddTjPxf2ANqRMZpzGpYRvMCN?= =?us-ascii?Q?SQiQ4zWGAUWxnLzA4wuGaEhmUbl69exmYWKEVzrOCLlnAZgQKUkeqGaZsEZH?= =?us-ascii?Q?KA8Ez0EnaRd79YZgJS/O/zfTCePWadUBkxW38hcaOPP/Gu/GM+UYjf69DNZO?= =?us-ascii?Q?BiDVThAMUkkDfoMTrqVnm6cKqfaRLigx0jKiHZDopOBjE5sEzNu4JZ0ghKV4?= =?us-ascii?Q?lWp+hC/XKURK22ecqhfQjVqgc9nDJ9UEe/DHjsYpHf+WhsfWQz16faBHKHbA?= =?us-ascii?Q?/0EvawFuGfWprjPNbwn0ng/FX7ZTmEXHnBIVYXt10yOJ9BDNaOoyaDyTtA9+?= =?us-ascii?Q?zSMP2/gpofX7+nw4GkkImv62zAyOXcDvNn9kN5cuiQaBErjAPCBUWxoESeEq?= =?us-ascii?Q?bI4pT2ODXPxqf8HD0Xa7zzsMRfaT+sha3qOVZNrqr80S+M6wcp9Z5THDOfoL?= =?us-ascii?Q?PG3a/RhY5AY3gKfvXl2ldF5IIKiV5VGYLo+g2xxN5tjr67lSnaNsfb4UzwoJ?= =?us-ascii?Q?wuMjEXyLRESIncs01XV7SVrhHrwLXzxK2h+mWsn7poDmrweYGXsD/KQMxq3X?= =?us-ascii?Q?kzhF5LRkjA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4666.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00feba57-76a3-4fd5-f645-08da3f11917b X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 12:16:31.3692 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RJJ7JGrlcY2thEAKNyZA3g2AzrtW1k2n3CvruMe+w44AqTIbYBoBUpyKs12DWXXSefHSjevZvgXFToVniIgJbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1425 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Alexander, > -----Original Message----- > From: Alexander Kozyrev > Sent: Sunday, May 22, 2022 1:51 PM > Subject: [PATCH v2 1/4] ethdev: add meter color flow matching item >=20 > Provide an ability to use a Color Marker set by a Meter > as a matching item in Flow API. The Color Marker reflects > the metering result by setting the metadata for a > packet to a particular codepoint: green, yellow or red. >=20 > Signed-off-by: Alexander Kozyrev > --- > doc/guides/prog_guide/rte_flow.rst | 7 +++++++ > doc/guides/rel_notes/release_22_07.rst | 4 ++++ > lib/ethdev/rte_flow.c | 1 + > lib/ethdev/rte_flow.h | 24 ++++++++++++++++++++++++ > 4 files changed, 36 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/r= te_flow.rst > index 588914b231..018def1033 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1651,6 +1651,13 @@ Matches a PPP header. > - ``proto_id``: PPP protocol identifier. > - Default ``mask`` matches addr, ctrl, proto_id. >=20 > +Item: ``METER_COLOR`` > +^^^^^^^^^^^^^^^^^^^^^ > + > +Matches Color Marker set by a Meter. > + > +- ``color``: Metering color marker. > + > Actions > ~~~~~~~ >=20 > diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_note= s/release_22_07.rst > index 0ed4f92820..c1804bc74f 100644 > --- a/doc/guides/rel_notes/release_22_07.rst > +++ b/doc/guides/rel_notes/release_22_07.rst > @@ -69,6 +69,10 @@ New Features > Added an API which can get the number of in-flight packets in > vhost async data path without using lock. >=20 > +* **Extended Metering and Marking support in the Flow API.** > + > + * Added METER_COLOR item to match Color Marker set by a Meter. > + > * **Updated Intel iavf driver.** >=20 > * Added Tx QoS queue rate limitation support. > diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c > index 2c35a2f13e..07d7e998c0 100644 > --- a/lib/ethdev/rte_flow.c > +++ b/lib/ethdev/rte_flow.c > @@ -161,6 +161,7 @@ static const struct rte_flow_desc_data rte_flow_desc_= item[] =3D { > rte_flow_item_flex_conv), > MK_FLOW_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)), > MK_FLOW_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), > + MK_FLOW_ITEM(METER_COLOR, sizeof(struct rte_flow_item_meter_color)), > }; >=20 > /** Generate flow_action[] entry. */ > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index d8827dd184..75ec6621ac 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -671,6 +671,14 @@ enum rte_flow_item_type { > * See struct rte_flow_item_gre_opt. > */ > RTE_FLOW_ITEM_TYPE_GRE_OPTION, > + > + /** > + * Matches Meter Color Marker. > + * > + * See struct rte_flow_item_meter_color. > + */ > + > + RTE_FLOW_ITEM_TYPE_METER_COLOR, > }; >=20 > /** > @@ -2201,6 +2209,22 @@ struct rte_flow_item_flex_conf { > uint32_t nb_outputs; > }; >=20 > +/** > + * RTE_FLOW_ITEM_TYPE_METER_COLOR. > + * > + * Matches Color Marker set by a Meter. > + */ > +struct rte_flow_item_meter_color { > + enum rte_color color; /**< Meter color marker. */ > +}; > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_METER_COLOR. */ > +#ifndef __cplusplus > +static const struct rte_flow_item_meter_color rte_flow_item_meter_color_= mask =3D { > + .color =3D RTE_COLORS, > +}; > +#endif > + > /** > * Action types. > * > -- > 2.18.2 Acked-by: Ori Kam Best, Ori