From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CC4FA0562; Wed, 14 Apr 2021 11:07:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD8481618B8; Wed, 14 Apr 2021 11:07:30 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770073.outbound.protection.outlook.com [40.107.77.73]) by mails.dpdk.org (Postfix) with ESMTP id CB1701618B1 for ; Wed, 14 Apr 2021 11:07:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZYR+fMbXOaYgNF21guN/63GIF8xa7kdnpcrs9nq7bc6SgQ+nsh0W0GuL7bo9cYkIJuMJKJ/h6fDHl42j9j8m6LQUqvoR7OYBW6mV8+PC7izuV/id6NDRzM2iIsdvvSzM7VtfddSQnPLKuN69zt81nYz68MBykkKEyDXBhoLXpcF5WVBtCw5GubyNBhYuQeWDF1p/a1txZrS5npCJYtDqzTfsD8tPJYed6xHN1p9AWqdSRZs0KGDnb9t5gkWRuC/oW4ckdSlEDPT8ffTwKf3t5lC3OfRn7KzMFqh4bw0DJtFABm2NpYL8r7+qrdfZqrMvchaajbFqBqOx4LZx5mlYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBffn26xd7iHqKOyPX3JRlRIsbdl/pUxoR4irsxw5sA=; b=JZOvlqM3anctlU9dOhYFfHM3xCXZBwUKxGET0jcP61CW9cc372DetnMSOH4auh+1lWwH8JWlziJB6u69BrXfYS+OPTpc59mdq3AElU8/wys/USRApanNlVVGY3G2X3wK1AhOYGbfNzu8EvGXJURAp6lIbc0zu3TwiuSKKGNgyZg1HdI29f2dBhjlKi1q/VVggh36N4v1EKEAMgfPavuxlRnEkKsyQHwTN5azguPpHOlURy/bjhXTWX/uIGx3L9ZpPjRfvW5t4RdbiEyH5Jy+tfAWVLW6J9vXouYIKZ3nj/GarhpDIYQVha5PSydB1y2R0uk2A6WD5J8i3yA5pMJyGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VBffn26xd7iHqKOyPX3JRlRIsbdl/pUxoR4irsxw5sA=; b=QxQlpfvcdyuz/O4r0/z7cBB1rs4QZtPlXdWnPUKfKZYN0rKLX8x9KgtB2OCAaFVl1qXmqwiSkOFyzxgY7+dZvhnKHmAN5khxuVWkaQ+ZC8N+dqAT3y8yjuPMfrMO57cbdgod20+EEP7R4InfWGG+RUBxyQVjI3r9sR9ZtbJ5drBx7Ef1bHQkCrJm7zgW/fY89t6jbZ9jQH6PF8WDyvPCNCwPLpftjZXePExp2Jy8xfBNO5qaSrPSejVnkiYocV6he2CnQ43PCGS98GJSdbrxkKHLuyl00mc2cor8K6WUOhB4aAvLAb633ZnEYAciNMmqU49E2clsmXA9j/HPnSw7lw== Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28) by MWHPR12MB1824.namprd12.prod.outlook.com (2603:10b6:300:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Wed, 14 Apr 2021 09:07:25 +0000 Received: from MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6c71:eb7f:ad9d:335b]) by MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6c71:eb7f:ad9d:335b%6]) with mapi id 15.20.4020.022; Wed, 14 Apr 2021 09:07:25 +0000 From: Haifei Luo To: NBU-Contact-Thomas Monjalon , Ori Kam CC: "dev@dpdk.org" , Slava Ovsiienko , Raslan Darawsheh , "Xueming(Steven) Li" , "ajit.khaparde@broadcom.com" , Xiaoyun Li , Matan Azrad , Shahaf Shuler , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH v4 1/3] ethdev: modify rte API for single flow dump Thread-Index: AQHXMQoIyYZhdoxpDUKt4kyJWviJl6qzt10AgAABfzA= Date: Wed, 14 Apr 2021 09:07:24 +0000 Message-ID: References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <1618389706-183883-1-git-send-email-haifeil@nvidia.com> <1618389706-183883-2-git-send-email-haifeil@nvidia.com> <17036885.Jqfv5cWjOq@thomas> In-Reply-To: <17036885.Jqfv5cWjOq@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [112.65.62.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ab02c12-b869-4372-568d-08d8ff24b87d x-ms-traffictypediagnostic: MWHPR12MB1824: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h84kvgsEjWQrxzP8t+29hKqehLxS/k0hYV/yCNRUDGOqFSKxtmictEgQGczLfqPC7KeqeIUj67g9IEUgnhl3Oq0dZuKJQctH6TCAsvnody7EkU6jTFABxcX6IBuhEmf9RO1h4gve0pnJRL75icvBbe3NCz4kPCFNTiWQFSUEvgL5LLPUMg//WWHK0RmW+BTSzsIca78r+c2h6YJW+u2huGByCEGhWiiKy5WqCSfzxvWgZi2wrZZ6ZDvICi5V4HuNh0AtjiIgzI5hFx3IF/07Sfkli5BkkJ5RolYex4tI2ux8Vc4YeqRNB9w8r9XQeINpxJDK/IWnv8vJ8A5V7dsdcTCH/tdv7EpJ3au8DglxqlAhtmVpCjJwN70V4t7+VNqsa9nr1wbUoxS508CHQgSmJad6qztwH0j/cC9M34awtdrjWdvmYPApQlXyE1m65XMI3Gu2w1xRYCdvdypWRc945M0QvBmIA6xFwLWx6y5foPB8iVU7JfzEjHjJTCp7QkqVVDfwbykMnT0KMWR/veYobXLlkkU8QkrCzrmuG5RFwaPEVM+10pGZTQQud6TxgIG3uAgOD3MMgNVNAMuk/vsTrV69EhKA9NYFJ4R28T35PLQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB4667.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(136003)(396003)(39860400002)(376002)(38100700002)(66446008)(66476007)(52536014)(33656002)(66556008)(8936002)(8676002)(76116006)(86362001)(64756008)(6506007)(478600001)(7696005)(6636002)(9686003)(110136005)(5660300002)(71200400001)(316002)(186003)(2906002)(4326008)(54906003)(53546011)(66946007)(122000001)(55016002)(26005)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hAW7qogEVbu1q+STWRIIhBvgyaWu6iwU/M/Sf4XDWIhxpMeqPSlys/aiVc9A?= =?us-ascii?Q?CGjeRNqUfgtwLQj0WH2md6bN8DvaMrzSF2/wD8zX+NDek2XZ4HqEYQVQIXsA?= =?us-ascii?Q?B8KhlEz8+xtH7xuNU8zBOZX/fVbNZp7pBmeOG3RJj+ORZ0TMDVeHKRGBKskJ?= =?us-ascii?Q?ga5Rt/1wiK6Xddpq7Rx+BNbFlSFoHg4WNLXqfRZrNAObqCNY2oV70j3tagGG?= =?us-ascii?Q?xcZBoS5PvJnZy3Er7fVhl2zuJchkbweRcWuakktBepLt5fJ6msig+mNu7aCn?= =?us-ascii?Q?VK/3FercCnJDWDsvWtfUAXOlLp+YGhzIySId+fy0sOoSxJmbkJyq91ZE54ht?= =?us-ascii?Q?dqd22J5K7AtLG7G3T2A23w1xxDcNrH9FFK0uScbGbxBXfB95Opzwhc/4Hzcl?= =?us-ascii?Q?PdQQRIMoTfNURcUaN9o1mkjq4jCYivg4yA9v0gKTR01SMJ9DksPrQ+o6WZci?= =?us-ascii?Q?i/87wBhZLNfgcybRlmUBgpLVxkt6cuzEod55jAE0RlsWnpxnJkkPHjZ9NN56?= =?us-ascii?Q?I3Vad8QMcJ8aydtiBkcRfKau6ckjEWlpic00KUgUcH8YXi0FflNriLhXfYGF?= =?us-ascii?Q?dFmgBfoXT0AVJltg7fY2zhxK6bXSea4VBX/i2SBPakx1lKKPrrPphbEhNk/T?= =?us-ascii?Q?xwJQrLIowf3rPRZ0lIpYK2eJzw3NhE+VegY+aXiERLIsxCYdJ/SOM84df4od?= =?us-ascii?Q?wz4Oof3v7iklfEkMYEN66708q/Vl4XHXUiYkPm6Ug/DiutNbBOvXXaiblKoe?= =?us-ascii?Q?sbORqA2/xqE77006Qj9qgP/94dPBi8zYPeNqSAVIMYXM6Wo0VAaJZ4b9kmkr?= =?us-ascii?Q?5HhhzG9WZ31Kndp/XwSqRZ80RyrDlIbnUbewWONlfuNEyJcNstpIDsPtA0Im?= =?us-ascii?Q?8Oe3K0uwg3DYqpC9+PedH04vdwJJadot3poxGnkC1IGr9QQkoUt/YVRmn9Up?= =?us-ascii?Q?WSiAc95DiRRh61rqZFmB/f+tRKR9FDag9Gwtjb4+qb+guge0wXkJIkvLykif?= =?us-ascii?Q?6yJKJp1w+jrs3pGezuO8OO0b32GK3JMMjyeA/Qx52ChLR5FJfAQ3+b2efqQH?= =?us-ascii?Q?pAWHbABpZEcmwC2OJbKmO0ReD6sROE7rGMEyCdOU+Nad6FxYjLDvXGDt8XT9?= =?us-ascii?Q?aa1munlPny/D0n+gJbpGtMTDbu3NoXGkF3UNLctkbDeNtAAM6DEqfQ0WRp+0?= =?us-ascii?Q?R7ZkKSwrBAjfytRJuzW3/upqD2xjdaBRZmju/emkABiYacDL/dXaLcs9SvT9?= =?us-ascii?Q?OtiUDK/ulrarU8io/plRBZ09/XeA+fHh8rLFNrha6Hg24raAoe6nmp2Wx1WH?= =?us-ascii?Q?lW4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ab02c12-b869-4372-568d-08d8ff24b87d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 09:07:24.9963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pg24ix/6mhhh/C+GQEUhJaYwoTqf2qHVmmdDoXeMwUUFCrRVimgaQ3DMuzZ3Vx/PjN1xeUk+Uv1qyEzbfXme5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1824 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, I will remove it from prog_guide/rte_flow.rst. Is it okay ? Thank you. -----Original Message----- From: Thomas Monjalon =20 Sent: Wednesday, April 14, 2021 5:01 PM To: Ori Kam Cc: dev@dpdk.org; Haifei Luo ; Slava Ovsiienko ; Raslan Darawsheh ; Xueming(Steven) Li= ; Haifei Luo ; ajit.khaparde@broa= dcom.com; Xiaoyun Li ; Matan Azrad = ; Shahaf Shuler ; Jerin Jacob ; Nit= hin Dabilpuram ; Kiran Kumar K ; Ferruh Yigit ; Andrew Rybchenko Subject: Re: [PATCH v4 1/3] ethdev: modify rte API for single flow dump External email: Use caution opening links or attachments 14/04/2021 10:41, Haifei Luo: > Previous implementations support dump all the flows. Add new arg=20 > rte_flow in rte_flow_dev_dump to dump one flow. > > Signed-off-by: Haifei Luo > Acked-by: Ajit Khaparde > Acked-by: Ori Kam [...] > +Dump > +~~~~~ > + > +Dump information for all or one flows. > + > +.. code-block:: c > + > + int > + rte_flow_dev_dump(uint16_t port_id, struct rte_flow *flow, > + FILE *file, > + struct rte_flow_error *error); > + > +Arguments: > + > +- ``port_id``: port identifier of Ethernet device. > +- ``flow``: flow rule handle to dump. NULL to dump all. > +- ``file``: a pointer to a file for output > +- ``error``: perform verbose error reporting if not NULL. PMDs=20 > +initialize > + this structure in case of error only. > + > +Return values: > + > +- 0 on success, a negative errno value otherwise and ``rte_errno`` is se= t. I really don't understand why we continue duplicating rte_flow doxygen in t= he guide. Please stop. Do one good API description in doxygen, and describe only the big picture and how-to in the guide.