From: Haifei Luo <haifeil@nvidia.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Kinsella, Ray" <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>,
Ori Kam <orika@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Neil Horman <nhorman@tuxdriver.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 3/5] common/mlx5: add mlx5 APIs for single flow dump feature
Date: Wed, 14 Apr 2021 06:23:08 +0000 [thread overview]
Message-ID: <MW2PR12MB466710AB47648CC60D487BFACE4E9@MW2PR12MB4667.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wOxcUzmT=c5yejsdeGb3QFHEcyu1AYuPiBAboS1=u1aQ@mail.gmail.com>
HI David,
Thank you for the description and I will modify accordingly.
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Wednesday, April 14, 2021 2:21 PM
To: Haifei Luo <haifeil@nvidia.com>
Cc: Kinsella, Ray <mdr@ashroe.eu>; dev@dpdk.org; Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Xueming(Steven) Li <xuemingl@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Neil Horman <nhorman@tuxdriver.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 3/5] common/mlx5: add mlx5 APIs for single flow dump feature
External email: Use caution opening links or attachments
On Wed, Apr 14, 2021 at 4:40 AM Haifei Luo <haifeil@nvidia.com> wrote:
>
> HI David,
> In current release, is the exports file necessary? I will keep the modification if yes. Thank you.
>
> drivers/common/mlx5/rte_common_mlx5_exports.def
It depends on the tree against which you send your patches.
If this subtree (like next-net, or next-net-mlx) has been rebased on
56ea803e87 - build: remove Windows export symbol list (6 days ago) <David Marchand>
Then no .def file is needed.
Else, you should keep this .def update.
In any case, this is easy to fix for maintainers who take the patch, since in your case, the .def update will trigger a conflict which can be just dropped.
--
David Marchand
next prev parent reply other threads:[~2021-04-14 6:23 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 8:15 [dpdk-dev] [PATCH 0/4] *** Support for one flow dump *** Haifei Luo
2021-03-09 8:15 ` [dpdk-dev] [PATCH 1/4] ethdev: add rte API for single flow dump Haifei Luo
2021-03-10 0:39 ` Stephen Hemminger
2021-03-10 7:05 ` Ori Kam
2021-03-09 8:15 ` [dpdk-dev] [PATCH 2/4] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-03-09 8:15 ` [dpdk-dev] [PATCH 3/4] common/mlx5: add mlx5 APIs " Haifei Luo
2021-03-09 8:15 ` [dpdk-dev] [PATCH 4/4] net/mlx5: " Haifei Luo
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 0/5] support single flow dump Haifei Luo
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 1/5] ethdev: modify rte API for " Haifei Luo
2021-04-12 19:33 ` Ori Kam
2021-04-13 4:38 ` Ajit Khaparde
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-13 16:36 ` Ajit Khaparde
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 3/5] common/mlx5: add mlx5 APIs " Haifei Luo
2021-04-12 7:32 ` Slava Ovsiienko
2021-04-13 16:44 ` Kinsella, Ray
2021-04-14 2:40 ` Haifei Luo
2021-04-14 6:21 ` David Marchand
2021-04-14 6:23 ` Haifei Luo [this message]
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: " Haifei Luo
2021-04-12 7:29 ` Slava Ovsiienko
2021-04-12 7:37 ` Slava Ovsiienko
2021-04-13 1:29 ` Haifei Luo
2021-04-13 7:22 ` Haifei Luo
2021-04-13 7:39 ` Slava Ovsiienko
2021-04-07 6:09 ` [dpdk-dev] [PATCH v2 5/5] doc: add single flow dump to guides Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 0/3] support single flow dump Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 1/3] ethdev: modify rte API for " Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 6:13 ` [dpdk-dev] [PATCH v3 3/3] doc: add single flow dump to guides Haifei Luo
2021-04-14 8:23 ` Ferruh Yigit
2021-04-14 8:25 ` Haifei Luo
2021-04-14 10:00 ` Haifei Luo
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 0/3] support single flow dump Haifei Luo
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for " Haifei Luo
2021-04-14 8:57 ` Thomas Monjalon
2021-04-14 9:10 ` Haifei Luo
2021-04-14 9:01 ` Thomas Monjalon
2021-04-14 9:07 ` Haifei Luo
2021-04-14 9:31 ` Thomas Monjalon
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 8:41 ` [dpdk-dev] [PATCH v4 3/3] doc: add single flow dump to guides Haifei Luo
2021-04-14 9:15 ` Ferruh Yigit
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 0/3] support single flow dump Haifei Luo
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 1/3] ethdev: dump single flow rule Haifei Luo
2021-04-14 10:33 ` Thomas Monjalon
2021-04-14 10:37 ` Haifei Luo
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 9:51 ` [dpdk-dev] [PATCH v5 3/3] doc: add single flow dump to guides Haifei Luo
2021-04-14 10:19 ` [dpdk-dev] [PATCH v6 0/2] single flow dump Haifei Luo
2021-04-14 10:19 ` [dpdk-dev] [PATCH v6 1/2] ethdev: dump single flow rule Haifei Luo
2021-04-14 10:20 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add CLIs for single flow dump feature Haifei Luo
2021-04-14 11:26 ` [dpdk-dev] [PATCH v6 0/2] single flow dump Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR12MB466710AB47648CC60D487BFACE4E9@MW2PR12MB4667.namprd12.prod.outlook.com \
--to=haifeil@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).