From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D832A0562; Wed, 14 Apr 2021 11:10:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 219891612F5; Wed, 14 Apr 2021 11:10:51 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770040.outbound.protection.outlook.com [40.107.77.40]) by mails.dpdk.org (Postfix) with ESMTP id 2597C160F8D for ; Wed, 14 Apr 2021 11:10:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l2dji3LDJQlMuJrQCEfagJ9EG4UZKTSBEJFeZ1vAudAYIQ8vC12jLD6jfFQ0dpDB07s1jS3D28N3XYEnYyYqniaCH1YNLufUItCE1sQ5+sYroBO8yMmaCxIRhs92pUS3LzcWso9ZFN0xt3sq9zTJXkF82rhDeuDNZWeW/vweTHyuMXdySkHT47cZAdUtOgOvwKkdMIPeOkb2ng4iyyX4grbnJDdHAzYSqu02koheWNMBi2BaA86ob7UNcz6NjUMkbWbfGKzOBFhEzeKBw80dCi8uyob5w4Ptc5Z8CE3YCht408B2rK9tszdDfOu8SI5r3hyaM2HOqk1tkm22WyqW0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OgvKh32ti82aBnK9qzHf38Nix5rdh86u61KOSMQ5tlI=; b=L3MVtTTtNdmxdnQYl1O/mSI1uoNo9abQrs9cuWAK38RTb14o1kfTbmTQUgsr4XOJM5A9InaIuQuoC3CZwzO8Yz87VA57m2Pxj2aciqG168W4pdnqgxInkNhmZHRYwR3akfs4NsKc4/HqY1xwzl1vnt/aJghkwrfc6Q/G20cKMH5QWZxO+bd5fYg5qEQ+D/i3uGHB7PHKGfffkUf1L28EdPjZ4L5pIujYL5Pxja5PSisHqv5ylOVgn3osCiiymB6TAAEc5NnzV7XTBeb+Yu+RErcutSccQxsCfqFtdzHmym1rFHBJhB1kNrp7IHN9y1t48SfgXf+dfP/WcmEERyH/3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OgvKh32ti82aBnK9qzHf38Nix5rdh86u61KOSMQ5tlI=; b=Rk3lH5C0TuMJOtKkoAARfZC70q9LFpTzdVrWSCJKtfE4XGP3+PKuI3YKdFCH+LghSc7aaSHlH4hdf/yB16IReIJheh70SdRAwSGUGrs7Eib9RVVklDC8LGi/wpw0RvMcxY16UNXw1nqb4wQ7TZG5cTqdM2Cb6l8aslLX0LezBwTzjgr+NjfYQaXtHHlINnprRYovj3FG+Qj1fHTaT0rejAFAlyMgvQWZZMxkDcqdSoZajIBt+mGmTLpPTHpimRF/rov5RaXWn1ZbjLqMPwB9hCV86cxl16KQ6o4SzIqncPiXxkpk73QaJkadmuLtz0STCUkY2htCLaANr2vvMWIGLg== Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28) by MWHPR12MB1824.namprd12.prod.outlook.com (2603:10b6:300:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Wed, 14 Apr 2021 09:10:47 +0000 Received: from MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6c71:eb7f:ad9d:335b]) by MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6c71:eb7f:ad9d:335b%6]) with mapi id 15.20.4020.022; Wed, 14 Apr 2021 09:10:47 +0000 From: Haifei Luo To: NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Ori Kam , Slava Ovsiienko , Raslan Darawsheh , "Xueming(Steven) Li" , "ajit.khaparde@broadcom.com" , Xiaoyun Li , Matan Azrad , Shahaf Shuler , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH v4 1/3] ethdev: modify rte API for single flow dump Thread-Index: AQHXMQoIyYZhdoxpDUKt4kyJWviJl6qztlcAgAAC1aA= Date: Wed, 14 Apr 2021 09:10:47 +0000 Message-ID: References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <1618389706-183883-1-git-send-email-haifeil@nvidia.com> <1618389706-183883-2-git-send-email-haifeil@nvidia.com> <5011689.uK669MFXqd@thomas> In-Reply-To: <5011689.uK669MFXqd@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [112.65.62.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43307fad-25af-4ab4-e926-08d8ff2530f4 x-ms-traffictypediagnostic: MWHPR12MB1824: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: R6Yo0FFjp5qELsEG7jkwzQ2zLThBYzqO1FxnQa35jPfLp9M01Qj12ERGFC0gzonHYKKutZ0TGXpzKUxh4/2B5ZG3gf4GuLF10QoJ1lDxD+ovtu9HYpVjR0J48UteM790UQYCbJgU48peKr7NmYyP11pTs+acxPACHFetvE+l205ewPfB2IDZ/3hdSNsbfenX+Is07nWH4yq4hCGl0W3pSRsqk7rbOz51PB8hhvNWAXvyFkEfy2nT1QQjbDZwTZ2PBtOmy3q9593GE+jMoYnpTCEZlk0sLczhQbm/MLG2KEavd5MxB8BRgZB5Xe4CxfRUCmnmOiLPLGgprDb+0/ZK3eA3Ygzj7eb+IVPTWGhBRYu6GdGucqwW/eLhZTq2K7LcE7bbuJ/DFPU6vrxGecz4xwL1qfPrSgzZ3rdwWXFb02d5Xh4IoGVS8hsFPgFQ1UMYDPxCJ0WyfZlNr76j7K1sx0pCVFNEhCguRXJmcMv8z1huIxXqEFA6ID4/dp6eNtNwJDnnnbIm3ui+Zk+Bpn/2E3b6FQD1+llGOCyy5zimM6G5nVLEh62UOTTrzdxSuP+L1nutYYabiqoqk9xvZZ48GpmiwCD1T8DjFee7pE2NLmY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB4667.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(136003)(396003)(39860400002)(376002)(38100700002)(66446008)(66476007)(52536014)(33656002)(66556008)(8936002)(8676002)(76116006)(86362001)(64756008)(6506007)(478600001)(7696005)(9686003)(5660300002)(71200400001)(316002)(186003)(2906002)(4326008)(54906003)(53546011)(6916009)(66946007)(122000001)(55016002)(26005)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?kbM/nvfqeyzMoRO1D3dZ37fCO3tlZQ+OTEZfRXqBRLgEs2/5L9kv5VcvNQMJ?= =?us-ascii?Q?sGrlawtIDIbgcrYKhZlFVoVtHByeohQSdiGiwFglfxh+vs9e23A+A/eToLiQ?= =?us-ascii?Q?J/5Efkr/lpeHTL2amDlMq5YPMXMUoz5fsKt18x1bsuPSCSzkBVhIycrVm/5V?= =?us-ascii?Q?xEOkRKY7G+dAfYbimdEGIZU0k/qoz2VNLHFwfKEo4Map1z/UHlCL4zBLUiGC?= =?us-ascii?Q?SrHJv0DcLVvvRGDzK+UBIMeMjjreyg1exjjNPY8JlV7y8aXam+jmJ+fTzPHT?= =?us-ascii?Q?LoPa4pJ7CSanWMYwh4WO3yb7wou67kgTYV0a/uz8lly1hdj5FZhVz1tea1Je?= =?us-ascii?Q?3RYHp19OwNjJ/d36qSAgc3HDosDJbMjbRhwi5ieqGdNyENrrwXfC6VHj+tJ6?= =?us-ascii?Q?884/u8w3YSCb3HpJdpx29OKAIMgztjNPlMc0yemwCJw7LGgsnVBsVbEEfMRf?= =?us-ascii?Q?ojyGy+mPq7BMy/CvrLw2TOCYGIF5z33ImGrV2BHNnbXjYPt/pVQu4czU5Hv2?= =?us-ascii?Q?t/2WQ/Ce9siHRK4CDGHW25+moiZBNW9d/b29s6r/pyW/D36jRqt+oENzGp7J?= =?us-ascii?Q?60aeBfGyBlznYVTjX/JfPC6/9fdNwzPzDqEUOp9j73xdpih3tBq/B1Axhe1v?= =?us-ascii?Q?kSGH6N+N4SyUn/aTeZ2HHcpxFzyBGMYguWWyFL9wAkx2EIoQ1Y/fubx910zS?= =?us-ascii?Q?+3wgBwsT/n+oiSFghCMT+qOZMMSoOs6e+Nqy5BmFvxXIGbZ72z+dZ5Q+LcKp?= =?us-ascii?Q?M9sdhVogkTYFkioC+0Sgc3+z5X2sDaq9FeJp6f2NcOJWS7BN6+blepJxFmC+?= =?us-ascii?Q?BwOwb7yxvovNQpx+8mhYt7GohJDRCT4QqcZX05zohNnkM5hNRvVIyI1ROUDe?= =?us-ascii?Q?ZUyT8t2jHnjoY0K261ODtmQMe9TlJmJktj3tEh/iwTvtUi5CJjqBHd/AWDlb?= =?us-ascii?Q?ngs3mIjuJVTzSxT+icao0yc2dfr8kYOQgNs5tHUCsruyDRU7348Wr7ut6F0o?= =?us-ascii?Q?LRgN4YKWrv9oF3hNGEx/ssWr/lit82YG/J/wdhXPLII/uKKnfR8TIGFGmfif?= =?us-ascii?Q?mvMUHges4nO+y84Wru5LVwzgU3N0iAsXMBqCYyQIwQjOcObfUm/V2KGdYMKm?= =?us-ascii?Q?zVqDeo7Q6BEv2U1RUR0cldY3haNJBScwsvz7tx7fVuHPboa53fLLEfNlhGW/?= =?us-ascii?Q?52Va4taF6jeM1Bs+QpUdZ1IB811Gy1otomoHqr/1Lt8ZvfgfCBwcVdfm6NXC?= =?us-ascii?Q?nf6VBZqKSq111yajHuIv1TxnO3tf10qmBZi0I07VOlxCsl/zLmyFg+w6Nlqz?= =?us-ascii?Q?z/8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43307fad-25af-4ab4-e926-08d8ff2530f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 09:10:47.1185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qluitu+wh5cOfIxyZFrg3M8Jnaxxli2PbXntbxKDfvoK17McwPQ7qwX/ARPpxFTH76kUIfXXL2st2HQIfybi8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1824 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Thomas, #1, okay , will modify title as " ethdev: dump single flow rule " . #2, yes, it can pass NULL. Will modify as you described. Thank you so much for the comments. -----Original Message----- From: Thomas Monjalon =20 Sent: Wednesday, April 14, 2021 4:58 PM To: Haifei Luo Cc: dev@dpdk.org; Ori Kam ; Slava Ovsiienko ; Raslan Darawsheh ; Xueming(Steven) Li ; Haifei Luo ; ajit.khaparde@broadcom.= com; Xiaoyun Li ; Matan Azrad ; Sha= haf Shuler ; Jerin Jacob ; Nithin D= abilpuram ; Kiran Kumar K ; Ferruh Yigit ; Andrew Rybchenko Subject: Re: [PATCH v4 1/3] ethdev: modify rte API for single flow dump External email: Use caution opening links or attachments About the title, what is "rte API"? I guess you mean DPDK API with rte prefix. But given all DPDK API have rte prefix, and this patch is for DPDK, you can just say "API". So the title can be: ethdev: modify API for single flow dump But it can look as single flow dump was possible before, which is wrong bec= ause it is a new feature. Another idea is wrong: The packets of the flow are not dumped, it is only dumping the HW representation of the flow rule. I propose to simply describe the new feature: ethdev: dump single flow rule > + * @param[in] flow > + * The pointer of rte flow. Please replace "rte flow" with 'flow rule". Is it allowed to pass NULL? Will it dump all? If yes, you can change to: Flow rule to dump. Dump all rules if NULL.