From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EEE4A0562; Wed, 14 Apr 2021 12:37:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1799016197C; Wed, 14 Apr 2021 12:37:41 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2080.outbound.protection.outlook.com [40.107.220.80]) by mails.dpdk.org (Postfix) with ESMTP id 3EBBF161978 for ; Wed, 14 Apr 2021 12:37:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsGeQ3EFktTPHShjAIidYxu85aFsH/EG0kUdzK4IqIVKbe17SIWGKsCQ5BVxabNt5q1ESzozDM+JDLO2jl2qDOaQUO0bNYD/wolipEA+n7CW6roOnPmLmM/iEusFbuxywQsRvDeGf3Wqe7wmt3DXPeAGhjU2fk6tFTrf4DLZPq7uWM9vRr0OUqiEqek0vKKWn9+Dpv3nXOY4AIrZIQLxdjxMHi+jOFJW0BNbUN2pWzcIpJkRi0QnTafMZEntxXOEKXgdc4zJ4AMNS4Z5pYl+kBP9z7SaE6tkkIFhZrSNyroAG9sIL1JYF9JHhfH66DcgmXxe13S8nRP5dEuOL34S0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHk8apCazI/yMcVHEscYo6Gq2TahyM2Y0TScdxKAAC0=; b=KB97jTN6Zv+9CeXOQwyRINU1WtZJtFYLWoxifvZ2uWMxMD9YcUpk+wiWrjkS5uGeEfnsEzucf76J0dYxqLnVi+DhouZbQjpQWYmz9MC+2eXgqL+9SNNQJ8n/DxggJFgQlFtfS23NxKic7++riaPO4CXtDttEUgl6ej+Wl0Ic559nMgiwSZz8kWP2IDDN+YDAHOQM5tgH8XjmbvFlLWqSXj51kvNJXWN6dbBZdAGM9K0yEMfJ1y3zMOpGYx6LijBSqzNy9s5SbneiMrQzYndLytw29ycY9V6TKy/fRyzoKQZzvGSl/50HcLxUg2mafYA432MhfxcFCnmR703X1j6StQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHk8apCazI/yMcVHEscYo6Gq2TahyM2Y0TScdxKAAC0=; b=KbnbedRwPoaqzM+ZlBdMmJjLzxAb9rlxI3nDtfSeLjOQ9bwcwT4hEAda86OW2yVDmH+FixQo1WJm22MRIdHLlvPjS1tsWgr7vC9TMhBnIj5a2pe/PIR9nUs7505CmrGnd8uQsUzE1v+/qbWyNM7Eoj0jq4+b02SR/9JdMnP+XQp/O/JvCbOUBaZubr9v7niCT8Kudt9xMs02Uge2VsjoHp4DOnUYAMaFm8Obn7IKcnsisgm0R6YkCPIbi6GKKAUl83OsxyXYvRY1qWuh3GjM7JCMh69wJzJNoNXfNUNyH7ie+La2UpsiAlVBH9QTSeTj0Hcxxb6+rwhH489vYlvCAg== Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28) by MW3PR12MB4361.namprd12.prod.outlook.com (2603:10b6:303:5a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Wed, 14 Apr 2021 10:37:38 +0000 Received: from MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6c71:eb7f:ad9d:335b]) by MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6c71:eb7f:ad9d:335b%6]) with mapi id 15.20.4020.022; Wed, 14 Apr 2021 10:37:38 +0000 From: Haifei Luo To: NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Ori Kam , Slava Ovsiienko , Raslan Darawsheh , "Xueming(Steven) Li" , "ajit.khaparde@broadcom.com" , Xiaoyun Li , Matan Azrad , Shahaf Shuler , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH v5 1/3] ethdev: dump single flow rule Thread-Index: AQHXMRPGXDBfU+2T70+fW/oMCTp3K6qz0POAgAAAmwA= Date: Wed, 14 Apr 2021 10:37:38 +0000 Message-ID: References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <1618393890-205395-1-git-send-email-haifeil@nvidia.com> <1618393890-205395-2-git-send-email-haifeil@nvidia.com> <2287062.Ys29FK9Loc@thomas> In-Reply-To: <2287062.Ys29FK9Loc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [112.65.62.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49e94a1b-e9a9-4ce5-5824-08d8ff315313 x-ms-traffictypediagnostic: MW3PR12MB4361: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b36Ia4DsnQUsyrsdwSXV7LRl3zqgF34WhMdLVNatSDsMc9pWTd9rQREr6BH3FvQEn8sR6g5klvv5eNvyPdNFBDcnNdbkoj/k9jlXAV/Y8g1JLyRT+v5g6HZr4D8rw2BX/QgOEh87Ryy0bPePGS2A1Nvtwdj8sc5THHOWlh/InRNtyZ3clD8W54bQu6ZlQZkzuvHodULF4qlDdSp5IMcgUYMAL36f9OWDoLAJZlGCK9YotHUJ0g7pOtU580hYSKpnY7m8YQ0Eem8BZO8eDdwsvS04HeXBlTq3Hhh+bmEyLEefi4IZ3HCwQUE77icEGsMRVhViI4KqMtOmbHAP2FEI0o9PODEwQ/XOfSjE8v3JR0aXr55WksXE4c+LAbClxCEu3Y1WkvNWvlT268lxqd5+GqkuKnbufd+VDigv2AA03vBgJcn+jWepfqRM0EvNU8SePaXnKLfu5wpSkfwR6kLmGMlEDpzWKLfQx4GhSVL/yHtYNFIp9gs1EZTgtPxY2TK540T86Hzc8dZK4Z/1u4hk97iaV95kpSWk4/7FQimv2qDN8vBmJKWSS1TNhiRB317L+SsyI1IuD9FrSigpquVLyz9gKr0tVK2l02cLZ8hEWic= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR12MB4667.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(186003)(38100700002)(6916009)(33656002)(5660300002)(66446008)(55016002)(54906003)(4326008)(316002)(8676002)(8936002)(53546011)(7696005)(66476007)(6506007)(76116006)(64756008)(478600001)(66556008)(122000001)(26005)(83380400001)(86362001)(71200400001)(2906002)(66946007)(52536014)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qd2MtI8xufQn3DYqxsRMd/i14zmG5aufV4YfHz42lN8KW4KQ6s9vY4sHKV9C?= =?us-ascii?Q?0to1OwQUku5axRSbhV+eBLuUKAPfMXgbtO7PbXmkfEceYt+Hz+GdggzmfClO?= =?us-ascii?Q?0OY/+5Gw1srDNN8mP2IXeRxSZLvVkk7ku4lnw4Wv+hJy9ynlEsHbRDcT9nFR?= =?us-ascii?Q?A05jCnPGcIcAKpnEfy8Dq5gZP7lGkDu0UuNcxW49ZmBFEpO1+dfYWj1NzJgA?= =?us-ascii?Q?55DHIyDqAS7l+UgnXR/GnfuiROjHP7wb/9femPgKrtJu4Je6Ufit4vbTDEaW?= =?us-ascii?Q?I5rRsP+Eq4r2Ac/tnbY/Iad8PEyzX5olCWCj4xNVpU/pAo6p9azyv9Sc+55k?= =?us-ascii?Q?PJATXZK9G0NBCpN8ShvK/rW69FZ/ce9nbpsagxhYr/ySgBfwdYhd0dCBbxBY?= =?us-ascii?Q?hrjE7WcyT/qO27+sjPxUqRi+ulPl/ajygQK4O8FsQO6zL5ug/VeHDyiNXBMx?= =?us-ascii?Q?F1oEXQegNLLJEoQNw4yf2IcthRIRsr96y+dDxAJpaJD20xOfzEDyf6Z5GxBp?= =?us-ascii?Q?2+sJz9vA+TkcL00GDdYbO2MtTKhT8rzsu6PN96mvg1IRga5GF50XaIKo8959?= =?us-ascii?Q?uoF2R090KDLe58yb9/iS+iAOkHn/Dy9MEx6PQXFnutcVUtLlUoQPbtE7f3Ev?= =?us-ascii?Q?5GVjIFsfIODPwsu+Wv0xQOM6GA/LdJQKMWzoYjtCSgn0Nocn7egyh/0VQSJq?= =?us-ascii?Q?4RsGzyXlLaZp5DKh0zGVn0EDvp41LjD7JC7gX9Yhq8ABhFPUeY7CVGywiibJ?= =?us-ascii?Q?6EpcHIT3BaUkE1IYacTDIUMjmmgTree7VIktGaIwJpc5fbUmjeZ2WfTjYo1/?= =?us-ascii?Q?Zk3sILsyUXATkGy4fsifPf5pRi7FnIowJUtCbpGwLPrbiffapx1UVR7AovB8?= =?us-ascii?Q?0SqTKlnNA5wnacUS6SJSax22r37Y85w0Lg4hWm6UKMem5wYAu96o7AJdSqZg?= =?us-ascii?Q?oApY+Qdlq6t0mq/4YCumyNfRJP3z4pmshXKF2tLtB220aiMpDe8jNfQZNLR/?= =?us-ascii?Q?BviYBOs7lgW1WsEZpf4exnpZEfWIrx+LDnwRKZGFRa9+myRQFZNIR98FN4sS?= =?us-ascii?Q?zD+PGckIZHpoOUpiFQfWf2CQ/kcEccq6PsTwixYmbhOxqhhdeFiuvQLQXS/a?= =?us-ascii?Q?zkIpS4EiHoMFNAKHWgF7sKzMALSlCQVD5nce4X2PbfEyGSoQEbCV9P2O6iIJ?= =?us-ascii?Q?gS8DmeKCA/fSonH0tsPy/lA2Hft41hjpoP0jSJdTl1BJ/bxBwLv0k+Psd1tw?= =?us-ascii?Q?syyh5oYvSIkpSmns35XVGkLKDxueZyS1L+yAFK58ue3dOfaX2XLFYo/1WSY4?= =?us-ascii?Q?a3g=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49e94a1b-e9a9-4ce5-5824-08d8ff315313 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 10:37:38.3213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u5eOgn8gGklWh67RQehtZLQLlqnWXz0b1KAZOjUB8Gqjzm2v2EgiH7hUMWFT7LDEA5AdmGg7+rMoQA4oBnnvjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4361 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: dump single flow rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Thomas, #1, okay. Will change the place for comments. #2, yes, I can change the description. Thank you so much. -----Original Message----- From: Thomas Monjalon =20 Sent: Wednesday, April 14, 2021 6:33 PM To: Haifei Luo Cc: dev@dpdk.org; Ori Kam ; Slava Ovsiienko ; Raslan Darawsheh ; Xueming(Steven) Li ; Haifei Luo ; ajit.khaparde@broadcom.= com; Xiaoyun Li ; Matan Azrad ; Sha= haf Shuler ; Jerin Jacob ; Nithin D= abilpuram ; Kiran Kumar K ; Ferruh Yigit ; Andrew Rybchenko Subject: Re: [PATCH v5 1/3] ethdev: dump single flow rule External email: Use caution opening links or attachments 14/04/2021 11:51, Haifei Luo: > Previous implementations support dump all the flows. Add new arg=20 > rte_flow in rte_flow_dev_dump to dump one flow. Rewording: The API supported dumping all the flow rules. A parameter is added to allow dumping a specific flow rule. > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -1837,13 +1837,16 @@ all flows with assistance of external tools. > > .. code-block:: console > > - testpmd> flow dump > + To dump all flows: > + testpmd> flow dump all > + and dump one flow: > + testpmd> flow dump rule Comments should not be in the code block. > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -3232,6 +3232,8 @@ enum rte_flow_conv_op { > * > * @param[in] port_id > * The port identifier of the Ethernet device. > + * @param[in] flow > + * The pointer of flow rule to dump. Dump all rules if NULL. Sorry for not making it explicit, when fixing "rte flow" I thought you would replace it also above in the exi= sting function description. I think "The pointer of" is useless in general but I'm OK if you want to k= eep it. To Ferruh and Andrew: we could make the ethdev API description lighter and = more pleasant to read.