From: Volodymyr Fialko <vfialko@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
Reshma Pattan <reshma.pattan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: RE: [EXT] Re: [PATCH] reorder: fix registration of dynamic field in mbuf
Date: Mon, 13 Mar 2023 13:08:40 +0000 [thread overview]
Message-ID: <MW2PR18MB2282A6590B3DF0595AB70A4BA8B99@MW2PR18MB2282.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8x6Oxr1nnR62vdLR+R+dNN0HG4hE_gbRCQQrb+8q6fPCg@mail.gmail.com>
> All rte_reorder_buffer objects need to go through rte_reorder_init().
> You can check rte_reorder_init() return code.
Hi David,
I agree with all comments, however there is one catch with locks.
Both reorder lib and mbuf dynamic field are using `rte_mcfg_tailq` read/write lock for synchronization, so
I moved alloc+init before lock+insert to avoid deadlocking in v2. Let me know if you see any issues with this approach.
next prev parent reply other threads:[~2023-03-13 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 9:34 Volodymyr Fialko
2023-03-13 10:19 ` David Marchand
2023-03-13 13:08 ` Volodymyr Fialko [this message]
2023-03-13 13:04 ` [PATCH v2] " Volodymyr Fialko
2023-03-15 15:29 ` Volodymyr Fialko
2023-03-15 15:43 ` David Marchand
2023-03-15 15:46 ` Pattan, Reshma
2023-03-16 15:36 ` David Marchand
2023-03-16 15:55 ` David Marchand
2023-03-13 15:51 ` [PATCH] " Stephen Hemminger
2023-03-13 17:29 ` [EXT] " Volodymyr Fialko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR18MB2282A6590B3DF0595AB70A4BA8B99@MW2PR18MB2282.namprd18.prod.outlook.com \
--to=vfialko@marvell.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).