From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 657D741EA1;
Wed, 15 Mar 2023 16:29:44 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 450E740A7A;
Wed, 15 Mar 2023 16:29:44 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174])
by mails.dpdk.org (Postfix) with ESMTP id 1E7EF40141;
Wed, 15 Mar 2023 16:29:42 +0100 (CET)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
32FE0p2C018063; Wed, 15 Mar 2023 08:29:42 -0700
Received: from nam12-bn8-obe.outbound.protection.outlook.com
(mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172])
by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3pbav61h8b-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Wed, 15 Mar 2023 08:29:41 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=k4wihcieFymkR7LwjFxqzmV+4WnoUYLzg/MDZgjpNVh712wlvt/o9VEAXfIVL0xDmEpr2kcoHGyx7Mnz/0Fysrr8wOniv5qaJzdFuo/w15lWgeaI7zE2rVeV1H6V9nNi5UeYvMtMZq5P5fIfaFuBVutqCbqNQ3Yt8NCJGQ2yu26xJrU+nI1mLTYbC0e01hKbuCCJLvPXAHDMglbJJXpAP5hgONnej+s6f+KhPJJHAv9K+aItBjnADcOkxAeIokdYUrGsWznEuCQZb4mS5KD4pBP57sGenp+Dhr/BMSnl5fVfNwRISsdcsDjawEXWldKU4w9iX5b7VVZqLFj578l5LQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=RspEKLOrlhCNWgi/rjLIZBcZzlO+8dS3mPLEuIxxqu8=;
b=IM7wMkE/NnLKDC10vkApypiaO93ddQwQV75YYK8g7FaGh2s4vHvlYjtRlhAHSL1Jwj99dKx/pMzb8rTcZod/VnH4etDOtyzobza94fHE766+sEx9wzGK3bIBN3hwxA7OVUJReFmpMLTHqrQWVqdzKkftzoYx1IenGtx6Z6DFTjMZfIFBQa+9vXhzPxVFSPbz3FMm/0JiYn7A/I8Whpt+t75g8YyYhjwbDWVLVPrZP+aqRTOv/eUv7pLQ4g3nZmLJAr6JVYmDrVQZAgZZ7fst7ddrmWd5AqsktacTNfXk3jV0PKcxvyx7BB1YMk5wG7ZFgFPMlXRk9cnCiFbD1TJ6qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=RspEKLOrlhCNWgi/rjLIZBcZzlO+8dS3mPLEuIxxqu8=;
b=gFlEnyFluy4crvSQmcfM5QnHJuQnRQxl71hRCur6uGhiFhE1XWZiG91hUmKwpdE7YiUem5jUXipery4Zp/iXDFfOMP0bVNhA5wxTDSxFnPiJnkBT1b5zWTxd+amYDAZQY42dA/vkm40co98jBsdu+n0QXJpUZmsw3ev67G4Lst8=
Received: from MW2PR18MB2282.namprd18.prod.outlook.com (2603:10b6:907:f::19)
by PH0PR18MB4544.namprd18.prod.outlook.com (2603:10b6:510:af::13) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar
2023 15:29:38 +0000
Received: from MW2PR18MB2282.namprd18.prod.outlook.com
([fe80::e0e0:c7fe:674e:ed00]) by MW2PR18MB2282.namprd18.prod.outlook.com
([fe80::e0e0:c7fe:674e:ed00%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023
15:29:37 +0000
From: Volodymyr Fialko <vfialko@marvell.com>
To: Volodymyr Fialko <vfialko@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
Reshma Pattan <reshma.pattan@intel.com>, David Marchand
<david.marchand@redhat.com>, Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru>, Stephen Hemminger
<stephen@networkplumber.org>
CC: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Anoob Joseph
<anoobj@marvell.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] reorder: fix registration of dynamic field in mbuf
Thread-Topic: [PATCH v2] reorder: fix registration of dynamic field in mbuf
Thread-Index: AQHZVaxgIeuaVgq3pkSbvDvbfi5WhK77+EOA
Date: Wed, 15 Mar 2023 15:29:37 +0000
Message-ID: <MW2PR18MB2282C331A6EC9744D192BCA9A8BF9@MW2PR18MB2282.namprd18.prod.outlook.com>
References: <20230313093450.2560058-1-vfialko@marvell.com>
<20230313130428.2650232-1-vfialko@marvell.com>
In-Reply-To: <20230313130428.2650232-1-vfialko@marvell.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MW2PR18MB2282:EE_|PH0PR18MB4544:EE_
x-ms-office365-filtering-correlation-id: 086050fa-1c12-45b0-28f6-08db256a167a
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: V+4aH7KHUbPRs2ppekT4hHbtZfCS7diP8YwqPIrxiYSWuJcmQ2X0+bIqwNVH9Sixc5wd14HH1k+mr9nL2Mc+mFRiaLzlRBsp3UnTEI9+kSxuwJ8TnzV+0TM5v+sLpYCm1KucV2Hk0xu2/rb2IJaTIqrYwlYeewkDIitvbHZ4dFhD3sH86G0N1U92GwGKKL+2sGL0QDmJsiXwLHvEU/gpP2211uSuDNweSFSslCmIkIjnfYr0eDKIdWfwSzSz13YYwNklMtBEgnmMVlFSi7QQw44XHmfV8ElUBZhld+Xs1e85STslrXOt98vgFr76LeRTmt0ZsGXMS8oSEWtlI8gukzHqxqUxaWcxVtSF6dl6eVmMQBs3tclrBptrvBj2OsEYOc60Y5fTrmomi/jFtDi8jruMD0y+OucsOFuxvKcduKhUG0eT3h6J8DAZsX/bI9Aswov4oPpeDN8f/WQjusJI9YCYonsNsRY3IYNXo6ck9iJGq0mMSE8Zp+1ifdECqcVavRpZj+S6VYqFUNUcHnaIj8Bh3vj9oX7P7iGM750pq72mz82BbBq6LWp98YgMEtUQvfK8fMMKYlA8i9/Y2odOqsmqs1Hv83g0qTdl0DinPR7TgnRC+eJ2Ocxpvb0t8YcZAf7flZ2xXa0PygURp16or3UGqQvNIZ53+D1yzwvRYYQTq+4Q9BXgwwvd89zJElDxhAqHaFd6ISlRhuHx6dZTOQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MW2PR18MB2282.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230025)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199018)(478600001)(83380400001)(186003)(71200400001)(53546011)(6506007)(8676002)(9686003)(54906003)(76116006)(110136005)(316002)(66946007)(26005)(7696005)(66476007)(64756008)(66446008)(66556008)(4326008)(41300700001)(52536014)(8936002)(5660300002)(38100700002)(122000001)(2906002)(55016003)(86362001)(38070700005)(33656002);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UQpiE8V6SuT2Uu/nM3zaIG5xFqy0215hmczzgZmbUZz+K0EtzKLCAQxZE2Dd?=
=?us-ascii?Q?BwDl+jDD2zqedN1UbT4kWqnYUyA7OQElOYkGQhJaIHyylY5agCZSV27r9K98?=
=?us-ascii?Q?2OC2aSp9ColVRWyJ/nouFMiIB7EjUq1N6SMt61cWZmfISmBklD1UimV4HbK9?=
=?us-ascii?Q?BZoMp4LXYzdHH3Fp/0XvgedHRg7BJgCDb5bUmdVxj/pOYshI1zqSCJxN9fQG?=
=?us-ascii?Q?QL4q1dnhpX+U36sPbTiLkiT717hgs3jVvynfArSCtNx/aUo+0n+QvbVWPXVs?=
=?us-ascii?Q?vo73U3pGeZq/827s8VsS6alNF7jKkBvTgdd05cF3OPMrNB6yrBOAVevbP4+Y?=
=?us-ascii?Q?v5O9Y9wiDIbb0iNFF+rec+8eAAfhXhuCQjqeHO+blJeXVaorzFl58NscbPOE?=
=?us-ascii?Q?NMDU2T7QhO7GERcenjHVi9KZMyW1D4zGfv0oWjfbHfL6IxiL0th6Mtjyu2/0?=
=?us-ascii?Q?4oiuVRjNic/iZe5FTRsxTWzMfFmqVUswAJUyInYYrEu/HjOb4O+FSdfeP1Ym?=
=?us-ascii?Q?EK49UkSy5IvlwPLBhU6zdnmpJh0/xjG9M6B63vLnDpC4mT7E6skhVHLtaJ/O?=
=?us-ascii?Q?0mwU78ryZQYFZxdUYQjbHk/YFW15sH97H1NAY68vSVQxeNvJIcipF52bwAlY?=
=?us-ascii?Q?XHYRjw6K1QT8B6twHrAc7wKdSTlsaZPJZcMoZry8Ma9UxE1z7dvmHFC8pBlW?=
=?us-ascii?Q?a8TLj/+sGcQJdBa31O9DVbqwJuLQxt5Ig5lnNzn0iLUy49BSXAPSvcbjL7/v?=
=?us-ascii?Q?PczFqZB5Oc0BwqcSfRP5yORgwFDCfjgShhYJtKgcViWUMyw3UcvGQAOwSgez?=
=?us-ascii?Q?8N6YLiVAx23Fd5ZkcbjwD6ptnRECS6i+iVrVJieHgpjaSY6qUZGA8Wx8OuEm?=
=?us-ascii?Q?fkit0byBau60q7BvIwB2iu14wtSVBGXMr4TUSFdVF4TmGlfI4SIi3TIvZENw?=
=?us-ascii?Q?L2qcsI5QWRP73q/FH3P9LnZOSiR+wadHOxtAJ7J7Xh0YtAWMXjIvwyMR8DFV?=
=?us-ascii?Q?W/Z1IXeqQkIgVlt/P4LYL+Ih8SOtME6FizCCQQmBzhy0f8rfG1aJHckp9WAm?=
=?us-ascii?Q?YaJQZj9bHPByYPMgErfIQ5m4IIwft1Ob05iIHrXOTcSddv2eDBBie3Mp/bzO?=
=?us-ascii?Q?cOoGVAwIeSIv3TaopxYCq4q9FJTLmcQDAHyG2nTU7/Ki5h77+vwnazgcL50W?=
=?us-ascii?Q?eXzV64FlHmaLiCF5n2Sd13pgrOufPMLoZ8I4SL86n5ufTp2reLJZW/6hD+Fw?=
=?us-ascii?Q?EguJi687O7FPO8ivS03ELS06MFFuZA69YQt3yi5/yYxHpzJ/fveTg7+Y/gfB?=
=?us-ascii?Q?aNk8+8sl57gqKglLiHLddlw7CVQbhKRx494gmvRn/vaqtc5jCMadiwLJ15Tk?=
=?us-ascii?Q?UVjQtIVch4zEefh6ACYRKtNuF85W4nGiPBROf3rjD6ou8nvYX3FxM28ITcMk?=
=?us-ascii?Q?Z1oO2IJBkWXTaFpLzihHcKBeBiXmmwFjo2UBdOh5gNruCkUbw7s+DIIlgVPn?=
=?us-ascii?Q?miRW6Xj/i426fUb0uNcCGfIC44HzVu8zF/8IFDtUXsG+zX6ZfXkG1SYPhdaO?=
=?us-ascii?Q?4sUdNzNOZ7br8SGY7I2HhQ2UtqlbERrJPM4N/Rp3?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2282.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 086050fa-1c12-45b0-28f6-08db256a167a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 15:29:37.6766 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F3jH9+VInt/6KNllmQJQyGCgwnqr/JRt7cCV/EoTQ1pdrD8n6S1thP4xcY1qZCPZ5lI7Pa7zUCWRtgi5gfy6pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4544
X-Proofpoint-ORIG-GUID: Onfoy9m5xcRuJ40tdU4Ef_4NPPlxPnLw
X-Proofpoint-GUID: Onfoy9m5xcRuJ40tdU4Ef_4NPPlxPnLw
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
definitions=2023-03-15_08,2023-03-15_01,2023-02-09_01
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Hi,
A gentle reminder, please review and ack/comment.
Can we have this merged before RC3?
> -----Original Message-----
> From: Volodymyr Fialko <vfialko@marvell.com>
> Sent: Monday, March 13, 2023 2:04 PM
> To: dev@dpdk.org; Reshma Pattan <reshma.pattan@intel.com>; David Marchand
> <david.marchand@redhat.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs=
.ru>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Anoob Joseph <anoobj@=
marvell.com>; Volodymyr
> Fialko <vfialko@marvell.com>; stable@dpdk.org
> Subject: [PATCH v2] reorder: fix registration of dynamic field in mbuf
>=20
> It's possible to initialize reorder buffer with user allocated memory via
> rte_reorder_init() function. In such case rte_reorder_create() is not req=
uired and reorder dynamic field in
> rte_mbuf will not be registered.
>=20
> Both reorder lib and mbuf dynamic field are using `rte_mcfg_tailq` read/w=
rite lock for synchronization, to
> avoid deadlocking move reorder buffer initialization before queue inserti=
on.
>=20
> Fixes: 01f3496695b5 ("reorder: switch sequence number to dynamic mbuf fie=
ld")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
> lib/reorder/rte_reorder.c | 94 +++++++++++++++++++++++++--------------
> lib/reorder/rte_reorder.h | 1 +
> 2 files changed, 61 insertions(+), 34 deletions(-)
<snip>