From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75E88A0548; Sun, 9 May 2021 11:32:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9D0A406FF; Sun, 9 May 2021 11:32:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id F1EA440140 for ; Sun, 9 May 2021 11:32:48 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1499Rvbc004058; Sun, 9 May 2021 02:32:47 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0a-0016f401.pphosted.com with ESMTP id 38dr0qk79s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 09 May 2021 02:32:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P3GWJQfuz02q/eOev1YNnoE56q4cMwSBVBEB6rjV9v4YEpCwXbSUO1afsvVgbMwaNSEs1mwLcjNkbANFi5f/Sga3E7B/hwN4+bH/POIunEm6cU93+L3KF3jZlzCnTnKV7H26OvPPkJL3N/QfhblMQL4UYHQA+x9Jo0fXrm/Q0cu4OcQPrwM3mhdQx75AM0DE7FlDnHzA/RkUWNZdPq4d/nfwomaGYos3Kvdd+b9AMXsNEjprfZ5egrILW3DifKplwxzpPnpA7wDWlyQhacDhAnltSLXtCZCzqcB+zHNugZaDma0WKMG/A2wE0ihtoOs4XnYrL24YLvSue6/dh6Y+Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTY04j5AjW3Ct38lhuuKmX0nwRpmkWeA+p09gJdUgoU=; b=WA7rDa0vyzm0lBHRz2hSmnIU5ovgXXY+85g8xu70m8IJlmJ/aucC/SGGbb2XbakMmWHAuboAuu7v7/cwwZgRCqUlRgRaOLnk5O/iYENj1PkovEt2XYwvJcRif1RAOohPjT3i2HTYbLlfG/Zd94tl/ZCYPkpW7N9XWXp96ArCLqE1+edDQUF1ABVG8d3fMB02s5BkpOIZLAadpZCRa6+KXM+1wUpijoIhCGMBcjOqsa3BhksPGbkndayaz99PQ5ib+4HNFlIzItnfRFS3ta3gqdblkfQ0WEWKaXoOwP5jQN4bnPogJYy4AoaXwgr/FEdigh/XeuxVckEFnvHNFrJcow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTY04j5AjW3Ct38lhuuKmX0nwRpmkWeA+p09gJdUgoU=; b=H10ueOpqN9HgZfDFp0A2nVv9xAB0iPVmJcsvo2tDtknlnVO+ILH1KwMMHN2fV8Wjyh6I7mgg4CVOWKvW/VHDXLmDWWpQXyireOA20ccTHoPzcDMH8n7SD+xiXQwOROvHt0hgibq7Qk9KctI/Nnt2IaJZ8IXtNHTduPyyno0VyjE= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1310.namprd18.prod.outlook.com (2603:10b6:320:2b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.30; Sun, 9 May 2021 09:32:45 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4108.031; Sun, 9 May 2021 09:32:45 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXQSnFSYNEr5fXDUSAriS5cqzCearZVWyQgAF3JoCAABqFwA== Date: Sun, 9 May 2021 09:32:45 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-2-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d74fd250-60d3-4dbb-2c08-08d912cd66d2 x-ms-traffictypediagnostic: MWHPR18MB1310: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nrpcSxS0Sj5x0eGswsUJDuU9ttuN30CrnHoq/b7lnwJ8UGIAeQgOtLW+dHp+JiZv2TotPq5F3dEE8S33G5ZbKzkYmSybv0nso6DRrDUew53UYJPP7twHU9OuPVGlthE1TGehFiYdqh3AQKWEnyd6arINK8hQQ9rlY5PXSq10nLqdbpC7jGwzNDUduV69LyBZ4+HrSpdrrzhtpm1aQq4qyy43H5q1rVk1htEgl8PY1PCD6BjcSLdPjkGqZi7h7wbTMr8uUZZdnHH3spC7SkukUYxgKumzfS/StZX018STxd1KZHQZbxnzNC3PA64nPH3ifOHqCwCq4MX6NKBTqi82TIVQTdu8A+BKslr/gOACf8IQrWc+m7n1q1BjKjpuKu4mxp1BISe9SvMlWCcBYViD2eYrgDb0xOSS6duC30cWUSE0ADIxFrZcNG2wIbczvD6j/v5pfA/DR0QkjK2ct87gpsB6yOxUTZUeZmny9owHzDd75TaWq3zNay8wrmfTmIYvS3emxnRAzG517bkY6Bf372Et5UpYwiqYwNdmQ80SUo+Nn6W4fl5gkh7Z8KqJhczphFRNlpGvArsm/viuv0e+TIkEmyQQAR/dZrDbgyc4Vqg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(396003)(366004)(346002)(376002)(71200400001)(5660300002)(7696005)(9686003)(8936002)(38100700002)(4326008)(122000001)(186003)(478600001)(52536014)(66476007)(4744005)(86362001)(6506007)(8676002)(2906002)(110136005)(66446008)(64756008)(66556008)(55016002)(54906003)(316002)(76116006)(33656002)(26005)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FFJEgxA4QcUd87aqGASTSGYXjMeKLaLJzGZLqTHnKg71fZkJcPDvHS2uqiIO?= =?us-ascii?Q?hAM3IaYzVtpN0knOA+YSiITe4nUlksGUxRCarJ6rB6y07bKX9E0W3fnM7Ds+?= =?us-ascii?Q?IjEotNTSW5qpDdy0nl+Tod60e3i6D76veUEOnbe6kympPvxurwmpU13Ihg+n?= =?us-ascii?Q?zKNIVpqMrL5tfePry+C2RGGQY7oAI3IBmN1CNODZFfERF8MRgjXArfNlPRGL?= =?us-ascii?Q?7KQTz0wcM4ziq5/sjjC6oRsN8m7O8wgOa/alrnHAD9itPh1KQQBtbuBCL/NW?= =?us-ascii?Q?00vhCRYpXoQ6dT0UOrWUOd5/r/r3jw9cbTSf6hy8G7z3hOtA3QDp4jX/U18T?= =?us-ascii?Q?85m23WO+c7CUEQR2BtWwroHr4zVcyXHQoUK/8XbC9huAtyURw3MOxK9rm6b8?= =?us-ascii?Q?992d87jxgSp0SAQP8MmM3SIIdOV4OicK8pKKwZocJtVxrP6GVbVy1g1em/uT?= =?us-ascii?Q?Q/6Dej0oWR4Qz/3WFbgFQZB7CHpan58FDsy0/KD/aNkXxLFHcLJ+FV54UIA3?= =?us-ascii?Q?A/JpSiE4rLXhxhaSPuWTtamdMj06Mgz0dw80mnAFe9G2MtKxad9YRuhzXrhP?= =?us-ascii?Q?cz9hAaHM9+m/yL4LmlU0dc7aGA+fwFEjmv0DKF/wN2CqO/olVQrCZiINZvpP?= =?us-ascii?Q?6F36m6YrafW1sBcdWZowU/WI4pPvYK+3s997ZAvgqG7Nb91LLBx5MMckLhMM?= =?us-ascii?Q?r5Nnh0Zro8a0hbcgiIHWNbw55VlbVzY7h9XpkREjfkHRK2E8DFOwWpsR7xqB?= =?us-ascii?Q?laPQ02lASiO5oQpToPi3OuY7R7mm1GlkJKi+ALvSEcBQ5MwJ65SRSJHnJhkg?= =?us-ascii?Q?t0Y2iiWHCLleAWUlbuA4MqzlpuJGWlOGz1qKpdPC0LPyydvdlqLYiZyZL8Em?= =?us-ascii?Q?RDBS7hohWf9T4LUrsBhiTtX++kRJVyEYR46Bc5mUyetVCr0W9A9au0F7yuoO?= =?us-ascii?Q?ZuzLGy3Mz/E+rUTnnoFkGiAvPZnH3PjH037k8KYHJkSYOXA9FVF+XZAtqOok?= =?us-ascii?Q?NHiSYGt65Ji0n/AYCYeqhD8rYdI7J2o1qNlV+Kn/dDPhgygBvZhXkcweFVh1?= =?us-ascii?Q?/lMkdG/ROi3/68P/XQa0QrtTxDNxTPRquRZ4upwrfegBvz38pGyozW83yRjl?= =?us-ascii?Q?8wCirbWZYSzJMkgn1v6GQxvpuQneDu0HdmrV2vgvDAY3HfDaeDG1hJFblzct?= =?us-ascii?Q?iMJyeIs4MqwcyreE9htz88qRsw/mDpSRz2E6GOEhhkU05nvtIGgW0tKFg8bx?= =?us-ascii?Q?N7g7Gyuef8AvT1qGliUvf5sLgQLLi7sMDJMpGJQlhTL6s/cVDVATOl6m/pB9?= =?us-ascii?Q?BS8=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d74fd250-60d3-4dbb-2c08-08d912cd66d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 09:32:45.0892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ge5+5AlhMipXCgeY8DNwoVPqIHeyzzJnTgTuvyyfmcjQp33x/jBZ+mP6WRKuNZtFrtvhScbJMQVMVuLOaMoO8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1310 X-Proofpoint-GUID: GhdAShVxv-ImtUFcVCjORKHhzYP3CQyA X-Proofpoint-ORIG-GUID: GhdAShVxv-ImtUFcVCjORKHhzYP3CQyA X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-09_06:2021-05-06, 2021-05-09 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > + > > > +fmt_name =3D 'mlx5_crypto' > > > +deps +=3D ['common_mlx5', 'eal', 'cryptodev'] > > > > I don't see a reason for eal dependency. Do you really need it? >=20 > See RTE_LOG_REGISTER. Compilation works fine even after removing this dependency. I believe it is internally managed in cryptodev. >=20 > > > +sources =3D files( > > > + 'mlx5_crypto.c', > > > +) > > > +cflags_options =3D [ > > > + '-std=3Dc11', > > > + '-Wno-strict-prototypes', > > > + '-D_BSD_SOURCE', > > > + '-D_DEFAULT_SOURCE', > > > + '-D_XOPEN_SOURCE=3D600', > > > +] > > > > Any specific reason to use '-Wno-strict-prototypes' > > Compilation works without this as well. >=20 > We use it in Mellanox driver usually. > This is internal mlx5 code convention. >=20 Ok.