From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BD60A0524; Tue, 13 Apr 2021 12:19:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D239A160DDC; Tue, 13 Apr 2021 12:19:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2109F160DDB for ; Tue, 13 Apr 2021 12:19:56 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13DAFEL7029625; Tue, 13 Apr 2021 03:19:56 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by mx0a-0016f401.pphosted.com with ESMTP id 37w6vugh1w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 03:19:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YrW4SA7qq6Sjr8lzO6WyNFlPtlPn9m77LYxqJLFA1CkvZPnWUq4tLDBIm24OlQ3TPOxMOHeMdsvGNoOc1omUcAnjDzOKnJezTcmFwBGld5fbwr5zjQogL8eAGg8bEpZpzzXVvGcV3EGCZbaSxpuKcoL3r8szCgwQWCgtRY+YCDGTdhUHkk/h5aCrIZAIX7AjZ820I97lszQf8sCMwf/qscCoKxvvL4VUJYcDV+G/VQmA6MaY2eDxttyi1eEcc9HHaNuiywPoWREhTLkJbq3lL2bMw8J8XJ3Pjh+SeAF6QlS1oZrNmNh2GW8PVwtypTtBrBijzBODOhQnvAum+oWnpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tt3H4SdJdcQ8jbNQYSnZVnTgA4cMcdrcb/RwKWHAlMQ=; b=MiDRp3DibK7EbLsVAnINdIkFPgqHT3ALS6iVwEhZfu4azKRibR5+L3Xa/Wh8Fr63HrSR/dkMWF8owqtmHQz42h9/OD6d0oNss2dtZeV+BqZDe5sCM/psf9bYKRGt0dU4VzP5CQB83m/DRKyqWLDo/Dde3vtvmFVvDMw8U9i+TGoTR6vGNzIKII0iTumcUmBMXsvIZ9zQ3wvevIAbzsGTkVX96SoMI2xv6K8P4UoI7WnErIFcTgMgZilKNERkDmrEFKZEI/nCfcbwr0a08q3a175WdeDD+F3zWDhbrWdpYDJfvIw/hi+5g0h7QYPNepvUCSrpegGGR5puvsB39F8n3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tt3H4SdJdcQ8jbNQYSnZVnTgA4cMcdrcb/RwKWHAlMQ=; b=gAlykm7RYzti7Bxo+RD/XQIiO8eraHGLPVGxr1LU3pnuc0gVlPIUWE3nmi6Xb5VCS6zt4uv0o3Op/RqoG6IP+7YkW9BjqBEhprGJ5p3Hmm6RxMByWFmje4+G9wkleh9HwZNPr6uBGWH0OpaRWcol2uwV9E0tnLNhB9rMFtYlouY= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR1801MB1936.namprd18.prod.outlook.com (2603:10b6:301:68::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Tue, 13 Apr 2021 10:19:52 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 10:19:52 +0000 From: Akhil Goyal To: Fan Zhang , "dev@dpdk.org" Thread-Topic: [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API Thread-Index: AQHXJlIz4sZI+IxaZUOOne7IJxDey6qyTy5Q Date: Tue, 13 Apr 2021 10:19:52 +0000 Message-ID: References: <20210316111455.509633-1-roy.fan.zhang@intel.com> <20210331172038.1718973-1-roy.fan.zhang@intel.com> In-Reply-To: <20210331172038.1718973-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7756253e-7e1b-48f4-1550-08d8fe65ad6b x-ms-traffictypediagnostic: MWHPR1801MB1936: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uoU4Dm2ZC4RYVy0jQmCmAdz5YnCH8KNj0pgIFQ4LDa0645ODuvPcry00R1aAOrHePftfFe3hrwEkX+zCo8XC+vFmJIRoovIL6dOn2kuunQ0tnJeLLr8hwPLIgjboR5USwOQScJXsy6GQo7JIwqSMDcLnN4Wcx37AzYuYuLAUkNwjQ6E6vue84xVEgTYYsJR4/TjHrnjMStmNQavGOczHPsYqivb99Mv5wDxfLd/dBP8UIE8eHnY4a2I44bnkT8NZEH49QYXQ7M5rVxImdcMZvCgoeN5y/BBBHjEUsuD+UrPKa8cPBpFCU3NKGrSMrLYoCAb2Ka/GRRvQb/HtWKgzgsu4A+Tfv5LpJnWaKyqsLF3dn+kjVeapJFlIPt7aeDrRmlhImjK+7cgx8I1U8IHu3ozKI2F/74cUQs+9SCHgV0tzpmA7BPLhT7zd7tyCpWidFuqTwIWsV+JqxbBP0rmUXmpJQztMMKY4KvRnz+VVTcTh/om/5lySzwljDu5oRLW+lK55WulpV09tPy9ToDpR0GRDudLNz/MmxzVsFv7YKa/i86aPH5CTLfVypc7DZ9s5iSchLnu5K7X4TjSKNKGrawTVSCw7wAvVXSBVFcO4y5A= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(66446008)(52536014)(5660300002)(6506007)(66556008)(316002)(76116006)(478600001)(64756008)(66476007)(122000001)(8676002)(71200400001)(55016002)(86362001)(66946007)(8936002)(2906002)(9686003)(186003)(7696005)(110136005)(83380400001)(33656002)(38100700002)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8EMkO5HOsYIJAMQBiZBhoIXvYrtaUe1BSsoxEZgvNuibr5veVRsUmYTQKGuJ?= =?us-ascii?Q?Kdpsbd3PyYjhvPQYUE+2erKhpqO99afwmfmsAC52eSe+I1yuzstkCI9q4uZf?= =?us-ascii?Q?twcsuuSA7BQ9g86dJhtX1LsmXsCxQ0KCif/S5I5LD9pqceF4fKT7nk7X/BVh?= =?us-ascii?Q?swIdZ9lfQSX8qW2aLuypJMZf4PxGzGY/hh7JN0F2P0IuKFr1r7mT40mGYpD+?= =?us-ascii?Q?cKqNOYB7X55Kw4X+oWmSDbnFRU0zoT/S56nD/qV7can8zM019tKqz9nrpioj?= =?us-ascii?Q?QE6ZJDSJVRoQxz0LURaDTJQ4MumjDPwJyk/AWpgV1K55DETPACiCU21zboNF?= =?us-ascii?Q?YkZoGBcmowsxoMgP3FDMvx9eCYM8X4fqKloi7RGjXztgRvJ/ogh7SEM1dWMT?= =?us-ascii?Q?Qv1xQK89KGeKoe63Ev6f2Htk3wpQ7GlnZxFjdz+3SKm8GwJyv+CniEBeq0Ey?= =?us-ascii?Q?RR03PBpCHZuIAZnKr/Z+iB803TFKHNXhUNZ6iaeMMBwLl1S3PQuFAgc1wrZB?= =?us-ascii?Q?AjNfXkDhDhRjm+v0OFeZiWi2oBVooI/36CQKtoMcxtsjZ0JxSdGJCIreJcji?= =?us-ascii?Q?E7j/z2ifQBthHrRsSkymtIL3+DpeVXI1adrRoMC4/VXIi9hJr1QERnbdZnH+?= =?us-ascii?Q?uMYGgqyyHi7FJkzFHHSjqseRpiB57VJBu18kNjYfR9gNwK2sm+Mb9zSe/jc7?= =?us-ascii?Q?IcmmZ4aSJnF0rHmjjS2Ad9Mm6seFZY2RclFKtAdtoPd5odZx7nXF89fBZokr?= =?us-ascii?Q?qi5kNAwU231ARuSrICaLYiZfKCrdztorkfZpaOGeptl0t/hQouOPdZe6H+/K?= =?us-ascii?Q?bkT1xcZp+tKNZNMArxhAHJHqW93KMA7I988CWjC8Y1uRN67F6sL/AK+Goaa5?= =?us-ascii?Q?pnE64efyhyjBWrz/llcNxdDD3R6NHUMO9PlH0T8dXjLXaTRM5JHT3235gS9I?= =?us-ascii?Q?whAJlm00aPW67W3Ot8F3v2EtKqkqJx4LEnQpQ6Ej7Q20vcHD9g3jLj2Hld6I?= =?us-ascii?Q?8e36Ar4mfgW8HIh8uGzSLiIHMNfuvzB5Beu1CfPX1ciHmxt1XxKzUsdFY+U+?= =?us-ascii?Q?9Xnd04Va4RoSaqJPim0FWaQytFM+WvsWmJsiS6DWZo4+kQym4nxpgGcZsStw?= =?us-ascii?Q?JECToBtE22W0Yer6JoS5XR25PlB5n7lHLtv2GbVIUfPbuMAsmI2ph2boSlaH?= =?us-ascii?Q?XZtZHsAAIxO0yfBqy8oDcMGtoCiL7ePpcGuXIVkkj6FQ05IGTZK50Ok9Hhm4?= =?us-ascii?Q?+mzOZAFsaic9Z2fvzGyWq5uBMMnTaKY9eyCyA+Q83gxWtt/FnHSIpbCorSie?= =?us-ascii?Q?VSk=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7756253e-7e1b-48f4-1550-08d8fe65ad6b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 10:19:52.5634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rF7bXxEUgI6l8XFsWNQwxUwnUk5FixfPQJnVfcm7JeExzn78uGHGVjuIbm13+0WXaxmGJV1uTo/2DVCOR3tiuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1936 X-Proofpoint-GUID: hH62NqEdo2zwUFuQOrcEAzjb-C6ooIp8 X-Proofpoint-ORIG-GUID: hH62NqEdo2zwUFuQOrcEAzjb-C6ooIp8 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-13_04:2021-04-13, 2021-04-13 signatures=0 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, > This patch changes the experimental raw data path dequeue burst API. > Originally the API enforces the user to provide callback function > to get maximum dequeue count. This change gives the user one more > option to pass directly the expected dequeue count. >=20 > Signed-off-by: Fan Zhang > --- > app/test/test_cryptodev.c | 8 +------- > doc/guides/rel_notes/release_21_05.rst | 3 +++ > drivers/crypto/qat/qat_sym_hw_dp.c | 21 ++++++++++++++++++--- > lib/librte_cryptodev/rte_cryptodev.c | 5 +++-- > lib/librte_cryptodev/rte_cryptodev.h | 8 ++++++++ > 5 files changed, 33 insertions(+), 12 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index f91debc168..a910547423 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -162,12 +162,6 @@ ceil_byte_length(uint32_t num_bits) > return (num_bits >> 3); > } >=20 > -static uint32_t > -get_raw_dp_dequeue_count(void *user_data __rte_unused) > -{ > - return 1; > -} > - > static void > post_process_raw_dp_op(void *user_data, uint32_t index __rte_unused, > uint8_t is_op_success) > @@ -345,7 +339,7 @@ process_sym_raw_dp_op(uint8_t dev_id, uint16_t > qp_id, > n =3D n_success =3D 0; > while (count++ < MAX_RAW_DEQUEUE_COUNT && n =3D=3D 0) { > n =3D rte_cryptodev_raw_dequeue_burst(ctx, > - get_raw_dp_dequeue_count, > post_process_raw_dp_op, > + NULL, 1, post_process_raw_dp_op, > (void **)&ret_op, 0, &n_success, > &dequeue_status); > if (dequeue_status < 0) { > diff --git a/doc/guides/rel_notes/release_21_05.rst > b/doc/guides/rel_notes/release_21_05.rst > index 8e686cc627..943f1596c5 100644 > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -130,6 +130,9 @@ API Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >=20 > +* cryptodev: the function ``rte_cryptodev_raw_dequeue_burst`` is added a > + parameter ``max_nb_to_dequeue`` to give user a more flexible dequeue > control. > + Shouldn't we remove the callback completely? What is the use case of having 2 different methods of passing a=20 Simple dequeue count? Why do we need such flexibility? Regards, Akhil