From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 694A9A0A02; Mon, 5 Apr 2021 20:58:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AECC4068C; Mon, 5 Apr 2021 20:58:42 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id BEE8D4014E for ; Mon, 5 Apr 2021 20:58:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 135Iuf91012149; Mon, 5 Apr 2021 11:58:40 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170]) by mx0b-0016f401.pphosted.com with ESMTP id 37q2ms48d0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Apr 2021 11:58:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgKfVuZQl95Zg6em7xZ8NR1MFZ9iVG/kXLb4PDWYYt9V0vUM4/tyU1P6/b24rVNZE50xt6O3Er4OA2wrXZLFK+zhvhh9UanGXt90nOcR9J4/SpoFGOTvLiHe+xr2Q4RZt94zh/2BZi30jEkw9I47pKd/P5uylkdg7lQt8CUnipEuCpmHKL8xDonbE0rmEjJpNduCUFZJgrpcpC8nekE09McM9Q2Wjsc5FsN8nVPG3MNjNBGZEpj2PXZRN4m1WIYnxoMTYsQWjFh1G7C2f5+ESE6MLUQJq9qB3ra1L6G+spyCSm2x6rtJHaO1g8U+O7nQUbZygMIO+zoiKLAJDSwG9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4G7Pm9qtRzHJfmyCt59q2k9CBjUTLiOB2zE8QEnKG4=; b=cBUzwLHgOtwVOV+1bkCQlbClIN2wD+nTFkDlpcia4C2q9/lh85L55Cw/rx5qAfyBwctuxVo0oVBKXZMIyLb+uck6krcnk2zRp9pQePeNXrBjyroBOCl2T86lYeLBEAS3F7l5i2uWtyZ7sTYUso8ss2YRde+/Tu6Dia7F4vEH4TPmJvQV2b1m1Sxd67cHUJB02V/qcvKmJV6/uB/hLWYttaRYtNXirgm8uMjJRjVL59MFtFTRqEss72r0Fou6Cf7xcfTtNLiHcsAsktGJodRnt86RhVn0w9X53HJsnIpEZ6PETUlSNvEVYii97SGKrcDU7eL+m5VE2sHTSR038/c3tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4G7Pm9qtRzHJfmyCt59q2k9CBjUTLiOB2zE8QEnKG4=; b=cNO6ulNxF4PnKHQ1iyexXUjSyNXnaNKm7NAEgbBIoi4Yk4U3DphJgqNpSy+LIsCdKGwnfE2rTCbmrAsp4/KxiC6gXM5QwempeMXrqqa2KKld2joFiSqGHs09juK+WR8MaktPJCs/CeKuVc6owl20mLcckb0LbuxmQFCs8rydLHk= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR1801MB1935.namprd18.prod.outlook.com (2603:10b6:301:63::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Mon, 5 Apr 2021 18:58:38 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.3999.032; Mon, 5 Apr 2021 18:58:37 +0000 From: Akhil Goyal To: Akhil Goyal , Adam Dybkowski , "dev@dpdk.org" , "declan.doherty@intel.com" , "arkadiuszx.kusztal@intel.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests Thread-Index: AdcgGdZT1LyyXAMxQtWE+7ZgU76dDgKM7Ocw Date: Mon, 5 Apr 2021 18:58:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a3ff8fa-1bac-4cea-43fa-08d8f864d233 x-ms-traffictypediagnostic: MWHPR1801MB1935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /7gRMPOrWi96psvzrD/eYamiV6ECiixY8TfhiLs8cci7EK81gVnpOrm1NwmKCUykexpGdO5stYGfDRue+sSKGEepfPTh12ooPCQyjoJ4RpC5tysXlI9/ccL9KoCnBB5MI1y/crAOtqMy7aksrOgDtioK+lYJO2cyX+ig+ceboRCkNxZF9YRKPWpYNfTa6DNhA6aW4pCqKiakP7h7funzPAvYGakuufomVK63P7ZOyuZja26HGfRCm+9l2WooS6op1ZB5vK36n+T79n6A1EdQxeEV5H5MMS9eImttZRzp1lw2c73sSxnHQhSiV+JPkbK8UQWXmAzFeexCz2PMQ0tsDio+IVBUayuwjwgo0Q2kE7liGt0/Z+5ovNfN5RvH6EGIAD6ybsnYE9jurpBhZJxNYAkcEbFtp+v6SStNAMT8MZiicRhaBnXYF9PFxb5biAmvAcS8h0fR2pW03fr4xWrfLzLJrkng6YAE8UcqiZV8uui+PJixSUqlYGUGmCnxbrRDh/DRqIeV6V8akpaB1he10d45/t0M14YVNq09k/LeU5H7zBXI52GHOSaCScfoocUTmpfMkWCIO6D0bfNWNE02nrOp2ZsVfHt6Z1W+ZZsdjNPWdmhb15WY2eS2kLFBvTyD2Pnxy0PseHs1ooCZ0MEmTeTsvHQdOZnYkuJuRu+Iuow= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(9686003)(55016002)(478600001)(38100700001)(26005)(110136005)(316002)(2906002)(6506007)(71200400001)(52536014)(64756008)(66476007)(83380400001)(66446008)(66556008)(66946007)(76116006)(8676002)(186003)(33656002)(8936002)(7696005)(86362001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8j/riQ7ZIK6Hv89Q54LH2bHTmwej2kapz5XV6CJSIwSNjXgk7mM54sKebXmf?= =?us-ascii?Q?BOLijafGsyuivQ2ejsfGrIa3fv7hmWQOa1Jx4vhv/IM8Gxg16owXRb+PEYlC?= =?us-ascii?Q?OxuJRIAvGtzBWS1nyVE+LvSVS4OWloY1XN06OcBN7h9r9L6pBc8RXwNzVtgD?= =?us-ascii?Q?6NHOCfhzJHp3P7poS/jH7/SeNp8t4OBOgorU+llqhew2PrAXy/NK0cjqTxBU?= =?us-ascii?Q?ll2IVQQsX2ZbjhvYhqbCSJXzOzovM0mhBodzmLrsevJRlu00Fv5GkONBmDob?= =?us-ascii?Q?SMe+KsiTLruJgfnw1lgHacJVLVp1s1Dc5OfBYk6W+ezhKNZLAkhZdsZ9uaGN?= =?us-ascii?Q?ZHrdbCWbcKGidty1mB+9SxaKCqbHb4Ftx5MhrgIwH4w025+Fj+YIfcy+u7S4?= =?us-ascii?Q?VlKbcTV3boIPccuS8/cryetCPQsRA603CPBJ/lclOYEbl/I0mfG6MSUhj7BZ?= =?us-ascii?Q?IdVcm7gfOxX5Cbh56i+Bwi7yuzpq7X/W31FVNWM6gGgxG+A64QJvIRiBMAIt?= =?us-ascii?Q?NcuZTRVGvEo5feZsS8SnZ56C+34JBXB2loBOEeQihsRfLwTbPYs8MYAEM5Zz?= =?us-ascii?Q?ek7pJp7j380tHNU82/5cJv8qS1ApEW9l2p2XTxkZUPxKeD3ysea540uMvi2Z?= =?us-ascii?Q?r9gq23GEePe324quX0mlO0p9vgrd5tvYLBbi1444RCcdF0Ta4PU35CUiRu4O?= =?us-ascii?Q?BBNi2cCejgOl2gI9jVHMV67qhb1uvsZEKFSlmBp6W7hrMk0NgOH3uVroCRkr?= =?us-ascii?Q?cIM3Zywh82zk/20N98Sx38J2RUSJi9P4UvEE1t7elxNIN2GPHgyXd1+6deCx?= =?us-ascii?Q?m5iuXlglKOk5ub5B2sHGLuwYFAJUZs3hGhcTgyMxBUfvPDd57yZgcRYxj1kV?= =?us-ascii?Q?B/9rdVixIcbmxCFSUDPa1iyM/k6Gfj9umEJlhUrlAgsfCdJvElwmsODPq2RZ?= =?us-ascii?Q?+QH+CBlyq3X4VrQC0oKlG3LVJC5jusMplljr1P2JfiCdohpTiMzEKiuZJkLf?= =?us-ascii?Q?3CN8MAXaXhZzE+XHAGQHSSS8mzjGGYL/WQFCZscVk+JajoAVLvi3Pj6kc2ZX?= =?us-ascii?Q?lxFro4Jda7uT4NHixcbs81uBKW83mqkg5ifmWBBxZPF2lqLdHPjmtPclZIN4?= =?us-ascii?Q?JgtbaOu9fliqKSvzt6mlxTdQtHMKFYV3sUNCwjtZH91PqM6cfFIhgAtCXRpF?= =?us-ascii?Q?dpH7VIZ6Hq1C9UA66DIf3zfDI+haezGCPzPAeKQCZrclWJ6XhEdL0lRAMPla?= =?us-ascii?Q?8FhN/vx0MLH2OQ8JAunRyZMUSN/mVDy8bMi0ljP2hZR2Cwr5llNSG2ZZXWnB?= =?us-ascii?Q?vIM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3ff8fa-1bac-4cea-43fa-08d8f864d233 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2021 18:58:37.7609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4Dv6rDOuJbUN9K4Obz7duaxmnLNiPhlA/OfHuMS99DK8ZQehZoZ0xzzwHfy0siJuOLUKmZLCKj6xOI3WLpKOkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1935 X-Proofpoint-GUID: oRsKe9iXu0puPY7uBnxixiq1yakNwsaT X-Proofpoint-ORIG-GUID: oRsKe9iXu0puPY7uBnxixiq1yakNwsaT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-04-05_14:2021-04-01, 2021-04-05 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam/Arek, Could you please reply to the below query. > > This patch adds closing of the PMD after running the tests. > > > > Signed-off-by: Adam Dybkowski > > --- > > app/test/test_cryptodev.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index f91debc16..ea965a64a 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -928,6 +928,7 @@ ut_teardown(void) > > struct crypto_testsuite_params *ts_params =3D &testsuite_params; > > struct crypto_unittest_params *ut_params =3D &unittest_params; > > struct rte_cryptodev_stats stats; > > + int res; > > > > /* free crypto session structure */ > > #ifdef RTE_LIB_SECURITY > > @@ -976,8 +977,11 @@ ut_teardown(void) > > > > rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats); > > > > - /* Stop the device */ > > + /* Stop and close the device */ > > rte_cryptodev_stop(ts_params->valid_devs[0]); > > + res =3D rte_cryptodev_close(ts_params->valid_devs[0]); > > + if (res) > > + RTE_LOG(ERR, USER1, "Crypto device close error %d\n", res); >=20 > Shouldn't this be part of testsuite_setup() instead of ut_teardown()? > In cases of vdev, devices are initialized as part of testsuite_setup(). >=20 > Should we also call rte_cryptodev_queue_pair_release from ut_teardown? >=20 > Regards, > Akhil