From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E25E5A0548; Sun, 9 May 2021 11:18:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41B1D406FF; Sun, 9 May 2021 11:18:01 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E1E0C40140 for <dev@dpdk.org>; Sun, 9 May 2021 11:17:59 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1499GkbD016251; Sun, 9 May 2021 02:17:58 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177]) by mx0a-0016f401.pphosted.com with ESMTP id 38dr0qk6dv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 09 May 2021 02:17:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0wkT3DrNn4d2qLdGOGuK5SOBzDN+JvP7aP2X0DNn2wGQmKPJP458fJAb/Cuyg7wDLbBufp+1Zm5gzP3TtOVTI6bdk3RFYH/17+FL/If+iy9buwpyDju38jBBUa4mw8Hvu4Uyws/XOZwX5SpPotkKCdCZzapqxO+SUd7ArmB/iak4e8iuIVzJsIfg3sMJL7P8SaiQpq97HPTY3EeE3Kvk+LligvMF0a+EXXsxIOJiUlwT26Zeao1K2MkXiQEE6SaluD1WPjKeIzZoKFW9wEr+x28d4dpl6V+ovKI7yPBFdpBUitYsZHYF4vHB+qv6AKVRxCoD6/NJcFR12I8alhqzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+RyWYroOfBX1RL+9E9d7Y2yXeCEKXjyS6KU0PUSyRU=; b=Mz5GNOP8e461r1hKg1sRJ/Zb996ds6/4dxOVwDmmwxFQD9j38bt3kmzB3flEuF9JygxO9YUfVWz1Wmt+7HjUEsSjQr9AUoGG2DD7vhShSRgeqkrZEUvRbsbwHhg+lXbvlxVpm4+PJS32EwYDKRDEn+t5YFJA3KRp6wIPRaZXagFNMsjwOnoWFYlKiLXTsfmpXbTvQ/WFx4phD3MW11q8hW7urrzeAs/pR6Ds7z2sxuf7b8IHVkPTSZpb44RlrCzQSuGTEUnP/2BDoVAP7SacmLPb/oaJl5yBKIcUW1yJkUFaSLsTQ+8K2x+q69odPz4zhykpbm6ujpWJBBeJQCc/0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+RyWYroOfBX1RL+9E9d7Y2yXeCEKXjyS6KU0PUSyRU=; b=j3ajQIFrxKiTR/ZbB24N7nCqX0T/pLQlCaqCsjLP5R5vHTAW/wT0c4x1uwyQPS1n75plHKoxCf+wyMQ7T0ZJw7bbJjyiyHOd70TSOzlXnN1nUz0V8oVAjZ7CszxJbAPNI5b90keFXxeB6qJecMz2Okdxd8UQR5YMSpgeK1WKPyE= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR1801MB2030.namprd18.prod.outlook.com (2603:10b6:301:69::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Sun, 9 May 2021 09:17:55 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4108.031; Sun, 9 May 2021 09:17:55 +0000 From: Akhil Goyal <gakhil@marvell.com> To: Matan Azrad <matan@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org> CC: Suanming Mou <suanmingm@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net> Thread-Topic: [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument Thread-Index: AQHXQSnPQf0MD2hMAUqO3HOD7BvLbqrZiTkQgAFP7wCAAAxGoA== Date: Sun, 9 May 2021 09:17:55 +0000 Message-ID: <MW2PR18MB22844210F471DFBEC19D251DD8559@MW2PR18MB2284.namprd18.prod.outlook.com> References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-11-matan@nvidia.com> <MW2PR18MB2284176B527394EE1E8F6C14D8569@MW2PR18MB2284.namprd18.prod.outlook.com> <DM4PR12MB538905148B47B15C81263FBBDF559@DM4PR12MB5389.namprd12.prod.outlook.com> In-Reply-To: <DM4PR12MB538905148B47B15C81263FBBDF559@DM4PR12MB5389.namprd12.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1c70a43-2678-42a5-9a9b-08d912cb5481 x-ms-traffictypediagnostic: MWHPR1801MB2030: x-microsoft-antispam-prvs: <MWHPR1801MB2030B17720D92664B01AA3DFD8559@MWHPR1801MB2030.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:569; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9oIisCvqirhJHceYCs/PqPkU1gkUNjNgfdZ+MGfw9DAn4qRRD/Y8o4MaaRvoWGqIyGbTusdX9KUKxMH40PZF6ZG0RR2fCxuk17qo6titkAQvgAaSwfzD/8z4GuSZBz4hZl+hyteayVqEu41N+hULXjI3q8m501Ty7IFXSf5PAuTOjeSnjNM8GW76PhzKIvwqS8bIS/ejyKquZ71EMU6bw5stf+NWGyaH79OhEx1WEUHnkm2meBc7MYYCrBYKWKG6c8YHkaGa9/91CUt4EE+1bLtH36RT7+LxJI8GrKVvwrewDKgMykFJpaGgiQU45/ko/EpatgPCDLZjzAmwREVACJ5HY8Yndkx3GyaqmCPCeRpmmiAMVup7o+KNcWH+A/FcyRSW3e5VhoMccDuDDY1kQ34zAJ7SPkXnZfCH2nAUrak1OyaKLEY/I1ltf5yBdQ9UGXUGe7L4UsJoX//HlWAAlvhgpkujKnNkrMWQ2rJsZRa1EKo8KEKQF99/89+Sp8Kw5NWfuGShzqEoNWj6YRSuQ4wEh+540tVEEFSBoXqpjGhQ3bCowoai5RVmytGEOB8fCqRgHWMPxRqs/YJR56DWyHathW6u9HUSzmGLlaQsg9M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39850400004)(136003)(366004)(396003)(376002)(83380400001)(86362001)(33656002)(55016002)(38100700002)(71200400001)(122000001)(26005)(66476007)(54906003)(110136005)(8676002)(186003)(8936002)(4326008)(66556008)(52536014)(5660300002)(478600001)(2906002)(7696005)(9686003)(6506007)(316002)(66446008)(64756008)(66946007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?W6TXZer8Gy4usnHqHn0LZTBZ8KbJzn58Iy795NcfYYLIqHiICGrmNUYy9+BI?= =?us-ascii?Q?hA5ydYabofIkEqjOHi3NBWNvty74dsWXSc8Ka3aMywfnT0Si92qFceQwZQHu?= =?us-ascii?Q?K+hRgsA4MivSzijNsWQaL9f3m9o3RVe+He+LJNN5127iz1BFJ+LNOy9AE+Ly?= =?us-ascii?Q?4GNEgfDJ/SLd4Pj9Ucu8sDsN5pAb80c+evQCCB2np6uxqRyAmMht3VoPKvNR?= =?us-ascii?Q?PZ8F1Hd2Mj2wrU9D5JHo9t+2j5iaeA9ZGRLAZFojE29RyEH8pmjhJ/lhvJ6W?= =?us-ascii?Q?I/prkf29Q34teuq0kQusupoRTfkIfcf2t2wr4bqi0BlUQdOJ45U8Nq2qgMUR?= =?us-ascii?Q?XZwhf2YuxYzEsf4942r1YWuTrP78P6JWlR0zA9T0dwkrtvbiHpVmLJfUIbxN?= =?us-ascii?Q?zaAgUbRvIlRrXKiBN5J8x5LmnC2rjz8qAGJfvYANPn4ZoJjMeexkoiD/KqFr?= =?us-ascii?Q?JVY5Cs0KZTRFZ8/eD1JyjIbxth19jitEqKkd+I9fWQLu3Re66TRMyIoXY8UN?= =?us-ascii?Q?JKyk2+dKDKIyh5+OJNhJ/lx06li26h+HNVIn6NVl/enPrV5Wcamjq5dpW6yF?= =?us-ascii?Q?oVa2iVdcjrkyZXiCHyXn3tD+uY8sqouIMgoLQd0TlkaXpsYsd3mGivB4Whix?= =?us-ascii?Q?THrGrOoP2n3zv43qGoMe1kIz87Lvs9Ih1/myHe5XF17cqwesILeuIq3DII+y?= =?us-ascii?Q?uJRNCJl0F4ReyyRuZDxGe4ZFJZpKmdxMsxJJsSypWVVE8Ner8r7McjFPQLbr?= =?us-ascii?Q?DqptfFdOLAvJr/EpEqXvThkrKh08noUHy9SOexSB0sSEogmYap4BTDJMme4E?= =?us-ascii?Q?Mpu+b3dXmis0PQmuzvN2/yFzWDyqLXOsUXX7cqm6HF4l8Z2Tkzfl4Twwp9Ay?= =?us-ascii?Q?kXFGNXyA0xZ8uAwKorXOPAzb6j1S0/+j5mNwh/jbPmAY719OL9Un0NrL8eq+?= =?us-ascii?Q?fpkq7gRku+81YR85ONkVRXCflLeLB8XfF8Jwlz2gThXObjKwWddWc00LMZCz?= =?us-ascii?Q?qEXkWo9wUghHI2PrwDjQj2AWmlIK+aWT72g/kk2MH0+yTKPuRphIB+iX0zRj?= =?us-ascii?Q?OH7Lc60j8zwYg/Xbqy44+VWLYaWDhc1NEqai3YYWZbEIWIdvRE5nXi4JgRaX?= =?us-ascii?Q?HWfVmsEvq+wW2JzcJtPuMNpf9NtJjzFADNEU73uknsDjToSICRPif9mhr7BU?= =?us-ascii?Q?oL/HyJxard/lsJIJNPLPdQqZEhgiOvUGc4R/Ky/1K5hlJEpjKPkPUYSaJk2I?= =?us-ascii?Q?42HU8UCZ3YrtO3kDCoMBUbXCZDy73iZohX79LGyO9i8fpKiOoO834q6hrphC?= =?us-ascii?Q?bWU=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1c70a43-2678-42a5-9a9b-08d912cb5481 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 09:17:55.3287 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0FJVCX8mrMtwWiPCwxx3gZfx1Ri96q7qgqOD03XS9d2Y1sC5CMAMCTHwCNEBPR5s+PeKWaMULnXIq2fK+wCUNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB2030 X-Proofpoint-GUID: K2Yiwis4jgV0bEdjHAJ1GXX14nxof3UG X-Proofpoint-ORIG-GUID: K2Yiwis4jgV0bEdjHAJ1GXX14nxof3UG X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-09_04:2021-05-06, 2021-05-09 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > From: Akhil Goyal > > > From: Suanming Mou <suanmingm@nvidia.com> > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the keytag > > > is also supplied in the BSF as plaintext. The HW will decrypt the DEK > > > (and the attached keytag) and will fail the operation if the keytags > > > don't match. > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > Signed-off-by: Suanming Mou <suanmingm@nvidia.com> > > > Signed-off-by: Matan Azrad <matan@nvidia.com> > > > --- > > Documentation for devargs should be part of this patch. > > Please split the last patch accordingly. > > > > Title can be shortened to > > Crypto/mlx5: add keytag devarg > > > > Fix other patches of devargs accordingly. >=20 > As I said before, no devargs is really active before adding datapath patc= hes. > The option to add all the supported features \ documentations in the patc= h > which actually adds the support is correct. >=20 > The last patch adds the capabilities and docs when all of them are really > supported. >=20 In that case split the patches in such a manner that data path is added Before devargs patch with some dummy values and add the devargs with Appropriate documentation update in a later patch.