From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4ABB1A0562; Wed, 14 Apr 2021 13:23:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C26271619CD; Wed, 14 Apr 2021 13:22:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 76C7D1619C9 for ; Wed, 14 Apr 2021 13:22:57 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13EBFQxt027545; Wed, 14 Apr 2021 04:22:47 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2049.outbound.protection.outlook.com [104.47.56.49]) by mx0a-0016f401.pphosted.com with ESMTP id 37wn4wsufg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Apr 2021 04:22:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlU+7/NYTinAvwQMA07gvWiDQvmALBNBllVUU3nV7KMPHSnun1m9c9dkPgcTPi+jh0mmgWd+ii084P9SwyvEAD0SvkPketCjAb9HT7+SeFGFZxQkuKwDWCyTDgOMUIu65LtK9Rc6Jz/ZeWrOR0AD6v2QqAsxZC29aZ8gjnvQrhg0PD79spLM1Cc+GFu36+pn6q45RDCe0NQNdNtA64ZUL0Frae8K2H/N1Q9AKr0okZdc4Duo5wOikaWkVeHpkrxbVmM7Ew8hVa3V9xw1BZ30CnIDYWQSQbeVI/bD5fkhJ8JcHA3IWJjUQSgRdvrvLciccEh+xG2+KCRSOf876sMwPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m/Emf/yh0oZGk7W3ahPOkP1cysMLJREl70TTdNVAIYo=; b=VJlQWVDu0sGpH49e8oK6VOP1hJxgAhAyyW7jSN9AaNrMzGzThEC2HHnmpDa72TuFGkhExttDBYS9Tkn6vn0aRirZORs2U+J5S/4loZHfnMl+xKi8dawz54MRxzcpa138FBAYL/FOo4x+ICTTFEJ0C7Xgl4+ST3hV/fVz+4JYwcqGGT4Ejz4gdPQ6B/oiDipyeNgycD4zfFCCm6wBTl2UPGUK60whMu0rXnw0RelSbbPpt1CyXjbBt7bsWOEx361HF1bQU6IjIyyGUqxkRwMMUN49uEvzzgEOVa8Ix1dHdAXlK1q2u8plaqF9ijlwxnaYrSLDyXjbG0v2kSF7XjNt8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m/Emf/yh0oZGk7W3ahPOkP1cysMLJREl70TTdNVAIYo=; b=QaMD/AqdAUbcerNsBdLeXmdAYFkp2QtVN8ycOHMBv7n6te2JoEAhcAFYQ6Q2+gAaNu+YTC+dULqycMcePr+l0CCPcXeFuGc1Gk6Wd75TjwKzyRUz2QCA+Q2hVd05vEzBu1eXLQyvB5uMUWvvzPHcHEDuKNyv9QaMRj0HRznUKF4= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB0974.namprd18.prod.outlook.com (2603:10b6:300:a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Wed, 14 Apr 2021 11:22:45 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 11:22:45 +0000 From: Akhil Goyal To: Thomas Monjalon , "Doherty, Declan" , Ciara Power CC: "dev@dpdk.org" , "aconole@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "ruifeng.wang@arm.com" , "asomalap@amd.com" , "ajit.khaparde@broadcom.com" , "g.singh@nxp.com" , Matan Azrad Thread-Topic: [EXT] [PATCH v2 3/6] test/crypto: refactor to use sub-testsuites Thread-Index: AQHXJ8v0IGOnaSkXdEK/hUlyc2SKGKqyw/FggAEqrQCAAAC6sIAAAY2AgAAAN2A= Date: Wed, 14 Apr 2021 11:22:45 +0000 Message-ID: References: <20210402142424.1353789-1-ciara.power@intel.com> <8133851.sdFIudDCVC@thomas> In-Reply-To: <8133851.sdFIudDCVC@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2ed5d465-2dfc-4859-884a-08d8ff37a0c1 x-ms-traffictypediagnostic: MWHPR18MB0974: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1zL5xwMJ9fhuipJ9AtdCqssko4hDtnN/kI5A6vIVeKVfI+/KU7PZid2s0mrz9BKkVoRCh4ZNbc1+GxyK08DuzW2pUADN8wnNO15Uh7nbsnSBU5s/In5YnU1b/h36T2S/4sQ3vp9V+7rjfgnyChlMN39ULj4TEQDJqdkyMeuNbgupEtU7x4ZC1B0iJtKrpE1UVqc2XQYFRSdocfQZOLsrzLMPBaRtc4Wu/2FJoFARZakHwhhagTIAaevzNUoMuE23vs/UwKuoIkV/UGSxrEdcq3THOL19qy/M95e6FNkxvTedj1yKKmYrwJFuj8jnn4vxsYnlEyqBeZJYRGs45rFu3/aQjbkKDoVBwkmEQFWKrlEzqEh3Kx5arB0aP/CbxFwxSf80+RI6+ZEnXYJ+LClbL2W+7C+d+tvUkWeuUr/hLRP7FJtr0u+FQk20leLF3++AlKdQIDaWs6HLdFeVhOc130NJloH8HZjCZwTpbFPoYJC6e+0jO3VXqP4PSDYf3uP0P51xHzUa11JMkiSG8IzDu1jP0AUhh/uFkpreIRjJD09qGg00Y/dGP5q1oaV26pRnMgdwi9ONrg13c9Sxcy2BiBU3Zfm2O//4hxkAMA1tyYE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(316002)(71200400001)(8676002)(66476007)(6506007)(54906003)(478600001)(26005)(4326008)(7696005)(5660300002)(110136005)(83380400001)(52536014)(38100700002)(76116006)(9686003)(33656002)(8936002)(7416002)(2906002)(66946007)(55016002)(64756008)(86362001)(186003)(122000001)(66446008)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jJeHtE4EXVVYCgWw+n/YGiPnpSpJeaAUDYRAgzpG51UvGQKbArsekLgUlSSo?= =?us-ascii?Q?f20kqpi4biAe+OuGvZFD2clMxyJ41PjhB54RbZnq2kX30hMKisDB37lDtZDd?= =?us-ascii?Q?ygs1FeXQc/eSMxwCGzlgWh9Fm+mNt6S0QIwYRZe1ffkM+H56yIN6rTfxpncE?= =?us-ascii?Q?aeiGY6WRVl1NpdfYWr+yv1ZECrWabwvdo1T8EbApcYgCxOji+DRUttN5d7ix?= =?us-ascii?Q?jIp/4eGKOJEe/aR84Swj8MtI1imqTwcfSdyUVUn8StuK9lCfF52Xb14WOlw7?= =?us-ascii?Q?KahYVJX0ngMpicTCT/CNZLsRT5EcjZQTQF+WwX7gX4oHi6Kh2vaeKurcRMlh?= =?us-ascii?Q?fW5Iea78rKMSJYCrqTooe4Q5IkRMkZjzfMHTGc15QkTBV1tpF/30fEO6ZCkV?= =?us-ascii?Q?8vgLPEXm5ZQAFCdX03cZ7tj/G6JueJZ9zsxVToCaBFUWos2odWJ9k3KGkIF1?= =?us-ascii?Q?X4mrUzJYP0mKYuNjfCWpAH+F/q4ha3C36t9Ve7f8dpSaxcbCB5rW7uXYuCe8?= =?us-ascii?Q?9y9COXHXMwrqXkQfQYugfGB7oZANm2jHAkZbHmg0s3XAVG0ceesnHhlW2OWv?= =?us-ascii?Q?hrW11oEqK/f98uE0K1HCG7qf7RP0Hg/q5wGnNyEZaR26mqZG6VQqRdVw6d0m?= =?us-ascii?Q?Us2jSb8pL9WYUIG1i1/9kyRtmIKB+iFSvsBuO0PDRbGrIkc1jZF6SXdk27E+?= =?us-ascii?Q?OH6NlgRNQs5YkSV/6thKMcj6PSwtsN3/doz4YaotMMVUW5fT80bj5tcZzfqM?= =?us-ascii?Q?cCc1Efei+cODBUVCgtR7qnZWtuw7+C34KAkUh1ZP82Xe/kUsZk/fGpYq3up/?= =?us-ascii?Q?7lTz0jgPYeFYx90X1oQwyKbhd7B30+x2Nl/TwlwenRvsPtJeRNCE3yclhQO6?= =?us-ascii?Q?9LeqJQf/k34WFQNA2RGZ6DzzEmB3C/GD8pY5ohmUqaJZccOLkN3PGvGBfGaY?= =?us-ascii?Q?lhMVxHhMtx6GJtUPChnpfwUodXo2I8/3uxUmITCxujb55mM8K0HKj/3978ty?= =?us-ascii?Q?SDJWS1G5oPBIndBPM8sOHuGieJ6/0VcwLCIcXQQuKaa5klC//zEDfDvaYWOC?= =?us-ascii?Q?dzkDW57Be6tUEAMcJRARoa6YQ6wv9M/T5SKV5BdfOI4BkBwVRoPyrNRw3nVS?= =?us-ascii?Q?fRdH2bcHbMl6/+u0CZy7EBpN2xyG5Ca7/A7GIY3FVE0XaSxQ5GJvr4Qkbv+w?= =?us-ascii?Q?m5bd89ZvdTEfSowVB0/W/O6MOFn8eA/K02yGR9dYtNfjkVV+IMmM5L5PnPCW?= =?us-ascii?Q?oUaVRejufOnKo5NUnv7IE2NnP55qpDPwNCMpQP7Bq4sorjoxe8m50pU0kdyY?= =?us-ascii?Q?QnE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed5d465-2dfc-4859-884a-08d8ff37a0c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 11:22:45.6078 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BkG6ZaKcNqbTWIuud6Rt0AL7jA0goGYCjTMVFPyK5W1WEEUj2QI0dOakDTWJ9zS1ZOBG8fjewPHC9wQEj8GbhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB0974 X-Proofpoint-ORIG-GUID: UsEx4BK-fK7z1ThYlqN1rCur6vgBlCKI X-Proofpoint-GUID: UsEx4BK-fK7z1ThYlqN1rCur6vgBlCKI X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-14_06:2021-04-14, 2021-04-14 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 3/6] test/crypto: refactor to use sub-testsuites X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > Splitting the complete testsuite into logical generic algo based su= b > testsuite > > > > Is a good idea. I appreciate that. > > > > > > > > But introducing PMD based test suite is not recommended. We have > been > > > > trying from past few releases to clean this up. And this patch is a= gain > > > introducing > > > > the same. When I first saw this series, I saw only the algo based s= plitting > > > and > > > > when it was run on the board, it was showing results in an organize= d > way. > > > > But this was not expected that, PMD based test suites are reintrodu= ced > by > > > > Intel who helped in removing them in last few releases. > > > > > > > > This will make an unnecessary addition of duplicate code whenever a > new > > > PMD > > > > is introduced. > > > > > > > > I recommend to use a single parent suite - cryptodev_testsuite and > there > > > > Can be multiple sub testsuites based on Algos etc. but not on the b= asis > of > > > PMD. > > > > > > > > Regards, > > > > Akhil > > > > > > > > > > Hey Akhil, I understand the sentiment of this, we were just trying to > > > avoid necessary failures by executing testsuites which aren't support= ed > > > by the PMD under test, and we're confident that all testsuites/tests = are > > > correctly verifying their capabilities requirements. If we add some c= ode > > > into the testsuite setup functions to test capabilities required for = the > > > testsuites vs those required by the PMD then we could do as you are > > > suggesting. If we can make this change quickly would you consider thi= s > > > patchset for inclusion in RC2? > > > > I can take these patches upto RC2. >=20 > Please don't merge patches which go in the wrong direction. >=20 I agreed to take patches by RC2, if above comments are addressed.