From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61A7BA0A02; Thu, 20 May 2021 22:18:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0BA340143; Thu, 20 May 2021 22:18:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 84BF340041 for ; Thu, 20 May 2021 22:18:01 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14KKFqLe017945; Thu, 20 May 2021 13:17:58 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by mx0a-0016f401.pphosted.com with ESMTP id 38nbc8ckx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 May 2021 13:17:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fuuDo2Lxp73kyDxMZ2qOCWL1XMfDYinK8sQDH/sTlBYFtWOKED8Zyj5m/54X4oPfEGBfJgDNN1Ky6+p2tkmMQnlumjV4MeCxBBBtp/0IgJzVs9IFvD+vVNkbQBiyLmz3NJcMgqJLqoTa3QsBYR4Sm5opX+45Jgv0TRSOohabQ1jyxdIiG9rWV2r1sp14iYB4DTOCHuhOk4kGN2B8ZJZisORpFG3z2bncoZLrPauqBrQAOe4tsGxlrA8kSPNW8t+rpRqeUzev7csUlkk6uXVPXph4OGrqi9BLEMz/dxlzdVxar5+IJ8EzRBlvEvry6oizJiMwq8DIsBQb5tDOA+giXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hebRStx3isZlg8mPV0SarYdh0qI7rFzANdOWx2ZmBxY=; b=fnthOUMz5/67SM0zudVtKjN9iVWiAFD4T+8xkv7xLQ32FM9Salra1K0BA9HUMPwgKA3nYZ4pbZBVj16kWVJtbT9XT73xo2VJ62yrtiyDWhelLnV0h2rP02pZ7NZtXSaqQqa1nH6PhtmTX1JQD1/C4cQVtfg5PfrpPg8PV0DDoPT33KMb6fRXHPvDCUOCyKF/NvHLvwE+RH6g8fWYP2eaL3XYDblul6mllmUhz2b6ISfbvxmIRD7igSqnx9Ix+y0RezV/cfvFM9ph4NYtGAUtSHwlSq0LQMEg8Ab9DsyS09xWirKa/MFOhLfGarfy50aX1JMm/c4a/0vVNyQkh5TWBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hebRStx3isZlg8mPV0SarYdh0qI7rFzANdOWx2ZmBxY=; b=WpQzdp0a/rbfnNM4oqDBl46AC+Rg7CeTzIcHjOStrSf75FMRIktsBukN76Lt/3hrsd2UM3nbmqWIDUkihxeTj7U4RJGe/5GzdnxDZPO0N2swQzVG2x69hcKOTLq5xufyjP6NkQ9zFfNMVr/tRZpkWPh58NIi9DzzHItnwOdE3t8= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR1801MB1934.namprd18.prod.outlook.com (2603:10b6:301:64::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Thu, 20 May 2021 20:17:54 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.035; Thu, 20 May 2021 20:17:54 +0000 From: Akhil Goyal To: Dmitry Kozlyuk CC: "dev@dpdk.org" , Ferruh Yigit , Fiona Trahe , Ashish Gupta , Khoa To , Ray Kinsella , Neil Horman , Thomas Monjalon , "bruce.richardson@intel.com" , Konstantin Ananyev , Jerin Jacob Kollanukkaran , "Zhang, Roy Fan" Thread-Topic: [EXT] [PATCH v3] doc: announce API changes for Windows compatibility Thread-Index: AQHXTaf6EoE1eZl57Eu1ACBK+v3ukqrst/MQgAAKQACAAAXeIA== Date: Thu, 20 May 2021 20:17:54 +0000 Message-ID: References: <20210310235421.23259-1-dmitry.kozliuk@gmail.com> <20210520184254.16790-1-dmitry.kozliuk@gmail.com> <20210520223140.6bef6046@sovereign> In-Reply-To: <20210520223140.6bef6046@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.68.13.184] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a06acdb3-2273-4d09-70f9-08d91bcc5a04 x-ms-traffictypediagnostic: MWHPR1801MB1934: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qhyAKR9M+CGF5vClOzBnLmsvTysVWobz+rIIHwOLRdBgH7ayh8mIOX3+itVMYEtK8KCXhDAZeLdJO2G8Ac8TAWf0FTKnOJz9n6VhUz+xFyl371JvN192F4KP8XoATALY4m6ZAB8ZtQKCGDg/CbBUZET762JuPsFclVbJMTuI+1dBMUyj4iOpVtbld1kG5TWW2DPCxyok/e+6syWtc+iGdjzUXWIJLnkhT3BbONobnZRiglhpG1y9gyss3g23xe1wuFJLu9+AJdfr/FoJdkIaz9hKv/qAN95qjS2cE3K0XUAb8AcIXL4CtnadPJqahD7zL5dQ33veIRTXKFoktvJzwlELTp3YenHnbao9Ta4EDF/VI3i6xSIjPNfQX7eVbLnJRzaDAcX8Eo4ZgZoMzYMnT0InFuwqpwuQ1RhcfV+CyCd1TE+Hina7Hwwj+0TdjEHQ1Yn/HmG1tE6BxO9MvEo9NI6BroPYQIMixNkPR5UjQsCYrTTKqmFqKRncCJ++MkP+EVH4UhR5sxI9Fv8ZKFntIiamZ8icQAdqB4NA0lwT+jdAB4d4YxTxMoiXuovOHevpJtA8/ngOSNbiC1k1hid+gjsQFHdsqpd8xZ11zQAZzOY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(396003)(376002)(366004)(346002)(136003)(86362001)(38100700002)(71200400001)(122000001)(66556008)(83380400001)(186003)(7416002)(6916009)(6506007)(7696005)(64756008)(316002)(2906002)(26005)(8676002)(54906003)(8936002)(5660300002)(478600001)(66476007)(4326008)(55016002)(9686003)(52536014)(33656002)(66446008)(76116006)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ASFXwnb91A+71IPCSzweWcvqLUcVC6ab4//ncrnXtaKpLi3rDcjWPTjheb4L?= =?us-ascii?Q?ln24rRY20hKmuj6DYJ/LQSa9G21XGTrK5SVXdAxvOilg47X9qiXFQOzoe8/A?= =?us-ascii?Q?uPKyl6Wg4h/R6A86liCdLps0sE1gV3rahC4IYJ+JImGr/Jj0UiJ0wxvTJPzY?= =?us-ascii?Q?144iSvmGPJLTI8ha82V4lToM/CfiAEZGyoVPgZws8VGYg+14t6CuYLAZC89w?= =?us-ascii?Q?xC7cFpTj0oXvtkSr5UnrN/qVSad9tE/eun4Y7rIaPS6bZQ8S6mECF2r7ZkmK?= =?us-ascii?Q?G4q3XiYGjJJ2KmdCIj68315lBR4NcgdL3AOzGfA8oQL+al2JWQEsgqsTA2vm?= =?us-ascii?Q?GJYpTFfjk5g8S1L2rLDTwKHpoNWAjmXCwLMtHv8uU9oCAnUyV4SP09lxadQv?= =?us-ascii?Q?ONIquXpO//5p6TRC848NZYxQUSTDekFEuWQX8wqh2/iW0+Ley7vdVHDyWq3A?= =?us-ascii?Q?ROVRCFeYvkp/MxP2otww/wlFIRUjozzMgBA/0+19xyauIObjSc/VMqrj7AkT?= =?us-ascii?Q?vqoTmHVzRDII7z+9rMPd5/HVKKX3RtVGvtVA4gqtkujcUeJJF1MPBVCIl0Et?= =?us-ascii?Q?k9vCpsxkcmrOV1tLHqHZRVwP+uEAmOgodfFHljik0qvY3UlAiR9KrOaG4GNu?= =?us-ascii?Q?YJPTUvPb0+tDSlvugEF5pKe6SiXgzMXY9MP31AU3U6kZXPHXFtuLLR6/5b3d?= =?us-ascii?Q?xgoz1ZI+U3Sx9kZKtdDGD3mWoz4sCPYBnKh7Zx2wJHpEHsHegOUsXrE7ss6X?= =?us-ascii?Q?SDqyEoagDo+o3WDywN1m11Eoiwy4lt9+EEFe4yBXobtW/x2Hxu9O9Fu3f/1i?= =?us-ascii?Q?/PuCKTpEV4II0vVgdqzpgwFSgasnPC8en7aLRz4f8j0SofB0AYghfJxx+fi2?= =?us-ascii?Q?81XkWyAbO952sJKzz4W1L+L4BTC5E4hR36xeJPAL6N+qB4gtM+BaG9h09vcN?= =?us-ascii?Q?h3y5sIv4q+uPq4FhDClxD/6bY12bX8dJRmA+WzGtRSBtl2zcMt9BVaI2VS4U?= =?us-ascii?Q?QkI60Rp+83jcs8Wlj/uvRaPec58Xwc+j40P8IpIT8ywKAbz2HmcLmF61Ry7n?= =?us-ascii?Q?erFjmFSAf/hHK6wv+6Ohb3xFjkP7YS5YmCLQyLehA2hwaguYF7sQw8n6IIWY?= =?us-ascii?Q?TGLwYGP8s3jwHBK9K7cFXsaMbWncaf9iFGmPm/g1nFYP5y/iDGpGPwVJZKrE?= =?us-ascii?Q?o+GbNz6d1kqbtDAxcQuNevgdpqlei4FenQ7N8l65lmd2j9/pBuUUYWSAHmfo?= =?us-ascii?Q?0hPv0yieqpdvEJBrHwdyQSsBYUPqKr9MRcC2BV4LdiELa+mvfqRxWHM2iist?= =?us-ascii?Q?FJORBwOD78cyJFOlpdNbojJx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a06acdb3-2273-4d09-70f9-08d91bcc5a04 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2021 20:17:54.5295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: REifo506ksuMWQFcVoX3jjB5IsewhRwdiwjTIl4SMOVoJ82Ykl/l5Iu+Q7a8+jzUn93vrP5jHVNw8TV4TDvlpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1934 X-Proofpoint-GUID: dS9beThPXaofJMzPI6AWrifYQTR_5dwg X-Proofpoint-ORIG-GUID: dS9beThPXaofJMzPI6AWrifYQTR_5dwg X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-20_06:2021-05-20, 2021-05-20 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 2021-05-20 18:59 (UTC+0000), Akhil Goyal: > > > Windows system headers define `s_addr`, `min`, and `max` macros which > > > break structure definitions containing fields with one of these names= . > > > Undefining those macros would break consumer code that relies on > them. > > > > > > > From the commit message the requirement for changing the structure > definitions > > Is not clear. Please note that 'min' - 'max' are not macros. These are > variables of a > > structure which should not break any other structure/Macro in windows. >=20 > Err, yes, that's what the commit message says. > Structure fields of course break nothing; they are broken by Windows > macros. > Would this make more sense? >=20 >=20 > Windows headers define `s_addr`, `min`, and `max` as macros. > If DPDK headers are included after Windows ones, DPDK structure > definitions containing fields with these names get broken. > If DPDK headers undefined these macros, it could break consumer > code > relying on these macros. It is proposed to rename structure fields > in DPDK, because Win32 headers are more widely used and harder > to fix. Yes it makes more sense now. But ideally it should be fixed in windows. This may be just one such issue, there may be many more. Will this also mean that nobody can define a local variable 'min'? Is this acceptable? Any macro definition in a subsystem should have a prefix to denote that, Just like in DPDK 'RTE_' is added. Macros with generic names should be avoided so that we do not get into these issues. Adding more people for comments. I don't have a good feeling about this change.