From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECE3EA0A0A; Mon, 5 Apr 2021 19:40:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A8974068C; Mon, 5 Apr 2021 19:40:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id DC0554014E for <dev@dpdk.org>; Mon, 5 Apr 2021 19:40:36 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 135HYJsc009850; Mon, 5 Apr 2021 10:40:36 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by mx0a-0016f401.pphosted.com with ESMTP id 37r72p00m0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Apr 2021 10:40:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DfPXLw/Ax9alL5EjaRlzUFNJLuKrxM6QcYeMU73EG6yAfVuMyLtnCSnB/8t5LhpZcc9T6rZQGM8XLp/kVeqLeGJ8k0PItOATYXc7H9ULbn0+gHb4ZnpX0bIthNX+sWGDBvFC9pMfj33c9AOMz5hBt9op9Jxg5HzeaRtF+UN7mlBbHYgeOKmPKf2pWZC1iqu7/30QYH2jT1Ot0knYrefQN5wUwdZAUehvEa6CaVDDe2VikQ0aUGx4mZP2STnH5Y6i6m7iAHF4aJXrafdg/8GwhHNxpqJJH2XxrS0Jb+brPxYvyfnf8RtcT3gvWAizrtncpIK97qFRHLN8qMoN/JSdcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jN7eNqksJCjMyMExvqZGzd1YQb/G8w9eoUU2gAY1x8w=; b=Pi/EkxP6eCDeUqtfsRtcMos0POkY/7KNA46qBv7TPTaYTLHjF/O2jP/Y33nOO5aC0ymVv9R4ZXJxhbBGOkFm4QwUJpztkjFmCUy2QsAZkxS+eLiYMfis/FZRdwD11XM6vvs/AuA48lH//GDe13N9NQRHs5KhrOZXK7LTBDKzKrbBJvQravfSYeHc2YmuAU4P93j7IFn3bnenGKK4WbWwDKwOI+Hmn9OfcBSVy8E+Y4ZfC6/+4g7pIihLoFo6AkOKXi5kFomo2A06kd9hvKI4wv0W3BwWzLMa7hsgTqv6m+s9P3BPBnxL8L0yTcSPMe9h8FWQmBgwDzLm7x4PkKgmYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jN7eNqksJCjMyMExvqZGzd1YQb/G8w9eoUU2gAY1x8w=; b=mNm4yTbZdbJAcNvPlj8NiauY79TX2EgO4s/+xTifuScgXBkZdgt+P7NXzsmVElnQWeN0QHPH9Ty0CszflW516s0SpZf8xItsJz5vsYUyZvw0eRxMux2GQZ1EjOqwFVP0GyUFKRLxDUXRMNyxjnMHACYYpjxxGSI9x2WYf87Oo4k= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB1456.namprd18.prod.outlook.com (2603:10b6:320:22::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Mon, 5 Apr 2021 17:40:34 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.3999.032; Mon, 5 Apr 2021 17:40:34 +0000 From: Akhil Goyal <gakhil@marvell.com> To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>, Shijith Thotton <sthotton@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "thomas@monjalon.net" <thomas@monjalon.net>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>, Anoob Joseph <anoobj@marvell.com>, "matan@nvidia.com" <matan@nvidia.com>, "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "g.singh@nxp.com" <g.singh@nxp.com>, "Carrillo, Erik G" <erik.g.carrillo@intel.com>, "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>, Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com> Thread-Topic: [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API Thread-Index: AQHXJ+H7QHX7fl5iEU6e+axEBTKZ86qiuvUAgAN2uaA= Date: Mon, 5 Apr 2021 17:40:33 +0000 Message-ID: <MW2PR18MB22845A0AF28DC5A5799FB1D6D8779@MW2PR18MB2284.namprd18.prod.outlook.com> References: <cover.1617375441.git.sthotton@marvell.com> <cover.1617382596.git.sthotton@marvell.com> <f63257083bd0874a10ec2ac33401c42d0e627934.1617382596.git.sthotton@marvell.com> <DM6PR11MB35488DC408BDDE090E08354EE8799@DM6PR11MB3548.namprd11.prod.outlook.com> In-Reply-To: <DM6PR11MB35488DC408BDDE090E08354EE8799@DM6PR11MB3548.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 373f0353-c9e1-4b62-f7c0-08d8f859ea69 x-ms-traffictypediagnostic: MWHPR18MB1456: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <MWHPR18MB1456ED49067C4CB44AD30983D8779@MWHPR18MB1456.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p31CEf5pT/D7DdtLgIUNGjI2LehErN6S+jZPjYC0jwo9NMEfASvw/2qWcICg2xkkYh2Zd5uAjAPTBijy5lwEIt/YFUu5gbOgJ2FQdTnhnkygD2G1lgcFp1PaX0mKbk8CTi9hYGGjufWLkzhpMobOpqbix7m6q/J1UHWdBttHLjh+VAsgVr0oIUNJJ6QtJEbEeJahzQ88+Oqsno+pmSoM21JXne9y5oaACzzy4Sqe/XeYaI2TyvuNR6a8BhKj7NNCcxumDD3nRxKN97Zv/7MhiJQtod+LY8JPylyGhfYM25Dka8MZ4yhHaxZsiHeubdae1DUd90s+2rNw+9V84mFqNdrUwlNldgQs3yvcdaiwptwJdqDOShYkPD489rLa3bho2/mJjjKrYcrdOytO1XH4Esuo+4n7Yenl0jaZbuQZv1rlSlfToHmP13To8lcpjDdGWNLMCM1cBrcbbP91lP83E7X+08YoQVmVyeDAgQO2Xkvbgb04y686FHOiRftjGd/WwTSRJ8TDnjPb13Wt4+POr4iercdddLT/8XaEvNcF1c1QcezwlYTy2xb3jXZ6nZnxIhCc8xbFUUuTDoTpfXV4nppq9D8kLmtRUevA+9rcCwnm0titMBkEY56GW5/3+WWHNXdAujPQcP+JiUft2eDNqz6ZTewgZLtzxaDFCjXLxNU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(376002)(366004)(136003)(76116006)(38100700001)(83380400001)(55016002)(33656002)(478600001)(5660300002)(186003)(86362001)(6506007)(7416002)(71200400001)(9686003)(26005)(316002)(8676002)(8936002)(4326008)(66556008)(66476007)(64756008)(52536014)(54906003)(66446008)(110136005)(2906002)(66946007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?JLRZ1PdBf+hR1haodJfCVbtGv6UM2O+aKtLsj42IJFFY4vcZB3I3XwXCQmxP?= =?us-ascii?Q?B4AH6sZS4ie81/zxrvKyv55t8w0pGZAhZBiB7NoOSuqiQA3KPxVrVdJw6b+4?= =?us-ascii?Q?4FXrRH0+I9SP3Pm1mMCK7uOphACZOGFa5/ifnEVo4EfLlUW9WcY00CwDRRPt?= =?us-ascii?Q?95y+ms7dgpHePMX9rcBChEmOafSVl4jiURmE6TcrfYowS1c4zWDkycOZpNiq?= =?us-ascii?Q?qhrqLD/f4SLRPGkwXhPtwGXf3JeRsRZsv41msah4Rks8Jq5a5n5vaAKcHjEF?= =?us-ascii?Q?mVUSid1NMrecBZtpdKD5wkJVQXm+qMOS2xgixkr/XSjbyyZeGeCYp9zidbYh?= =?us-ascii?Q?GUZ9AwnbpMFX045XMgt3b3D+bXhsmxxupeEY+Mwe0aS5KNjwhPQ8+cNXwgLt?= =?us-ascii?Q?TqghGw1ZGZbUJdfXCVs/Zhxoh+1SXgUo48NXGf1Z/mxRoWaqi1VfgCikO6Yt?= =?us-ascii?Q?GcrSO6lXi9bFShgNAYTcsKe4zV1tgpfAZ8Xk2JRxpwxHvD6csIRIXgk5X21u?= =?us-ascii?Q?g4JF6Hck0btlO/SyZzm2crkTMfn/VD2LNajIjEcXK3ZdAx/DwVFb4+emRxlC?= =?us-ascii?Q?hvNgwfpGlX0Wg0C986ijeg68DbaQb7Rs+MMKSe93kpZlQysq2S7c8J1X6fBc?= =?us-ascii?Q?5xbXaXdFNdq7povFNU/0whL7+i89joFHVmHsbuJq90Kq7RLocC12eYEJ4yRv?= =?us-ascii?Q?5DtxTlpIPNH6apAmtI2XDrLB3VaSaHRdTKs/vbUhbJSk6OSreWdjjYK7eht3?= =?us-ascii?Q?EP8MZs/csHtrQt8THepOJQ68IB8uT1Quv3OboEoGvanq48hfR13XbLloIiMo?= =?us-ascii?Q?x9lMa1Q9hbVpCLJURd+12fMGlVMXeTv5us4XcntNAkcTH99k26QM+ujLE8O9?= =?us-ascii?Q?C6na5Sc8MaFe9E5HfvlLOs+7F2vAd6VtNplDdgirKhY5gOHLHC0++IbjFf1j?= =?us-ascii?Q?0z/XVOpeHvC8nScZQAf3gdUKnP2IPSNIl+2NuqRleyV8g1EKIZQuupIpCAGi?= =?us-ascii?Q?vQhSm5robUMSgYUpegAq8k1QHBwe+s1LzAap5vQrkha3ThAnx675Od6CGB5v?= =?us-ascii?Q?LMy4TPbre6Gkwv3uxgnCNfXo+ZylU45WEZGxX8pAcfFyTr4DO3OQpy+x/d6k?= =?us-ascii?Q?Ufo2NYAWCno5ceFc/14Fnn4NDSLImMOofRlGbqOA6qu1QFd608Q/MjxzG5YC?= =?us-ascii?Q?SNNOwuIRoeaeiOzAY2c8J5eglyuSOEvE0M07cj2EA3lj8rS2CXIawTltJSEY?= =?us-ascii?Q?fjUpXEpUjAq1vKcU++ppIZqLLviNSWmqsVtuB3lCWEiTznRwH1OPRZK6OtH+?= =?us-ascii?Q?B5o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 373f0353-c9e1-4b62-f7c0-08d8f859ea69 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2021 17:40:33.9667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c4Nx875vLtuWYzVlOmBHiuPPzSv3tNxi3Y55R74xL6Rm6GH9kUWIQKc0QfMly4ucFWJ8PntGTxV6LBCbEdAFSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1456 X-Proofpoint-GUID: yXYhgAKAgGix-ziYGcWVhrVoA1ld83OP X-Proofpoint-ORIG-GUID: yXYhgAKAgGix-ziYGcWVhrVoA1ld83OP X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-04-05_14:2021-04-01, 2021-04-05 signatures=0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Abhnandan, > > > > In case an event from a previous stage is required to be forwarded to a > > crypto adapter and PMD supports internal event port in crypto adapter, > > exposed via capability > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not > > have a way to check in the API rte_event_enqueue_burst(), whether it is= for > > crypto adapter or for eth tx adapter. > I may be missing something here. Crypto adapter is an atomic stage has a > port which is setup during the adapter configuration. > So, application enqueuing events will end up sending to the crypto adapte= r > (As the adapter dequeues from a specific port). > Still wondering why there is requirement for new API. While we do rte_event_enqueue_burst(), we do not have a way to identify whe= ther The event is for crypto adapter or the eth adaptor. At the application layer, we know where to send the event, but in the event= lib We do not know which port it need to be sent. IMO, event port is specifically designed to work for OP_NEW mode. I did not find a way to make it land into crypto adapter. Please let me know in case there is a better option other than adding a new= API. >=20 > > > > Hence we need a new API similar to rte_event_eth_tx_adapter_enqueue(), > > which can send to a crypto adapter. > > > > Note that RTE_EVENT_TYPE_* cannot be used to make that decision, as it = is > > meant for event source and not event destination. > > And event port designated for crypto adapter is designed to be used for > > OP_NEW mode. > > > > Hence, in order to support an event PMD which has an internal event por= t > in > > crypto adapter (RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD mode), > > exposed via capability > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, > > application should use rte_event_crypto_adapter_enqueue() API to > > enqueue events. > > > > When internal port is not > available(RTE_EVENT_CRYPTO_ADAPTER_OP_NEW > > mode), application can use API rte_event_enqueue_burst() as it was doin= g > > earlier, i.e. retrieve event port used by crypto adapter and bind its e= vent > > queues to that port and enqueue events using the API > > rte_event_enqueue_burst(). > > > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>