From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 417D3A0A0A; Tue, 23 Mar 2021 20:27:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F06634014D; Tue, 23 Mar 2021 20:27:04 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9067240143 for ; Tue, 23 Mar 2021 20:27:03 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12NJPNsa014136; Tue, 23 Mar 2021 12:27:03 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by mx0b-0016f401.pphosted.com with ESMTP id 37dgjp24tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Mar 2021 12:27:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cml0mJ5+DyvaQSB5P32HK67OpL0KI02zmtHphggWcAaHUh8V/nhNVW94B+xpgtHbzPIUK7/HwsvL/MrgVmzHr/P0tvmPlf1pR084cxtRQuztORDBL8XUwpGqo9NH2no2AEjafKmLHrlP2S/02J6BAJLLJtOMI7hZmI4LPD+06dBI4nZs/iw6oTKde7Zz4olGzewNXXdTVH6Ih5Q8F5aVmxBsfMzMUmGL2l2PtgKWSsAOeX/WJhpNYREsIWn6wh6Bv1V2rPGsnS2QiCJ7bpSa4J7pe83I5E2KsIJDc7yI7RpMq+f5/C9L6nnOMGQAQLcsWLRzDFOz8LdVXSbdtVlx1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a6gfrI/3mX4xd4UyqsHmXLU50kKB/paWlgkL9BCi2Kk=; b=nFasSAu3K8zwJdjLkgOh9WIZ/nbQe2hY8OEYqHKxVOQrYjzCf/yFNS1qCKO68GbjvMAEDdyNLZU/73HAylhVDIoAMgjTZuW3x0ePGCiCxKl2qG8f0JPxcOtdeSprNOU59NgLQKlb1c7hWhfcDrbrIIrYSah8OH8ZkS7KovmTCnIU4RXmzO7fX7DVzTVk4QBpOIC2FWDH0RmJcYUehqLIOlvXWOIO82hKG0wmlTl9XRRIBVe1sUu0uw0bROfgngjre3RgPxWv5dWM+/bI0K8BkLX0XNarnuiyiHHET+47X44zExE6ZbWLJxcUliAc2wxkv28gUrKsyDRhr81r2V1w4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a6gfrI/3mX4xd4UyqsHmXLU50kKB/paWlgkL9BCi2Kk=; b=mnATfLfcl7OvG0P1hVqo9v3ReW6G6J5osJMX3S/7qHU3jSjf1Ju+SVP3JyKlYCY80ZBhnTuzv9yG7e/uRX7a0+tvxfF2Nmyv8IIYqroIT0TU9jrSOIm6Y09wYkj5Wtl+0K3CGAP7E6Ookw7zlnPUYYV/vcqkWs+z8jmmCPB7HAY= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB0990.namprd18.prod.outlook.com (2603:10b6:300:a6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Tue, 23 Mar 2021 19:27:01 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::b40a:1145:2f52:123a]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::b40a:1145:2f52:123a%7]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 19:27:01 +0000 From: Akhil Goyal To: Adam Dybkowski , "dev@dpdk.org" , "declan.doherty@intel.com" , "arkadiuszx.kusztal@intel.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests Thread-Index: AdcgGdZT1LyyXAMxQtWE+7ZgU76dDg== Date: Tue, 23 Mar 2021 19:27:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [122.162.28.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d2d00e7-e7d6-4fba-8f8c-08d8ee31a20d x-ms-traffictypediagnostic: MWHPR18MB0990: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1107; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: enisl0UU/tGOTUOSwDV8zoFtIb2ZxgtAy94evM1JYXOXiyrrUsdlDBCiq80CYveEdISRzK7ziPEnhaV5AP4P/OMiTn6Gw1dITy/r1sphldY8ANFYHUfFFNOy0qp08tI3f4xn5dHyj06IZMbVvYSxhEJG2sHFSWRMZNTSEs/ur4KgUJP54jMiVUvxB60EW/J14plh3ZaGWzWr8XkqASR7oBdWnFgjQ6pIYRqfK67SrMopD/v/gMZRi4v92Ji0NnTn+WHNRq3FxNga54oGGptst6sF9L69thlhW0r23rfNYFVSe26eoxPehzs1Q9jja+VAvV9rd+yzd41CpD1CYBy6+JkDJ09b2i6EgKQZzYfiztHoh+CxXOTSuQ7ZJbUy28kpB/y5VxKMtUVGlyWTYtcEz/nXF9EygAG6Jj+w6SDH4lJ6QmOTabGSXlrrUye6bYhe6xivuJq6FhNtzIAN9wN2f1GmasKJxGsmmaHsjQMs9MQHxAIsnleYVULvs1GTMiIfbd44ai4tqMnFko1kckQfqOEnrcdRGKOup1DyyoZrqPj3jqDU4m+0Db/aUKSToWLyUaEcwO9ITebkFAaPlRH61Wbb5lVrTheqhSznKyj7yp2qo+ZvIxvgf/U9OJDlTTv4aRQkEWQg9TRVWmV1u++HSgC9mYfNuDFzl/IhSNxXP6E= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(346002)(39850400004)(366004)(55016002)(83380400001)(7696005)(2906002)(316002)(9686003)(8676002)(5660300002)(8936002)(71200400001)(110136005)(38100700001)(478600001)(33656002)(66946007)(86362001)(66446008)(76116006)(6506007)(64756008)(66476007)(186003)(26005)(52536014)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6x3xxHAPW59o44zG01W9TULVV/DWyN0efqFsRmDp53kIM9lw8r9wldKGIZlI?= =?us-ascii?Q?4TrybhhsoizsVnM34Gw24E/pT5hGhuphnW6uRemko5e7ihpp4KENaPdUG7mv?= =?us-ascii?Q?ietRyfkDfx/xDQt+fb80soVmAg2VCQvQIr4mTD8rJSwz481p9E9Pus/C5jaW?= =?us-ascii?Q?eswAolmF3pc9rSJcqFdB5FLg8Qn0giHqqEfinMXpIxMXwt0mBrH5lQ19/hfp?= =?us-ascii?Q?kXqxxe23dlKjZLZ0fuXMONBEyvxpqpGrMDT0Dehy/Igj8TSc7qBHiK9fMaHI?= =?us-ascii?Q?lYTvYFaAusutOdi91WCDPNFO9bEjQgaLKAFCyGTbDUJ6E1z3BRV/0skHPOE3?= =?us-ascii?Q?l/KnuftXpf5Yjjemko8IlNxPxTYSrWdNO2YE9/AAMn2c1g/othI/O1eU1Xod?= =?us-ascii?Q?uPLQwtnflmOFltUf/CnrQLfDpvRFuvRx0lepWs3RkauW0xOyiqik8RF+KamN?= =?us-ascii?Q?PyucqC5keFZD0FCt3a+DbMxPgeibTYZqJdwxnKbPcQ0jhd2e7gQx2Aqhx+ve?= =?us-ascii?Q?F01Yca2oJ/ILgnwec6LQh5914WUPTZEemhOC247xKf60upPHFb13JpbUWEzU?= =?us-ascii?Q?ZxdBVUC3uc8ozbvysqyIoWRQFduCGGs56qU837MXAxRDE4fpkhuaumDUfwTE?= =?us-ascii?Q?Iy3IQ/4Bz1RPz+OEWJUzA8yfuvzXEZ84Snxxjep+53cNIfxsyk+OVFylrdyO?= =?us-ascii?Q?gjCGxTzH6jPwp5ewBH0ZZ02fXlM5SFrj470AplCOPCsYKd3OtqndRCX0FY2Q?= =?us-ascii?Q?RDD9HKbdE1x9fFzOnH45w1YPghdYbgp4VAbw3/TUMNwHh+Gs2MDiQVhB1rQp?= =?us-ascii?Q?tAi+0sNm26FIPPCviwykeWvxizvVkU9yeES0joXY6R9B3pwervlI1/vgpv7v?= =?us-ascii?Q?8HDnVwzBrVRVgtA8fTbckVLxHGEpdWNjOXw3CXIum8BBlcVjcN3LNj9La/of?= =?us-ascii?Q?XDisX7zpwvsPWso/lfvtjiZMQFjv+I77diJOrk5nMKXrqQERRqE9uBtJXg/H?= =?us-ascii?Q?ca2r5I/q00sXBx/6NG2IcaRSs0cnLURfxLZRg4fb2plpt1KlRcr5OeejFTha?= =?us-ascii?Q?xuJ80g/DfJTDQOv27HGz2AnBmIBs0dCqkscnNjXVx+1EDqgpk+XGbfoIZj76?= =?us-ascii?Q?tWNf0uc1sq+mz93upEN0KSzCAFnnfF+tJxC9ba4wrXDmDdvmp7phlTTBQPcM?= =?us-ascii?Q?89ztgKG+tGNsQUeXASZMIFAeYpty3Lot7TXUbvdweZU8ndKTIR+KkkRjw9nA?= =?us-ascii?Q?2s/3+kgRT1AFfm7vIbqUz2TNa9xCGdMcLO2Vfm6ZxnM7k3dilPrFrIYDrhmM?= =?us-ascii?Q?H/+QEwWxY9xAVqSTDXTKS92v?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d2d00e7-e7d6-4fba-8f8c-08d8ee31a20d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 19:27:01.0692 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1Bc3Yt3aZ8KQWJWottt9GpYYFsdEcf2vB+ctELxIoelXXjcUEy5gHcOuW5shP41scY4fqm6qSMTTiyieZZGkuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB0990 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-23_09:2021-03-23, 2021-03-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > This patch adds closing of the PMD after running the tests. >=20 > Signed-off-by: Adam Dybkowski > --- > app/test/test_cryptodev.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index f91debc16..ea965a64a 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -928,6 +928,7 @@ ut_teardown(void) > struct crypto_testsuite_params *ts_params =3D &testsuite_params; > struct crypto_unittest_params *ut_params =3D &unittest_params; > struct rte_cryptodev_stats stats; > + int res; >=20 > /* free crypto session structure */ > #ifdef RTE_LIB_SECURITY > @@ -976,8 +977,11 @@ ut_teardown(void) >=20 > rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats); >=20 > - /* Stop the device */ > + /* Stop and close the device */ > rte_cryptodev_stop(ts_params->valid_devs[0]); > + res =3D rte_cryptodev_close(ts_params->valid_devs[0]); > + if (res) > + RTE_LOG(ERR, USER1, "Crypto device close error %d\n", res); Shouldn't this be part of testsuite_setup() instead of ut_teardown()? In cases of vdev, devices are initialized as part of testsuite_setup(). Should we also call rte_cryptodev_queue_pair_release from ut_teardown? Regards, Akhil