From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0066EA0C3F; Thu, 15 Apr 2021 16:46:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCF171621CE; Thu, 15 Apr 2021 16:46:05 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6EF2016219E for ; Thu, 15 Apr 2021 16:46:03 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13FEVRIh009447; Thu, 15 Apr 2021 07:46:01 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2170.outbound.protection.outlook.com [104.47.56.170]) by mx0b-0016f401.pphosted.com with ESMTP id 37wqtm5wum-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Apr 2021 07:46:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GDvo8oHKZ8RX0kVMeMSUqqr+NjAT4TRh5fJEBkDHltB9RaCBlerq7DTDZ3IyuZU09sOcvGzhiDl3W1mmzhYGq5hVW5Ff702tAS1IFmm+ot5+dGwTed8el/msvxNveH978L6qEYak910GSXXio0EeaXRghhn4j2lSI5e6H9TBdkdzNbme7nqfloO6zELgGr+HUGmOpFx0KvFFjXO5MyoSo2bbfAEAGSMZbQZlOXf2+jU5Np+34xSqgCiP1VZKWqVG2jJcUNfPZHhqqMkAdXzreNCmxIYRH+IyjexlqkiZQVj2pifJAP0aZe1kXb9fEfKnH283g7PGSahip29ZNk9Gew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pye+AwOiHp3IM+FAsUQhXGphhlidBZQkj9NLjNLjcFY=; b=oWjwnNDsuPUvvGZFKn8+FcP46qi3tv2L3zX0lbRjVG4qASjgmJZGFvkOHmznwJaJDKreQC4JfzaDCTqcDGRrxS5KcjA/M1GEi9VWiwhoPxwHBhMdkpxVqRVSADWD2KlSbCNmiTw/rfAd98ydp7Zv+XB+4Yysz5OL8lFUUMg9mqnvD4tJZg/YPp7r5IBz69EZeYetBy1RUZBftVaxFjHF0EPW7+vSixoVnerZhWvfJjdiuIxpbylGMAsWjBGt4kLWtZuTpofGfmcaia4wItVl8XGkiQ3hP7iVGhbMTsECNHflnOg0vgMXTqkGJam1vAA92nXyvQT8q/ML6OU6sjapTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pye+AwOiHp3IM+FAsUQhXGphhlidBZQkj9NLjNLjcFY=; b=tN4U100gqwCbbEGg7Zp2EhOc7gnNPt6XiBK+e1hMkW1OEvohRKUf+3ZKJW8ORvAjLKHGfM02apg6J9ZPbFLMty/3x2hpDvuWj3vY1h6kXFG7DxCgKPNwZy1rhk3LcNpYKzQVC8ufSiKryusKhFLjsa20D9642QxXX+X9qTEch9s= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR1801MB2063.namprd18.prod.outlook.com (2603:10b6:301:6a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Thu, 15 Apr 2021 14:45:59 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.018; Thu, 15 Apr 2021 14:45:59 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "matan@nvidia.com" , Konstantin Ananyev , Hemant Agrawal , Anoob Joseph , "asomalap@amd.com" Thread-Topic: [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API Thread-Index: AQHXJlIz4sZI+IxaZUOOne7IJxDey6qyTy5QgAMkjICAAEofoA== Date: Thu, 15 Apr 2021 14:45:58 +0000 Message-ID: References: <20210316111455.509633-1-roy.fan.zhang@intel.com> <20210331172038.1718973-1-roy.fan.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b6e9f206-4464-4956-0429-08d9001d2ef0 x-ms-traffictypediagnostic: MWHPR1801MB2063: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZkJRETyvGgkSDU28B2ERBCcbG/O+4hVQnj4vYscEMHpO8jGQucL2FLgNin15eSG6NJKNP4OKOHYrl/OAX3B3r+92kPs4cDWNcrfql8eGIi+ENw0KvoOo2t/8ci3/fGgE84OfUuyvejhrVI83gyRpEYiGBo+EQIQuk4hompT8WKzXWFXEh8NbT40K2/sXbci2TC9zPyhnoYKOWuJeoBwefheT0ib3YV56yCGiD1SgsQEsDjSg+oySUfkj6B4sKjpvfubtrAggzmIN8r2dXv2qiXGQRhyt/7kJBiv7EIGPxR9uviXvFgs4hOZASBTGItykftGRU1n2kzQkzZpprNNJeKwNjhcUDkNLDXGBAsKjnfshwFi3oeLgjd4W9mti8SWT1HFx83Dr73FoEwHr/VXDJH0wH7vrUpG/PnnwyxZPip/TtwVEC1mwEuv4CdDh/eXlLkqVrAt453xsN0R8jpXFMecs7RvdCjpdgmSYQ1qCj/7vGmmQNkGymDZhmGzqZ5cKDDwqWZ7TI2qLZJx9MGzk0b8YMT6XDTHSfriXcp5EyQtQNJNXQhUhBK/EmR92lbpuH9tACSBULxI/USpWkCBM0xedwHHEdrq9+rIV6mj6Dow= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(366004)(136003)(39840400004)(33656002)(54906003)(6506007)(4326008)(66946007)(478600001)(110136005)(186003)(316002)(26005)(8676002)(76116006)(7696005)(9686003)(55016002)(86362001)(38100700002)(2906002)(5660300002)(66556008)(64756008)(71200400001)(122000001)(8936002)(52536014)(66446008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fvgcRVGVYHyFM3Mffj0DvI2gFH4GBeEeKoStxdU71WCKCKXNz2K0ei69JTM4?= =?us-ascii?Q?WxRl+CiPc4RQMFZHiTXD4j/Da8mkA1Jt/3KKeZFp0zKUsZ1E2ZXpz481eeGB?= =?us-ascii?Q?DIrtFVeX2r8bRxVjGcGz6alOqWUBminDtnP0oqk1LyZRIRdhjkRzBQYvA+nm?= =?us-ascii?Q?Mt7UX6B2+nn+llA8gFq0+xJ7u2MvEdDSEu/LOkKR72R8bLF/6aZBtX6pZr2Q?= =?us-ascii?Q?4dgpcp4pwT4JennHomW8ho9uPkKhFBvtEx/JCQOz217d92VwjUNGLmhWctK6?= =?us-ascii?Q?L3Nr4WDOOVHrfI4XiANAgG0SQlWJJUG/tZD0rf1f5rOcyupGaSvh3eJcxA6K?= =?us-ascii?Q?IjmV6N34ZZEXDfW9YeAxD1eEu0KIVkXtAiDs/Ob/1/vkc06dXuw2vmm832eB?= =?us-ascii?Q?bO1x95XESDr2UqAodeHPFICpF6pEW4harnvd96o3DegiKeOJLB++3Q+pCcRP?= =?us-ascii?Q?2BtQQiwgJ5gvKYwDt4suzu9y050rnL3vJiKXuXwG0nOb309el7r1byYTM1dx?= =?us-ascii?Q?F23OYor2yaeHOdolAYbQcSB2ygRwBQWzRaiA5Ammd6Zz1zCyYMtqq0P+FAuH?= =?us-ascii?Q?skGoIvdfj+El/xODjeTALjsGhbnjNNUChTyxt7YVg1Pprvzh68oacwB+dN7J?= =?us-ascii?Q?IJtW5c5hSBRRuDk83moHxlYIDlM0989uk3sl006pLKA5nr8vDUzSXj5fkGSL?= =?us-ascii?Q?kydtD+iEwkXrhx2UvFyrxyttx5CUDAM8WUD4fTQ8hvvljxzdbTFc99ZV4hK/?= =?us-ascii?Q?r3ZbmwLrQAIKNpkRo/FFZLHOT71vhOxJn+qwVbN4H9TcCHVrDk/X9O4bXS+c?= =?us-ascii?Q?fKiHx4z7zN6Q1qHQhgSt0OUPdvRA1+rfuY6W/zKtSZI9VucpVPupup7LyAYQ?= =?us-ascii?Q?veqgp/536YgjdQR3e1Xy8EmcI5XGc8O16rHJwy9OUB+46kVL8Sr0Mstp8r9c?= =?us-ascii?Q?o6JKwhuoSWttxLdonUJ4ldPREGg84fLPw9Y7X67I1+93EtXdrvcwG3jLORTW?= =?us-ascii?Q?rJb88HSfFnF+o7SgIJDmoyHpIhHBzwaTfhGsqO0F2YHuEBaZEuLfpdDDEnuk?= =?us-ascii?Q?uWpqq49MLx+pqEgGgHZ/CbLF8dvWVNERWbyq7T5Hm8kTxwxl+/NwshEsJZJP?= =?us-ascii?Q?c/XcgEoKQxAmSrRUjzXiIUxEc5AI/7L5IKSVWxbR/nPABEpwAASi4D/lovgz?= =?us-ascii?Q?Y0kyHyShaqpWK5Zij+1NfOXV29hhT54FqKWK6P5mi0O2rEeVZAzI77fIPc9B?= =?us-ascii?Q?+jsFo4nZVOABhmZwCd0sGPsJ/C+9QLgDlwGyodtooEfjpTneQN6Z7P+5da9h?= =?us-ascii?Q?kXo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6e9f206-4464-4956-0429-08d9001d2ef0 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 14:45:58.9150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zdK4yOWvQV3dingmnHDySk5AN1IV+pgDTJ0f/MtmvjqFO8jcmzCGeidvYO6o5rQ+H7nta1uS91VSZIow+4TZZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB2063 X-Proofpoint-ORIG-GUID: eU9dieqA2GUuFPhDtBSwONY5K1bXi-xI X-Proofpoint-GUID: eU9dieqA2GUuFPhDtBSwONY5K1bXi-xI X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-15_06:2021-04-15, 2021-04-15 signatures=0 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > It is possible the user don't know how many ops to dequeue. > For example in VPP crypto up to 64 buffers (vnet_crypto_async_frame_elt_t= ) > are wrapped into the following data structure >=20 > typedef struct > { > CLIB_CACHE_LINE_ALIGN_MARK (cacheline0); > vnet_crypto_async_frame_state_t state; > vnet_crypto_async_op_id_t op:8; > u16 n_elts; > vnet_crypto_async_frame_elt_t elts[VNET_CRYPTO_FRAME_SIZE]; > u32 buffer_indices[VNET_CRYPTO_FRAME_SIZE]; > u16 next_node_index[VNET_CRYPTO_FRAME_SIZE]; > u32 enqueue_thread_index; > } vnet_crypto_async_frame_t; >=20 > Instead of passing vnet_crypto_async_frame_elt_t Pointer as metadata to > cryptodev, we have to pass vnet_crypto_async_frame_t pointer into > cryptodev. > The callback function helps parse the first dequeued metadata to get n_el= ts > and will dequeue that many ops. >=20 > But in case we cannot dequeue the whole frame, passing the number of ops > not dequeued yet in the next dequeue_burst operation should help us to > dequeue the whole frame. In this case we only have to cache up to 1 frame > pointer for half dequeued frame. >=20 > As the patch stated this should help cover both cases for user either deq= ueue > the wrapped data structure with multiple buffers, or dequeue a burst of > packets - hence giving people more flexibility. >=20 > Regards, > Fan >=20 Ok. Acked-by: Akhil Goyal