From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21549A0C40; Fri, 16 Apr 2021 12:12:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D64C141CB8; Fri, 16 Apr 2021 12:12:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D8628141CB2 for ; Fri, 16 Apr 2021 12:12:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13GA5tqe002499; Fri, 16 Apr 2021 03:12:25 -0700 Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2059.outbound.protection.outlook.com [104.47.38.59]) by mx0a-0016f401.pphosted.com with ESMTP id 37y5rjrhve-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Apr 2021 03:12:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDpvNnWxuBL6lS3eLnl592jCeEUEKuNt/Ncm6mpxa4ionPtfgyyKWBUB0kP4GbitZa2X67d32BPQkILtl4j0ZobbAj8jvnPRforZVodvhiV15xTMMZb1aw1Y701Zs7rpXYk3Hwz8+OkzU70H1p0Q4DXoWVT9SQl0YZpuJhEv9Pc4JUQot7GU2zsR/bd4rnAyo/pTgKFpgV2XXQFEdF7SAEcwiQbFs9PP7It3EEt+yWDfQjedfIoOAcct64OJhxBNAateM69j+N94t2cf4JZZ6o+QX3Dja8h2jRD4OZ31GCZO120uD1Z4+6Y+Eu0DdYdgdsb7haR0xJg/qkk2lz8TdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LPgs6yA7sUeA0H8ttaMeTFYDmLbZ0wI0TH87dYtKulo=; b=T8IVYlEcyiao3KcHnTyEQ64qxME/7vq5nm+kNc+9vO5LV5CqzkIeFlmtZLneRCtsoy5QqW9aMIAKxWuSAzLsigNWKVaTP6V/8OMY4HTTWT44A0wKhH28HIHlrJ/WoA68fYnudykRp1tSYDXTwaWU6x1QJTEmbQY6YbT1SedYxBE+CbaaXgc0KC58PVwZimbbULlbFjBZR2g0vYcBvpBU+3Uz7xLsny5XAwwwx3y5osWHbJWmh01cKsmLrpIQ0sIMxHOPBuhuu78B13yvEFX5ITQIygQmaec5tUZ8MMB4bVeZIlxBnkZjo/PMUvEAHSllMQMU1ePG4O3TGBdQQqjnYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LPgs6yA7sUeA0H8ttaMeTFYDmLbZ0wI0TH87dYtKulo=; b=aVbFE1TuHNbAql3THniULkEpaJwLdX4NdgCqlQC/pvTkuar7C3qFeL0l+KLqdZe1nBx6BWnFnPIVHgrnLE7sDYNS0G+vf/6HcSOcXWJIMt3rCIbykRakVwrlV5U5ioCfLfE6HgDgrzIafWpbdnI3CU7XD0wQd08Z0PoTFrqvZVk= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by CO6PR18MB3969.namprd18.prod.outlook.com (2603:10b6:5:348::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Fri, 16 Apr 2021 10:12:22 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4042.018; Fri, 16 Apr 2021 10:12:22 +0000 From: Akhil Goyal To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "matan@nvidia.com" , Konstantin Ananyev , Hemant Agrawal , Anoob Joseph , "asomalap@amd.com" Thread-Topic: [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API Thread-Index: AQHXJlIz4sZI+IxaZUOOne7IJxDey6qyTy5QgAMkjICAAEofoIABR1mg Date: Fri, 16 Apr 2021 10:12:22 +0000 Message-ID: References: <20210316111455.509633-1-roy.fan.zhang@intel.com> <20210331172038.1718973-1-roy.fan.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [182.69.47.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e857c90b-2353-486a-bac9-08d900c02061 x-ms-traffictypediagnostic: CO6PR18MB3969: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V8TTOPo4JZ31zQdvsPltf2lWnNNBKJcjATfkpsW52WZzv6iKZjK8aGfMjQkE4Vi/8Qe1B1ByX8N0VqF23hp/q0O7ppu/+m86u1TuLkly+jER1C9IyDHRT+w0OwZZsb7zKAyoNVDWCQKOhU8dDJhirsGhFu/spCwNG8aRr9iwIuW8MiDWCJcWoe2hmyfy3N22eJJDCaOLF12to6uDRd8EFV1SQuqFgnSRpCleyOHDr7cnrpQI8KZF6RvWQe/CrN7RFWdDOE1zIjbrGosnGkvw/5Rn/2Dcar7nEELVi73frUb5fDZ1H4+XuApyp0u1cfVVUE7dlcZPmN1zFswSNkt720iL1abM8v6Bl2hfPPOOb92H+8FEJBeKGe2QIsrUvwQsgapTg/GeWm4dQ2/9mKPktMDS4/venX9UKEHW/0l06KTTOX713+nfcp7na4xrHcH6XryNgDwgiZjCsxSh1UctI5WMXt6z8iBpxnOZQP83xPKo7p92MugfVz5PmHBgj4pIownB5woGBuvOuEddCJQ8gr93x6sX+g9ILSrIPfgcIACvfQ/Qofyj9zwIsQkutljgye9dSvxzCurNvvijX1Jil5mEu/9epnmhbRXHnYpiNFU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(478600001)(54906003)(66946007)(64756008)(66476007)(66446008)(66556008)(55016002)(7696005)(6506007)(26005)(52536014)(86362001)(8676002)(8936002)(71200400001)(316002)(110136005)(33656002)(5660300002)(122000001)(9686003)(38100700002)(76116006)(186003)(4326008)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1ENd87XlUIulm5aq6UXyuO+TNni9uuxNCmyZ4EI75NfN4auGXw9ojizMNAt9?= =?us-ascii?Q?1sfiHOdz/3x9u/5VrX/snVYe/CtdFeZmj5kS0FSeaxGqSNJCU0MN05tvwV96?= =?us-ascii?Q?oztiBeHbFOhEg6gN8Jo0GVjDZ26WEyyCxprgC8dmblXYiA0lpftHGV2FfF6H?= =?us-ascii?Q?SnmoFDTYOu3l7QY+rKFNoBVt5DgZGVSMxi1ygmfuE86iAeWYVFqH7h2P1iSH?= =?us-ascii?Q?TRl0q9b1W9pXYeGd2qDRsuxHNqc/vCp8smD33FQXXYec4gB4dTaBRRxWS8Rf?= =?us-ascii?Q?ynkrr56R0qH5tOhW9b5H/NkepcEyHV5ecYfnqnjdlzY1fHToMXz9Gt42w7nq?= =?us-ascii?Q?Ui7SqN0uN9zA/g1JJVRfSgPZBZ9qgQkYOPgwgmDzrXDlVs3voNUQi6ssAjhu?= =?us-ascii?Q?mhHxQbHJp819h3TPavh0bkK4mzldDB4LbJD9undMbPnVwjHQskaBaCXwm1+B?= =?us-ascii?Q?ZSdB68beKo68tgNcULZ/A26ft5Nz5HTgpBhdCSnvPYdPRJ+5b+2Mdh4QW/Wa?= =?us-ascii?Q?tpObD6/NBYG98WSyoTQLujlaoKWqR2OEZ+50mFxGj/va50sqMUczFvYQMBxG?= =?us-ascii?Q?j8VjqDpYemicgUmABS1VUNWDdDoKnr3Bn7ldPqcD9jh/lZ/NVkvXyP2H/dQU?= =?us-ascii?Q?7mXMaDhU1n8GHGYJeNm4MbkuHHokok4rRHXXdYz8Vjlr4HnKLQDom+bN1SmO?= =?us-ascii?Q?aH2fKXpcPVh9n/EIt/2MytQfhS7ULYEqHkkX1/uBL8iqDNiXcX3Mi0X8V0j9?= =?us-ascii?Q?B4He01NTZXZa/M0FQildySx6OfbZywzNDcBTJyQlr2Y81awbPKonY24zcpvQ?= =?us-ascii?Q?v1jvBpjRw/uj1SN+6S8VNjVFNUyVp8pEITs0sVjB3tOiBlv49YF7Fy0LQqLl?= =?us-ascii?Q?HJJuMCuENS+Ui0r9TTAEuaYCI++kfpXb/iOAULIi21Xt4lfDr0zG4N0fU6LE?= =?us-ascii?Q?RbIvBn5COgA4mgR+h9BxSHCasFnlM+vnpAwAKBSjL5ITWyoQjfCcHLRU/lKh?= =?us-ascii?Q?4ari9z4XetQrZJZC5Pl4hTvxfkZpWUeryrhcWF90fuD9GNeKRq437WbbU6/2?= =?us-ascii?Q?GBcXvRleMlApVeCcM91rc5vp7Lcknu5Y+DFeWioZRXK2dTNTpZ3rhkbCsoKV?= =?us-ascii?Q?JNHi7szoZsMTp4hZX+yepfAEV38Giu2ovfl1wUs0BR10GO0/i8TdhRlauI8+?= =?us-ascii?Q?rrJgu+QjDPB6A1v9rqhxZXiGpXVeIJtewCN0KjzAjiHID8btFAUfEqKhVzvY?= =?us-ascii?Q?q9ihnAtQDr20KPRqOhVZz7gl0pHSxypwybFxRSK9QQreGqu5zFa0mb04EcuT?= =?us-ascii?Q?tNA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e857c90b-2353-486a-bac9-08d900c02061 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2021 10:12:22.4613 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gkh6zRQWKuJp6edAeub2DITy2sCUinBofZLRWNXhxbSxSjGQVX/uzgxEwVevQL1ur9EUIm5toaPYpDanMP0c6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3969 X-Proofpoint-GUID: q59tGAaBpcJrHpH3vC2KCIVN9AIAejjv X-Proofpoint-ORIG-GUID: q59tGAaBpcJrHpH3vC2KCIVN9AIAejjv X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-16_06:2021-04-15, 2021-04-16 signatures=0 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > Hi Akhil, > > > > It is possible the user don't know how many ops to dequeue. > > For example in VPP crypto up to 64 buffers > (vnet_crypto_async_frame_elt_t) > > are wrapped into the following data structure > > > > typedef struct > > { > > CLIB_CACHE_LINE_ALIGN_MARK (cacheline0); > > vnet_crypto_async_frame_state_t state; > > vnet_crypto_async_op_id_t op:8; > > u16 n_elts; > > vnet_crypto_async_frame_elt_t elts[VNET_CRYPTO_FRAME_SIZE]; > > u32 buffer_indices[VNET_CRYPTO_FRAME_SIZE]; > > u16 next_node_index[VNET_CRYPTO_FRAME_SIZE]; > > u32 enqueue_thread_index; > > } vnet_crypto_async_frame_t; > > > > Instead of passing vnet_crypto_async_frame_elt_t Pointer as metadata to > > cryptodev, we have to pass vnet_crypto_async_frame_t pointer into > > cryptodev. > > The callback function helps parse the first dequeued metadata to get n_= elts > > and will dequeue that many ops. > > > > But in case we cannot dequeue the whole frame, passing the number of > ops > > not dequeued yet in the next dequeue_burst operation should help us to > > dequeue the whole frame. In this case we only have to cache up to 1 fra= me > > pointer for half dequeued frame. > > > > As the patch stated this should help cover both cases for user either > dequeue > > the wrapped data structure with multiple buffers, or dequeue a burst of > > packets - hence giving people more flexibility. > > > > Regards, > > Fan > > > Ok. >=20 > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.